Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package ghc-bifunctors for openSUSE:Factory checked in at 2021-02-16 22:37:02 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/ghc-bifunctors (Old) and /work/SRC/openSUSE:Factory/.ghc-bifunctors.new.28504 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "ghc-bifunctors" Tue Feb 16 22:37:02 2021 rev:24 rq:870446 version:5.5.10 Changes: -------- --- /work/SRC/openSUSE:Factory/ghc-bifunctors/ghc-bifunctors.changes 2021-01-08 17:39:53.196983595 +0100 +++ /work/SRC/openSUSE:Factory/.ghc-bifunctors.new.28504/ghc-bifunctors.changes 2021-02-16 22:45:17.494330326 +0100 @@ -1,0 +2,9 @@ +Sun Jan 24 16:09:29 UTC 2021 - [email protected] + +- Update bifunctors to version 5.5.10. + 5.5.10 [2021.01.21] + ------------------- + * Fix a bug in which `deriveBifoldable` could generate code that triggers + `-Wunused-matches` warnings. + +------------------------------------------------------------------- Old: ---- bifunctors-5.5.9.tar.gz New: ---- bifunctors-5.5.10.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ ghc-bifunctors.spec ++++++ --- /var/tmp/diff_new_pack.qRhWpq/_old 2021-02-16 22:45:18.242331310 +0100 +++ /var/tmp/diff_new_pack.qRhWpq/_new 2021-02-16 22:45:18.250331320 +0100 @@ -1,7 +1,7 @@ # # spec file for package ghc-bifunctors # -# Copyright (c) 2020 SUSE LLC +# Copyright (c) 2021 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -19,7 +19,7 @@ %global pkg_name bifunctors %bcond_with tests Name: ghc-%{pkg_name} -Version: 5.5.9 +Version: 5.5.10 Release: 0 Summary: Collection Haskell 98 bifunctors, bifoldables and bitraversables License: BSD-2-Clause ++++++ bifunctors-5.5.9.tar.gz -> bifunctors-5.5.10.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/bifunctors-5.5.9/CHANGELOG.markdown new/bifunctors-5.5.10/CHANGELOG.markdown --- old/bifunctors-5.5.9/CHANGELOG.markdown 2001-09-09 03:46:40.000000000 +0200 +++ new/bifunctors-5.5.10/CHANGELOG.markdown 2001-09-09 03:46:40.000000000 +0200 @@ -1,3 +1,8 @@ +5.5.10 [2021.01.21] +------------------- +* Fix a bug in which `deriveBifoldable` could generate code that triggers + `-Wunused-matches` warnings. + 5.5.9 [2020.12.30] ------------------ * Explicitly mark modules as Safe or Trustworthy. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/bifunctors-5.5.9/bifunctors.cabal new/bifunctors-5.5.10/bifunctors.cabal --- old/bifunctors-5.5.9/bifunctors.cabal 2001-09-09 03:46:40.000000000 +0200 +++ new/bifunctors-5.5.10/bifunctors.cabal 2001-09-09 03:46:40.000000000 +0200 @@ -1,6 +1,6 @@ name: bifunctors category: Data, Functors -version: 5.5.9 +version: 5.5.10 license: BSD3 cabal-version: >= 1.10 license-file: LICENSE @@ -120,7 +120,7 @@ type: exitcode-stdio-1.0 hs-source-dirs: tests main-is: Spec.hs - other-modules: BifunctorSpec + other-modules: BifunctorSpec T89Spec ghc-options: -Wall if impl(ghc >= 8.6) ghc-options: -Wno-star-is-type diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/bifunctors-5.5.9/src/Data/Bifunctor/TH.hs new/bifunctors-5.5.10/src/Data/Bifunctor/TH.hs --- old/bifunctors-5.5.9/src/Data/Bifunctor/TH.hs 2001-09-09 03:46:40.000000000 +0200 +++ new/bifunctors-5.5.10/src/Data/Bifunctor/TH.hs 2001-09-09 03:46:40.000000000 +0200 @@ -1211,14 +1211,30 @@ -- Make a 'LamE' using a fresh variable. mkSimpleLam :: (Exp -> Q Exp) -> Q Exp mkSimpleLam lam = do - n <- newName "n" + -- Use an underscore in front of the variable name, as it's possible for + -- certain Bifoldable instances to generate code like this (see #89): + -- + -- @ + -- bifoldMap (\\_n -> mempty) ... + -- @ + -- + -- Without the underscore, that code would trigger -Wunused-matches warnings. + n <- newName "_n" body <- lam (VarE n) return $ LamE [VarP n] body -- Make a 'LamE' using two fresh variables. mkSimpleLam2 :: (Exp -> Exp -> Q Exp) -> Q Exp mkSimpleLam2 lam = do - n1 <- newName "n1" + -- Use an underscore in front of the variable name, as it's possible for + -- certain Bifoldable instances to generate code like this (see #89): + -- + -- @ + -- bifoldr (\\_n1 n2 -> n2) ... + -- @ + -- + -- Without the underscore, that code would trigger -Wunused-matches warnings. + n1 <- newName "_n1" n2 <- newName "n2" body <- lam (VarE n1) (VarE n2) return $ LamE [VarP n1, VarP n2] body diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/bifunctors-5.5.9/tests/T89Spec.hs new/bifunctors-5.5.10/tests/T89Spec.hs --- old/bifunctors-5.5.9/tests/T89Spec.hs 1970-01-01 01:00:00.000000000 +0100 +++ new/bifunctors-5.5.10/tests/T89Spec.hs 2001-09-09 03:46:40.000000000 +0200 @@ -0,0 +1,21 @@ +{-# LANGUAGE TemplateHaskell #-} + +-- | A regression test for #89 which ensures that a TH-generated Bifoldable +-- instance of a certain shape does not trigger -Wunused-matches warnings. +module T89Spec where + +import Data.Bifunctor.TH +import Test.Hspec + +data X = MkX +data Y a b = MkY a b +newtype XY a b = XY { getResp :: Either X (Y a b) } + +$(deriveBifoldable ''Y) +$(deriveBifoldable ''XY) + +main :: IO () +main = hspec spec + +spec :: Spec +spec = return ()
