Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package radvd for openSUSE:Factory checked in at 2021-02-18 20:38:16 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/radvd (Old) and /work/SRC/openSUSE:Factory/.radvd.new.28504 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "radvd" Thu Feb 18 20:38:16 2021 rev:37 rq:871609 version:2.19 Changes: -------- --- /work/SRC/openSUSE:Factory/radvd/radvd.changes 2020-08-21 19:01:00.252243097 +0200 +++ /work/SRC/openSUSE:Factory/.radvd.new.28504/radvd.changes 2021-02-18 20:41:35.286735798 +0100 @@ -1,0 +2,10 @@ +Fri Jan 29 10:09:21 UTC 2021 - Wang Jun <[email protected]> + +- Update to version 2.19 + * bug fixes + * cleanups +- Modify the patches becuase of version updating + * radvd-configure.patch and radvd-systemd.patch +- Update radvd.keyring for signing source code + +------------------------------------------------------------------- Old: ---- radvd-2.18.tar.xz radvd-2.18.tar.xz.asc New: ---- radvd-2.19.tar.xz radvd-2.19.tar.xz.asc ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ radvd.spec ++++++ --- /var/tmp/diff_new_pack.QjI5dQ/_old 2021-02-18 20:41:36.302736715 +0100 +++ /var/tmp/diff_new_pack.QjI5dQ/_new 2021-02-18 20:41:36.306736719 +0100 @@ -1,7 +1,7 @@ # # spec file for package radvd # -# Copyright (c) 2020 SUSE LLC +# Copyright (c) 2021 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -26,16 +26,16 @@ %endif Name: radvd -Version: 2.18 +Version: 2.19 Release: 0 Summary: Router ADVertisement Daemon for IPv6 License: BSD-3-Clause Group: Productivity/Networking/Routing URL: http://v6web.litech.org/radvd -Source0: http://www.litech.org/radvd/dist/%{name}-%{version}.tar.xz +Source0: https://radvd.litech.org/dist/%{name}-%{version}.tar.xz Source2: sysconfig.radvd Source3: system-user-radvd.conf -Source42: http://www.litech.org/radvd/dist/%{name}-%{version}.tar.xz.asc +Source42: https://radvd.litech.org/dist/%{name}-%{version}.tar.xz.asc Source43: %{name}.keyring Patch1: 0001-run-as-user-radvd-by-default.diff Patch2: radvd-configure.patch ++++++ radvd-2.18.tar.xz -> radvd-2.19.tar.xz ++++++ ++++ 3022 lines of diff (skipped) ++++ retrying with extended exclude list diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/radvd-2.18/CHANGES new/radvd-2.19/CHANGES --- old/radvd-2.18/CHANGES 2019-02-26 05:34:57.000000000 +0100 +++ new/radvd-2.19/CHANGES 2020-09-24 07:14:13.000000000 +0200 @@ -1,3 +1,7 @@ +2020/09/23 Release v2.19 + bug fixes + cleanups + 2019/02/25 Release v2.18 2019/02/15 Add TravisCI config diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/radvd-2.18/Makefile.am new/radvd-2.19/Makefile.am --- old/radvd-2.18/Makefile.am 2019-02-16 07:08:33.000000000 +0100 +++ new/radvd-2.19/Makefile.am 2019-07-20 05:58:19.000000000 +0200 @@ -43,10 +43,14 @@ AM_CFLAGS = \ -fno-strict-aliasing \ - -fstack-protector \ $(ENABLE_WARNINGS) \ $(DISABLE_WARNINGS) +if HAVE_STACK_PROTECTOR +AM_CFLAGS += \ + -fstack-protector +endif + ### CPP is C PreProcessor ### AM_YFLAGS = -d diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/radvd-2.18/configure.ac new/radvd-2.19/configure.ac --- old/radvd-2.18/configure.ac 2019-02-26 05:35:34.000000000 +0100 +++ new/radvd-2.19/configure.ac 2020-09-24 07:11:32.000000000 +0200 @@ -13,7 +13,7 @@ dnl dnl If adding rcX to version, be sure to separate with a '-' -AC_INIT(radvd, [2.18]) +AC_INIT(radvd, [2.19]) AC_CONFIG_SRCDIR(radvd.c) AC_CANONICAL_SYSTEM AM_INIT_AUTOMAKE @@ -50,6 +50,9 @@ AC_PROG_CC_C99 AC_PROG_RANLIB +AC_ARG_WITH([stack-protector], AS_HELP_STRING([--without-stack-protector], [Build without -fstack-protector]),[],[with_stack_protector=yes]) +AM_CONDITIONAL(HAVE_STACK_PROTECTOR, test x"$with_stack_protector" = xyes) + AC_ARG_WITH([check], AS_HELP_STRING([--without-check], [Build without check unit testing framework]),[],[with_check=no]) AS_IF([test "x$with_check" = "xyes"], [ AS_IF([test "x$arch" = "xlinux"], [ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/radvd-2.18/gram.y new/radvd-2.19/gram.y --- old/radvd-2.18/gram.y 2019-02-16 06:30:57.000000000 +0100 +++ new/radvd-2.19/gram.y 2019-07-20 05:58:19.000000000 +0200 @@ -947,10 +947,10 @@ struct Interface * readin_config(char const *path) { + IfaceList = 0; FILE * in = fopen(path, "r"); if (in) { filename = path; - IfaceList = 0; num_lines = 1; iface = 0; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/radvd-2.18/includes.h new/radvd-2.19/includes.h --- old/radvd-2.18/includes.h 2018-02-18 23:45:02.000000000 +0100 +++ new/radvd-2.19/includes.h 2019-09-21 23:50:05.000000000 +0200 @@ -76,7 +76,12 @@ #include <sys/sysctl.h> #endif +#if !defined(__GLIBC__) && defined(linux) +#include <linux/if.h> +#define IF_NAMESIZE IFNAMSIZ +#else #include <net/if.h> +#endif #ifdef HAVE_NET_IF_DL_H #include <net/if_dl.h> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/radvd-2.18/netlink.c new/radvd-2.19/netlink.c --- old/radvd-2.18/netlink.c 2018-02-18 23:45:02.000000000 +0100 +++ new/radvd-2.19/netlink.c 2019-09-21 23:50:05.000000000 +0200 @@ -15,6 +15,7 @@ #include "netlink.h" #include "config.h" +#include "includes.h" #include "log.h" #include "radvd.h" @@ -22,7 +23,7 @@ #include <errno.h> #include <linux/netlink.h> #include <linux/rtnetlink.h> -#include <net/if.h> + #include <stdio.h> #include <stdlib.h> #include <string.h> @@ -43,7 +44,7 @@ struct iplink_req req = {}; struct iovec iov = {&req, sizeof(req)}; struct sockaddr_nl sa = {}; - struct msghdr msg = {(void *)&sa, sizeof(sa), &iov, 1, NULL, 0, 0}; + struct msghdr msg = {.msg_name=(void *)&sa, .msg_namelen=sizeof(sa), .msg_iov=&iov, .msg_iovlen=1, .msg_control=NULL, .msg_controllen=0, .msg_flags=0}; int sock, len, addr_len = -1; unsigned short type; char answer[32768]; @@ -99,7 +100,7 @@ char buf[4096]; struct iovec iov = {buf, sizeof(buf)}; struct sockaddr_nl sa; - struct msghdr msg = {(void *)&sa, sizeof(sa), &iov, 1, NULL, 0, 0}; + struct msghdr msg = {.msg_name=(void *)&sa, .msg_namelen=sizeof(sa), .msg_iov=&iov, .msg_iovlen=1, .msg_control=NULL, .msg_controllen=0, .msg_flags=0}; int len = recvmsg(sock, &msg, 0); if (len == -1) { flog(LOG_ERR, "netlink: recvmsg failed: %s", strerror(errno)); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/radvd-2.18/radvd.conf.5.man new/radvd-2.19/radvd.conf.5.man --- old/radvd-2.18/radvd.conf.5.man 2018-02-18 23:45:02.000000000 +0100 +++ new/radvd-2.19/radvd.conf.5.man 2020-09-24 07:09:50.000000000 +0200 @@ -134,7 +134,7 @@ .BR IgnoreIfMissing " " on | off A flag indicating whether or not the interface is ignored -if it does not exist at start-up. By default, radvd exits. +if it does not exist at start-up. This is useful for dynamic interfaces which are not active when radvd starts or which are dynamically disabled and re-enabled during the time diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/radvd-2.18/redhat/SysV/radvd.spec new/radvd-2.19/redhat/SysV/radvd.spec --- old/radvd-2.18/redhat/SysV/radvd.spec 2019-02-26 05:36:53.000000000 +0100 +++ new/radvd-2.19/redhat/SysV/radvd.spec 2020-09-24 07:15:05.000000000 +0200 @@ -5,7 +5,7 @@ Summary: A Router Advertisement daemon Name: radvd -Version: 2.18 +Version: 2.19 Release: 1 # The code includes the advertising clause, so it's GPL-incompatible License: BSD with advertising diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/radvd-2.18/redhat/systemd/radvd-tmpfs.conf new/radvd-2.19/redhat/systemd/radvd-tmpfs.conf --- old/radvd-2.18/redhat/systemd/radvd-tmpfs.conf 2019-02-16 06:30:57.000000000 +0100 +++ new/radvd-2.19/redhat/systemd/radvd-tmpfs.conf 2019-07-20 05:58:19.000000000 +0200 @@ -1 +1 @@ -d /var/run/radvd 0755 radvd radvd +d /run/radvd 0755 radvd radvd diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/radvd-2.18/redhat/systemd/radvd.service new/radvd-2.19/redhat/systemd/radvd.service --- old/radvd-2.18/redhat/systemd/radvd.service 2019-02-16 06:30:57.000000000 +0100 +++ new/radvd-2.19/redhat/systemd/radvd.service 2020-09-24 07:09:50.000000000 +0200 @@ -7,7 +7,7 @@ EnvironmentFile=/etc/sysconfig/radvd ExecStart=/usr/sbin/radvd $OPTIONS Type=forking -PIDFile=/var/run/radvd/radvd.pid +PIDFile=/run/radvd/radvd.pid ExecReload=/bin/kill -HUP $MAINPID [Install] diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/radvd-2.18/redhat/systemd/radvd.spec new/radvd-2.19/redhat/systemd/radvd.spec --- old/radvd-2.18/redhat/systemd/radvd.spec 2019-02-26 05:36:53.000000000 +0100 +++ new/radvd-2.19/redhat/systemd/radvd.spec 2020-09-24 07:15:05.000000000 +0200 @@ -2,7 +2,7 @@ Summary: A Router Advertisement daemon Name: radvd -Version: 2.18 +Version: 2.19 Release: 1%{?dist} # The code includes the advertising clause, so it's GPL-incompatible License: BSD with advertising diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/radvd-2.18/send.c new/radvd-2.19/send.c --- old/radvd-2.18/send.c 2018-12-09 00:35:39.000000000 +0100 +++ new/radvd-2.19/send.c 2020-09-24 07:09:50.000000000 +0200 @@ -158,7 +158,7 @@ struct AdvPrefix *prefix = iface->AdvPrefixList; while (prefix) { - if ((!prefix->DecrementLifetimesFlag || prefix->curr_preferredlft > 0)) { + if (!prefix->DecrementLifetimesFlag || prefix->curr_preferredlft > 0) { if (!(iface->state_info.cease_adv && prefix->DeprecatePrefixFlag)) { if (prefix->DecrementLifetimesFlag) { @@ -289,7 +289,12 @@ if (strncmp(ifa->ifa_name, ifname, IFNAMSIZ)) continue; - + + if (ifa->ifa_addr == NULL) { + flog(LOG_WARNING, "ifa_addr == NULL for dev %s !? Ignoring in add_auto_prefixes", ifname); + continue; + } + if (ifa->ifa_addr->sa_family != AF_INET6) continue; @@ -328,7 +333,7 @@ struct in6_addr const *dest) { while (prefix) { - if ((!prefix->DecrementLifetimesFlag || prefix->curr_preferredlft > 0)) { + if (!prefix->DecrementLifetimesFlag || prefix->curr_preferredlft > 0) { struct in6_addr zero = {}; if (prefix->if6to4[0] || prefix->if6[0] || 0 == memcmp(&prefix->Prefix, &zero, sizeof(zero))) { if (prefix->if6to4[0]) { @@ -786,16 +791,6 @@ cur = cur->next; } - if (option_count == 0 && total_seen_options > 0) { - // If option_count == 0 and total_seen_options==0 we make sure to - // send ONE RA out, so that clients get the RA header fields. - } else if (option_count == 0 && total_seen_options > 0) { - // None of the RA options are scheduled for this window. - dlog(LOG_DEBUG, 5, - "No RA options scheduled in this pass, staying quiet; already sent at least one RA packet"); - break; - } - // RA built, now send it. dlog(LOG_DEBUG, 5, "sending RA to %s on %s (%s), %lu options (using %zd/%u bytes)", dest_text, iface->props.name, src_text, option_count, sb->used, iface->props.max_ra_option_size); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/radvd-2.18/test/util.c new/radvd-2.19/test/util.c --- old/radvd-2.18/test/util.c 2018-02-18 23:45:02.000000000 +0100 +++ new/radvd-2.19/test/util.c 2019-07-20 05:58:19.000000000 +0200 @@ -259,6 +259,20 @@ } END_TEST +START_TEST(test_cfg_removal_with_sighup) +{ + struct Interface *tmpIface = NULL; + + tmpIface = readin_config("test/test1.conf"); + ck_assert(tmpIface); + + free_ifaces(tmpIface); + + tmpIface = readin_config("test/file_that_should_not_exists.conf"); + ck_assert(!tmpIface); +} +END_TEST + Suite *util_suite(void) { TCase *tc_safe_buffer = tcase_create("safe_buffer"); @@ -288,6 +302,7 @@ TCase *tc_misc = tcase_create("misc"); tcase_add_test(tc_misc, test_rand_between); + tcase_add_test(tc_misc, test_cfg_removal_with_sighup); Suite *s = suite_create("util"); suite_add_tcase(s, tc_safe_buffer); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/radvd-2.18/ylwrap new/radvd-2.19/ylwrap --- old/radvd-2.18/ylwrap 2019-02-26 05:36:38.000000000 +0100 +++ new/radvd-2.19/ylwrap 2020-09-24 07:15:02.000000000 +0200 @@ -1,9 +1,9 @@ #! /bin/sh # ylwrap - wrapper for lex/yacc invocations. -scriptversion=2013-01-12.17; # UTC +scriptversion=2016-01-11.22; # UTC -# Copyright (C) 1996-2014 Free Software Foundation, Inc. +# Copyright (C) 1996-2017 Free Software Foundation, Inc. # # Written by Tom Tromey <[email protected]>. # @@ -242,6 +242,6 @@ # eval: (add-hook 'write-file-hooks 'time-stamp) # time-stamp-start: "scriptversion=" # time-stamp-format: "%:y-%02m-%02d.%02H" -# time-stamp-time-zone: "UTC" +# time-stamp-time-zone: "UTC0" # time-stamp-end: "; # UTC" # End: ++++++ radvd-configure.patch ++++++ --- /var/tmp/diff_new_pack.QjI5dQ/_old 2021-02-18 20:41:36.438736837 +0100 +++ /var/tmp/diff_new_pack.QjI5dQ/_new 2021-02-18 20:41:36.438736837 +0100 @@ -1,8 +1,6 @@ -Index: radvd-2.11/configure.ac -=================================================================== ---- radvd-2.11.orig/configure.ac -+++ radvd-2.11/configure.ac -@@ -47,7 +47,9 @@ you must specify it with --target on the +--- radvd-2.19/configure.ac.orig 2021-01-29 17:35:44.957137874 +0800 ++++ radvd-2.19/configure.ac 2021-01-29 17:40:10.884531444 +0800 +@@ -47,7 +47,9 @@ esac dnl Determine CC and preset CFLAGS @@ -12,4 +10,4 @@ +AC_SYS_LARGEFILE AC_PROG_RANLIB - AC_ARG_WITH([check], AS_HELP_STRING([--without-check], [Build without check unit testing framework]),[],[with_check=no]) + AC_ARG_WITH([stack-protector], AS_HELP_STRING([--without-stack-protector], [Build without -fstack-protector]),[],[with_stack_protector=yes]) ++++++ radvd-systemd.patch ++++++ --- /var/tmp/diff_new_pack.QjI5dQ/_old 2021-02-18 20:41:36.446736845 +0100 +++ /var/tmp/diff_new_pack.QjI5dQ/_new 2021-02-18 20:41:36.446736845 +0100 @@ -1,25 +1,14 @@ -Index: radvd-2.18/redhat/systemd/radvd.service -=================================================================== ---- radvd-2.18.orig/redhat/systemd/radvd.service -+++ radvd-2.18/redhat/systemd/radvd.service -@@ -4,10 +4,9 @@ After=network-online.target +--- radvd-2.19/redhat/systemd/radvd.service.orig 2021-01-29 17:55:55.894674187 +0800 ++++ radvd-2.19/redhat/systemd/radvd.service 2021-01-29 17:56:28.194647566 +0800 +@@ -4,9 +4,8 @@ Wants=network-online.target [Service] -EnvironmentFile=/etc/sysconfig/radvd -ExecStart=/usr/sbin/radvd $OPTIONS -Type=forking --PIDFile=/var/run/radvd/radvd.pid +EnvironmentFile=-/etc/sysconfig/radvd +ExecStart=/usr/sbin/radvd --nodaemon $RADVD_OPTIONS -+PIDFile=/run/radvd/radvd.pid + PIDFile=/run/radvd/radvd.pid ExecReload=/bin/kill -HUP $MAINPID - [Install] -Index: radvd-2.18/redhat/systemd/radvd-tmpfs.conf -=================================================================== ---- radvd-2.18.orig/redhat/systemd/radvd-tmpfs.conf -+++ radvd-2.18/redhat/systemd/radvd-tmpfs.conf -@@ -1 +1 @@ --d /var/run/radvd 0755 radvd radvd -+d /run/radvd 0755 radvd radvd ++++++ radvd.keyring ++++++ ++++ 653 lines (skipped) ++++ between radvd.keyring ++++ and /work/SRC/openSUSE:Factory/.radvd.new.28504/radvd.keyring
