Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package perl-MooseX-App for openSUSE:Factory
checked in at 2021-02-19 23:45:10
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/perl-MooseX-App (Old)
and /work/SRC/openSUSE:Factory/.perl-MooseX-App.new.28504 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "perl-MooseX-App"
Fri Feb 19 23:45:10 2021 rev:2 rq:873688 version:1.41
Changes:
--------
--- /work/SRC/openSUSE:Factory/perl-MooseX-App/perl-MooseX-App.changes
2020-11-23 10:39:18.381933234 +0100
+++
/work/SRC/openSUSE:Factory/.perl-MooseX-App.new.28504/perl-MooseX-App.changes
2021-02-19 23:45:48.555395389 +0100
@@ -1,0 +2,9 @@
+Tue Feb 16 09:29:50 UTC 2021 - Frank Schreiner <[email protected]>
+
+- fixes boo#1181616
+ addded 0000_reproducible_bash_completion.patch.
+ Sort options in bash completion to get reproducible builds.
+- added 0001_fix_testing_for_Moose_2.2014.patch
+ fixes https://github.com/maros/MooseX-App/issues/62
+
+-------------------------------------------------------------------
New:
----
0000_reproducible_bash_completion.patch
0001_fix_testing_for_Moose_2.2014.patch
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ perl-MooseX-App.spec ++++++
--- /var/tmp/diff_new_pack.QEGnZL/_old 2021-02-19 23:45:49.155395977 +0100
+++ /var/tmp/diff_new_pack.QEGnZL/_new 2021-02-19 23:45:49.155395977 +0100
@@ -1,7 +1,7 @@
#
# spec file for package perl-MooseX-App
#
-# Copyright (c) 2020 SUSE LLC
+# Copyright (c) 2021 SUSE LLC
#
# All modifications and additions to the file contributed by third parties
# remain the property of their copyright owners, unless otherwise agreed
@@ -16,18 +16,20 @@
#
+%define cpan_name MooseX-App
Name: perl-MooseX-App
Version: 1.41
Release: 0
-%define cpan_name MooseX-App
Summary: Write user-friendly command line apps with even less suffering
License: Artistic-1.0 OR GPL-1.0-or-later
-Group: Development/Libraries/Perl
URL: https://metacpan.org/release/%{cpan_name}
Source0:
https://cpan.metacpan.org/authors/id/M/MA/MAROS/%{cpan_name}-%{version}.tar.gz
Source1: cpanspec.yml
+# PATCH-FIX-UPSTREAM fixes
https://bugzilla.opensuse.org/show_bug.cgi?id=1181616 and might get superseded
by https://github.com/maros/MooseX-App/pull/64
+Patch0: 0000_reproducible_bash_completion.patch
+# PATCH-FIX-UPSTREAM fixes https://github.com/maros/MooseX-App/issues/62 and
might get superseded by https://github.com/maros/MooseX-App/pull/66
+Patch1: 0001_fix_testing_for_Moose_2.2014.patch
BuildArch: noarch
-BuildRoot: %{_tmppath}/%{name}-%{version}-build
BuildRequires: perl
BuildRequires: perl-macros
BuildRequires: perl(Config::Any)
@@ -63,12 +65,12 @@
keywords respectively.
%prep
-%setup -q -n %{cpan_name}-%{version}
+%autosetup -n %{cpan_name}-%{version} -p1
find . -type f ! -path "*/t/*" ! -name "*.pl" ! -path "*/bin/*" ! -path
"*/script/*" ! -name "configure" -print0 | xargs -0 chmod 644
%build
perl Makefile.PL INSTALLDIRS=vendor
-make %{?_smp_mflags}
+%make_build
%check
make test
@@ -79,7 +81,6 @@
%perl_gen_filelist
%files -f %{name}.files
-%defattr(-,root,root,755)
%doc Changes README.md TODO
%license LICENCE LICENSE
++++++ 0000_reproducible_bash_completion.patch ++++++
commit a7ed05478eb200f6c909e11b82e3809a1019aa5a
Author: Frank Schreiner <[email protected]>
Date: Mon Feb 1 08:03:38 2021 +0100
sort options in bash_completion
without this patch the output of "<command> bash_completion" differs between
each call. This breaks reproducible builds like in Debian or SUSE, because,
even without code changes, the content of a built package (deb or rpm) which
include a file containing the bash_completion differs on each build.
See also https://wiki.debian.org/ReproducibleBuilds.
This patch sorts the options before generating the output of bash_completion
to generate reproducible results.
diff --git a/lib/MooseX/App/Plugin/BashCompletion/Command.pm
b/lib/MooseX/App/Plugin/BashCompletion/Command.pm
index 247ee6f..311cc2f 100644
--- a/lib/MooseX/App/Plugin/BashCompletion/Command.pm
+++ b/lib/MooseX/App/Plugin/BashCompletion/Command.pm
@@ -62,7 +62,7 @@ EOT
foreach my $command (sort keys %command_map) {
$syntax .= "_${prefix}_macc_${command}() {\n _${prefix}_compreply
\"";
#$syntax .= join(" ", @{$data->{parameters}});
- $syntax .= join(" ", @{$command_map{$command}->{options}});
+ $syntax .= join(" ", sort @{$command_map{$command}->{options}});
$syntax .= "\"\n}\n\n";
}
++++++ 0001_fix_testing_for_Moose_2.2014.patch ++++++
commit e5c538e469096cf12ec69d3828f81c1c56aacb5b
Author: Frank Schreiner <[email protected]>
Date: Wed Feb 17 10:47:45 2021 +0100
fix testing for Moose 2.2014
Without this patch the test suite breaks with the new Moose version
(2.2014).
This patch should be able to handle the old and the new error messages.
fixes issue #62
diff --git a/t/05_extended.t b/t/05_extended.t
index 37dab9a..18e8063 100755
--- a/t/05_extended.t
+++ b/t/05_extended.t
@@ -241,7 +241,9 @@ subtest 'Test enum error message' => sub {
MooseX::App::ParsedArgv->new(argv => [qw(somecommand --another hase hh h
ggg)]);
my $test18 = Test03->new_with_command();
isa_ok($test18,'MooseX::App::Message::Envelope');
- is($test18->blocks->[0]->body,"Value must be one of these values: aaa,
bbb, ccc, ddd, eee, fff (not 'ggg')","Check enum error message");
+ like($test18->blocks->[0]->body,
+ qr{(Value must be one of these values: aaa, bbb, ccc, ddd, eee, fff
\(not 'ggg'\)|Validation failed for '__ANON__' with value "?ggg"?. Value must
be equal to "aaa", "bbb", "ccc", "ddd", "eee", or "fff".)},
+ "Check enum error message");
};
subtest 'Test empty multi' => sub {
@@ -283,4 +285,4 @@ subtest 'Test mixed multi' => sub {
my $test22 = Test03->new_with_command();
isa_ok($test22,'Test03::SomeCommand');
cmp_deeply($test22->list,[qw(val1 val2 val3 val4)],'List ok');
-};
\ No newline at end of file
+};
++++++ cpanspec.yml ++++++
--- /var/tmp/diff_new_pack.QEGnZL/_old 2021-02-19 23:45:49.195396016 +0100
+++ /var/tmp/diff_new_pack.QEGnZL/_new 2021-02-19 23:45:49.199396020 +0100
@@ -7,8 +7,9 @@
#sources:
# - source1
# - source2
-#patches:
-# foo.patch: -p1
+patches:
+ 0000_reproducible_bash_completion.patch: -p1 PATCH-FIX-UPSTREAM fixes
https://bugzilla.opensuse.org/show_bug.cgi?id=1181616 and might get superseded
by https://github.com/maros/MooseX-App/pull/64
+ 0001_fix_testing_for_Moose_2.2014.patch: -p1 PATCH-FIX-UPSTREAM fixes
https://github.com/maros/MooseX-App/issues/62 and might get superseded by
https://github.com/maros/MooseX-App/pull/66
# bar.patch:
#preamble: |-
# BuildRequires: gcc-c++
