Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package yast2-firewall for openSUSE:Factory checked in at 2021-02-26 21:58:03 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2-firewall (Old) and /work/SRC/openSUSE:Factory/.yast2-firewall.new.2378 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-firewall" Fri Feb 26 21:58:03 2021 rev:89 rq:871472 version:4.3.10 Changes: -------- --- /work/SRC/openSUSE:Factory/yast2-firewall/yast2-firewall.changes 2020-11-03 15:16:00.536007897 +0100 +++ /work/SRC/openSUSE:Factory/.yast2-firewall.new.2378/yast2-firewall.changes 2021-02-26 21:58:06.251749827 +0100 @@ -1,0 +2,7 @@ +Fri Feb 12 14:31:50 UTC 2021 - Ancor Gonzalez Sosa <[email protected]> + +- Adapted unit test to recent changes in Yast::Report (related to + bsc#1179893) +- 4.3.10 + +------------------------------------------------------------------- Old: ---- yast2-firewall-4.3.9.tar.bz2 New: ---- yast2-firewall-4.3.10.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-firewall.spec ++++++ --- /var/tmp/diff_new_pack.Ia4gXm/_old 2021-02-26 21:58:06.771750284 +0100 +++ /var/tmp/diff_new_pack.Ia4gXm/_new 2021-02-26 21:58:06.775750287 +0100 @@ -1,7 +1,7 @@ # # spec file for package yast2-firewall # -# Copyright (c) 2020 SUSE LLC +# Copyright (c) 2021 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -17,7 +17,7 @@ Name: yast2-firewall -Version: 4.3.9 +Version: 4.3.10 Release: 0 Summary: YaST2 - Firewall Configuration License: GPL-2.0-only ++++++ yast2-firewall-4.3.9.tar.bz2 -> yast2-firewall-4.3.10.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-firewall-4.3.9/.github/workflows/ci.yml new/yast2-firewall-4.3.10/.github/workflows/ci.yml --- old/yast2-firewall-4.3.9/.github/workflows/ci.yml 1970-01-01 01:00:00.000000000 +0100 +++ new/yast2-firewall-4.3.10/.github/workflows/ci.yml 2021-02-12 16:00:27.000000000 +0100 @@ -0,0 +1,82 @@ + +# See https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions + +name: CI + +on: [push, pull_request] + +jobs: + Tests: + runs-on: ubuntu-latest + container: registry.opensuse.org/yast/head/containers/yast-ruby:latest + + steps: + + - name: Git Checkout + uses: actions/checkout@v2 + + # just for easier debugging... + - name: Inspect Installed Packages + run: rpm -qa | sort + + - name: Unit Tests + run: rake test:unit + # enable code coverage reporting + env: + COVERAGE: 1 + + # send the coverage report to coveralls.io + - name: Coveralls Report + uses: coverallsapp/github-action@master + with: + github-token: ${{ secrets.GITHUB_TOKEN }} + + Rubocop: + runs-on: ubuntu-latest + container: registry.opensuse.org/yast/head/containers/yast-ruby:latest + + steps: + + - name: Git Checkout + uses: actions/checkout@v2 + + - name: Rubocop + run: rake check:rubocop + + Package: + runs-on: ubuntu-latest + container: registry.opensuse.org/yast/head/containers/yast-ruby:latest + + steps: + + - name: Git Checkout + uses: actions/checkout@v2 + + - name: Package Build + run: yast-ci-ruby -o package + + Yardoc: + runs-on: ubuntu-latest + container: registry.opensuse.org/yast/head/containers/yast-ruby:latest + + steps: + + - name: Git Checkout + uses: actions/checkout@v2 + + - name: Yardoc + run: rake check:doc + + # downloading the Docker image takes some time so bundling several fast + # checks into one job avoids that overhead + Checks: + runs-on: ubuntu-latest + container: registry.opensuse.org/yast/head/containers/yast-ruby:latest + + steps: + + - name: Git Checkout + uses: actions/checkout@v2 + + - name: POT Check + run: rake check:pot diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-firewall-4.3.9/.travis.yml new/yast2-firewall-4.3.10/.travis.yml --- old/yast2-firewall-4.3.9/.travis.yml 2020-10-31 13:34:18.000000000 +0100 +++ new/yast2-firewall-4.3.10/.travis.yml 1970-01-01 01:00:00.000000000 +0100 @@ -1,12 +0,0 @@ -sudo: required -language: bash -services: - - docker - -before_install: - - docker build -t yast-firewall-image . -script: - # the "yast-travis-ruby" script is included in the base yastdevel/ruby image - # see https://github.com/yast/docker-yast-ruby/blob/master/yast-travis-ruby - - docker run -it -e TRAVIS=1 -e TRAVIS_JOB_ID="$TRAVIS_JOB_ID" yast-firewall-image yast-travis-ruby - - docker run -it -e TRAVIS=1 -e TRAVIS_JOB_ID="$TRAVIS_JOB_ID" yast-firewall-image rake check:doc diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-firewall-4.3.9/Dockerfile new/yast2-firewall-4.3.10/Dockerfile --- old/yast2-firewall-4.3.9/Dockerfile 2020-10-31 13:34:18.000000000 +0100 +++ new/yast2-firewall-4.3.10/Dockerfile 1970-01-01 01:00:00.000000000 +0100 @@ -1,3 +0,0 @@ -FROM registry.opensuse.org/yast/head/containers/yast-ruby:latest -COPY . /usr/src/app - diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-firewall-4.3.9/README.md new/yast2-firewall-4.3.10/README.md --- old/yast2-firewall-4.3.9/README.md 2020-10-31 13:34:18.000000000 +0100 +++ new/yast2-firewall-4.3.10/README.md 2021-02-12 16:00:27.000000000 +0100 @@ -1,9 +1,11 @@ # YaST Firewall - Configures Firewalld # -[](https://coveralls.io/github/yast/yast-firewall?branch=master) -[](https://travis-ci.org/yast/yast-firewall) -[](https://ci.opensuse.org/view/Yast/job/yast-firewall-master/) +[]( +https://github.com/yast/yast-firewall/actions?query=branch%3Amaster) +[]( +https://ci.opensuse.org/view/Yast/job/yast-yast-firewall-master/) +[]( +https://coveralls.io/github/yast/yast-firewall?branch=master) Since the adoption of `firewalld` this repository contains just some useful diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-firewall-4.3.9/package/yast2-firewall.changes new/yast2-firewall-4.3.10/package/yast2-firewall.changes --- old/yast2-firewall-4.3.9/package/yast2-firewall.changes 2020-10-31 13:34:18.000000000 +0100 +++ new/yast2-firewall-4.3.10/package/yast2-firewall.changes 2021-02-12 16:00:27.000000000 +0100 @@ -1,4 +1,11 @@ ------------------------------------------------------------------- +Fri Feb 12 14:31:50 UTC 2021 - Ancor Gonzalez Sosa <[email protected]> + +- Adapted unit test to recent changes in Yast::Report (related to + bsc#1179893) +- 4.3.10 + +------------------------------------------------------------------- Fri Oct 30 11:47:21 UTC 2020 - Knut Anderssen <[email protected]> - AutoYaST: When no firewall section is defined, write the service diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-firewall-4.3.9/package/yast2-firewall.spec new/yast2-firewall-4.3.10/package/yast2-firewall.spec --- old/yast2-firewall-4.3.9/package/yast2-firewall.spec 2020-10-31 13:34:18.000000000 +0100 +++ new/yast2-firewall-4.3.10/package/yast2-firewall.spec 2021-02-12 16:00:27.000000000 +0100 @@ -17,7 +17,7 @@ Name: yast2-firewall -Version: 4.3.9 +Version: 4.3.10 Release: 0 Summary: YaST2 - Firewall Configuration Group: System/YaST diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-firewall-4.3.9/test/lib/y2firewall/clients/installation_finish_test.rb new/yast2-firewall-4.3.10/test/lib/y2firewall/clients/installation_finish_test.rb --- old/yast2-firewall-4.3.9/test/lib/y2firewall/clients/installation_finish_test.rb 2020-10-31 13:34:18.000000000 +0100 +++ new/yast2-firewall-4.3.10/test/lib/y2firewall/clients/installation_finish_test.rb 2021-02-12 16:00:27.000000000 +0100 @@ -33,6 +33,7 @@ allow(proposal_settings).to receive(:enable_sshd).and_return(enable_sshd) allow(firewalld).to receive(:installed?).and_return(installed) allow(proposal_settings).to receive(:open_ssh).and_return(false) + allow(subject).to receive(:configure_firewall) end it "enables the sshd service if enabled in the proposal" do diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-firewall-4.3.9/test/lib/y2firewall/dialogs/main_test.rb new/yast2-firewall-4.3.10/test/lib/y2firewall/dialogs/main_test.rb --- old/yast2-firewall-4.3.9/test/lib/y2firewall/dialogs/main_test.rb 2020-10-31 13:34:18.000000000 +0100 +++ new/yast2-firewall-4.3.10/test/lib/y2firewall/dialogs/main_test.rb 2021-02-12 16:00:27.000000000 +0100 @@ -30,6 +30,7 @@ before do firewall.reset allow(firewall).to receive(:read) + allow(firewall).to receive(:write_only).and_return(true) allow_any_instance_of(Y2Firewall::Widgets::OverviewTreePager) .to receive(:items).and_return([]) end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-firewall-4.3.9/test/lib/y2firewall/importer_strategies/suse_firewall_test.rb new/yast2-firewall-4.3.10/test/lib/y2firewall/importer_strategies/suse_firewall_test.rb --- old/yast2-firewall-4.3.9/test/lib/y2firewall/importer_strategies/suse_firewall_test.rb 2020-10-31 13:34:18.000000000 +0100 +++ new/yast2-firewall-4.3.10/test/lib/y2firewall/importer_strategies/suse_firewall_test.rb 2021-02-12 16:00:27.000000000 +0100 @@ -67,6 +67,7 @@ context "when the profile is not empty" do before do + allow(Yast::Report).to receive(:Warning).with(/profile in use is based on SuSEFirewall2/) subject.import end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-firewall-4.3.9/test/lib/y2firewall/widgets/zone_test.rb new/yast2-firewall-4.3.10/test/lib/y2firewall/widgets/zone_test.rb --- old/yast2-firewall-4.3.9/test/lib/y2firewall/widgets/zone_test.rb 2020-10-31 13:34:18.000000000 +0100 +++ new/yast2-firewall-4.3.10/test/lib/y2firewall/widgets/zone_test.rb 2021-02-12 16:00:27.000000000 +0100 @@ -24,18 +24,30 @@ require "y2firewall/widgets/zone" describe Y2Firewall::Dialogs::NameWidget do + before do + allow(Yast::Report).to receive(:Error).with(/provide a valid alphanumeric name/) + end + subject { described_class.new(double(name: "test")) } include_examples "CWM::AbstractWidget" end describe Y2Firewall::Dialogs::ShortWidget do + before do + allow(Yast::Report).to receive(:Error).with(/provide a short name/) + end + subject { described_class.new(double(short: "test")) } include_examples "CWM::AbstractWidget" end describe Y2Firewall::Dialogs::DescriptionWidget do + before do + allow(Yast::Report).to receive(:Error).with(/provide a description/) + end + subject { described_class.new(double(description: "test")) } include_examples "CWM::AbstractWidget" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-firewall-4.3.9/test/test_helper.rb new/yast2-firewall-4.3.10/test/test_helper.rb --- old/yast2-firewall-4.3.9/test/test_helper.rb 2020-10-31 13:34:18.000000000 +0100 +++ new/yast2-firewall-4.3.10/test/test_helper.rb 2021-02-12 16:00:27.000000000 +0100 @@ -33,9 +33,9 @@ end # stub classes from other modules to speed up a build -stub_module("AutoInstall") # rubocop:disable Style/SingleLineMethods # rubocop:disable Style/MethodName +stub_module("AutoInstall", Class.new { def self.issues_list; []; end }) stub_module("UsersSimple", Class.new { def self.GetRootPassword; "secret"; end }) # rubocop:enable Style/SingleLineMethods # rubocop:enable Style/MethodName @@ -44,6 +44,14 @@ ENV["LANG"] = "en_US.UTF-8" ENV["LC_ALL"] = "en_US.UTF-8" +RSpec.configure do |config| + config.mock_with :rspec do |c| + # make sure we mock only the existing methods + # https://relishapp.com/rspec/rspec-mocks/v/3-0/docs/verifying-doubles/partial-doubles + c.verify_partial_doubles = true + end +end + if ENV["COVERAGE"] require "simplecov" SimpleCov.start do @@ -53,12 +61,20 @@ # track all ruby files under src SimpleCov.track_files("#{srcdir}/**/*.rb") - # use coveralls for on-line code coverage reporting at Travis CI - if ENV["TRAVIS"] - require "coveralls" - SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new [ + # additionally use the LCOV format for on-line code coverage reporting at CI + if ENV["CI"] || ENV["COVERAGE_LCOV"] + require "simplecov-lcov" + + SimpleCov::Formatter::LcovFormatter.config do |c| + c.report_with_single_file = true + # this is the default Coveralls GitHub Action location + # https://github.com/marketplace/actions/coveralls-github-action + c.single_report_path = "coverage/lcov.info" + end + + SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[ SimpleCov::Formatter::HTMLFormatter, - Coveralls::SimpleCov::Formatter + SimpleCov::Formatter::LcovFormatter ] end end
