Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package yast2-sysconfig for openSUSE:Factory
checked in at 2021-02-26 21:58:06
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-sysconfig (Old)
and /work/SRC/openSUSE:Factory/.yast2-sysconfig.new.2378 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-sysconfig"
Fri Feb 26 21:58:06 2021 rev:44 rq:872291 version:4.3.3
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-sysconfig/yast2-sysconfig.changes
2020-08-14 13:08:57.513201727 +0200
+++
/work/SRC/openSUSE:Factory/.yast2-sysconfig.new.2378/yast2-sysconfig.changes
2021-02-26 21:58:09.651752814 +0100
@@ -1,0 +2,7 @@
+Mon Feb 15 07:43:53 UTC 2021 - Josef Reidinger <jreidin...@suse.com>
+
+- Adapted unit test to recent changes in Yast::Report (related to
+ bsc#1179893).
+- 4.3.3
+
+-------------------------------------------------------------------
Old:
----
yast2-sysconfig-4.3.2.tar.bz2
New:
----
yast2-sysconfig-4.3.3.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-sysconfig.spec ++++++
--- /var/tmp/diff_new_pack.mEbrDU/_old 2021-02-26 21:58:10.047753161 +0100
+++ /var/tmp/diff_new_pack.mEbrDU/_new 2021-02-26 21:58:10.047753161 +0100
@@ -1,7 +1,7 @@
#
# spec file for package yast2-sysconfig
#
-# Copyright (c) 2020 SUSE LINUX GmbH, Nuernberg, Germany.
+# Copyright (c) 2021 SUSE LLC
#
# All modifications and additions to the file contributed by third parties
# remain the property of their copyright owners, unless otherwise agreed
@@ -12,7 +12,7 @@
# license that conforms to the Open Source Definition (Version 1.9)
# published by the Open Source Initiative.
-# Please submit bugfixes or comments via http://bugs.opensuse.org/
+# Please submit bugfixes or comments via https://bugs.opensuse.org/
#
@@ -20,9 +20,9 @@
Summary: YaST2 - Sysconfig Editor
License: GPL-2.0-or-later
Group: System/YaST
-Version: 4.3.2
+Version: 4.3.3
Release: 0
-Url: https://github.com/yast/yast-sysconfig
+URL: https://github.com/yast/yast-sysconfig
Source0: %{name}-%{version}.tar.bz2
++++++ yast2-sysconfig-4.3.2.tar.bz2 -> yast2-sysconfig-4.3.3.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-sysconfig-4.3.2/.github/workflows/ci.yml
new/yast2-sysconfig-4.3.3/.github/workflows/ci.yml
--- old/yast2-sysconfig-4.3.2/.github/workflows/ci.yml 1970-01-01
01:00:00.000000000 +0100
+++ new/yast2-sysconfig-4.3.3/.github/workflows/ci.yml 2021-02-15
09:08:43.000000000 +0100
@@ -0,0 +1,71 @@
+
+# See
https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions
+
+name: CI
+
+on: [push, pull_request]
+
+jobs:
+ Tests:
+ runs-on: ubuntu-latest
+ container: registry.opensuse.org/yast/head/containers/yast-ruby:latest
+
+ steps:
+
+ - name: Git Checkout
+ uses: actions/checkout@v2
+
+ # just for easier debugging...
+ - name: Inspect Installed Packages
+ run: rpm -qa | sort
+
+ - name: Unit Tests
+ run: rake test:unit
+ # enable code coverage reporting
+ env:
+ COVERAGE: 1
+
+ # send the coverage report to coveralls.io
+ - name: Coveralls Report
+ uses: coverallsapp/github-action@master
+ with:
+ github-token: ${{ secrets.GITHUB_TOKEN }}
+
+ Package:
+ runs-on: ubuntu-latest
+ container: registry.opensuse.org/yast/head/containers/yast-ruby:latest
+
+ steps:
+
+ - name: Git Checkout
+ uses: actions/checkout@v2
+
+ - name: Package Build
+ run: yast-ci-ruby -o package
+
+ Yardoc:
+ runs-on: ubuntu-latest
+ container: registry.opensuse.org/yast/head/containers/yast-ruby:latest
+
+ steps:
+
+ - name: Git Checkout
+ uses: actions/checkout@v2
+
+ - name: Yardoc
+ # FIXME: you can just run "yardoc" if "check:doc" task is too strict...
+ run: rake check:doc
+
+ # downloading the Docker image takes some time so bundling several fast
+ # checks into one job avoids that overhead
+ Checks:
+ runs-on: ubuntu-latest
+ container: registry.opensuse.org/yast/head/containers/yast-ruby:latest
+
+ steps:
+
+ - name: Git Checkout
+ uses: actions/checkout@v2
+
+ - name: POT Check
+ run: rake check:pot
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-sysconfig-4.3.2/.travis.yml
new/yast2-sysconfig-4.3.3/.travis.yml
--- old/yast2-sysconfig-4.3.2/.travis.yml 2020-08-12 12:07:11.000000000
+0200
+++ new/yast2-sysconfig-4.3.3/.travis.yml 1970-01-01 01:00:00.000000000
+0100
@@ -1,11 +0,0 @@
-sudo: required
-language: bash
-services:
- - docker
-
-before_install:
- - docker build -t yast-sysconfig-image .
-script:
- # the "yast-travis-ruby" script is included in the base yastdevel/ruby image
- # see https://github.com/yast/docker-yast-ruby/blob/master/yast-travis-ruby
- - docker run -it --privileged -e TRAVIS=1 -e TRAVIS_JOB_ID="$TRAVIS_JOB_ID"
yast-sysconfig-image yast-travis-ruby
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-sysconfig-4.3.2/Dockerfile
new/yast2-sysconfig-4.3.3/Dockerfile
--- old/yast2-sysconfig-4.3.2/Dockerfile 2020-08-12 12:07:11.000000000
+0200
+++ new/yast2-sysconfig-4.3.3/Dockerfile 1970-01-01 01:00:00.000000000
+0100
@@ -1,3 +0,0 @@
-FROM registry.opensuse.org/yast/head/containers/yast-ruby:latest
-COPY . /usr/src/app
-
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-sysconfig-4.3.2/README.md
new/yast2-sysconfig-4.3.3/README.md
--- old/yast2-sysconfig-4.3.2/README.md 2020-08-12 12:07:11.000000000 +0200
+++ new/yast2-sysconfig-4.3.3/README.md 2021-02-15 09:08:43.000000000 +0100
@@ -1,5 +1,9 @@
# YaST - The Sysconfig Module #
-[](https://travis-ci.org/yast/yast-sysconfig)
-[](https://ci.opensuse.org/view/Yast/job/yast-sysconfig-master/)
+[](
+https://github.com/yast/yast-sysconfig/actions?query=branch%3Amaster)
+[](
+https://ci.opensuse.org/view/Yast/job/yast-yast-sysconfig-master/)
+[](https://coveralls.io/r/yast/yast-sysconfig?branch=master)
+[](http://inch-ci.org/github/yast/yast-sysconfig)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-sysconfig-4.3.2/package/yast2-sysconfig.changes
new/yast2-sysconfig-4.3.3/package/yast2-sysconfig.changes
--- old/yast2-sysconfig-4.3.2/package/yast2-sysconfig.changes 2020-08-12
12:07:11.000000000 +0200
+++ new/yast2-sysconfig-4.3.3/package/yast2-sysconfig.changes 2021-02-15
09:08:43.000000000 +0100
@@ -1,4 +1,11 @@
-------------------------------------------------------------------
+Mon Feb 15 07:43:53 UTC 2021 - Josef Reidinger <jreidin...@suse.com>
+
+- Adapted unit test to recent changes in Yast::Report (related to
+ bsc#1179893).
+- 4.3.3
+
+-------------------------------------------------------------------
Mon Aug 10 16:48:09 CEST 2020 - sch...@suse.de
- AutoYaST: Added supplements: autoyast(sysconfig) into the spec file
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-sysconfig-4.3.2/package/yast2-sysconfig.spec
new/yast2-sysconfig-4.3.3/package/yast2-sysconfig.spec
--- old/yast2-sysconfig-4.3.2/package/yast2-sysconfig.spec 2020-08-12
12:07:11.000000000 +0200
+++ new/yast2-sysconfig-4.3.3/package/yast2-sysconfig.spec 2021-02-15
09:08:43.000000000 +0100
@@ -18,7 +18,7 @@
Name: yast2-sysconfig
Summary: YaST2 - Sysconfig Editor
-Version: 4.3.2
+Version: 4.3.3
Release: 0
Url: https://github.com/yast/yast-sysconfig
Group: System/YaST
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-sysconfig-4.3.2/src/modules/Sysconfig.rb
new/yast2-sysconfig-4.3.3/src/modules/Sysconfig.rb
--- old/yast2-sysconfig-4.3.2/src/modules/Sysconfig.rb 2020-08-12
12:07:11.000000000 +0200
+++ new/yast2-sysconfig-4.3.3/src/modules/Sysconfig.rb 2021-02-15
09:08:43.000000000 +0100
@@ -1165,7 +1165,7 @@
# Restarts or reloads a service using #exec_action
# @see #exec_action
# @param name [String] service name
- # @param action [Symbol] :reload or :restart
+ # @param type [Symbol] :reload or :restart
# @return [Symbol] result returned by #exec_action
def exec_service_action(name, type = :reload)
case type
@@ -1194,7 +1194,7 @@
# Returns whether given service is active (info from systemd)
# If service is not found, reports error in UI and returns nil
#
- # @param service name
+ # @param service_name
# @return [Boolean] active?
def service_active?(service_name)
service_unit = Yast2::Systemd::Service.find(service_name)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-sysconfig-4.3.2/test/sysconfig_test.rb
new/yast2-sysconfig-4.3.3/test/sysconfig_test.rb
--- old/yast2-sysconfig-4.3.2/test/sysconfig_test.rb 2020-08-12
12:07:11.000000000 +0200
+++ new/yast2-sysconfig-4.3.3/test/sysconfig_test.rb 2021-02-15
09:08:43.000000000 +0100
@@ -176,7 +176,13 @@
let(:nodns_var_id) { "#{nodns_var}$#{postfix_file}" }
let(:nodns_value) { "yes" }
- before { sysconfig.Read }
+ before do
+ # mock service operations
+ service = double("postfix_service", active?: true, reload: true,
restart: true)
+ allow(Yast2::Systemd::Service).to
receive(:find).with("postfix").and_return service
+
+ sysconfig.Read
+ end
it "writes all the modified values" do
# This methods are private
@@ -186,8 +192,10 @@
expect(Yast::SCR).to receive(:Write)
.with(path(".syseditor.value.\"#{postfix_file}\".#{myhostname_var}"),
myhostname_value)
+ .and_return(true)
expect(Yast::SCR).to receive(:Write)
.with(path(".syseditor.value.\"#{postfix_file}\".#{nullclient_var}"),
nullclient_value)
+ .and_return(true)
# Flush
expect(Yast::SCR).to receive(:Write).with(path(".syseditor"), nil)
@@ -198,11 +206,12 @@
it "restarts associated services" do
allow(Yast::SCR).to receive(:Write).with(path_matching(/^\.syseditor/),
anything)
+ .and_return(true)
service = double("postfix_service")
allow(Yast2::Systemd::Service).to
receive(:find).with("postfix").and_return service
expect(service).to receive(:active?).and_return true
- expect(service).to receive(:restart)
+ expect(service).to receive(:restart).and_return true
sysconfig.set_value(nullclient_var_id, nullclient_value, false, false)
sysconfig.Write
@@ -210,11 +219,12 @@
it "reloads associated services" do
allow(Yast::SCR).to receive(:Write).with(path_matching(/^\.syseditor/),
anything)
+ .and_return(true)
service = double("postfix_service")
allow(Yast2::Systemd::Service).to
receive(:find).with("postfix").and_return service
expect(service).to receive(:active?).and_return true
- expect(service).to receive(:reload)
+ expect(service).to receive(:reload).and_return true
sysconfig.set_value(nodns_var_id, nodns_value, false, false)
sysconfig.Write
@@ -222,6 +232,7 @@
it "runs associated commands" do
allow(Yast::SCR).to receive(:Write).with(path_matching(/^\.syseditor/),
anything)
+ .and_return(true)
expect(Yast::SCR).to receive(:Execute)
.with(path(".target.bash_output"), /echo example command/)
.and_return({"exit" => 0, "stdout" => "", "stderr" => ""})
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-sysconfig-4.3.2/test/test_helper.rb
new/yast2-sysconfig-4.3.3/test/test_helper.rb
--- old/yast2-sysconfig-4.3.2/test/test_helper.rb 2020-08-12
12:07:11.000000000 +0200
+++ new/yast2-sysconfig-4.3.3/test/test_helper.rb 2021-02-15
09:08:43.000000000 +0100
@@ -24,21 +24,37 @@
require "yast"
require "yast/rspec"
+RSpec.configure do |config|
+ config.mock_with :rspec do |mocks|
+ # make sure we mock only the existing methods
+ mocks.verify_partial_doubles = true
+ end
+end
+
if ENV["COVERAGE"]
require "simplecov"
SimpleCov.start do
add_filter "/test/"
end
- # for coverage we need to load all ruby files
- Dir["#{SRC_PATH}/modules/**/*.rb"].each { |f| require_relative f }
+ src_location = File.expand_path("../src", __dir__)
+ # track all ruby files under src
+ SimpleCov.track_files("#{src_location}/**/*.rb")
+
+ # additionally use the LCOV format for on-line code coverage reporting at CI
+ if ENV["CI"] || ENV["COVERAGE_LCOV"]
+ require "simplecov-lcov"
+
+ SimpleCov::Formatter::LcovFormatter.config do |c|
+ c.report_with_single_file = true
+ # this is the default Coveralls GitHub Action location
+ # https://github.com/marketplace/actions/coveralls-github-action
+ c.single_report_path = "coverage/lcov.info"
+ end
- # use coveralls for on-line code coverage reporting at Travis CI
- if ENV["TRAVIS"]
- require "coveralls"
SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
SimpleCov::Formatter::HTMLFormatter,
- Coveralls::SimpleCov::Formatter
+ SimpleCov::Formatter::LcovFormatter
]
end
end
