Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package yast2-packager for openSUSE:Factory checked in at 2021-02-26 21:58:41 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2-packager (Old) and /work/SRC/openSUSE:Factory/.yast2-packager.new.2378 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-packager" Fri Feb 26 21:58:41 2021 rev:407 rq:873818 version:4.3.14 Changes: -------- --- /work/SRC/openSUSE:Factory/yast2-packager/yast2-packager.changes 2021-01-19 15:59:47.787162495 +0100 +++ /work/SRC/openSUSE:Factory/.yast2-packager.new.2378/yast2-packager.changes 2021-02-26 21:58:46.923785548 +0100 @@ -0,0 +1,16 @@ +Fri Feb 19 14:07:15 UTC 2021 - Josef Reidinger <[email protected]> +------------------------------------------------------------------- + +- Show correct number of downloaded packages in log (bsc#1180278) +- Fix crash when installation proposal require pattern and such + pattern is not available in any repository (found during testing + jsc#SLE-17427) +- 4.3.14 + +------------------------------------------------------------------- +Mon Feb 15 20:07:15 UTC 2021 - Josef Reidinger <[email protected]> + +- Adapted unit test to recent changes in Yast::Report (related to + bsc#1179893). +- 4.3.13 + Old: ---- yast2-packager-4.3.12.tar.bz2 New: ---- yast2-packager-4.3.14.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-packager.spec ++++++ --- /var/tmp/diff_new_pack.79RQ7B/_old 2021-02-26 21:58:47.443786004 +0100 +++ /var/tmp/diff_new_pack.79RQ7B/_new 2021-02-26 21:58:47.443786004 +0100 @@ -17,7 +17,7 @@ Name: yast2-packager -Version: 4.3.12 +Version: 4.3.14 Release: 0 Summary: YaST2 - Package Library License: GPL-2.0-or-later ++++++ yast2-packager-4.3.12.tar.bz2 -> yast2-packager-4.3.14.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-packager-4.3.12/package/yast2-packager.changes new/yast2-packager-4.3.14/package/yast2-packager.changes --- old/yast2-packager-4.3.12/package/yast2-packager.changes 2021-01-15 14:33:35.000000000 +0100 +++ new/yast2-packager-4.3.14/package/yast2-packager.changes 2021-02-19 16:52:01.000000000 +0100 @@ -1,3 +1,19 @@ +Fri Feb 19 14:07:15 UTC 2021 - Josef Reidinger <[email protected]> +------------------------------------------------------------------- + +- Show correct number of downloaded packages in log (bsc#1180278) +- Fix crash when installation proposal require pattern and such + pattern is not available in any repository (found during testing + jsc#SLE-17427) +- 4.3.14 + +------------------------------------------------------------------- +Mon Feb 15 20:07:15 UTC 2021 - Josef Reidinger <[email protected]> + +- Adapted unit test to recent changes in Yast::Report (related to + bsc#1179893). +- 4.3.13 + ------------------------------------------------------------------- Fri Jan 15 12:11:32 UTC 2021 - Ancor Gonzalez Sosa <[email protected]> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-packager-4.3.12/package/yast2-packager.spec new/yast2-packager-4.3.14/package/yast2-packager.spec --- old/yast2-packager-4.3.12/package/yast2-packager.spec 2021-01-15 14:33:35.000000000 +0100 +++ new/yast2-packager-4.3.14/package/yast2-packager.spec 2021-02-19 16:52:01.000000000 +0100 @@ -17,7 +17,7 @@ Name: yast2-packager -Version: 4.3.12 +Version: 4.3.14 Release: 0 Summary: YaST2 - Package Library License: GPL-2.0-or-later diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-packager-4.3.12/src/modules/PackageSlideShow.rb new/yast2-packager-4.3.14/src/modules/PackageSlideShow.rb --- old/yast2-packager-4.3.12/src/modules/PackageSlideShow.rb 2021-01-15 14:33:35.000000000 +0100 +++ new/yast2-packager-4.3.14/src/modules/PackageSlideShow.rb 2021-02-19 16:52:01.000000000 +0100 @@ -811,7 +811,7 @@ @total_downloaded += @current_provide_size @total_count_downloaded += 1 - log.info "Downloaded #{@total_downloaded}/#{@total_count_to_download} packages" + log.info "Downloaded #{@total_count_downloaded}/#{@total_count_to_download} packages" # move the progress also for downloaded files UpdateTotalProgressValue() diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-packager-4.3.12/src/modules/Packages.rb new/yast2-packager-4.3.14/src/modules/Packages.rb --- old/yast2-packager-4.3.12/src/modules/Packages.rb 2021-01-15 14:33:35.000000000 +0100 +++ new/yast2-packager-4.3.14/src/modules/Packages.rb 2021-02-19 16:52:01.000000000 +0100 @@ -2540,7 +2540,7 @@ missing[type] = [] unless missing[type] # use quoted "summary" value for patterns as they usually contain spaces - name = (type == :pattern) ? statuses.first.summary.inspect : item + name = (type == :pattern && !statuses.empty?) ? statuses.first.summary.inspect : item missing[type] << name end end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-packager-4.3.12/test/addon_product_test.rb new/yast2-packager-4.3.14/test/addon_product_test.rb --- old/yast2-packager-4.3.12/test/addon_product_test.rb 2021-01-15 14:33:35.000000000 +0100 +++ new/yast2-packager-4.3.14/test/addon_product_test.rb 2021-02-19 16:52:01.000000000 +0100 @@ -302,6 +302,8 @@ expect(Yast::Package).to receive(:Install).with("yast2-registration").and_return(false) expect(Yast::WFM).to_not receive(:CallFunction) .with("inst_scc", ["register_media_addon", repo_id]) + # also error is shown + expect(Yast::Report).to receive(:Error) Yast::AddOnProduct.RegisterAddOnProduct(repo_id) end @@ -470,6 +472,7 @@ allow(subject).to receive(:Integrate) allow(subject).to receive(:AddRepo).with(repo["url"], repo["path"], repo["priority"]) .and_return(repo_id) + allow(Yast::Report).to receive(:Error) end it "adds the repository" do @@ -777,6 +780,7 @@ allow(Yast::FileUtils).to receive(:Exists).and_return(true) allow(Yast::XML).to receive(:XMLToYCPFile).and_raise(Yast::XMLDeserializationError) + allow(Yast::Report).to receive(:Error) end it "return empty array" do diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-packager-4.3.12/test/lib/clients/inst_productsources_test.rb new/yast2-packager-4.3.14/test/lib/clients/inst_productsources_test.rb --- old/yast2-packager-4.3.12/test/lib/clients/inst_productsources_test.rb 2021-01-15 14:33:35.000000000 +0100 +++ new/yast2-packager-4.3.14/test/lib/clients/inst_productsources_test.rb 2021-02-19 16:52:01.000000000 +0100 @@ -106,6 +106,8 @@ before do allow(Yast::Pkg).to receive(:RepositoryProbe).and_return("RPM-MD") allow(Yast::Pkg).to receive(:RepositoryAdd).and_return(1) + allow(Yast::Pkg).to receive(:SourceRefreshNow).and_return(true) + allow(Yast::Pkg).to receive(:SourceSetEnabled).and_return(true) end it "probes repo" do diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-packager-4.3.12/test/lib/widgets/product_license_confirmation_test.rb new/yast2-packager-4.3.14/test/lib/widgets/product_license_confirmation_test.rb --- old/yast2-packager-4.3.12/test/lib/widgets/product_license_confirmation_test.rb 2021-01-15 14:33:35.000000000 +0100 +++ new/yast2-packager-4.3.14/test/lib/widgets/product_license_confirmation_test.rb 2021-02-19 16:52:01.000000000 +0100 @@ -125,7 +125,8 @@ context "and license is still unconfirmed" do let(:license_confirmed?) { false } - it "returns false" do + it "reports the error and returns false" do + expect(Yast::Report).to receive(:Message) expect(widget.validate).to eq(false) end end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-packager-4.3.12/test/packages_test.rb new/yast2-packager-4.3.14/test/packages_test.rb --- old/yast2-packager-4.3.12/test/packages_test.rb 2021-01-15 14:33:35.000000000 +0100 +++ new/yast2-packager-4.3.14/test/packages_test.rb 2021-02-19 16:52:01.000000000 +0100 @@ -1856,4 +1856,15 @@ end end end + + describe "#check_missing_resolvables" do + it "does not crash for non available pattern" do + allow(Yast::PackagesProposal).to receive(:GetAllResolvablesForAllTypes) + .and_return(pattern: ["non-existing"]) + allow(Y2Packager::Resolvable).to receive(:find).with(kind: :pattern, name: "non-existing") + .and_return([]) + + expect(subject.send(:check_missing_resolvables)).to eq(pattern: ["non-existing"]) + end + end end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-packager-4.3.12/test/product_license_test.rb new/yast2-packager-4.3.14/test/product_license_test.rb --- old/yast2-packager-4.3.12/test/product_license_test.rb 2021-01-15 14:33:35.000000000 +0100 +++ new/yast2-packager-4.3.14/test/product_license_test.rb 2021-02-19 16:52:01.000000000 +0100 @@ -22,6 +22,7 @@ before do allow(Yast::Language).to receive(:GetLanguagesMap).and_return({}) allow(Yast::Language).to receive(:supported_language?).and_return(true) + allow(Yast::Report).to receive(:Error) # partial test does not fully mock end it "works" do diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-packager-4.3.12/test/repositories_include_test.rb new/yast2-packager-4.3.14/test/repositories_include_test.rb --- old/yast2-packager-4.3.12/test/repositories_include_test.rb 2021-01-15 14:33:35.000000000 +0100 +++ new/yast2-packager-4.3.14/test/repositories_include_test.rb 2021-02-19 16:52:01.000000000 +0100 @@ -78,6 +78,7 @@ before do # URL expansion returns nil (bsc#1059744) allow(Yast::Pkg).to receive(:ExpandedUrl).with(url).and_return(nil) + allow(Yast::Report).to receive(:Error) end it "returns :again symbol" do
