Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package chromium for openSUSE:Factory checked in at 2021-03-10 08:49:47 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/chromium (Old) and /work/SRC/openSUSE:Factory/.chromium.new.2378 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "chromium" Wed Mar 10 08:49:47 2021 rev:285 rq:877004 version:89.0.4389.72 Changes: -------- --- /work/SRC/openSUSE:Factory/chromium/chromium.changes 2021-02-23 20:21:17.535702774 +0100 +++ /work/SRC/openSUSE:Factory/.chromium.new.2378/chromium.changes 2021-03-10 08:51:44.978548010 +0100 @@ -1,0 +2,67 @@ +Fri Mar 5 11:44:48 UTC 2021 - Callum Farmer <gm...@opensuse.org> + +- Update to 89.0.4389.72 bsc#1182960 + - CVE-2021-21159: Heap buffer overflow in TabStrip. + - CVE-2021-21160: Heap buffer overflow in WebAudio. + - CVE-2021-21161: Heap buffer overflow in TabStrip. + - CVE-2021-21162: Use after free in WebRTC. + - CVE-2021-21163: Insufficient data validation in Reader Mode. + - CVE-2021-21164: Insufficient data validation in Chrome for iOS. + - CVE-2021-21165: Object lifecycle issue in audio. + - CVE-2021-21166: Object lifecycle issue in audio. + - CVE-2021-21167: Use after free in bookmarks. + - CVE-2021-21168: Insufficient policy enforcement in appcache. + - CVE-2021-21169: Out of bounds memory access in V8. + - CVE-2021-21170: Incorrect security UI in Loader. + - CVE-2021-21171: Incorrect security UI in TabStrip and Navigation. + - CVE-2021-21172: Insufficient policy enforcement in File System API. + - CVE-2021-21173: Side-channel information leakage in Network Internals. + - CVE-2021-21174: Inappropriate implementation in Referrer. + - CVE-2021-21175: Inappropriate implementation in Site isolation. + - CVE-2021-21176: Inappropriate implementation in full screen mode. + - CVE-2021-21177: Insufficient policy enforcement in Autofill. + - CVE-2021-21178: Inappropriate implementation in Compositing. + - CVE-2021-21179: Use after free in Network Internals. + - CVE-2021-21180: Use after free in tab search. + - CVE-2020-27844: Heap buffer overflow in OpenJPEG. + - CVE-2021-21181: Side-channel information leakage in autofill. + - CVE-2021-21182: Insufficient policy enforcement in navigations. + - CVE-2021-21183: Inappropriate implementation in performance APIs. + - CVE-2021-21184: Inappropriate implementation in performance APIs. + - CVE-2021-21185: Insufficient policy enforcement in extensions. + - CVE-2021-21186: Insufficient policy enforcement in QR scanning. + - CVE-2021-21187: Insufficient data validation in URL formatting. + - CVE-2021-21188: Use after free in Blink. + - CVE-2021-21189: Insufficient policy enforcement in payments. + - CVE-2021-21190: Uninitialized Use in PDFium. +- Added patches: + - chromium-89-quiche-private.patch + - chromium-89-quiche-dcheck.patch + - chromium-89-skia-CropRect.patch + - chromium-89-dawn-include.patch + - chromium-89-webcodecs-deps.patch + - chromium-89-EnumTable-crash.patch + - chromium-shim_headers.patch + - chromium-89-missing-cstring-header.patch + - chromium-89-AXTreeSerializer-include.patch + - chromium-88-gcc-fix-swiftshader-libEGL-visibility.patch + (bsc#1182775) +- Removed patches: + - chromium-fix-char_traits.patch + - build-with-pipewire-0.3.patch + - chromium-79-gcc-protobuf-alignas.patch + - chromium-87-CursorFactory-include.patch + - chromium-87-openscreen-include.patch + - chromium-88-vaapi-attribute.patch + - chromium-88-ozone-deps.patch + - chromium-87-webcodecs-deps.patch + - chromium-88-ityp-include.patch + - chromium-88-AXTreeFormatter-include.patch + - chromium-88-BookmarkModelObserver-include.patch + - chromium-88-federated_learning-include.patch + - chromium-88-ideographicSpaceCharacter.patch + - chromium-88-StringPool-include.patch + - chromium-88-dawn-static.patch + - chromium-88-CompositorFrameReporter-dcheck.patch + +------------------------------------------------------------------- Old: ---- build-with-pipewire-0.3.patch chromium-79-gcc-protobuf-alignas.patch chromium-87-CursorFactory-include.patch chromium-87-openscreen-include.patch chromium-87-webcodecs-deps.patch chromium-88-AXTreeFormatter-include.patch chromium-88-BookmarkModelObserver-include.patch chromium-88-CompositorFrameReporter-dcheck.patch chromium-88-StringPool-include.patch chromium-88-dawn-static.patch chromium-88-federated_learning-include.patch chromium-88-ideographicSpaceCharacter.patch chromium-88-ityp-include.patch chromium-88-ozone-deps.patch chromium-88-vaapi-attribute.patch chromium-88.0.4324.182.tar.xz chromium-fix-char_traits.patch New: ---- chromium-88-gcc-fix-swiftshader-libEGL-visibility.patch chromium-89-AXTreeSerializer-include.patch chromium-89-EnumTable-crash.patch chromium-89-dawn-include.patch chromium-89-missing-cstring-header.patch chromium-89-quiche-dcheck.patch chromium-89-quiche-private.patch chromium-89-skia-CropRect.patch chromium-89-webcodecs-deps.patch chromium-89.0.4389.72.tar.xz chromium-shim_headers.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ chromium.spec ++++++ --- /var/tmp/diff_new_pack.t9y50H/_old 2021-03-10 08:51:53.246556544 +0100 +++ /var/tmp/diff_new_pack.t9y50H/_new 2021-03-10 08:51:53.250556548 +0100 @@ -49,7 +49,7 @@ %endif %bcond_with clang Name: chromium -Version: 88.0.4324.182 +Version: 89.0.4389.72 Release: 0 Summary: Google's open source browser project License: BSD-3-Clause AND LGPL-2.1-or-later @@ -72,8 +72,6 @@ Patch4: chromium-buildname.patch Patch5: chromium-system-libusb.patch Patch6: gcc-enable-lto.patch -Patch7: chromium-fix-char_traits.patch -Patch9: build-with-pipewire-0.3.patch # Do not use unrar code, it is non-free Patch10: chromium-norar.patch # revert location on old GCC on 15.1, 15.2 gets it right tho @@ -83,7 +81,6 @@ Patch14: chromium-lp151-old-drm.patch # gentoo/fedora/arch patchset Patch50: chromium-78-protobuf-RepeatedPtrField-export.patch -Patch51: chromium-79-gcc-protobuf-alignas.patch Patch52: chromium-80-QuicStreamSendBuffer-deleted-move-constructor.patch Patch53: chromium-84-blink-disable-clang-format.patch Patch54: chromium-88-compiler.patch @@ -93,21 +90,18 @@ Patch58: chromium-86-nearby-include.patch Patch60: chromium-86-f_seal.patch Patch61: chromium-gcc11.patch -Patch62: chromium-87-CursorFactory-include.patch -Patch63: chromium-87-openscreen-include.patch -Patch65: chromium-88-vaapi-attribute.patch -Patch66: chromium-88-ozone-deps.patch -Patch67: chromium-87-webcodecs-deps.patch Patch68: chromium-lp152-missing-includes.patch -Patch71: chromium-88-ityp-include.patch -Patch72: chromium-88-AXTreeFormatter-include.patch -Patch73: chromium-88-BookmarkModelObserver-include.patch -Patch74: chromium-88-federated_learning-include.patch -Patch75: chromium-88-ideographicSpaceCharacter.patch -Patch76: chromium-88-StringPool-include.patch -Patch77: chromium-88-dawn-static.patch -Patch78: chromium-88-CompositorFrameReporter-dcheck.patch Patch79: chromium-glibc-2.33.patch +Patch80: chromium-89-quiche-private.patch +Patch81: chromium-89-quiche-dcheck.patch +Patch82: chromium-89-skia-CropRect.patch +Patch83: chromium-89-dawn-include.patch +Patch84: chromium-89-webcodecs-deps.patch +Patch85: chromium-89-EnumTable-crash.patch +Patch86: chromium-shim_headers.patch +Patch87: chromium-89-missing-cstring-header.patch +Patch88: chromium-89-AXTreeSerializer-include.patch +Patch89: chromium-88-gcc-fix-swiftshader-libEGL-visibility.patch # Google seem not too keen on merging this but GPU accel is quite important # https://chromium-review.googlesource.com/c/chromium/src/+/532294 # https://github.com/saiarcot895/chromium-ubuntu-build/tree/master/debian/patches @@ -189,6 +183,7 @@ BuildRequires: pkgconfig(libwebp) >= 0.4.0 BuildRequires: pkgconfig(libxml-2.0) >= 2.9.5 BuildRequires: pkgconfig(libxslt) +BuildRequires: pkgconfig(xshmfence) BuildRequires: pkgconfig(minizip) BuildRequires: pkgconfig(nspr) >= 4.9.5 BuildRequires: pkgconfig(nss) >= 3.26 @@ -291,6 +286,7 @@ %setup -q -n %{rname}-%{version} %autopatch -p1 +%build # Fix the path to nodejs binary mkdir -p third_party/node/linux/node-linux-x64/bin ln -s %{_bindir}/node third_party/node/linux/node-linux-x64/bin/node @@ -325,13 +321,6 @@ third_party/angle/src/third_party/libXNVCtrl third_party/angle/src/third_party/trace_event third_party/angle/src/third_party/volk - third_party/angle/third_party/glslang - third_party/angle/third_party/spirv-headers - third_party/angle/third_party/spirv-tools - third_party/angle/third_party/vulkan-headers - third_party/angle/third_party/vulkan-loader - third_party/angle/third_party/vulkan-tools - third_party/angle/third_party/vulkan-validation-layers third_party/apple_apsl third_party/axe-core third_party/blink @@ -388,7 +377,6 @@ third_party/fusejs/dist third_party/libgifcodec third_party/libxcb-keysyms/keysyms - third_party/glslang third_party/google_input_tools third_party/google_input_tools/third_party/closure_library third_party/google_input_tools/third_party/closure_library/third_party/closure @@ -414,9 +402,11 @@ third_party/libsrtp third_party/libsync third_party/libudev + third_party/liburlpattern third_party/libwebm third_party/libx11/src third_party/libxml/chromium + third_party/libva_protected_content third_party/libyuv third_party/lottie third_party/lss @@ -449,6 +439,7 @@ third_party/pdfium/third_party/libtiff third_party/pdfium/third_party/skia_shared third_party/perfetto + third_party/perfetto/protos/third_party/chromium third_party/pffft third_party/ply third_party/polymer @@ -462,7 +453,6 @@ third_party/s2cellid third_party/schema_org third_party/securemessage - third_party/shaka-player third_party/shell-encryption third_party/simplejson third_party/skia @@ -471,8 +461,6 @@ third_party/skia/include/third_party/vulkan/ third_party/skia/include/third_party/skcms/ third_party/smhasher - third_party/spirv-headers - third_party/SPIRV-Tools third_party/sqlite third_party/swiftshader third_party/swiftshader/third_party/astc-encoder @@ -528,14 +516,12 @@ %endif # needed due to bugs in GN keeplibs+=( - third_party/adobe third_party/speech-dispatcher third_party/usb_ids third_party/xdg-utils ) build/linux/unbundle/remove_bundled_libraries.py "${keeplibs[@]}" --do-remove -%build # GN sets lto on its own and we need just ldflag options, not cflags %define _lto_cflags %{nil} %if %{with clang} @@ -564,10 +550,10 @@ export AR=ar export NM=nm %if 0%{?suse_version} <= 1500 +mkdir -p "$HOME/bin/" export CC=gcc-10 export CXX=g++-10 # some still call gcc/g++ -mkdir -p "$HOME/bin/" ln -sfn %{_bindir}/$CC $HOME/bin/gcc ln -sfn %{_bindir}/$CXX $HOME/bin/g++ export PATH="$HOME/bin/:$PATH" @@ -662,7 +648,7 @@ myconf_gn+=" enable_vulkan=true" %if %{with pipewire} myconf_gn+=" rtc_use_pipewire=true rtc_link_pipewire=true" -myconf_gn+=" rtc_use_pipewire_version=\"0.3\"" +myconf_gn+=" rtc_pipewire_version=\"0.3\"" %endif %if %{with clang} myconf_gn+=" is_clang=true clang_base_path=\"/usr\" clang_use_chrome_plugins=false" ++++++ chromium-86-fix-vaapi-on-intel.patch ++++++ --- /var/tmp/diff_new_pack.t9y50H/_old 2021-03-10 08:51:53.298556597 +0100 +++ /var/tmp/diff_new_pack.t9y50H/_new 2021-03-10 08:51:53.298556597 +0100 @@ -5,7 +5,7 @@ return VA_RT_FORMAT_YUV420; } -+#if defined(OS_ANDROID) || defined(OS_CHROMEOS) ++#if defined(OS_ANDROID) || BUILDFLAG(IS_CHROMEOS_ASH) // Returns true if the CPU is an Intel Gemini Lake or later (including Kaby // Lake) Cpu platform id's are referenced from the following file in kernel // source arch/x86/include/asm/intel-family.h @@ -21,7 +21,7 @@ if (output_mode_ == VideoDecodeAccelerator::Config::OutputMode::IMPORT) return BufferAllocationMode::kNormal; -+#if defined(OS_ANDROID) || defined(OS_CHROMEOS) ++#if defined(OS_ANDROID) || BUILDFLAG(IS_CHROMEOS_ASH) + // Move this to chromeOs only as it is causing problem in some intel linux drivers // On Gemini Lake, Kaby Lake and later we can pass to libva the client's // PictureBuffers to decode onto, which skips the use of the Vpp unit and its ++++++ chromium-88-gcc-fix-swiftshader-libEGL-visibility.patch ++++++ diff -up chromium-88.0.4324.182/third_party/swiftshader/src/OpenGL/libEGL/BUILD.gn.gcc-swiftshader-visibility chromium-88.0.4324.182/third_party/swiftshader/src/OpenGL/libEGL/BUILD.gn --- chromium-88.0.4324.182/third_party/swiftshader/src/OpenGL/libEGL/BUILD.gn.gcc-swiftshader-visibility 2021-02-25 16:31:51.929335783 +0000 +++ chromium-88.0.4324.182/third_party/swiftshader/src/OpenGL/libEGL/BUILD.gn 2021-02-25 16:31:51.929335783 +0000 @@ -42,7 +42,8 @@ config("swiftshader_libEGL_private_confi } else if (is_clang) { defines += [ "EGLAPI=__attribute__((visibility(\"protected\"))) __attribute__((no_sanitize(\"function\")))" ] } else { - defines += [ "EGLAPI= " ] + cflags += [ "-fvisibility=protected" ] + defines += [ "EGLAPI=__attribute__((visibility(\"protected\")))" ] } } } diff -up chromium-88.0.4324.182/third_party/swiftshader/src/OpenGL/libGLESv2/BUILD.gn.gcc-swiftshader-visibility chromium-88.0.4324.182/third_party/swiftshader/src/OpenGL/libGLESv2/BUILD.gn --- chromium-88.0.4324.182/third_party/swiftshader/src/OpenGL/libGLESv2/BUILD.gn.gcc-swiftshader-visibility 2021-02-25 18:16:28.576901417 +0000 +++ chromium-88.0.4324.182/third_party/swiftshader/src/OpenGL/libGLESv2/BUILD.gn 2021-02-25 18:17:50.356567690 +0000 @@ -57,7 +57,8 @@ config("swiftshader_libGLESv2_private_co } else if (is_clang) { defines += [ "GL_APICALL=__attribute__((visibility(\"protected\"))) __attribute__((no_sanitize(\"function\")))" ] } else { - defines += [ "GL_APICALL= " ] + cflags += [ "-fvisibility=protected" ] + defines += [ "GL_APICALL=__attribute__((visibility(\"protected\")))" ] } } } ++++++ chromium-89-AXTreeSerializer-include.patch ++++++ >From c06ddc4935bf1394812c011ce5d93898ccc8a53a Mon Sep 17 00:00:00 2001 From: Stephan Hartmann <sth...@googlemail.com> Date: Tue, 09 Feb 2021 19:22:57 +0000 Subject: [PATCH] IWYU: add ctime for std::time Bug: None Change-Id: I8bdae43209984242b9f5e538d74ece4409b65e3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2679610 Reviewed-by: Katie Dektar <ka...@chromium.org> Commit-Queue: Katie Dektar <ka...@chromium.org> Cr-Commit-Position: refs/heads/master@{#852287} --- diff --git a/ui/accessibility/ax_tree_serializer.h b/ui/accessibility/ax_tree_serializer.h index ddbbdcd..1790e3b 100644 --- a/ui/accessibility/ax_tree_serializer.h +++ b/ui/accessibility/ax_tree_serializer.h @@ -8,6 +8,7 @@ #include <stddef.h> #include <stdint.h> +#include <ctime> #include <ostream> #include <unordered_map> #include <unordered_set> ++++++ chromium-89-EnumTable-crash.patch ++++++ diff --git a/components/cast_channel/enum_table.h b/components/cast_channel/enum_table.h index e3130c7..2ad16ea 100644 --- a/components/cast_channel/enum_table.h +++ b/components/cast_channel/enum_table.h @@ -212,7 +212,7 @@ class template <typename E> friend class EnumTable; - DISALLOW_COPY_AND_ASSIGN(GenericEnumTableEntry); + DISALLOW_ASSIGN(GenericEnumTableEntry); }; // Yes, these constructors really needs to be inlined. Even though they look @@ -250,8 +250,7 @@ class EnumTable { // Constructor for regular entries. constexpr Entry(E value, base::StringPiece str) : GenericEnumTableEntry(static_cast<int32_t>(value), str) {} - - DISALLOW_COPY_AND_ASSIGN(Entry); + DISALLOW_ASSIGN(Entry); }; static_assert(sizeof(E) <= sizeof(int32_t), @@ -306,15 +305,14 @@ class EnumTable { if (is_sorted_) { const std::size_t index = static_cast<std::size_t>(value); if (ANALYZER_ASSUME_TRUE(index < data_.size())) { - const auto& entry = data_.begin()[index]; + const auto& entry = data_[index]; if (ANALYZER_ASSUME_TRUE(entry.has_str())) return entry.str(); } return base::nullopt; } return GenericEnumTableEntry::FindByValue( - reinterpret_cast<const GenericEnumTableEntry*>(data_.begin()), - data_.size(), static_cast<int32_t>(value)); + &data_[0], data_.size(), static_cast<int32_t>(value)); } // This overload of GetString is designed for cases where the argument is a @@ -342,8 +340,7 @@ class EnumTable { // enum value directly. base::Optional<E> GetEnum(base::StringPiece str) const { auto* entry = GenericEnumTableEntry::FindByString( - reinterpret_cast<const GenericEnumTableEntry*>(data_.begin()), - data_.size(), str); + &data_[0], data_.size(), str); return entry ? static_cast<E>(entry->value) : base::Optional<E>(); } @@ -358,7 +355,7 @@ class EnumTable { // Align the data on a cache line boundary. alignas(64) #endif - std::initializer_list<Entry> data_; + const std::vector<Entry> data_; bool is_sorted_; constexpr EnumTable(std::initializer_list<Entry> data, bool is_sorted) @@ -370,8 +367,8 @@ class EnumTable { for (std::size_t i = 0; i < data.size(); i++) { for (std::size_t j = i + 1; j < data.size(); j++) { - const Entry& ei = data.begin()[i]; - const Entry& ej = data.begin()[j]; + const Entry& ei = data[i]; + const Entry& ej = data[j]; DCHECK(ei.value != ej.value) << "Found duplicate enum values at indices " << i << " and " << j; DCHECK(!(ei.has_str() && ej.has_str() && ei.str() == ej.str())) ++++++ chromium-89-dawn-include.patch ++++++ >From 5a56bfe8d281250a1deee0d116a9fcde65b9c29a Mon Sep 17 00:00:00 2001 From: Stephan Hartmann <sth...@googlemail.com> Date: Fri, 15 Jan 2021 18:37:05 +0000 Subject: [PATCH] IWYU: add various missing includes std::weak_ptr and std::shared_ptr require map *int*_t types require cstdint --- third_party/dawn/src/dawn_wire/client/Device.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/third_party/dawn/src/dawn_wire/client/Device.h b/third_party/dawn/src/dawn_wire/client/Device.h index 3f16700..1082549 100644 --- a/third_party/dawn/src/dawn_wire/client/Device.h +++ b/third_party/dawn/src/dawn_wire/client/Device.h @@ -22,7 +22,9 @@ #include "dawn_wire/client/ApiObjects_autogen.h" #include "dawn_wire/client/ObjectBase.h" +#include <cstdint> #include <map> +#include <memory> namespace dawn_wire { namespace client { -- 2.26.2 ++++++ chromium-89-missing-cstring-header.patch ++++++ diff -up chromium-89.0.4389.72/third_party/webrtc/audio/utility/channel_mixer.cc.missing-cstring chromium-89.0.4389.72/third_party/webrtc/audio/utility/channel_mixer.cc --- chromium-89.0.4389.72/third_party/webrtc/audio/utility/channel_mixer.cc.missing-cstring 2021-03-02 12:48:16.000000000 -0500 +++ chromium-89.0.4389.72/third_party/webrtc/audio/utility/channel_mixer.cc 2021-03-04 13:31:42.894817353 -0500 @@ -8,6 +8,8 @@ * be found in the AUTHORS file in the root of the source tree. */ +#include <cstring> + #include "audio/utility/channel_mixer.h" #include "audio/utility/channel_mixing_matrix.h" diff -up chromium-89.0.4389.72/third_party/webrtc/modules/desktop_capture/linux/base_capturer_pipewire.cc.missing-cstring chromium-89.0.4389.72/third_party/webrtc/modules/desktop_capture/linux/base_capturer_pipewire.cc --- chromium-89.0.4389.72/third_party/webrtc/modules/desktop_capture/linux/base_capturer_pipewire.cc.missing-cstring 2021-03-04 13:31:42.895817359 -0500 +++ chromium-89.0.4389.72/third_party/webrtc/modules/desktop_capture/linux/base_capturer_pipewire.cc 2021-03-04 13:45:27.795162431 -0500 @@ -23,6 +23,7 @@ #include <sys/mman.h> #include <sys/syscall.h> +#include <cstring> #include <memory> #include <utility> diff -up chromium-89.0.4389.72/third_party/webrtc/modules/video_coding/utility/ivf_file_reader.cc.missing-cstring chromium-89.0.4389.72/third_party/webrtc/modules/video_coding/utility/ivf_file_reader.cc --- chromium-89.0.4389.72/third_party/webrtc/modules/video_coding/utility/ivf_file_reader.cc.missing-cstring 2021-03-02 12:48:17.000000000 -0500 +++ chromium-89.0.4389.72/third_party/webrtc/modules/video_coding/utility/ivf_file_reader.cc 2021-03-04 13:31:42.895817359 -0500 @@ -10,6 +10,7 @@ #include "modules/video_coding/utility/ivf_file_reader.h" +#include <cstring> #include <string> #include <vector> ++++++ chromium-89-quiche-dcheck.patch ++++++ >From 7cd4eab0bfca6192f14d6143410e1ae774eb1c29 Mon Sep 17 00:00:00 2001 From: Stephan Hartmann <sth...@googlemail.com> Date: Thu, 31 Dec 2020 11:57:22 +0000 Subject: [PATCH] GCC: do not pass unique_ptr to DCHECK_NE, but the actual pointer DCHECK_NE comparison requires CheckOpValueStr to be defined for the type, or providing an output stream operator. A unique_ptr does not provide any. USE DCHECK instead. --- net/third_party/quiche/src/quic/core/quic_path_validator.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/third_party/quiche/src/quic/core/quic_path_validator.cc b/net/third_party/quiche/src/quic/core/quic_path_validator.cc index 0722216..fb2aeaf 100644 --- a/net/third_party/quiche/src/quic/core/quic_path_validator.cc +++ b/net/third_party/quiche/src/quic/core/quic_path_validator.cc @@ -68,7 +68,7 @@ void QuicPathValidator::OnPathResponse(const QuicPathFrameBuffer& probing_data, void QuicPathValidator::StartPathValidation( std::unique_ptr<QuicPathValidationContext> context, std::unique_ptr<ResultDelegate> result_delegate) { - DCHECK_NE(nullptr, context); + DCHECK(context); QUIC_DLOG(INFO) << "Start validating path " << *context << " via writer: " << context->WriterToUse(); if (path_context_ != nullptr) { -- 2.26.2 ++++++ chromium-89-quiche-private.patch ++++++ >From 1ee06c3678a85d158eb82d4af438d1e43a4c814e Mon Sep 17 00:00:00 2001 From: Stephan Hartmann <sth...@googlemail.com> Date: Sun, 6 Dec 2020 16:14:17 +0000 Subject: [PATCH] GCC: change make_visitor visibility to public GCC complains that make_visitor is used in private context from inner Iterator class. --- net/third_party/quiche/src/quic/core/quic_interval_set.h | 1 - 1 file changed, 1 deletion(-) diff --git a/net/third_party/quiche/src/quic/core/quic_interval_set.h b/net/third_party/quiche/src/quic/core/quic_interval_set.h index af64e29..7ee8978 100644 --- a/net/third_party/quiche/src/quic/core/quic_interval_set.h +++ b/net/third_party/quiche/src/quic/core/quic_interval_set.h @@ -1874,7 +1874,6 @@ class QUIC_NO_EXPORT QuicIntervalSet { return absl::visit([&](auto& s) { return s.Contains(min, max); }, qiset_); } - private: template <class A, class B, class C> struct overloader : A, B, C { overloader(A a, B b, C c) : A(a), B(b), C(c) {} -- 2.26.2 ++++++ chromium-89-skia-CropRect.patch ++++++ diff --git a/third_party/skia/include/effects/SkImageFilters.h b/third_party/skia/include/effects/SkImageFilters.h index 04cce0a..d06b007 100644 --- a/third_party/skia/include/effects/SkImageFilters.h +++ b/third_party/skia/include/effects/SkImageFilters.h @@ -23,6 +23,9 @@ class SkColorFilter; class SkPaint; class SkRegion; +constexpr SkRect kNoCropRect = {SK_ScalarNegativeInfinity, SK_ScalarNegativeInfinity, + SK_ScalarInfinity, SK_ScalarInfinity}; + // A set of factory functions providing useful SkImageFilter effects. For image filters that take an // input filter, providing nullptr means it will automatically use the dynamic source image. This // source depends on how the filter is applied, but is either the contents of a saved layer when @@ -33,8 +36,6 @@ public: // to those types as a crop rect for the image filter factories. It's not intended to be used // directly. struct CropRect { - static constexpr SkRect kNoCropRect = {SK_ScalarNegativeInfinity, SK_ScalarNegativeInfinity, - SK_ScalarInfinity, SK_ScalarInfinity}; CropRect() : fCropRect(kNoCropRect) {} // Intentionally not explicit so callers don't have to use this type but can use SkIRect or // SkRect as desired. diff --git a/third_party/skia/src/effects/imagefilters/SkImageFilters.cpp b/third_party/skia/src/effects/imagefilters/SkImageFilters.cpp index 5290b00..fb97fc1 100644 --- a/third_party/skia/src/effects/imagefilters/SkImageFilters.cpp +++ b/third_party/skia/src/effects/imagefilters/SkImageFilters.cpp @@ -47,10 +47,6 @@ static SkImageFilter::CropRect to_legacy_crop_rect(const SkImageFilters::CropRec : SkImageFilter::CropRect(SkRect::MakeEmpty(), 0x0); } -// Allow kNoCropRect to be referenced (for certain builds, e.g. macOS libFuzzer chromium target, -// see crbug.com/1139725) -constexpr SkRect SkImageFilters::CropRect::kNoCropRect; - void SkImageFilters::RegisterFlattenables() { SkAlphaThresholdFilter::RegisterFlattenables(); SkArithmeticImageFilter::RegisterFlattenables(); ++++++ chromium-87-webcodecs-deps.patch -> chromium-89-webcodecs-deps.patch ++++++ --- /work/SRC/openSUSE:Factory/chromium/chromium-87-webcodecs-deps.patch 2020-11-23 18:38:55.808649584 +0100 +++ /work/SRC/openSUSE:Factory/.chromium.new.2378/chromium-89-webcodecs-deps.patch 2021-03-10 08:49:54.414433887 +0100 @@ -1,27 +1,26 @@ -From 47f6a3bcf7e72c467ca6a2cd633a5c3585a218d5 Mon Sep 17 00:00:00 2001 +From b6f16f656bb8683f70ce8ce19791d594fce4163b Mon Sep 17 00:00:00 2001 From: Stephan Hartmann <sth...@googlemail.com> -Date: Fri, 2 Oct 2020 06:44:53 +0000 -Subject: [PATCH] add dependency on openh264:encoder +Date: Fri, 15 Jan 2021 19:54:08 +0000 +Subject: [PATCH] add dependency on opus in webcodecs -webcodecs uses openh264 encoder, but dependency is missing. With -unbundled openh264 library build fails, because include path is -incomplete. +webcodecs uses opus, but dependency is missing. With unbundled +opus library build fails, because include path is incomplete. --- third_party/blink/renderer/modules/webcodecs/BUILD.gn | 1 + 1 file changed, 1 insertion(+) diff --git a/third_party/blink/renderer/modules/webcodecs/BUILD.gn b/third_party/blink/renderer/modules/webcodecs/BUILD.gn -index 99d0e47..7c4d188 100644 +index 2c407ec..0474bfe 100644 --- a/third_party/blink/renderer/modules/webcodecs/BUILD.gn +++ b/third_party/blink/renderer/modules/webcodecs/BUILD.gn -@@ -54,6 +54,7 @@ blink_modules_sources("webcodecs") { +@@ -63,6 +63,7 @@ blink_modules_sources("webcodecs") { "//media/mojo/clients", "//media/mojo/mojom", "//third_party/libyuv:libyuv", -+ "//third_party/openh264:encoder", ++ "//third_party/opus", ] - public_deps = [ - "//third_party/blink/renderer/modules/mediastream:mediastream", + if (media_use_openh264) { + deps += [ "//third_party/openh264:encoder" ] -- 2.26.2 ++++++ chromium-88.0.4324.182.tar.xz -> chromium-89.0.4389.72.tar.xz ++++++ /work/SRC/openSUSE:Factory/chromium/chromium-88.0.4324.182.tar.xz /work/SRC/openSUSE:Factory/.chromium.new.2378/chromium-89.0.4389.72.tar.xz differ: char 26, line 1 ++++++ chromium-master-prefs-path.patch ++++++ --- /var/tmp/diff_new_pack.t9y50H/_old 2021-03-10 08:51:53.434556738 +0100 +++ /var/tmp/diff_new_pack.t9y50H/_new 2021-03-10 08:51:53.438556742 +0100 @@ -9,6 +9,6 @@ - if (!base::PathService::Get(base::DIR_EXE, &initial_prefs)) - return base::FilePath(); + initial_prefs = base::FilePath("/etc/chromium"); - return initial_prefs.AppendASCII(installer::kDefaultMasterPrefs); + return initial_prefs.AppendASCII(installer::kLegacyInitialPrefs); } ++++++ chromium-norar.patch ++++++ --- /var/tmp/diff_new_pack.t9y50H/_old 2021-03-10 08:51:53.446556750 +0100 +++ /var/tmp/diff_new_pack.t9y50H/_new 2021-03-10 08:51:53.446556750 +0100 @@ -84,7 +84,7 @@ --- chromium-86.0.4240.75.orig/chrome/services/file_util/BUILD.gn +++ chromium-86.0.4240.75/chrome/services/file_util/BUILD.gn @@ -15,7 +15,6 @@ source_set("file_util") { - "//base", + "//build:chromeos_buildflags", "//chrome/common/safe_browsing", "//chrome/common/safe_browsing:archive_analyzer_results", - "//chrome/common/safe_browsing:rar_analyzer", ++++++ chromium-shim_headers.patch ++++++ >From e273172bbafedca36984fc40f4aa6c44b79ac2ef Mon Sep 17 00:00:00 2001 From: Stephan Hartmann <sth...@googlemail.com> Date: Fri, 25 Dec 2020 09:10:32 +0000 Subject: [PATCH] shim_headers: fix outputs generation --- build/shim_headers.gni | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/build/shim_headers.gni b/build/shim_headers.gni index 0900cba..5138647 100644 --- a/build/shim_headers.gni +++ b/build/shim_headers.gni @@ -6,6 +6,8 @@ template("shim_headers") { action_name = "gen_${target_name}" config_name = "${target_name}_config" shim_headers_path = "${root_gen_dir}/shim_headers/${target_name}" + shim_root_path = rebase_path(invoker.root_path) + shim_rel_path = rebase_path("${shim_root_path}", rebase_path("//")) config(config_name) { include_dirs = [ shim_headers_path ] @@ -16,7 +18,7 @@ template("shim_headers") { args = [ "--generate", "--headers-root", - rebase_path(invoker.root_path), + "${shim_root_path}", "--output-directory", rebase_path(shim_headers_path), ] @@ -27,9 +29,10 @@ template("shim_headers") { ] } args += invoker.headers - - outputs = process_file_template(invoker.headers, - "${shim_headers_path}/{{source_file_part}}") + outputs = [] + foreach(shim_header, invoker.headers) { + outputs += [ "${shim_headers_path}/${shim_rel_path}/" + shim_header ] + } } group(target_name) { -- 2.26.2 ++++++ chromium-vaapi.patch ++++++ --- /var/tmp/diff_new_pack.t9y50H/_old 2021-03-10 08:51:53.478556784 +0100 +++ /var/tmp/diff_new_pack.t9y50H/_new 2021-03-10 08:51:53.478556784 +0100 @@ -1,46 +1,46 @@ diff -up chromium-88.0.4324.11/chrome/browser/about_flags.cc.accel-mjpeg chromium-88.0.4324.11/chrome/browser/about_flags.cc --- chromium-88.0.4324.11/chrome/browser/about_flags.cc.accel-mjpeg 2020-11-19 20:51:19.000000000 -0500 +++ chromium-88.0.4324.11/chrome/browser/about_flags.cc 2020-11-30 16:14:32.393366384 -0500 -@@ -3309,12 +3309,12 @@ const FeatureEntry kFeatureEntries[] = { +@@ -3526,12 +3526,12 @@ flag_descriptions::kWebXrForceRuntimeDescription, kOsDesktop, MULTI_VALUE_TYPE(kWebXrForceRuntimeChoices)}, #endif // ENABLE_VR --#if defined(OS_CHROMEOS) -+#if defined(OS_CHROMEOS) || defined(OS_LINUX) +-#if BUILDFLAG(IS_CHROMEOS_ASH) ++#if BUILDFLAG(IS_CHROMEOS_ASH) || (defined(OS_LINUX) && !defined(OS_ANDROID)) {"disable-accelerated-mjpeg-decode", flag_descriptions::kAcceleratedMjpegDecodeName, - flag_descriptions::kAcceleratedMjpegDecodeDescription, kOsCrOS, + flag_descriptions::kAcceleratedMjpegDecodeDescription, kOsCrOS | kOsLinux, SINGLE_DISABLE_VALUE_TYPE(switches::kDisableAcceleratedMjpegDecode)}, --#endif // OS_CHROMEOS -+#endif // OS_CHROMEOS || OS_LINUX +-#endif // BUILDFLAG(IS_CHROMEOS_ASH) ++#endif // BUILDFLAG(IS_CHROMEOS_ASH) || (defined(OS_LINUX) && !defined(OS_ANDROID)) {"system-keyboard-lock", flag_descriptions::kSystemKeyboardLockName, flag_descriptions::kSystemKeyboardLockDescription, kOsDesktop, FEATURE_VALUE_TYPE(features::kSystemKeyboardLock)}, diff -up chromium-88.0.4324.11/chrome/browser/flag_descriptions.cc.accel-mjpeg chromium-88.0.4324.11/chrome/browser/flag_descriptions.cc --- chromium-88.0.4324.11/chrome/browser/flag_descriptions.cc.accel-mjpeg 2020-11-30 16:14:32.393366384 -0500 +++ chromium-88.0.4324.11/chrome/browser/flag_descriptions.cc 2020-11-30 16:20:50.174195910 -0500 -@@ -3572,9 +3572,9 @@ const char kVideoToolboxVp9DecodingDescr - - #endif - --// Chrome OS ------------------------------------------------------------------- -+// Chrome OS and Linux --------------------------------------------------------- - --#if defined(OS_CHROMEOS) -+#if defined(OS_CHROMEOS) || (defined(OS_LINUX) && !defined(OS_ANDROID)) - +@@ -3704,12 +3704,24 @@ + "Settings. " + "See go/betterAM"; + ++#endif ++ ++// Chrome OS and Linux -------------------------------------------------------- ++ ++#if BUILDFLAG(IS_CHROMEOS_ASH) || (defined(OS_LINUX) && !defined(OS_ANDROID)) ++ const char kAcceleratedMjpegDecodeName[] = "Hardware-accelerated mjpeg decode for captured frame"; -@@ -3582,6 +3582,12 @@ const char kAcceleratedMjpegDecodeDescri + const char kAcceleratedMjpegDecodeDescription[] = "Enable hardware-accelerated mjpeg decode for captured frame where " "available."; - + +#endif + -+// Chrome OS ------------------------------------------------------------------- ++// Chrome OS ------------------------------------------------------------------ + -+#if defined(OS_CHROMEOS) ++#if BUILDFLAG(IS_CHROMEOS_ASH) + const char kAllowDisableMouseAccelerationName[] = "Allow disabling mouse acceleration"; @@ -48,24 +48,25 @@ diff -up chromium-88.0.4324.11/chrome/browser/flag_descriptions.h.accel-mjpeg chromium-88.0.4324.11/chrome/browser/flag_descriptions.h --- chromium-88.0.4324.11/chrome/browser/flag_descriptions.h.accel-mjpeg 2020-11-30 16:14:32.394366389 -0500 +++ chromium-88.0.4324.11/chrome/browser/flag_descriptions.h 2020-11-30 16:22:13.831601058 -0500 -@@ -2068,13 +2068,19 @@ extern const char kVideoToolboxVp9Decodi - - #endif // defined(OS_MAC) - --// Chrome OS ------------------------------------------------------------------ +@@ -2138,9 +2138,21 @@ + extern const char kAccountManagementFlowsV2Name[]; + extern const char kAccountManagementFlowsV2Description[]; + ++#endif ++ +// Chrome OS and Linux -------------------------------------------------------- - --#if defined(OS_CHROMEOS) -+#if defined(OS_CHROMEOS) || (defined(OS_LINUX) && !defined(OS_ANDROID)) - ++ ++#if BUILDFLAG(IS_CHROMEOS_ASH) || (defined(OS_LINUX) && !defined(OS_ANDROID)) ++ extern const char kAcceleratedMjpegDecodeName[]; extern const char kAcceleratedMjpegDecodeDescription[]; - + +#endif + -+// Chrome OS ------------------------------------------------------------------ ++#if BUILDFLAG(IS_CHROMEOS_ASH) + -+#if defined(OS_CHROMEOS) ++// Chrome OS ------------------------------------------------------------------ + extern const char kAllowDisableMouseAccelerationName[]; extern const char kAllowDisableMouseAccelerationDescription[]; + ++++++ gcc-enable-lto.patch ++++++ --- /var/tmp/diff_new_pack.t9y50H/_old 2021-03-10 08:51:53.502556809 +0100 +++ /var/tmp/diff_new_pack.t9y50H/_new 2021-03-10 08:51:53.502556809 +0100 @@ -23,7 +23,7 @@ + if (is_win) { default_compiler_configs += [ - "//build/config/win:default_crt", + "//build/config/win:default_cfg_compiler", Index: chromium-85.0.4183.69/build/config/compiler/BUILD.gn =================================================================== --- chromium-85.0.4183.69.orig/build/config/compiler/BUILD.gn