Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package libfilezilla for openSUSE:Factory checked in at 2021-03-20 21:26:16 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/libfilezilla (Old) and /work/SRC/openSUSE:Factory/.libfilezilla.new.2401 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libfilezilla" Sat Mar 20 21:26:16 2021 rev:38 rq:880240 version:0.27.1 Changes: -------- --- /work/SRC/openSUSE:Factory/libfilezilla/libfilezilla.changes 2021-03-11 20:13:20.428765660 +0100 +++ /work/SRC/openSUSE:Factory/.libfilezilla.new.2401/libfilezilla.changes 2021-03-20 21:26:36.413221010 +0100 @@ -1,0 +2,12 @@ +Sat Mar 20 10:27:40 UTC 2021 - ecsos <ec...@opensuse.org> + +- Update to 0.27.1 + * Bugfixes and minor changes: + - Fixed a socket event sequencing invariant violation in + tls_layer + - Fixed query_string constructor leaving object in undefined + state if set fails + - Fixed arguments passed from the templated equal_constime + helper + +------------------------------------------------------------------- Old: ---- libfilezilla-0.27.0.tar.bz2 New: ---- libfilezilla-0.27.1.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libfilezilla.spec ++++++ --- /var/tmp/diff_new_pack.ANUZSh/_old 2021-03-20 21:26:37.037221740 +0100 +++ /var/tmp/diff_new_pack.ANUZSh/_new 2021-03-20 21:26:37.037221740 +0100 @@ -20,7 +20,7 @@ %define libname %{name}%{major} %define develname %{name}-devel Name: libfilezilla -Version: 0.27.0 +Version: 0.27.1 Release: 0 Summary: C++ library for filezilla License: GPL-2.0-or-later ++++++ libfilezilla-0.27.0.tar.bz2 -> libfilezilla-0.27.1.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libfilezilla-0.27.0/NEWS new/libfilezilla-0.27.1/NEWS --- old/libfilezilla-0.27.0/NEWS 2021-03-04 14:27:18.000000000 +0100 +++ new/libfilezilla-0.27.1/NEWS 2021-03-15 09:01:00.000000000 +0100 @@ -1,3 +1,9 @@ +0.27.1 (2021-03-15) + +- Fixed a socket event sequencing invariant violation in tls_layer +- Fixed query_string constructor leaving object in undefined state if set fails +- Fixed arguments passed from the templated equal_constime helper + 0.27.0 (2021-03-04) + Added fz::normalize_hypens to replace all hyphen-like characters in a string with the good old hyphen-minus diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libfilezilla-0.27.0/configure new/libfilezilla-0.27.1/configure --- old/libfilezilla-0.27.0/configure 2021-03-04 14:27:25.000000000 +0100 +++ new/libfilezilla-0.27.1/configure 2021-03-15 09:01:07.000000000 +0100 @@ -1,6 +1,6 @@ #! /bin/sh # Guess values for system-dependent variables and create Makefiles. -# Generated by GNU Autoconf 2.69 for libfilezilla 0.27.0. +# Generated by GNU Autoconf 2.69 for libfilezilla 0.27.1. # # Report bugs to <tim.ko...@filezilla-project.org>. # @@ -590,8 +590,8 @@ # Identity of this package. PACKAGE_NAME='libfilezilla' PACKAGE_TARNAME='libfilezilla' -PACKAGE_VERSION='0.27.0' -PACKAGE_STRING='libfilezilla 0.27.0' +PACKAGE_VERSION='0.27.1' +PACKAGE_STRING='libfilezilla 0.27.1' PACKAGE_BUGREPORT='tim.ko...@filezilla-project.org' PACKAGE_URL='https://lib.filezilla-project.org/' @@ -1445,7 +1445,7 @@ # Omit some internal or obsolete options to make the list less imposing. # This message is too long to be a string in the A/UX 3.1 sh. cat <<_ACEOF -\`configure' configures libfilezilla 0.27.0 to adapt to many kinds of systems. +\`configure' configures libfilezilla 0.27.1 to adapt to many kinds of systems. Usage: $0 [OPTION]... [VAR=VALUE]... @@ -1516,7 +1516,7 @@ if test -n "$ac_init_help"; then case $ac_init_help in - short | recursive ) echo "Configuration of libfilezilla 0.27.0:";; + short | recursive ) echo "Configuration of libfilezilla 0.27.1:";; esac cat <<\_ACEOF @@ -1670,7 +1670,7 @@ test -n "$ac_init_help" && exit $ac_status if $ac_init_version; then cat <<\_ACEOF -libfilezilla configure 0.27.0 +libfilezilla configure 0.27.1 generated by GNU Autoconf 2.69 Copyright (C) 2012 Free Software Foundation, Inc. @@ -2115,7 +2115,7 @@ This file contains any messages produced by compilers while running configure, to aid debugging if configure makes a mistake. -It was created by libfilezilla $as_me 0.27.0, which was +It was created by libfilezilla $as_me 0.27.1, which was generated by GNU Autoconf 2.69. Invocation command line was $ $0 $@ @@ -2470,7 +2470,7 @@ # If any interfaces have been added since the last public release, then increment age. # If any interfaces have been removed or changed since the last public release, then set age to 0. # CURRENT:REVISION:AGE -LIBRARY_VERSION=12:0:0 +LIBRARY_VERSION=12:1:0 ac_config_headers="$ac_config_headers config/config.hpp" @@ -2991,7 +2991,7 @@ # Define the identity of the package. PACKAGE='libfilezilla' - VERSION='0.27.0' + VERSION='0.27.1' cat >>confdefs.h <<_ACEOF @@ -22203,7 +22203,7 @@ # report actual input values of CONFIG_FILES etc. instead of their # values after options handling. ac_log=" -This file was extended by libfilezilla $as_me 0.27.0, which was +This file was extended by libfilezilla $as_me 0.27.1, which was generated by GNU Autoconf 2.69. Invocation command line was CONFIG_FILES = $CONFIG_FILES @@ -22270,7 +22270,7 @@ cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1 ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`" ac_cs_version="\\ -libfilezilla config.status 0.27.0 +libfilezilla config.status 0.27.1 configured by $0, generated by GNU Autoconf 2.69, with options \\"\$ac_cs_config\\" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libfilezilla-0.27.0/configure.ac new/libfilezilla-0.27.1/configure.ac --- old/libfilezilla-0.27.0/configure.ac 2021-03-04 14:27:18.000000000 +0100 +++ new/libfilezilla-0.27.1/configure.ac 2021-03-15 09:01:00.000000000 +0100 @@ -1,4 +1,4 @@ -???AC_INIT([libfilezilla],[0.27.0],[tim.ko...@filezilla-project.org],[],[https://lib.filezilla-project.org/]) +???AC_INIT([libfilezilla],[0.27.1],[tim.ko...@filezilla-project.org],[],[https://lib.filezilla-project.org/]) # Update the version information only immediately before a public release of your software # If the library source code has changed at all since the last update, then increment revision (???c:r:a??? becomes ???c:r+1:a???). @@ -6,7 +6,7 @@ # If any interfaces have been added since the last public release, then increment age. # If any interfaces have been removed or changed since the last public release, then set age to 0. # CURRENT:REVISION:AGE -LIBRARY_VERSION=12:0:0 +LIBRARY_VERSION=12:1:0 AC_CONFIG_HEADERS([config/config.hpp]) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libfilezilla-0.27.0/lib/libfilezilla/glue/wx.hpp new/libfilezilla-0.27.1/lib/libfilezilla/glue/wx.hpp --- old/libfilezilla-0.27.0/lib/libfilezilla/glue/wx.hpp 2020-10-13 14:16:48.000000000 +0200 +++ new/libfilezilla-0.27.1/lib/libfilezilla/glue/wx.hpp 2021-03-15 09:01:00.000000000 +0100 @@ -5,6 +5,12 @@ * \brief Glue to handle support wxString for some functions */ + +#include "../private/defs.hpp" +#if FZ_WINDOWS +#include "../private/windows.hpp" +#endif + #include <wx/string.h> #include "../format.hpp" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libfilezilla-0.27.0/lib/libfilezilla/util.hpp new/libfilezilla-0.27.1/lib/libfilezilla/util.hpp --- old/libfilezilla-0.27.0/lib/libfilezilla/util.hpp 2020-08-21 15:35:14.000000000 +0200 +++ new/libfilezilla-0.27.1/lib/libfilezilla/util.hpp 2021-03-15 09:01:00.000000000 +0100 @@ -64,8 +64,8 @@ sizeof(typename Second::value_type) == sizeof(uint8_t)>* = nullptr> inline bool equal_consttime(First const& lhs, Second const& rhs) { - return equal_consttime(std::basic_string_view<uint8_t>(reinterpret_cast<uint8_t const*>(lhs.data()), rhs.size()), - std::basic_string_view<uint8_t>(reinterpret_cast<uint8_t const*>(lhs.data()), rhs.size())); + return equal_consttime(std::basic_string_view<uint8_t>(reinterpret_cast<uint8_t const*>(lhs.data()), lhs.size()), + std::basic_string_view<uint8_t>(reinterpret_cast<uint8_t const*>(rhs.data()), rhs.size())); } } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libfilezilla-0.27.0/lib/tls_layer_impl.cpp new/libfilezilla-0.27.1/lib/tls_layer_impl.cpp --- old/libfilezilla-0.27.0/lib/tls_layer_impl.cpp 2021-03-04 14:27:18.000000000 +0100 +++ new/libfilezilla-0.27.1/lib/tls_layer_impl.cpp 2021-03-15 09:01:00.000000000 +0100 @@ -696,13 +696,17 @@ } while (!send_buffer_.empty()); - if (state_ == socket_state::connected) { - if (tls_layer_.event_handler_) { + if (write_blocked_by_send_buffer_) { + write_blocked_by_send_buffer_ = false; + + if (state_ == socket_state::connected) { + if (tls_layer_.event_handler_) { #if DEBUG_SOCKETEVENTS - assert(!debug_can_write_); - debug_can_write_ = true; + assert(!debug_can_write_); + debug_can_write_ = true; #endif - tls_layer_.event_handler_->send_event<socket_event>(&tls_layer_, socket_event_flag::write, 0); + tls_layer_.event_handler_->send_event<socket_event>(&tls_layer_, socket_event_flag::write, 0); + } } } @@ -971,6 +975,7 @@ #endif if (!send_buffer_.empty()) { + write_blocked_by_send_buffer_ = true; #if DEBUG_SOCKETEVENTS debug_can_write_ = false; #endif @@ -2120,6 +2125,8 @@ void tls_layer_impl::set_event_handler(event_handler* pEvtHandler, fz::socket_event_flag retrigger_block) { + write_blocked_by_send_buffer_ = false; + fz::socket_event_flag const pending = change_socket_event_handler(tls_layer_.event_handler_, pEvtHandler, &tls_layer_, retrigger_block); tls_layer_.event_handler_ = pEvtHandler; @@ -2137,7 +2144,7 @@ } if (state_ == socket_state::connected || state_ == socket_state::shutting_down) { debug_can_write_ = true; - + } #endif } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libfilezilla-0.27.0/lib/tls_layer_impl.hpp new/libfilezilla-0.27.1/lib/tls_layer_impl.hpp --- old/libfilezilla-0.27.0/lib/tls_layer_impl.hpp 2021-03-04 14:27:18.000000000 +0100 +++ new/libfilezilla-0.27.1/lib/tls_layer_impl.hpp 2021-03-15 09:01:00.000000000 +0100 @@ -168,6 +168,8 @@ bool initialized_{}; bool server_{}; + bool write_blocked_by_send_buffer_{}; + #if DEBUG_SOCKETEVENTS bool debug_can_read_{}; bool debug_can_write_{}; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libfilezilla-0.27.0/lib/uri.cpp new/libfilezilla-0.27.1/lib/uri.cpp --- old/libfilezilla-0.27.0/lib/uri.cpp 2020-07-07 14:06:31.000000000 +0200 +++ new/libfilezilla-0.27.1/lib/uri.cpp 2021-03-15 09:01:00.000000000 +0100 @@ -254,17 +254,20 @@ for (auto const& token : tokens) { size_t pos = token.find('='); if (!pos) { + segments_.clear(); return false; } std::string key = percent_decode_s(token.substr(0, pos)); if (key.empty()) { + segments_.clear(); return false; } std::string value; if (pos != std::string::npos) { value = percent_decode_s(token.substr(pos + 1)); if (value.empty() && pos + 1 != token.size()) { + segments_.clear(); return false; } }