Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package pam_pkcs11 for openSUSE:Factory checked in at 2024-09-25 21:54:05 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/pam_pkcs11 (Old) and /work/SRC/openSUSE:Factory/.pam_pkcs11.new.29891 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "pam_pkcs11" Wed Sep 25 21:54:05 2024 rev:39 rq:1203262 version:0.6.12 Changes: -------- --- /work/SRC/openSUSE:Factory/pam_pkcs11/pam_pkcs11.changes 2024-05-10 12:05:57.075257791 +0200 +++ /work/SRC/openSUSE:Factory/.pam_pkcs11.new.29891/pam_pkcs11.changes 2024-09-25 21:54:35.399522889 +0200 @@ -1,0 +2,8 @@ +Tue Sep 24 21:07:33 UTC 2024 - Simon Vogl <[email protected]> + +- Fix for boo#1230870: + * Add patch 0001-memory-leak-fixes.patch +- Add -Wno-implicit-function-declaration to CFLAGS to fix build + with gcc14 and newer + +------------------------------------------------------------------- New: ---- 0001-memory-leak-fixes.patch BETA DEBUG BEGIN: New:- Fix for boo#1230870: * Add patch 0001-memory-leak-fixes.patch - Add -Wno-implicit-function-declaration to CFLAGS to fix build BETA DEBUG END: ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ pam_pkcs11.spec ++++++ --- /var/tmp/diff_new_pack.v4HgdP/_old 2024-09-25 21:54:35.927544852 +0200 +++ /var/tmp/diff_new_pack.v4HgdP/_new 2024-09-25 21:54:35.927544852 +0200 @@ -1,7 +1,7 @@ # # spec file for package pam_pkcs11 # -# Copyright (c) 2023 SUSE LLC +# Copyright (c) 2024 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -35,6 +35,8 @@ Patch1: %{name}-0.5.3-nss-conf.patch Patch3: %{name}-0.6.0-nss-autoconf.patch Patch4: 0001-Set-slot_num-configuration-parameter-to-0-by-default.patch +# 0001-memory-leak-fixes.patch - Fix memory leaks and issues with kscreenlocker (boo#1230870) - adapted from https://github.com/OpenSC/pam_pkcs11/commit/f8e7d85aa3ca4fd2e2a8c2dfe601d1224debe372.patch +Patch6: 0001-memory-leak-fixes.patch BuildRequires: curl-devel BuildRequires: docbook-xsl-stylesheets BuildRequires: doxygen @@ -97,6 +99,7 @@ %build ./bootstrap %configure\ + CFLAGS="${CFLAGS:-%optflags} -Wno-implicit-function-declaration"\ --docdir=%{_docdir}/%{name}\ --with-nss\ --with-curl ++++++ 0001-memory-leak-fixes.patch ++++++ --- a/src/mappers/mapper.c +++ b/src/mappers/mapper.c @@ -83,7 +83,12 @@ /* get a line from buffer */ from = mfile->pt; /* set up pointer */ - while( *from && isspace(*from) ) from++; + while( *from && isspace(*from)){ + if(from - mfile->buffer + 1 >= mfile->length){ + return 0; + } + from++; + } to = strchr(from,'\n'); /* if no newline, assume string ends at end of buffer */ if (!to) to=mfile->buffer+mfile->length; --- a/src/pam_pkcs11/pam_pkcs11.c +++ b/src/pam_pkcs11/pam_pkcs11.c @@ -208,7 +208,7 @@ { int i, rv; const char *user = NULL; - char *password; + char *password = NULL; unsigned int slot_num = 0; int is_a_screen_saver = 0; struct configuration_st *configuration;
