Script 'mail_helper' called by obssrc
Hello community,

here is the log from the commit of package helmfile for openSUSE:Factory 
checked in at 2024-10-22 14:53:35
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/helmfile (Old)
 and      /work/SRC/openSUSE:Factory/.helmfile.new.26871 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "helmfile"

Tue Oct 22 14:53:35 2024 rev:61 rq:1216957 version:0.169.1

Changes:
--------
--- /work/SRC/openSUSE:Factory/helmfile/helmfile.changes        2024-10-16 
23:53:43.366423361 +0200
+++ /work/SRC/openSUSE:Factory/.helmfile.new.26871/helmfile.changes     
2024-10-22 14:54:32.651969769 +0200
@@ -1,0 +2,10 @@
+Tue Oct 22 08:01:22 UTC 2024 - Manfred Hollstein <manfre...@gmx.net>
+
+- Update to version 0.169.1:
+  * feat: update sops version to 3.9.1 by @zhaque44 in #1742
+  * chore: improve test assertions and descriptions for file
+    download test by @zhaque44 in #1745
+  * feat: add 'hide-notes' flag to helm in sync and apply commands
+    by @yxxhero in #1746
+
+-------------------------------------------------------------------

Old:
----
  helmfile-0.169.0.tar.gz

New:
----
  helmfile-0.169.1.tar.gz

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ helmfile.spec ++++++
--- /var/tmp/diff_new_pack.2WR8yl/_old  2024-10-22 14:54:33.736015060 +0200
+++ /var/tmp/diff_new_pack.2WR8yl/_new  2024-10-22 14:54:33.740015227 +0200
@@ -17,9 +17,9 @@
 #
 
 
-%define git_commit 18529ab7c550bfa6d6eefddeb47418f1685f4a7f
+%define git_commit 8b16d36903bbfac39c50f30c79f081e43bc4350f
 Name:           helmfile
-Version:        0.169.0
+Version:        0.169.1
 Release:        0
 Summary:        Deploy Kubernetes Helm Charts
 License:        MIT

++++++ _service ++++++
--- /var/tmp/diff_new_pack.2WR8yl/_old  2024-10-22 14:54:33.768016396 +0200
+++ /var/tmp/diff_new_pack.2WR8yl/_new  2024-10-22 14:54:33.772016564 +0200
@@ -5,7 +5,7 @@
     <param name="exclude">.git</param>
     <param name="versionformat">@PARENT_TAG@</param>
     <param name="versionrewrite-pattern">v(.*)</param>
-    <param name="revision">v0.169.0</param>
+    <param name="revision">v0.169.1</param>
     <param name="changesgenerate">enable</param>
   </service>
   <service name="recompress" mode="manual">

++++++ _servicedata ++++++
--- /var/tmp/diff_new_pack.2WR8yl/_old  2024-10-22 14:54:33.788017232 +0200
+++ /var/tmp/diff_new_pack.2WR8yl/_new  2024-10-22 14:54:33.792017399 +0200
@@ -1,5 +1,5 @@
 <servicedata>
 <service name="tar_scm">
                 <param 
name="url">https://github.com/helmfile/helmfile.git</param>
-              <param 
name="changesrevision">dea501cb10fb9b0020bd8c6132e89704efc11b52</param></service></servicedata>
+              <param 
name="changesrevision">8b16d36903bbfac39c50f30c79f081e43bc4350f</param></service></servicedata>
 

++++++ helmfile-0.169.0.tar.gz -> helmfile-0.169.1.tar.gz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/helmfile-0.169.0/.github/workflows/Makefile 
new/helmfile-0.169.1/.github/workflows/Makefile
--- old/helmfile-0.169.0/.github/workflows/Makefile     2024-10-15 
16:26:59.000000000 +0200
+++ new/helmfile-0.169.1/.github/workflows/Makefile     2024-10-21 
15:52:56.000000000 +0200
@@ -2,7 +2,7 @@
 KUSTOMIZE_VERSION ?= v5.4.3
 K8S_VERSION ?= v1.28.11
 MINIKUBE_VERSION ?= v1.31.1
-SOPS_VERSION ?= v3.9.0
+SOPS_VERSION ?= v3.9.1
 
 # ---
 CHANGE_MINIKUBE_NONE_USER ?= true
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/helmfile-0.169.0/Dockerfile 
new/helmfile-0.169.1/Dockerfile
--- old/helmfile-0.169.0/Dockerfile     2024-10-15 16:26:59.000000000 +0200
+++ new/helmfile-0.169.1/Dockerfile     2024-10-21 15:52:56.000000000 +0200
@@ -77,7 +77,7 @@
     rm "${KUSTOMIZE_FILENAME}" && \
     [ "$(kustomize version)" = "${KUSTOMIZE_VERSION}" ]
 
-ENV SOPS_VERSION="v3.9.0"
+ENV SOPS_VERSION="v3.9.1"
 ARG SOPS_FILENAME="sops-${SOPS_VERSION}.${TARGETOS}.${TARGETARCH}"
 RUN set -x && \
     curl --retry 5 --retry-connrefused -LO 
"https://github.com/getsops/sops/releases/download/${SOPS_VERSION}/${SOPS_FILENAME}";
 && \
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/helmfile-0.169.0/Dockerfile.debian-stable-slim 
new/helmfile-0.169.1/Dockerfile.debian-stable-slim
--- old/helmfile-0.169.0/Dockerfile.debian-stable-slim  2024-10-15 
16:26:59.000000000 +0200
+++ new/helmfile-0.169.1/Dockerfile.debian-stable-slim  2024-10-21 
15:52:56.000000000 +0200
@@ -82,7 +82,7 @@
     rm "${KUSTOMIZE_FILENAME}" && \
     [ "$(kustomize version)" = "${KUSTOMIZE_VERSION}" ]
 
-ENV SOPS_VERSION="v3.9.0"
+ENV SOPS_VERSION="v3.9.1"
 ARG SOPS_FILENAME="sops-${SOPS_VERSION}.${TARGETOS}.${TARGETARCH}"
 RUN set -x && \
     curl --retry 5 --retry-connrefused -LO 
"https://github.com/getsops/sops/releases/download/${SOPS_VERSION}/${SOPS_FILENAME}";
 && \
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/helmfile-0.169.0/Dockerfile.ubuntu 
new/helmfile-0.169.1/Dockerfile.ubuntu
--- old/helmfile-0.169.0/Dockerfile.ubuntu      2024-10-15 16:26:59.000000000 
+0200
+++ new/helmfile-0.169.1/Dockerfile.ubuntu      2024-10-21 15:52:56.000000000 
+0200
@@ -82,7 +82,7 @@
     rm "${KUSTOMIZE_FILENAME}" && \
     [ "$(kustomize version)" = "${KUSTOMIZE_VERSION}" ]
 
-ENV SOPS_VERSION="v3.9.0"
+ENV SOPS_VERSION="v3.9.1"
 ARG SOPS_FILENAME="sops-${SOPS_VERSION}.${TARGETOS}.${TARGETARCH}"
 RUN set -x && \
     curl --retry 5 --retry-connrefused -LO 
"https://github.com/getsops/sops/releases/download/${SOPS_VERSION}/${SOPS_FILENAME}";
 && \
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/helmfile-0.169.0/cmd/apply.go 
new/helmfile-0.169.1/cmd/apply.go
--- old/helmfile-0.169.0/cmd/apply.go   2024-10-15 16:26:59.000000000 +0200
+++ new/helmfile-0.169.1/cmd/apply.go   2024-10-21 15:52:56.000000000 +0200
@@ -61,6 +61,7 @@
        f.BoolVar(&applyOptions.SuppressSecrets, "suppress-secrets", false, 
"suppress secrets in the diff output. highly recommended to specify on CI/CD 
use-cases")
        f.BoolVar(&applyOptions.ShowSecrets, "show-secrets", false, "do not 
redact secret values in the diff output. should be used for debug purpose only")
        f.BoolVar(&applyOptions.NoHooks, "no-hooks", false, "do not diff 
changes made by hooks.")
+       f.BoolVar(&applyOptions.HideNotes, "hide-notes", false, "add 
--hide-notes flag to helm")
        f.BoolVar(&applyOptions.SuppressDiff, "suppress-diff", false, "suppress 
diff in the output. Usable in new installs")
        f.BoolVar(&applyOptions.Wait, "wait", false, `Override 
helmDefaults.wait setting "helm upgrade --install --wait"`)
        f.BoolVar(&applyOptions.WaitForJobs, "wait-for-jobs", false, `Override 
helmDefaults.waitForJobs setting "helm upgrade --install --wait-for-jobs"`)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/helmfile-0.169.0/cmd/sync.go 
new/helmfile-0.169.1/cmd/sync.go
--- old/helmfile-0.169.0/cmd/sync.go    2024-10-15 16:26:59.000000000 +0200
+++ new/helmfile-0.169.1/cmd/sync.go    2024-10-21 15:52:56.000000000 +0200
@@ -41,6 +41,7 @@
        f.BoolVar(&syncOptions.SkipCRDs, "skip-crds", false, "if set, no CRDs 
will be installed on sync. By default, CRDs are installed if not already 
present")
        f.BoolVar(&syncOptions.IncludeNeeds, "include-needs", false, 
`automatically include releases from the target release's "needs" when 
--selector/-l flag is provided. Does nothing when --selector/-l flag is not 
provided`)
        f.BoolVar(&syncOptions.IncludeTransitiveNeeds, 
"include-transitive-needs", false, `like --include-needs, but also includes 
transitive needs (needs of needs). Does nothing when --selector/-l flag is not 
provided. Overrides exclusions of other selectors and conditions.`)
+       f.BoolVar(&syncOptions.HideNotes, "hide-notes", false, "add 
--hide-notes flag to helm")
        f.BoolVar(&syncOptions.Wait, "wait", false, `Override helmDefaults.wait 
setting "helm upgrade --install --wait"`)
        f.BoolVar(&syncOptions.WaitForJobs, "wait-for-jobs", false, `Override 
helmDefaults.waitForJobs setting "helm upgrade --install --wait-for-jobs"`)
        f.BoolVar(&syncOptions.ReuseValues, "reuse-values", false, `Override 
helmDefaults.reuseValues "helm upgrade --install --reuse-values"`)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/helmfile-0.169.0/pkg/app/init_test.go 
new/helmfile-0.169.1/pkg/app/init_test.go
--- old/helmfile-0.169.0/pkg/app/init_test.go   2024-10-15 16:26:59.000000000 
+0200
+++ new/helmfile-0.169.1/pkg/app/init_test.go   2024-10-21 15:52:56.000000000 
+0200
@@ -8,27 +8,28 @@
        "path/filepath"
        "regexp"
        "testing"
+
+       "github.com/stretchr/testify/assert"
 )
 
 func TestDownloadfile(t *testing.T) {
-       var ts *httptest.Server
        cases := []struct {
                name        string
                handler     func(http.ResponseWriter, *http.Request)
-               url         string
                filepath    string
                wantContent string
                wantError   string
        }{
                {
-                       name: "download success",
+                       name: "successful download of file content",
                        handler: func(w http.ResponseWriter, r *http.Request) {
+                               w.WriteHeader(http.StatusOK)
                                fmt.Fprint(w, "helmfile")
                        },
                        wantContent: "helmfile",
                },
                {
-                       name: "download 404",
+                       name: "404 error when file not found",
                        handler: func(w http.ResponseWriter, r *http.Request) {
                                w.WriteHeader(http.StatusNotFound)
                                fmt.Fprint(w, "not found")
@@ -36,7 +37,7 @@
                        wantError: "download .*? error, code: 404",
                },
                {
-                       name: "download 500",
+                       name: "500 error on server failure",
                        handler: func(w http.ResponseWriter, r *http.Request) {
                                w.WriteHeader(http.StatusInternalServerError)
                                fmt.Fprint(w, "server error")
@@ -44,14 +45,16 @@
                        wantError: "download .*? error, code: 500",
                },
                {
-                       name: "download path error",
+                       name: "error due to invalid file path",
                        handler: func(w http.ResponseWriter, r *http.Request) {
+                               w.WriteHeader(http.StatusOK)
                                fmt.Fprint(w, "helmfile")
                        },
                        filepath:  "abc/down.txt",
                        wantError: "open .*? no such file or directory",
                },
        }
+
        for _, c := range cases {
                t.Run(c.name, func(t *testing.T) {
                        dir := t.TempDir()
@@ -60,30 +63,24 @@
                                downfile = filepath.Join(dir, c.filepath)
                        }
 
-                       ts = httptest.NewServer(http.HandlerFunc(func(w 
http.ResponseWriter, r *http.Request) {
-                               c.handler(w, r)
-                       }))
+                       ts := httptest.NewServer(http.HandlerFunc(c.handler))
                        defer ts.Close()
-                       url := ts.URL
-                       if c.url != "" {
-                               url = c.url
-                       }
-                       err := downloadfile(downfile, url)
+
+                       err := downloadfile(downfile, ts.URL)
+
                        if c.wantError != "" {
-                               if err == nil {
-                                       t.Errorf("download got no error, want 
error: %v", c.wantError)
-                               } else if matched, regexErr := 
regexp.MatchString(c.wantError, err.Error()); regexErr != nil || !matched {
-                                       t.Errorf("download got error: %v, want 
error: %v", err, c.wantError)
+                               assert.Error(t, err)
+                               if err != nil {
+                                       matched, regexErr := 
regexp.MatchString(c.wantError, err.Error())
+                                       assert.NoError(t, regexErr)
+                                       assert.True(t, matched, "expected error 
message to match regex: %s", c.wantError)
                                }
                                return
                        }
+
                        content, err := os.ReadFile(downfile)
-                       if err != nil {
-                               t.Errorf("read download file error: %v", err)
-                       }
-                       if string(content) != c.wantContent {
-                               t.Errorf("download file content got: %v, want 
content: %v", string(content), c.wantContent)
-                       }
+                       assert.NoError(t, err)
+                       assert.Equal(t, c.wantContent, string(content), 
"unexpected content in downloaded file")
                })
        }
 }

++++++ vendor.tar.gz ++++++
/work/SRC/openSUSE:Factory/helmfile/vendor.tar.gz 
/work/SRC/openSUSE:Factory/.helmfile.new.26871/vendor.tar.gz differ: char 5, 
line 1

Reply via email to