Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package libvirt-cim for openSUSE:Factory checked in at 2024-11-06 16:56:13 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/libvirt-cim (Old) and /work/SRC/openSUSE:Factory/.libvirt-cim.new.2020 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libvirt-cim" Wed Nov 6 16:56:13 2024 rev:51 rq:1221695 version:0.6.3+git92.a5a073c Changes: -------- --- /work/SRC/openSUSE:Factory/libvirt-cim/libvirt-cim.changes 2024-03-01 23:37:57.502564279 +0100 +++ /work/SRC/openSUSE:Factory/.libvirt-cim.new.2020/libvirt-cim.changes 2024-11-06 16:57:17.373332177 +0100 @@ -1,0 +2,30 @@ +Wed Nov 6 08:32:58 UTC 2024 - Klaus Kämpf <kkae...@suse.de> + +- fix version number in _service + +------------------------------------------------------------------- +Tue Nov 05 15:47:35 UTC 2024 - kkae...@suse.de + +- Update to version v0.6.3+git20230822.a5a073c: + * ci: lcitool: Maintain project package deps lists here + * README: Update link to upstream repo and drop mailing list refernce + * ci: refresh with latest lcitool manifest + * ci: mark bleeding edge distros as allowing failures + * configure: convert to using xz archives for dist + * ci: refresh with lcitool manifest + * Switch to new GitHub repo-lockdown configuration + * ci: remove obsolete refresh script and documentation + * ci: re-generate containers/gitlab config from manifest + * ci: define a CI manifest file + +- add 0005-include-stdlib.h.patch, 0006-drop-base_schema.patch + +- drop f6b7eeaf.patch, upstream + +- rename + provider-reg.patch to 0001-provider-reg.patch + automake.patch to 0002-automake.patch + libvirt-cim-0.6.3-fix-bashisms.patch to 0003-fix-bashisms.patch + memory_leaks.patch to 0004-memory-leaks.patch + +------------------------------------------------------------------- Old: ---- automake.patch f6b7eeaf.patch libvirt-cim-0.6.3-fix-bashisms.patch libvirt-cim-0.6.3.tar.bz2 memory_leaks.patch provider-reg.patch New: ---- 0001-provider-reg.patch 0002-automake.patch 0003-fix-bashisms.patch 0004-memory-leaks.patch 0005-include-stdlib.h.patch 0006-drop-base_schema.patch _service _servicedata libvirt-cim-0.6.3+git92.a5a073c.tar.gz BETA DEBUG BEGIN: Old: provider-reg.patch to 0001-provider-reg.patch automake.patch to 0002-automake.patch libvirt-cim-0.6.3-fix-bashisms.patch to 0003-fix-bashisms.patch Old: - drop f6b7eeaf.patch, upstream Old: automake.patch to 0002-automake.patch libvirt-cim-0.6.3-fix-bashisms.patch to 0003-fix-bashisms.patch memory_leaks.patch to 0004-memory-leaks.patch Old: libvirt-cim-0.6.3-fix-bashisms.patch to 0003-fix-bashisms.patch memory_leaks.patch to 0004-memory-leaks.patch Old:- rename provider-reg.patch to 0001-provider-reg.patch automake.patch to 0002-automake.patch BETA DEBUG END: BETA DEBUG BEGIN: New:- rename provider-reg.patch to 0001-provider-reg.patch automake.patch to 0002-automake.patch New: provider-reg.patch to 0001-provider-reg.patch automake.patch to 0002-automake.patch libvirt-cim-0.6.3-fix-bashisms.patch to 0003-fix-bashisms.patch New: automake.patch to 0002-automake.patch libvirt-cim-0.6.3-fix-bashisms.patch to 0003-fix-bashisms.patch memory_leaks.patch to 0004-memory-leaks.patch New: libvirt-cim-0.6.3-fix-bashisms.patch to 0003-fix-bashisms.patch memory_leaks.patch to 0004-memory-leaks.patch New: - add 0005-include-stdlib.h.patch, 0006-drop-base_schema.patch New: - add 0005-include-stdlib.h.patch, 0006-drop-base_schema.patch BETA DEBUG END: ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libvirt-cim.spec ++++++ --- /var/tmp/diff_new_pack.aqoAej/_old 2024-11-06 16:57:18.017358957 +0100 +++ /var/tmp/diff_new_pack.aqoAej/_new 2024-11-06 16:57:18.021359123 +0100 @@ -23,20 +23,21 @@ Name: libvirt-cim -Url: http://libvirt.org/CIM/ +Url: http://libvirt.org License: LGPL-2.1+ Group: System/Management -Version: 0.6.3 +Version: 0.6.3+git92.a5a073c Release: 0 Summary: CMPI-based CIM provider implementing DMTF SVPC model -Source: %{name}-%{version}.tar.bz2 +Source: %{name}-%{version}.tar.gz Source1: libvirt-cim-rpmlintrc Source2: README.SUSE -Patch0: provider-reg.patch -Patch1: automake.patch -Patch2: libvirt-cim-0.6.3-fix-bashisms.patch -Patch3: f6b7eeaf.patch -Patch4: memory_leaks.patch +Patch1: 0001-provider-reg.patch +Patch2: 0002-automake.patch +Patch3: 0003-fix-bashisms.patch +Patch4: 0004-memory-leaks.patch +Patch5: 0005-include-stdlib.h.patch +Patch6: 0006-drop-base_schema.patch BuildRoot: %{_tmppath}/%{name}-%{version}-build BuildRequires: automake BuildRequires: autoconf @@ -71,12 +72,6 @@ exported by libvirt itself, enabling management of multiple platforms with a single provider. - - -Authors: --------- - Dan Smith <da...@us.ibm.com> - %define REGISTRATION %{_datadir}/%{name}/*.registration %define SCHEMA %{_datadir}/%{name}/*.mof %define INTEROP_REG %{_datadir}/%{name}/{RegisteredProfile,ElementConformsToProfile,ReferencedProfile}.registration @@ -122,7 +117,6 @@ %post /sbin/ldconfig -%{_datadir}/%{name}/install_base_schema.sh %{_datadir}/%{name} # Register libvirt-cim on the sfcb's providers list %{_datadir}/%{name}/provider-register.sh -t sfcb \ -n root/virt \ @@ -171,9 +165,6 @@ %{_datadir}/%{name}/*.sh %{_datadir}/%{name}/*.mof %{_datadir}/%{name}/*.registration -%{_datadir}/%{name}/cim_schema_*-MOFs.zip -%{_datadir}/%{name}/cimv*-cimv2_mof -%{_datadir}/%{name}/cimv*-interop_mof %dir %attr(0700, root, root) %{_sysconfdir}/libvirt %dir %attr(0700, root, root) %{_sysconfdir}/libvirt/cim %if 0%{?suse_version} ++++++ 0001-provider-reg.patch ++++++ >From fd50bb9a521c26a6de4e9ab15ec0e71e4c4189c7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Klaus=20K=C3=A4mpf?= <kkae...@gmail.com> Date: Tue, 5 Nov 2024 16:50:11 +0100 Subject: [PATCH 1/6] provider-reg add " around echo parameters --- provider-register.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/provider-register.sh b/provider-register.sh index f66fe54..cd44462 100755 --- a/provider-register.sh +++ b/provider-register.sh @@ -742,7 +742,7 @@ gb_getopt() shift;; esac done - echo $options $registrations $moffiles + echo "$options $registrations $moffiles" } prepargs=`gb_getopt $*` -- 2.47.0 ++++++ 0002-automake.patch ++++++ >From 8393769c95a491d7c92f02445db178c7fa0d64c4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Klaus=20K=C3=A4mpf?= <kkae...@gmail.com> Date: Tue, 5 Nov 2024 16:51:59 +0100 Subject: [PATCH 2/6] automake add missing files --- AUTHORS | 1 + ChangeLog | 1 + INSTALL | 365 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ NEWS | 1 + 4 files changed, 368 insertions(+) create mode 100644 AUTHORS create mode 100644 ChangeLog create mode 100644 INSTALL create mode 100644 NEWS diff --git a/AUTHORS b/AUTHORS new file mode 100644 index 0000000..a43b026 --- /dev/null +++ b/AUTHORS @@ -0,0 +1 @@ +Dan Smith <da...@us.ibm.com> diff --git a/ChangeLog b/ChangeLog new file mode 100644 index 0000000..b873268 --- /dev/null +++ b/ChangeLog @@ -0,0 +1 @@ +See http://libvirt.org/CIM/ diff --git a/INSTALL b/INSTALL new file mode 100644 index 0000000..d3b6e4e --- /dev/null +++ b/INSTALL @@ -0,0 +1,365 @@ +Installation Instructions +************************* + +Basic Installation +================== + + The following shell commands: + + test -f configure || ./bootstrap + ./configure + make + make install + +should configure, build, and install this package. The first line, +which bootstraps, is intended for developers; when building from +distribution tarballs it does nothing and can be skipped. + + The following more-detailed instructions are generic; see the +âREADMEâ file for instructions specific to this package. Some packages +provide this âINSTALLâ file but do not implement all of the features +documented below. The lack of an optional feature in a given package is +not necessarily a bug. More recommendations for GNU packages can be +found in the GNU Coding Standards. + + Many packages have scripts meant for developers instead of ordinary +builders, as they may use developer tools that are less commonly +installed, or they may access the network, which has privacy +implications. If the âbootstrapâ shell script exists, it attempts to +build the âconfigureâ shell script and related files, possibly using +developer tools or the network. Because the output of âbootstrapâ is +system-independent, it is normally run by a package developer so that +its output can be put into the distribution tarball and ordinary +builders and users need not run âbootstrapâ. Some packages have +commands like â./autopull.shâ and â./autogen.shâ that you can run +instead of â./bootstrapâ, for more fine-grained control over +bootstrapping. + + The âconfigureâ shell script attempts to guess correct values for +various system-dependent variables used during compilation. It uses +those values to create a âMakefileâ in each directory of the package. +It may also create one or more â.hâ files containing system-dependent +definitions. Finally, it creates a shell script âconfig.statusâ that +you can run in the future to recreate the current configuration, and a +file âconfig.logâ containing output useful for debugging âconfigureâ. + + It can also use an optional file (typically called âconfig.cacheâ and +enabled with â--cache-file=config.cacheâ or simply â-Câ) that saves the +results of its tests to speed up reconfiguring. Caching is disabled by +default to prevent problems with accidental use of stale cache files. + + If you need to do unusual things to compile the package, please try +to figure out how âconfigureâ could check whether to do them, and mail +diffs or instructions to the address given in the âREADMEâ so they can +be considered for the next release. If you are using the cache, and at +some point âconfig.cacheâ contains results you donât want to keep, you +may remove or edit it. + + The âautoconfâ program generates âconfigureâ from the file +âconfigure.acâ. Normally you should edit âconfigure.acâ instead of +editing âconfigureâ directly. + + The simplest way to compile this package is: + + 1. âcdâ to the directory containing the packageâs source code. + + 2. If this is a developer checkout and file âconfigureâ does not yet + exist, type â./bootstrapâ to create it. You may need special + developer tools and network access to bootstrap, and the network + access may have privacy implications. + + 3. Type â./configureâ to configure the package for your system. This + might take a while. While running, âconfigureâ prints messages + telling which features it is checking for. + + 4. Type âmakeâ to compile the package. + + 5. Optionally, type âmake checkâ to run any self-tests that come with + the package, generally using the just-built uninstalled binaries. + + 6. Type âmake installâ to install the programs and any data files and + documentation. When installing into a prefix owned by root, it is + recommended that the package be configured and built as a regular + user, and only the âmake installâ phase executed with root + privileges. + + 7. Optionally, type âmake installcheckâ to repeat any self-tests, but + this time using the binaries in their final installed location. + This target does not install anything. Running this target as a + regular user, particularly if the prior âmake installâ required + root privileges, verifies that the installation completed + correctly. + + 8. You can remove the program binaries and object files from the + source code directory by typing âmake cleanâ. To also remove the + files that âconfigureâ created (so you can compile the package for + a different kind of computer), type âmake distcleanâ. There is + also a âmake maintainer-cleanâ target, but that is intended mainly + for the packageâs developers. If you use it, you may have to + bootstrap again. + + 9. If the package follows the GNU Coding Standards, you can type âmake + uninstallâ to remove the installed files. + +Compilers and Options +===================== + + Some systems require unusual options for compilation or linking that +the âconfigureâ script does not know about. Run â./configure --helpâ +for details on some of the pertinent environment variables. + + You can give âconfigureâ initial values for configuration parameters +by setting variables in the command line or in the environment. Here is +an example: + + ./configure CC=gcc CFLAGS=-g LIBS=-lposix + + See âDefining Variablesâ for more details. + +Compiling For Multiple Architectures +==================================== + + You can compile the package for more than one kind of computer at the +same time, by placing the object files for each system in their own +directory. To do this, you can use GNU âmakeâ. âcdâ to the directory +where you want the object files and executables to go and run the +âconfigureâ script. âconfigureâ automatically checks for the source +code in the directory that âconfigureâ is in and in â..â. This is known +as a âVPATHâ build. + + With a non-GNU âmakeâ, it is safer to compile the package for one +system at a time in the source code directory. After you have installed +the package for one system, use âmake distcleanâ before reconfiguring +for another system. + + Some platforms, notably macOS, support âfatâ or âuniversalâ binaries, +where a single binary can execute on different architectures. On these +platforms you can configure and compile just once, with options specific +to that platform. + +Installation Names +================== + + By default, âmake installâ installs the packageâs commands under +â/usr/local/binâ, include files under â/usr/local/includeâ, etc. You +can specify an installation prefix other than â/usr/localâ by giving +âconfigureâ the option â--prefix=PREFIXâ, where PREFIX must be an +absolute file name. + + You can specify separate installation prefixes for +architecture-specific files and architecture-independent files. If you +pass the option â--exec-prefix=PREFIXâ to âconfigureâ, the package uses +PREFIX as the prefix for installing programs and libraries. +Documentation and other data files still use the regular prefix. + + In addition, if you use an unusual directory layout you can give +options like â--bindir=DIRâ to specify different values for particular +kinds of files. Run âconfigure --helpâ for a list of the directories +you can set and what kinds of files go in them. In general, the default +for these options is expressed in terms of â${prefix}â, so that +specifying just â--prefixâ will affect all of the other directory +specifications that were not explicitly provided. + + The most portable way to affect installation locations is to pass the +correct locations to âconfigureâ; however, many packages provide one or +both of the following shortcuts of passing variable assignments to the +âmake installâ command line to change installation locations without +having to reconfigure or recompile. + + The first method involves providing an override variable for each +affected directory. For example, âmake install +prefix=/alternate/directoryâ will choose an alternate location for all +directory configuration variables that were expressed in terms of +â${prefix}â. Any directories that were specified during âconfigureâ, +but not in terms of â${prefix}â, must each be overridden at install time +for the entire installation to be relocated. The approach of makefile +variable overrides for each directory variable is required by the GNU +Coding Standards, and ideally causes no recompilation. However, some +platforms have known limitations with the semantics of shared libraries +that end up requiring recompilation when using this method, particularly +noticeable in packages that use GNU Libtool. + + The second method involves providing the âDESTDIRâ variable. For +example, âmake install DESTDIR=/alternate/directoryâ will prepend +â/alternate/directoryâ before all installation names. The approach of +âDESTDIRâ overrides is not required by the GNU Coding Standards, and +does not work on platforms that have drive letters. On the other hand, +it does better at avoiding recompilation issues, and works well even +when some directory options were not specified in terms of â${prefix}â +at âconfigureâ time. + +Optional Features +================= + + If the package supports it, you can cause programs to be installed +with an extra prefix or suffix on their names by giving âconfigureâ the +option â--program-prefix=PREFIXâ or â--program-suffix=SUFFIXâ. + + Some packages pay attention to â--enable-FEATUREâ and +â--disable-FEATUREâ options to âconfigureâ, where FEATURE indicates an +optional part of the package. They may also pay attention to +â--with-PACKAGEâ and â--without-PACKAGEâ options, where PACKAGE is +something like âgnu-ldâ. â./configure --helpâ should mention the +â--enable-...â and â--with-...â options that the package recognizes. + + Some packages offer the ability to configure how verbose the +execution of âmakeâ will be. For these packages, running â./configure +--enable-silent-rulesâ sets the default to minimal output, which can be +overridden with âmake V=1â; while running â./configure +--disable-silent-rulesâ sets the default to verbose, which can be +overridden with âmake V=0â. + +Specifying a System Type +======================== + + By default âconfigureâ builds for the current system. To create +binaries that can run on a different system type, specify a +â--host=TYPEâ option along with compiler variables that specify how to +generate object code for TYPE. For example, to create binaries intended +to run on a 64-bit ARM processor: + + ./configure --host=aarch64-linux-gnu \ + CC=aarch64-linux-gnu-gcc \ + CXX=aarch64-linux-gnu-g++ + +If done on a machine that can execute these binaries (e.g., via +âqemu-aarch64â, â$QEMU_LD_PREFIXâ, and Linuxâs âbinfmt_miscâ +capability), the build behaves like a native build. Otherwise it is a +cross-build: âconfigureâ will make cross-compilation guesses instead of +running test programs, and âmake checkâ will not work. + + A system type can either be a short name like âmingw64â, or a +canonical name like âx86_64-pc-linux-gnuâ. Canonical names have the +form CPU-COMPANY-SYSTEM where SYSTEM is either OS or KERNEL-OS. To +canonicalize and validate a system type, you can run the command +âconfig.subâ, which is often squirreled away in a subdirectory like +âbuild-auxâ. For example: + + $ build-aux/config.sub arm64-linux + aarch64-unknown-linux-gnu + $ build-aux/config.sub riscv-lnx + Invalid configuration 'riscv-lnx': OS 'lnx' not recognized + +You can look at the âconfig.subâ file to see which types are recognized. +If the file is absent, this package does not need the system type. + + If âconfigureâ fails with the diagnostic âcannot guess build typeâ. +âconfig.subâ did not recognize your systemâs type. In this case, first +fetch the newest versions of these files from the GNU config package +(https://savannah.gnu.org/projects/config). If that fixes things, +please report it to the maintainers of the package containing +âconfigureâ. Otherwise, you can try the configure option â--build=TYPEâ +where TYPE comes close to your system type; also, please report the +problem to <config-patc...@gnu.org>. + + For more details about configuring system types, see the Autoconf +documentation. + +Sharing Defaults +================ + + If you want to set default values for âconfigureâ scripts to share, +you can create a site shell script called âconfig.siteâ that gives +default values for variables like âCCâ, âcache_fileâ, and âprefixâ. +âconfigureâ looks for âPREFIX/share/config.siteâ if it exists, then +âPREFIX/etc/config.siteâ if it exists. Or, you can set the +âCONFIG_SITEâ environment variable to the location of the site script. +A warning: not all âconfigureâ scripts look for a site script. + +Defining Variables +================== + + Variables not defined in a site shell script can be set in the +environment passed to âconfigureâ. However, some packages may run +configure again during the build, and the customized values of these +variables may be lost. In order to avoid this problem, you should set +them in the âconfigureâ command line, using âVAR=valueâ. For example: + + ./configure CC=/usr/local2/bin/gcc + +causes the specified âgccâ to be used as the C compiler (unless it is +overridden in the site shell script). + +Unfortunately, this technique does not work for âCONFIG_SHELLâ due to an +Autoconf limitation. Until the limitation is lifted, you can use this +workaround: + + CONFIG_SHELL=/bin/bash ./configure CONFIG_SHELL=/bin/bash + +âconfigureâ Invocation +====================== + + âconfigureâ recognizes the following options to control how it +operates. + +â--helpâ +â-hâ + Print a summary of all of the options to âconfigureâ, and exit. + +â--help=shortâ +â--help=recursiveâ + Print a summary of the options unique to this packageâs + âconfigureâ, and exit. The âshortâ variant lists options used only + in the top level, while the ârecursiveâ variant lists options also + present in any nested packages. + +â--versionâ +â-Vâ + Print the version of Autoconf used to generate the âconfigureâ + script, and exit. + +â--cache-file=FILEâ + Enable the cache: use and save the results of the tests in FILE, + traditionally âconfig.cacheâ. FILE defaults to â/dev/nullâ to + disable caching. + +â--config-cacheâ +â-Câ + Alias for â--cache-file=config.cacheâ. + +â--srcdir=DIRâ + Look for the packageâs source code in directory DIR. Usually + âconfigureâ can determine that directory automatically. + +â--prefix=DIRâ + Use DIR as the installation prefix. See âInstallation Namesâ for + more details, including other options available for fine-tuning the + installation locations. + +â--host=TYPEâ + Build binaries for system TYPE. See âSpecifying a System Typeâ. + +â--enable-FEATUREâ +â--disable-FEATUREâ + Enable or disable the optional FEATURE. See âOptional Featuresâ. + +â--with-PACKAGEâ +â--without-PACKAGEâ + Use or omit PACKAGE when building. See âOptional Featuresâ. + +â--quietâ +â--silentâ +â-qâ + Do not print messages saying which checks are being made. To + suppress all normal output, redirect it to â/dev/nullâ (any error + messages will still be shown). + +â--no-createâ +â-nâ + Run the configure checks, but stop before creating any output + files. + +âconfigureâ also recognizes several environment variables, and accepts +some other, less widely useful, options. Run âconfigure --helpâ for +more details. + +Copyright notice +================ + + Copyright © 1994â1996, 1999â2002, 2004â2017, 2020â2024 Free Software +Foundation, Inc. + + Copying and distribution of this file, with or without modification, +are permitted in any medium without royalty provided the copyright +notice and this notice are preserved. This file is offered as-is, +without warranty of any kind. diff --git a/NEWS b/NEWS new file mode 100644 index 0000000..6011c7f --- /dev/null +++ b/NEWS @@ -0,0 +1 @@ +See http://libvirt.org -- 2.47.0 ++++++ libvirt-cim-0.6.3-fix-bashisms.patch -> 0003-fix-bashisms.patch ++++++ --- /work/SRC/openSUSE:Factory/libvirt-cim/libvirt-cim-0.6.3-fix-bashisms.patch 2014-12-03 22:48:05.000000000 +0100 +++ /work/SRC/openSUSE:Factory/.libvirt-cim.new.2020/0003-fix-bashisms.patch 2024-11-06 16:57:16.661302569 +0100 @@ -1,7 +1,17 @@ -diff -Ndur libvirt-cim-0.6.3/provider-register.sh libvirt-cim-0.6.3-fix-bashisms/provider-register.sh ---- libvirt-cim-0.6.3/provider-register.sh 2013-04-08 12:40:35.000000000 +0300 -+++ libvirt-cim-0.6.3-fix-bashisms/provider-register.sh 2014-11-29 22:21:08.224843458 +0200 -@@ -146,12 +146,12 @@ +From 010f6e617eb8d7b1ff7e9fe5f27953e3f8b58cb4 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Klaus=20K=C3=A4mpf?= <kkae...@gmail.com> +Date: Tue, 5 Nov 2024 16:53:28 +0100 +Subject: [PATCH 3/6] fix bashisms + +--- + provider-register.sh | 20 ++++++++++---------- + 1 file changed, 10 insertions(+), 10 deletions(-) + +diff --git a/provider-register.sh b/provider-register.sh +index cd44462..0b60a9a 100755 +--- a/provider-register.sh ++++ b/provider-register.sh +@@ -146,12 +146,12 @@ EOFP done #produce Capabilities @@ -16,7 +26,7 @@ numcap= for cap in $CAPS do -@@ -772,14 +772,14 @@ +@@ -792,14 +792,14 @@ mofs=$* if [ "$help" = "1" ] then usage @@ -39,3 +49,6 @@ echo echo Use this command to install schema mofs and register providers. echo CIM Server Type is required as well as at least one registration file and one mof. +-- +2.47.0 + ++++++ 0004-memory-leaks.patch ++++++ >From d07f47b783e8de1a49a744354ef9744334906fa4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Klaus=20K=C3=A4mpf?= <kkae...@gmail.com> Date: Tue, 5 Nov 2024 17:19:57 +0100 Subject: [PATCH 4/6] memory leaks Other asprintf memory leaks found. Forwarded upstream. Author: Adam Majer <ama...@suse.de> --- src/Virt_ComputerSystem.c | 2 ++ src/Virt_SettingsDefineCapabilities.c | 6 ++++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/Virt_ComputerSystem.c b/src/Virt_ComputerSystem.c index da07f93..c6cbfd2 100644 --- a/src/Virt_ComputerSystem.c +++ b/src/Virt_ComputerSystem.c @@ -417,6 +417,8 @@ static int set_other_id_info(const CMPIBroker *broker, CMPI_string); } + free (model); + CMSetProperty(instance, "OtherIdentifyingInfo", &id_info, CMPI_stringA); diff --git a/src/Virt_SettingsDefineCapabilities.c b/src/Virt_SettingsDefineCapabilities.c index 85cb27a..9750217 100644 --- a/src/Virt_SettingsDefineCapabilities.c +++ b/src/Virt_SettingsDefineCapabilities.c @@ -1980,7 +1980,6 @@ static CMPIStatus set_input_props(const CMPIObjectPath *ref, char *cap; if (get_input_dev_caption(type, bus, &cap) != 1) { - free(cap); cu_statusf(_BROKER, &s, CMPI_RC_ERR_NOT_FOUND, "Unable to build input caption"); @@ -1988,12 +1987,15 @@ static CMPIStatus set_input_props(const CMPIObjectPath *ref, } if (caption != NULL) { - if (asprintf(&cap, "%s %s", caption, cap) == -1) { + char *old_cap = cap; + if (asprintf(&cap, "%s %s", caption, old_cap) == -1) { + free(old_cap); cu_statusf(_BROKER, &s, CMPI_RC_ERR_NOT_FOUND, "Unable to build input caption"); goto out; } + free(old_cap); } inst = sdc_rasd_inst(&s, ref, CIM_RES_TYPE_INPUT, DEVICE_RASD); -- 2.47.0 ++++++ 0005-include-stdlib.h.patch ++++++ >From a3b3538d3a2a3d3193b044811ddeb0b53243d134 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Klaus=20K=C3=A4mpf?= <kkae...@gmail.com> Date: Tue, 5 Nov 2024 17:24:24 +0100 Subject: [PATCH 5/6] include stdlib.h to reduce warnings aroung malloc/realloc/free --- libxkutil/infostore.c | 1 + libxkutil/xml_parse_test.c | 1 + 2 files changed, 2 insertions(+) diff --git a/libxkutil/infostore.c b/libxkutil/infostore.c index d2b2f71..060a83b 100644 --- a/libxkutil/infostore.c +++ b/libxkutil/infostore.c @@ -26,6 +26,7 @@ #include <sys/stat.h> #include <sys/file.h> #include <string.h> +#include <stdlib.h> #include <libvirt/libvirt.h> #include <libxml/parser.h> diff --git a/libxkutil/xml_parse_test.c b/libxkutil/xml_parse_test.c index 303880d..62bf224 100644 --- a/libxkutil/xml_parse_test.c +++ b/libxkutil/xml_parse_test.c @@ -1,5 +1,6 @@ #include <stdio.h> #include <inttypes.h> +#include <stdlib.h> #include <getopt.h> -- 2.47.0 ++++++ 0006-drop-base_schema.patch ++++++ >From 2604c1377e7c0525f813569b24309cc3bc14dbef Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Klaus=20K=C3=A4mpf?= <kkae...@gmail.com> Date: Tue, 5 Nov 2024 17:28:18 +0100 Subject: [PATCH 6/6] drop base_schema the respective CIM MOF files are provided via the cim-schema runtime requirement --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index bebaf60..91f847e 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1,7 +1,7 @@ # Copyright IBM Corp. 2007-2014 AUTOMAKE_OPTIONS=dist-bzip2 -SUBDIRS = libxkutil src doc base_schema +SUBDIRS = libxkutil src doc MOFS = \ $(top_srcdir)/schema/ComputerSystem.mof \ -- 2.47.0 ++++++ _service ++++++ <services> <service name="download_files" mode="manual"/> <service name="tar_scm" mode="manual"> <param name="url">https://gitlab.com/libvirt/libvirt-cim.git</param> <param name="scm">git</param> <param name="exclude">.git</param> <param name="versionformat">@PARENT_TAG@+git@TAG_OFFSET@.%h</param> <param name="versionrewrite-pattern">v(.*)</param> <param name="versionrewrite-replacement">\1</param> <param name="revision">master</param> <param name="changesgenerate">enable</param> </service> <service name="recompress" mode="manual"> <param name="file">libvirt-cim-*.tar</param> <param name="compression">gz</param> </service> <service name="set_version" mode="manual"> <param name="basename">libvirt-cim</param> </service> </services> ++++++ _servicedata ++++++ <servicedata> <service name="tar_scm"> <param name="url">https://gitlab.com/libvirt/libvirt-cim.git</param> <param name="changesrevision">a5a073cf241a168da261e69b566e106b4366b4ba</param></service></servicedata> (No newline at EOF)