Script 'mail_helper' called by obssrc
Hello community,

here is the log from the commit of package alsa for openSUSE:Factory checked in 
at 2024-11-25 23:19:42
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/alsa (Old)
 and      /work/SRC/openSUSE:Factory/.alsa.new.28523 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "alsa"

Mon Nov 25 23:19:42 2024 rev:229 rq:1226062 version:1.2.13

Changes:
--------
--- /work/SRC/openSUSE:Factory/alsa/alsa.changes        2024-11-17 
16:39:33.455142476 +0100
+++ /work/SRC/openSUSE:Factory/.alsa.new.28523/alsa.changes     2024-11-25 
23:19:50.838539265 +0100
@@ -1,0 +2,7 @@
+Sun Nov 24 08:56:17 UTC 2024 - Takashi Iwai <ti...@suse.com>
+
+- Fix header inclusions for implicit dependnecies (bsc#1233682)
+  0002-configure-Make-sequencer-dependent-on-rawmidi.patch
+  0003-seq-include-UMP-headers.patch
+
+-------------------------------------------------------------------

New:
----
  0002-configure-Make-sequencer-dependent-on-rawmidi.patch
  0003-seq-include-UMP-headers.patch

BETA DEBUG BEGIN:
  New:- Fix header inclusions for implicit dependnecies (bsc#1233682)
  0002-configure-Make-sequencer-dependent-on-rawmidi.patch
  0003-seq-include-UMP-headers.patch
  New:  0002-configure-Make-sequencer-dependent-on-rawmidi.patch
  0003-seq-include-UMP-headers.patch
BETA DEBUG END:

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ alsa.spec ++++++
--- /var/tmp/diff_new_pack.iXp5sL/_old  2024-11-25 23:19:51.778578454 +0100
+++ /var/tmp/diff_new_pack.iXp5sL/_new  2024-11-25 23:19:51.778578454 +0100
@@ -17,7 +17,7 @@
 
 
 %define build_from_git 0
-%define do_autoreconf 0
+%define do_autoreconf 1
 
 #Compat macro for new _fillupdir macro introduced in Nov 2017
 %if ! %{defined _fillupdir}
@@ -64,6 +64,8 @@
 Source35:       alsa.keyring
 # upstream fixes
 Patch1:         0001-src-Versions.in.in-Update-_tempo_base-name.patch
+Patch2:         0002-configure-Make-sequencer-dependent-on-rawmidi.patch
+Patch3:         0003-seq-include-UMP-headers.patch
 # rest suse fixes
 Patch101:       alsa-lib-ignore-non-accessible-ALSA_CONFIG_PATH.patch
 BuildRequires:  doxygen

++++++ 0002-configure-Make-sequencer-dependent-on-rawmidi.patch ++++++
>From 6880219ad4ba55ae8a94a34b7a987b3369f7c96f Mon Sep 17 00:00:00 2001
From: Takashi Iwai <ti...@suse.de>
Date: Sun, 24 Nov 2024 09:32:29 +0100
Subject: [PATCH] configure: Make sequencer dependent on rawmidi

The sequencer feature requires rawmidi implicitly, and it became more
obvious with UMP support.  Add the dependency check to configure
script.

Signed-off-by: Takashi Iwai <ti...@suse.de>
---
 configure.ac | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/configure.ac b/configure.ac
index 1cd22a5984d7..69aeb978af0d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -483,6 +483,12 @@ fi
 AC_SUBST(PYTHON_LIBS)
 AC_SUBST(PYTHON_INCLUDES)
 
+if test "$build_rawmidi" != "yes"; then
+  if test "$build_seq" = "yes"; then
+    AC_ERROR([Cannot enable sequencer without rawmidi])
+  fi
+fi
+
 AM_CONDITIONAL([BUILD_MIXER], [test x$build_mixer = xyes])
 AM_CONDITIONAL([BUILD_PCM], [test x$build_pcm = xyes])
 AM_CONDITIONAL([BUILD_RAWMIDI], [test x$build_rawmidi = xyes])
-- 
2.43.0


++++++ 0003-seq-include-UMP-headers.patch ++++++
>From 07cee0ba05179a56764c35975d5822420d4f31f9 Mon Sep 17 00:00:00 2001
From: Takashi Iwai <ti...@suse.de>
Date: Sun, 24 Nov 2024 09:33:16 +0100
Subject: [PATCH] seq: include UMP headers

Some applications seem including alsa/seqmid.h individually, and this
got broken with the update of alsa-lib because now we have
dependencies to UMP stuff.  Include the necessary UMP headers
internally.  Also, add the inclusion of rawmidi.h in ump.h for similar
reasons.

Link: https://bugzilla.suse.com/show_bug.cgi?id=1233682
Signed-off-by: Takashi Iwai <ti...@suse.de>
---
 include/seq.h       | 2 ++
 include/seq_event.h | 2 ++
 include/ump.h       | 2 ++
 3 files changed, 6 insertions(+)

diff --git a/include/seq.h b/include/seq.h
index 2eee95a643b4..5082ad0ad82b 100644
--- a/include/seq.h
+++ b/include/seq.h
@@ -29,6 +29,8 @@
 #ifndef __ALSA_SEQ_H
 #define __ALSA_SEQ_H
 
+#include "ump.h"
+
 #ifdef __cplusplus
 extern "C" {
 #endif
diff --git a/include/seq_event.h b/include/seq_event.h
index 9ca384ee4a0a..0b59202f6e62 100644
--- a/include/seq_event.h
+++ b/include/seq_event.h
@@ -28,6 +28,8 @@
 #ifndef __ALSA_SEQ_EVENT_H
 #define __ALSA_SEQ_EVENT_H
 
+#include "ump_msg.h"
+
 /**
  *  \defgroup SeqEvents Sequencer Event Definitions
  *  Sequencer Event Definitions
diff --git a/include/ump.h b/include/ump.h
index 1043d237c68f..06c86a5e8ba3 100644
--- a/include/ump.h
+++ b/include/ump.h
@@ -9,6 +9,8 @@
 #ifndef __ALSA_UMP_H
 #define __ALSA_UMP_H
 
+#include "rawmidi.h"
+
 #ifdef __cplusplus
 extern "C" {
 #endif
-- 
2.43.0

Reply via email to