Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package mpg123 for openSUSE:Factory checked in at 2024-12-16 19:09:07 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/mpg123 (Old) and /work/SRC/openSUSE:Factory/.mpg123.new.29675 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "mpg123" Mon Dec 16 19:09:07 2024 rev:43 rq:1231019 version:1.32.10 Changes: -------- --- /work/SRC/openSUSE:Factory/mpg123/mpg123.changes 2024-11-03 07:17:37.795997850 +0100 +++ /work/SRC/openSUSE:Factory/.mpg123.new.29675/mpg123.changes 2024-12-16 19:09:17.894949665 +0100 @@ -1,0 +2,12 @@ +Sat Dec 14 19:05:04 UTC 2024 - Luigi Baldoni <aloi...@gmx.com> + +- Update to version 1.32.10 + * scripts/tag_lyrics.py: fix for python3 + * libout123: Use strtok_r() to avoid conflicts multithreaded + contexts (both sides should avoid plain strtok()! + * libmpg123: Un-break DLL builds that need I/O functions + defined in libmpg123.c + * ports/cmake: More fixup to also produce .pc files with + Libs.private. + +------------------------------------------------------------------- Old: ---- mpg123-1.32.9.tar.bz2 mpg123-1.32.9.tar.bz2.sig New: ---- mpg123-1.32.10.tar.bz2 mpg123-1.32.10.tar.bz2.sig ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ mpg123.spec ++++++ --- /var/tmp/diff_new_pack.5kIatB/_old 2024-12-16 19:09:18.790986852 +0100 +++ /var/tmp/diff_new_pack.5kIatB/_new 2024-12-16 19:09:18.794987018 +0100 @@ -18,7 +18,7 @@ %define sover 0 Name: mpg123 -Version: 1.32.9 +Version: 1.32.10 Release: 0 Summary: Console MPEG audio player and decoder library License: LGPL-2.1-only ++++++ mpg123-1.32.9.tar.bz2 -> mpg123-1.32.10.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mpg123-1.32.9/NEWS new/mpg123-1.32.10/NEWS --- old/mpg123-1.32.9/NEWS 2024-11-01 09:07:23.000000000 +0100 +++ new/mpg123-1.32.10/NEWS 2024-12-14 16:00:11.000000000 +0100 @@ -1,3 +1,14 @@ +1.32.10 +------ +- scripts/tag_lyrics.py: fix for python3 (thanks to cclauss, + github PR 16) +- libout123: Use strtok_r() to avoid conflicts multithreaded contexts + (both sides should avoid plain strtok()! Debian-bug 1089543). +- libmpg123: +-- Un-break DLL builds that need I/O functions defined in libmpg123.c + (like mpg123_open(), bug 374). +- ports/cmake: More fixup to also produce .pc files with Libs.private. + 1.32.9 ------ - libmpg123: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mpg123-1.32.9/configure new/mpg123-1.32.10/configure --- old/mpg123-1.32.9/configure 2024-11-01 09:14:05.000000000 +0100 +++ new/mpg123-1.32.10/configure 2024-12-14 16:01:08.000000000 +0100 @@ -1,6 +1,6 @@ #! /bin/sh # Guess values for system-dependent variables and create Makefiles. -# Generated by GNU Autoconf 2.71 for mpg123 1.32.9. +# Generated by GNU Autoconf 2.71 for mpg123 1.32.10. # # Report bugs to <maintai...@mpg123.org>. # @@ -621,8 +621,8 @@ # Identity of this package. PACKAGE_NAME='mpg123' PACKAGE_TARNAME='mpg123' -PACKAGE_VERSION='1.32.9' -PACKAGE_STRING='mpg123 1.32.9' +PACKAGE_VERSION='1.32.10' +PACKAGE_STRING='mpg123 1.32.10' PACKAGE_BUGREPORT='maintai...@mpg123.org' PACKAGE_URL='' @@ -1727,7 +1727,7 @@ # Omit some internal or obsolete options to make the list less imposing. # This message is too long to be a string in the A/UX 3.1 sh. cat <<_ACEOF -\`configure' configures mpg123 1.32.9 to adapt to many kinds of systems. +\`configure' configures mpg123 1.32.10 to adapt to many kinds of systems. Usage: $0 [OPTION]... [VAR=VALUE]... @@ -1798,7 +1798,7 @@ if test -n "$ac_init_help"; then case $ac_init_help in - short | recursive ) echo "Configuration of mpg123 1.32.9:";; + short | recursive ) echo "Configuration of mpg123 1.32.10:";; esac cat <<\_ACEOF @@ -2076,7 +2076,7 @@ test -n "$ac_init_help" && exit $ac_status if $ac_init_version; then cat <<\_ACEOF -mpg123 configure 1.32.9 +mpg123 configure 1.32.10 generated by GNU Autoconf 2.71 Copyright (C) 2021 Free Software Foundation, Inc. @@ -2621,7 +2621,7 @@ This file contains any messages produced by compilers while running configure, to aid debugging if configure makes a mistake. -It was created by mpg123 $as_me 1.32.9, which was +It was created by mpg123 $as_me 1.32.10, which was generated by GNU Autoconf 2.71. Invocation command line was $ $0$ac_configure_args_raw @@ -3991,7 +3991,7 @@ # Define the identity of the package. PACKAGE='mpg123' - VERSION='1.32.9' + VERSION='1.32.10' printf "%s\n" "#define PACKAGE \"$PACKAGE\"" >>confdefs.h @@ -22453,7 +22453,7 @@ # report actual input values of CONFIG_FILES etc. instead of their # values after options handling. ac_log=" -This file was extended by mpg123 $as_me 1.32.9, which was +This file was extended by mpg123 $as_me 1.32.10, which was generated by GNU Autoconf 2.71. Invocation command line was CONFIG_FILES = $CONFIG_FILES @@ -22521,7 +22521,7 @@ cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1 ac_cs_config='$ac_cs_config_escaped' ac_cs_version="\\ -mpg123 config.status 1.32.9 +mpg123 config.status 1.32.10 configured by $0, generated by GNU Autoconf 2.71, with options \\"\$ac_cs_config\\" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mpg123-1.32.9/mpg123.spec new/mpg123-1.32.10/mpg123.spec --- old/mpg123-1.32.9/mpg123.spec 2024-11-01 09:14:42.000000000 +0100 +++ new/mpg123-1.32.10/mpg123.spec 2024-12-14 16:01:22.000000000 +0100 @@ -3,7 +3,7 @@ # - devel packages for alsa, sdl, etc... to build the respective output modules. Summary: The fast console mpeg audio decoder/player. Name: mpg123 -Version: 1.32.9 +Version: 1.32.10 Release: 1 URL: http://www.mpg123.org/ License: GPL diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mpg123-1.32.9/ports/cmake/src/CMakeLists.txt new/mpg123-1.32.10/ports/cmake/src/CMakeLists.txt --- old/mpg123-1.32.9/ports/cmake/src/CMakeLists.txt 2024-11-01 09:08:47.000000000 +0100 +++ new/mpg123-1.32.10/ports/cmake/src/CMakeLists.txt 2024-12-14 16:00:11.000000000 +0100 @@ -41,6 +41,14 @@ check_function_exists(sin HAVE_M) endfunction(check_m) check_m() +# Cargo coding the check if there is a library rt, possibly providing +# a canary symbol. I am not sure if this logic really mirrors what +# autotools does. +function(check_rt) + set(CMAKE_REQUIRED_LIBRARIES rt) + check_function_exists(clock_gettime HAVE_RT) +endfunction(check_rt) +check_rt() check_function_exists(atoll HAVE_ATOLL) check_function_exists(getaddrinfo HAVE_IPV6) @@ -450,3 +458,7 @@ endif() configure_file(config.cmake.h.in config.h) + +set(LIBMPG123_LIBS "${LIBMPG123_LIBS}" PARENT_SCOPE) +set(LIBOUT123_LIBS "${LIBOUT123_LIBS}" PARENT_SCOPE) +set(LIBSYN123_LIBS "${LIBSYN123_LIBS}" PARENT_SCOPE) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mpg123-1.32.9/ports/cmake/src/libmpg123/CMakeLists.txt new/mpg123-1.32.10/ports/cmake/src/libmpg123/CMakeLists.txt --- old/mpg123-1.32.9/ports/cmake/src/libmpg123/CMakeLists.txt 2024-11-01 09:08:47.000000000 +0100 +++ new/mpg123-1.32.10/ports/cmake/src/libmpg123/CMakeLists.txt 2024-12-14 16:00:11.000000000 +0100 @@ -235,6 +235,13 @@ target_sources(${TARGET} PRIVATE ${PLATFORM_SOURCES}) endif() +if(HAVE_M) + string(APPEND LIBMPG123_LIBS " -lm") +endif() +if(WANT_WIN32_UNICODE) + string(APPEND LIBMPG123_LIBS " -lshlwapi") +endif() +set(LIBMPG123_LIBS "${LIBMPG123_LIBS}" PARENT_SCOPE) target_link_libraries(${TARGET} PRIVATE $<$<BOOL:${HAVE_M}>:m> $<$<BOOL:${WANT_WIN32_UNICODE}>:shlwapi>) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mpg123-1.32.9/ports/cmake/src/libout123/CMakeLists.txt new/mpg123-1.32.10/ports/cmake/src/libout123/CMakeLists.txt --- old/mpg123-1.32.9/ports/cmake/src/libout123/CMakeLists.txt 2024-11-01 09:08:47.000000000 +0100 +++ new/mpg123-1.32.10/ports/cmake/src/libout123/CMakeLists.txt 2024-12-14 16:00:11.000000000 +0100 @@ -18,9 +18,24 @@ set_target_properties(${TARGET} PROPERTIES OUTPUT_NAME out123) +if(HAVE_UNIX_DL) + string(APPEND LIBOUT123_LIBS " -ldl") +endif() +if(HAVE_M) + string(APPEND LIBOUT123_LIBS " -lm") +endif() +if(HAVE_RT) + string(APPEND LIBOUT123_LIBS " -lrt") +endif() +if(WANT_WIN32_UNICODE) + string(APPEND LIBOUT123_LIBS " -lshlwapi") +endif() +set(LIBOUT123_LIBS "${LIBOUT123_LIBS}" PARENT_SCOPE) target_link_libraries(${TARGET} PRIVATE $<TARGET_NAME_IF_EXISTS:defaultmodule> $<$<BOOL:${HAVE_UNIX_DL}>:dl> + $<$<BOOL:${HAVE_M}>:m> + $<$<BOOL:${HAVE_RT}>:rt> $<$<BOOL:${WANT_WIN32_UNICODE}>:shlwapi>) target_include_directories(${TARGET} INTERFACE diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mpg123-1.32.9/ports/cmake/src/libsyn123/CMakeLists.txt new/mpg123-1.32.10/ports/cmake/src/libsyn123/CMakeLists.txt --- old/mpg123-1.32.9/ports/cmake/src/libsyn123/CMakeLists.txt 2024-11-01 09:08:47.000000000 +0100 +++ new/mpg123-1.32.10/ports/cmake/src/libsyn123/CMakeLists.txt 2024-12-14 16:00:11.000000000 +0100 @@ -19,9 +19,12 @@ "$<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}>" "$<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>") +if(HAVE_M) + string(APPEND LIBSYN123_LIBS " -lm") +endif() +set(LIBSYN123_LIBS "${LIBSYN123_LIBS}" PARENT_SCOPE) target_link_libraries(${TARGET} PRIVATE - $<$<BOOL:${HAVE_M}>:m> - $<$<BOOL:${WANT_WIN32_UNICODE}>:shlwapi>) + $<$<BOOL:${HAVE_M}>:m>) install(TARGETS ${TARGET} EXPORT targets ARCHIVE DESTINATION "${CMAKE_INSTALL_LIBDIR}/" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mpg123-1.32.9/scripts/tag_lyrics.py new/mpg123-1.32.10/scripts/tag_lyrics.py --- old/mpg123-1.32.9/scripts/tag_lyrics.py 2024-11-01 09:08:53.000000000 +0100 +++ new/mpg123-1.32.10/scripts/tag_lyrics.py 2024-12-14 16:00:12.000000000 +0100 @@ -20,10 +20,10 @@ # get workdir from first arg or use current dir if (len(sys.argv) > 1): fname = sys.argv[1] - print "fname=" + fname + print("fname=" + fname) else: - print 'Give me at least a file name to work on, plus the lyrics from stdin' - print 'Optionally, you can provide the language (3 lowercase letters) of the lyrics and a description' + print('Give me at least a file name to work on, plus the lyrics from stdin') + print('Optionally, you can provide the language (3 lowercase letters) of the lyrics and a description') sys.exit() if (len(sys.argv) > 2): @@ -32,7 +32,7 @@ if (len(sys.argv) > 3): TEXT_DESC = sys.argv[3] -print "reading lyrics from standard input ..." +print("reading lyrics from standard input ...") lyrics = sys.stdin.read().strip() @@ -41,25 +41,25 @@ try: lyrics = lyrics.decode(enc) TEXT_DESC = TEXT_DESC.decode(enc) - print enc, + print(enc, end=" ") break except: pass -print "Adding lyrics to " + fname -print "Language: " + TEXT_LANG -print "Description: " + TEXT_DESC +print("Adding lyrics to " + fname) +print("Language: " + TEXT_LANG) +print("Description: " + TEXT_DESC) # create ID3 tag if not exists try: tags = ID3(fname) except ID3NoHeaderError: - print "Adding ID3 header;", + print("Adding ID3 header;", end=" ") tags = ID3() # remove old unsychronized lyrics if len(tags.getall(u"USLT::'"+TEXT_LANG+"'")) != 0: - print "Removing Lyrics." + print("Removing Lyrics.") tags.delall(u"USLT::'"+TEXT_LANG+"'") #tags.save(fname) # hm, why? @@ -68,9 +68,9 @@ # USLT frames are present #tags[u"USLT::'eng'"] = (USLT(encoding=3, lang=u'eng', desc=u'desc', text=lyrics)) tags[u"USLT::'"+TEXT_LANG+"'"] = (USLT(encoding=3, lang=TEXT_LANG, desc=TEXT_DESC, text=lyrics)) -print 'Added USLT frame to', fname +print('Added USLT frame to', fname) tags.save(fname) -print 'Done' +print('Done') diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mpg123-1.32.9/src/libmpg123/format.c new/mpg123-1.32.10/src/libmpg123/format.c --- old/mpg123-1.32.9/src/libmpg123/format.c 2024-11-01 09:08:01.000000000 +0100 +++ new/mpg123-1.32.10/src/libmpg123/format.c 2024-12-14 16:00:12.000000000 +0100 @@ -688,7 +688,7 @@ #include "../common/swap_bytes_impl.h" -void swap_endian(struct outbuffer *buf, int block) +static void swap_endian(struct outbuffer *buf, int block) { size_t count; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mpg123-1.32.9/src/libmpg123/id3.c new/mpg123-1.32.10/src/libmpg123/id3.c --- old/mpg123-1.32.9/src/libmpg123/id3.c 2024-11-01 09:08:01.000000000 +0100 +++ new/mpg123-1.32.10/src/libmpg123/id3.c 2024-12-14 16:00:12.000000000 +0100 @@ -794,7 +794,7 @@ #endif /* NO_ID3V2 */ -int store_id3v2( mpg123_handle *fr +static int store_id3v2( mpg123_handle *fr , unsigned long first4bytes, unsigned char buf[6], unsigned long length ) { int ret = 1; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mpg123-1.32.9/src/libmpg123/mpg123lib_intern.h new/mpg123-1.32.10/src/libmpg123/mpg123lib_intern.h --- old/mpg123-1.32.9/src/libmpg123/mpg123lib_intern.h 2024-11-01 09:08:01.000000000 +0100 +++ new/mpg123-1.32.10/src/libmpg123/mpg123lib_intern.h 2024-12-14 16:00:12.000000000 +0100 @@ -21,7 +21,10 @@ // Only portable API plays a role in the library itself, outside of lfs_wrap.c. // Also, we need to ensure no suffix renaming for the primary implementations. -#define MPG123_PORTABLE_API +// But: The _definition_ of non-portable API needs to be present for those +// primary implementations being exported for DLL builds. Just the largefile +// renaming needs to be skipped! +#define MPG123_NO_LARGENAME #define MPG123_ENUM_API #include "mpg123.h" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mpg123-1.32.9/src/libmpg123/optimize.c new/mpg123-1.32.10/src/libmpg123/optimize.c --- old/mpg123-1.32.9/src/libmpg123/optimize.c 2024-11-01 09:08:01.000000000 +0100 +++ new/mpg123-1.32.10/src/libmpg123/optimize.c 2024-12-14 16:00:12.000000000 +0100 @@ -1027,7 +1027,7 @@ NULL }; -void check_decoders(void) +static void check_decoders(void) { #ifndef OPT_MULTI /* In non-multi mode, only the full list (one entry) is used. */ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mpg123-1.32.9/src/libout123/libout123.c new/mpg123-1.32.10/src/libout123/libout123.c --- old/mpg123-1.32.9/src/libout123/libout123.c 2024-11-01 09:08:40.000000000 +0100 +++ new/mpg123-1.32.10/src/libout123/libout123.c 2024-12-14 16:00:12.000000000 +0100 @@ -1,7 +1,7 @@ /* audio: audio output interface - copyright ?-2023 by the mpg123 project - free software under the terms of the LGPL 2.1 + copyright ?-2024 by the mpg123 project - free software under the terms of the LGPL 2.1 see COPYING and AUTHORS files in distribution or http://mpg123.org initially written by Michael Hipp */ @@ -455,11 +455,12 @@ } /* Now loop over the list of possible modules to find one that works. */ - nextname = strtok(modnames, ","); + char *toksave = NULL; + nextname = strtok_r(modnames, ",", &toksave); while(!ao->open && nextname) { char *curname = nextname; - nextname = strtok(NULL, ","); + nextname = strtok_r(NULL, ",", &toksave); check_output_module(ao, curname, device, !nextname); if(ao->open) { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mpg123-1.32.9/src/libout123/modules/sndio.c new/mpg123-1.32.10/src/libout123/modules/sndio.c --- old/mpg123-1.32.9/src/libout123/modules/sndio.c 2024-11-01 09:08:40.000000000 +0100 +++ new/mpg123-1.32.10/src/libout123/modules/sndio.c 2024-12-14 16:00:12.000000000 +0100 @@ -129,7 +129,8 @@ hdl = sio_open(ao->device /* NULL is fine */, SIO_PLAY, 0); if (hdl == NULL) { - error("Got nothing from sio_open(). "); + if(!AOQUIET) + error("Got nothing from sio_open(). "); return -1; } @@ -152,7 +153,8 @@ hdl = sio_open(ao->device, SIO_PLAY, 0); if(hdl == NULL) { - error("Re-opening of device for channel guessing failed."); + if(!AOQUIET) + error("Re-opening of device for channel guessing failed."); return -1; } par.pchan = guess_channels(hdl); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/mpg123-1.32.9/src/version.h new/mpg123-1.32.10/src/version.h --- old/mpg123-1.32.9/src/version.h 2024-11-01 09:07:23.000000000 +0100 +++ new/mpg123-1.32.10/src/version.h 2024-12-14 16:00:29.000000000 +0100 @@ -16,7 +16,7 @@ // only single spaces as separator to ease parsing by build scripts #define MPG123_MAJOR 1 #define MPG123_MINOR 32 -#define MPG123_PATCH 9 +#define MPG123_PATCH 10 // Don't get too wild with that to avoid confusing m4. No brackets. // Also, it should fit well into a sane file name for the tarball. #define MPG123_SUFFIX ""