Script 'mail_helper' called by obssrc
Hello community,

here is the log from the commit of package yast2-bootloader for 
openSUSE:Factory checked in at 2024-12-22 17:58:55
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-bootloader (Old)
 and      /work/SRC/openSUSE:Factory/.yast2-bootloader.new.1881 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "yast2-bootloader"

Sun Dec 22 17:58:55 2024 rev:341 rq:1232832 version:5.0.13

Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-bootloader/yast2-bootloader.changes        
2024-11-08 11:58:39.635662361 +0100
+++ 
/work/SRC/openSUSE:Factory/.yast2-bootloader.new.1881/yast2-bootloader.changes  
    2024-12-22 17:59:06.223198965 +0100
@@ -1,0 +2,7 @@
+Fri Dec 20 10:26:41 UTC 2024 - Josef Reidinger <jreidin...@suse.com>
+
+- Always filter out from installation parameters "root=" as it
+  needs to be always changed to installed system (bsc#1234678)
+- 5.0.13
+
+-------------------------------------------------------------------

Old:
----
  yast2-bootloader-5.0.12.tar.bz2

New:
----
  yast2-bootloader-5.0.13.tar.bz2

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ yast2-bootloader.spec ++++++
--- /var/tmp/diff_new_pack.dNUeRn/_old  2024-12-22 17:59:06.723219501 +0100
+++ /var/tmp/diff_new_pack.dNUeRn/_new  2024-12-22 17:59:06.727219665 +0100
@@ -17,7 +17,7 @@
 
 
 Name:           yast2-bootloader
-Version:        5.0.12
+Version:        5.0.13
 Release:        0
 Summary:        YaST2 - Bootloader Configuration
 License:        GPL-2.0-or-later

++++++ yast2-bootloader-5.0.12.tar.bz2 -> yast2-bootloader-5.0.13.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/yast2-bootloader-5.0.12/package/yast2-bootloader.changes 
new/yast2-bootloader-5.0.13/package/yast2-bootloader.changes
--- old/yast2-bootloader-5.0.12/package/yast2-bootloader.changes        
2024-11-05 11:39:24.000000000 +0100
+++ new/yast2-bootloader-5.0.13/package/yast2-bootloader.changes        
2024-12-20 13:45:06.000000000 +0100
@@ -1,4 +1,11 @@
 -------------------------------------------------------------------
+Fri Dec 20 10:26:41 UTC 2024 - Josef Reidinger <jreidin...@suse.com>
+
+- Always filter out from installation parameters "root=" as it
+  needs to be always changed to installed system (bsc#1234678)
+- 5.0.13
+
+-------------------------------------------------------------------
 Tue Nov  5 09:57:58 UTC 2024 - Josef Reidinger <jreidin...@suse.com>
 
 - Sync warning text from s390 secure boot to be identical in
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/yast2-bootloader-5.0.12/package/yast2-bootloader.spec 
new/yast2-bootloader-5.0.13/package/yast2-bootloader.spec
--- old/yast2-bootloader-5.0.12/package/yast2-bootloader.spec   2024-11-05 
11:39:24.000000000 +0100
+++ new/yast2-bootloader-5.0.13/package/yast2-bootloader.spec   2024-12-20 
13:45:06.000000000 +0100
@@ -17,7 +17,7 @@
 
 
 Name:           yast2-bootloader
-Version:        5.0.12
+Version:        5.0.13
 Release:        0
 Summary:        YaST2 - Bootloader Configuration
 License:        GPL-2.0-or-later
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-bootloader-5.0.12/src/modules/BootArch.rb 
new/yast2-bootloader-5.0.13/src/modules/BootArch.rb
--- old/yast2-bootloader-5.0.12/src/modules/BootArch.rb 2024-11-05 
11:39:24.000000000 +0100
+++ new/yast2-bootloader-5.0.13/src/modules/BootArch.rb 2024-12-20 
13:45:06.000000000 +0100
@@ -57,6 +57,8 @@
         "additional_kernel_parameters"
       )
       kernel_cmdline = Kernel.GetCmdLine.dup
+      # filter out root= parameter as installation special root cannot work on 
target system
+      kernel_cmdline.gsub!(/root=\S+/, "")
 
       if Arch.i386 || Arch.x86_64 || Arch.aarch64 || Arch.arm || Arch.ppc || 
Arch.riscv64
         ret = kernel_cmdline
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-bootloader-5.0.12/test/boot_arch_test.rb 
new/yast2-bootloader-5.0.13/test/boot_arch_test.rb
--- old/yast2-bootloader-5.0.12/test/boot_arch_test.rb  2024-11-05 
11:39:24.000000000 +0100
+++ new/yast2-bootloader-5.0.13/test/boot_arch_test.rb  2024-12-20 
13:45:06.000000000 +0100
@@ -30,6 +30,14 @@
         expect(subject.DefaultKernelParams("/dev/sda2")).to 
include("console=ttyS0")
       end
 
+      it "filters out root= parameter from boot command line" do
+        allow(Yast::Kernel).to receive(:GetCmdLine)
+          
.and_return("root=live:http://example.com/agama-installer.x86_64-10.0.0-SLE-Build40.6.iso
 live.password=nots3cr3t console=ttyS1,115200")
+
+        expect(subject.DefaultKernelParams("/dev/sda2")).to 
include("live.password=nots3cr3t console=ttyS1,115200")
+        expect(subject.DefaultKernelParams("/dev/sda2")).to_not 
include("root=")
+      end
+
       it "adds additional parameters from Product file" do
         allow(Yast::ProductFeatures).to receive(:GetStringFeature)
           .with("globals", 
"additional_kernel_parameters").and_return("console=ttyS0")

Reply via email to