Script 'mail_helper' called by obssrc
Hello community,

here is the log from the commit of package netgen for openSUSE:Factory checked 
in at 2024-12-22 18:05:08
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/netgen (Old)
 and      /work/SRC/openSUSE:Factory/.netgen.new.1881 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "netgen"

Sun Dec 22 18:05:08 2024 rev:15 rq:1233007 version:6.2.2404

Changes:
--------
--- /work/SRC/openSUSE:Factory/netgen/netgen.changes    2024-12-19 
21:41:05.917845417 +0100
+++ /work/SRC/openSUSE:Factory/.netgen.new.1881/netgen.changes  2024-12-22 
18:05:24.942752823 +0100
@@ -1,0 +2,7 @@
+Fri Dec 20 13:30:27 UTC 2024 - Stefan Brüns <stefan.bru...@rwth-aachen.de>
+
+- Enable python tests on Tumbleweed (requires python-check).
+- Fix crash in boundarylayer tests, add
+  * 0001-Fix-invalid-string-access-in-BoundaryLayerTool.patch
+
+-------------------------------------------------------------------

New:
----
  0001-Fix-invalid-string-access-in-BoundaryLayerTool.patch

BETA DEBUG BEGIN:
  New:- Fix crash in boundarylayer tests, add
  * 0001-Fix-invalid-string-access-in-BoundaryLayerTool.patch
BETA DEBUG END:

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ netgen.spec ++++++
--- /var/tmp/diff_new_pack.4a96DB/_old  2024-12-22 18:05:25.614780422 +0100
+++ /var/tmp/diff_new_pack.4a96DB/_new  2024-12-22 18:05:25.614780422 +0100
@@ -19,8 +19,12 @@
 %bcond_with openmpi
 %bcond_without ffmpeg
 %bcond_without opencascade
+%if 0%{?suse_version} > 1500
+%bcond_without pytest
+%else
 # pytest-check is not available
 %bcond_with pytest
+%endif
 
 Name:           netgen
 Version:        6.2.2404
@@ -50,6 +54,8 @@
 Patch13:        0001-Do-not-EXPORT-python-modules-as-CMake-targets.patch
 # PATCH-FIX-UPSTREAM -- https://github.com/NGSolve/netgen/issues/201
 Patch14:        0001-Fix-static-initialization-order-for-UserFormatRegist.patch
+# PATCH-FIX-UPSTREAM -- https://github.com/NGSolve/netgen/issues/203
+Patch15:        0001-Fix-invalid-string-access-in-BoundaryLayerTool.patch
 %if %{with opencascade}
 BuildRequires:  occt-devel
 BuildRequires:  (pkgconfig(catch2) >= 2.13.4 with pkgconfig(catch2) < 3)
@@ -213,11 +219,19 @@
 
 %check
 export LD_LIBRARY_PATH=%{buildroot}%{_libdir}/%{name}
-export PYTHONDONTWRITEBYTECODE=1
-%ctest %{!?with_pytest: --exclude-regex pytest}
-
 # Test if the binary actually works
 %{buildroot}/%{_bindir}/netgen -batchmode || true
+%ctest --exclude-regex pytest
+
+%if %{with pytest}
+# run manually, to see progress/failures
+# tolerance failures on aarch64 and ppc64le, see 
https://github.com/NGSolve/netgen/issues/167
+%ifarch %{arm64} %{ppc64}
+export PYTEST_ADDOPTS='-k "not (boxcyl.geo-mp11-5 or cylsphere.geo-mp58-4 or 
hinge.stl-mp93-5 or part1.stl-mp123-1 or part1.stl-mp126-4 or 
sculpture.geo-mp143-4 or sphereincube.geo-mp162-5 or twobricks.geo-mp195-2 or 
twocubes.geo-mp201-2)"'
+%endif
+export COLUMNS=120
+(cd tests/pytest; %{python3_pytest_arch})
+%endif
 
 %files
 %license LICENSE

++++++ 0001-Fix-invalid-string-access-in-BoundaryLayerTool.patch ++++++
>From cd9a7c5dd2e0a195f521bf316641b2e8b189b153 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Br=C3=BCns?= <stefan.bru...@rwth-aachen.de>
Date: Fri, 20 Dec 2024 14:29:28 +0100
Subject: [PATCH] Fix invalid string access in BoundaryLayerTool

When AddFaceDescriptor reallocates the array the fd reference becomes
dangling.
---
 libsrc/meshing/boundarylayer.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libsrc/meshing/boundarylayer.cpp b/libsrc/meshing/boundarylayer.cpp
index 9db4601..bcfc8c2 100644
--- a/libsrc/meshing/boundarylayer.cpp
+++ b/libsrc/meshing/boundarylayer.cpp
@@ -722,7 +722,8 @@ namespace netgen
             new_fd.SetBCProperty(new_si);
             mesh.AddFaceDescriptor(new_fd);
             si_map[facei] = new_si;
-            mesh.SetBCName(new_si-1, fd.GetBCName());
+            // AddFaceDescriptor may reallocate, fd is invalidated
+            mesh.SetBCName(new_si-1, 
mesh.GetFaceDescriptor(facei).GetBCName());
             face_done.SetBit(facei);
           }
       }
-- 
2.47.1

Reply via email to