Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package fcitx5-qt for openSUSE:Factory checked in at 2025-01-29 16:17:45 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/fcitx5-qt (Old) and /work/SRC/openSUSE:Factory/.fcitx5-qt.new.2316 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "fcitx5-qt" Wed Jan 29 16:17:45 2025 rev:16 rq:1241109 version:5.1.9 Changes: -------- --- /work/SRC/openSUSE:Factory/fcitx5-qt/fcitx5-qt.changes 2025-01-06 16:05:46.603155528 +0100 +++ /work/SRC/openSUSE:Factory/.fcitx5-qt.new.2316/fcitx5-qt.changes 2025-01-29 16:18:21.179312613 +0100 @@ -1,0 +2,8 @@ +Wed Jan 29 07:10:40 UTC 2025 - Marguerite Su <[email protected]> + +- Update to 5.1.9 + * refactor: use range-based for loop to enhance readability + * refactory: replace non-empty QString constructors with + QStringLiteral + +------------------------------------------------------------------- Old: ---- fcitx5-qt-5.1.8.tar.zst New: ---- fcitx5-qt-5.1.9.tar.zst ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ fcitx5-qt.spec ++++++ --- /var/tmp/diff_new_pack.OyGqnC/_old 2025-01-29 16:18:21.959344960 +0100 +++ /var/tmp/diff_new_pack.OyGqnC/_new 2025-01-29 16:18:21.963345126 +0100 @@ -29,7 +29,7 @@ %define build_qt5 1 Name: fcitx5-qt -Version: 5.1.8 +Version: 5.1.9 Release: 0 Summary: Qt library and IM module for fcitx5 License: BSD-3-Clause AND LGPL-2.1-or-later ++++++ fcitx5-qt-5.1.8.tar.zst -> fcitx5-qt-5.1.9.tar.zst ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/fcitx5-qt-5.1.8/CMakeLists.txt new/fcitx5-qt-5.1.9/CMakeLists.txt --- old/fcitx5-qt-5.1.8/CMakeLists.txt 2024-10-18 02:39:59.000000000 +0200 +++ new/fcitx5-qt-5.1.9/CMakeLists.txt 2025-01-23 00:27:37.000000000 +0100 @@ -1,5 +1,5 @@ cmake_minimum_required(VERSION 3.16) -project(fcitx5-qt VERSION 5.1.8) +project(fcitx5-qt VERSION 5.1.9) set(FCITX5_QT_VERSION ${PROJECT_VERSION}) set(REQUIRED_QT4_VERSION 4.8.0) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/fcitx5-qt-5.1.8/qt5/platforminputcontext/fcitx4inputcontextproxy_p.h new/fcitx5-qt-5.1.9/qt5/platforminputcontext/fcitx4inputcontextproxy_p.h --- old/fcitx5-qt-5.1.8/qt5/platforminputcontext/fcitx4inputcontextproxy_p.h 2024-10-18 02:39:59.000000000 +0200 +++ new/fcitx5-qt-5.1.9/qt5/platforminputcontext/fcitx4inputcontextproxy_p.h 2025-01-23 00:27:37.000000000 +0100 @@ -116,7 +116,7 @@ unsigned int> reply(*createInputContextWatcher_); - QString path = QString("/inputcontext_%1").arg(reply.value()); + QString path = QStringLiteral("/inputcontext_%1").arg(reply.value()); icproxy_ = new Fcitx4InputContextProxyImpl(improxy_->service(), path, improxy_->connection(), q); QObject::connect(icproxy_, &Fcitx4InputContextProxyImpl::CommitString, diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/fcitx5-qt-5.1.8/qt5/platforminputcontext/fcitx4watcher.cpp new/fcitx5-qt-5.1.9/qt5/platforminputcontext/fcitx4watcher.cpp --- old/fcitx5-qt-5.1.8/qt5/platforminputcontext/fcitx4watcher.cpp 2024-10-18 02:39:59.000000000 +0200 +++ new/fcitx5-qt-5.1.9/qt5/platforminputcontext/fcitx4watcher.cpp 2025-01-23 00:27:37.000000000 +0100 @@ -48,7 +48,7 @@ QString socketFile() { QString filename = - QString("%1-%2") + QStringLiteral("%1-%2") .arg(QString::fromLatin1(QDBusConnection::localMachineId())) .arg(displayNumber()); @@ -56,7 +56,7 @@ if (home.isEmpty()) { home = QDir::homePath().append(QLatin1String("/.config")); } - return QString("%1/fcitx/dbus/%2").arg(home).arg(filename); + return QStringLiteral("%1/fcitx/dbus/%2").arg(home).arg(filename); } namespace fcitx { @@ -64,13 +64,13 @@ QString newUniqueConnectionName() { static int idx = 0; const auto newIdx = idx++; - return QString("_fcitx4_%1").arg(newIdx); + return QStringLiteral("_fcitx4_%1").arg(newIdx); } Fcitx4Watcher::Fcitx4Watcher(QDBusConnection sessionBus, QObject *parent) : QObject(parent), connection_(nullptr), sessionBus_(sessionBus), socketFile_(socketFile()), - serviceName_(QString("org.fcitx.Fcitx-%1").arg(displayNumber())), + serviceName_(QStringLiteral("org.fcitx.Fcitx-%1").arg(displayNumber())), availability_(false), uniqueConnectionName_(newUniqueConnectionName()) {} Fcitx4Watcher::~Fcitx4Watcher() { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/fcitx5-qt-5.1.8/qt5/platforminputcontext/fcitxcandidatewindow.cpp new/fcitx5-qt-5.1.9/qt5/platforminputcontext/fcitxcandidatewindow.cpp --- old/fcitx5-qt-5.1.8/qt5/platforminputcontext/fcitxcandidatewindow.cpp 2024-10-18 02:39:59.000000000 +0200 +++ new/fcitx5-qt-5.1.9/qt5/platforminputcontext/fcitxcandidatewindow.cpp 2025-01-23 00:27:37.000000000 +0100 @@ -452,11 +452,11 @@ doLayout(lowerLayout_); labelLayouts_.clear(); candidateLayouts_.clear(); - for (int i = 0; i < candidates.size(); i++) { - labelLayouts_.emplace_back(std::make_unique<MultilineText>( - theme_->font(), candidates[i].key())); - candidateLayouts_.emplace_back(std::make_unique<MultilineText>( - theme_->font(), candidates[i].value())); + for (const auto &candidate : candidates) { + labelLayouts_.emplace_back( + std::make_unique<MultilineText>(theme_->font(), candidate.key())); + candidateLayouts_.emplace_back( + std::make_unique<MultilineText>(theme_->font(), candidate.value())); } highlight_ = candidateIndex; hasPrev_ = hasPrev; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/fcitx5-qt-5.1.8/qt5/platforminputcontext/fcitxtheme.cpp new/fcitx5-qt-5.1.9/qt5/platforminputcontext/fcitxtheme.cpp --- old/fcitx5-qt-5.1.8/qt5/platforminputcontext/fcitxtheme.cpp 2024-10-18 02:39:59.000000000 +0200 +++ new/fcitx5-qt-5.1.9/qt5/platforminputcontext/fcitxtheme.cpp 2025-01-23 00:27:37.000000000 +0100 @@ -39,7 +39,7 @@ } else if (colorString.size() == 9) { // Qt accept "#AARRGGBB" auto newColorString = - QString("#%1%2") + QStringLiteral("#%1%2") .arg(colorString.mid(7, 2), colorString.mid(1, 6)) .toUpper(); color = QColor(newColorString); @@ -55,13 +55,13 @@ if (auto image = settings.value("Image").toString(); !image.isEmpty()) { auto file = QStandardPaths::locate( QStandardPaths::GenericDataLocation, - QString("fcitx5/themes/%1/%2").arg(name, image)); + QStringLiteral("fcitx5/themes/%1/%2").arg(name, image)); image_.load(file); } if (auto image = settings.value("Overlay").toString(); !image.isEmpty()) { auto file = QStandardPaths::locate( QStandardPaths::GenericDataLocation, - QString("fcitx5/themes/%1/%2").arg(name, image)); + QStringLiteral("fcitx5/themes/%1/%2").arg(name, image)); overlay_.load(file); } @@ -130,7 +130,7 @@ if (auto image = settings.value("Image").toString(); !image.isEmpty()) { auto file = QStandardPaths::locate( QStandardPaths::GenericDataLocation, - QString("fcitx5/themes/%1/%2").arg(name, image)); + QStringLiteral("fcitx5/themes/%1/%2").arg(name, image)); image_.load(file); valid_ = !image_.isNull(); } @@ -185,7 +185,8 @@ if (!themeConfigPath_.isEmpty()) { watcher_->removePath(themeConfigPath_); } - auto themeConfig = QString("/fcitx5/themes/%1/theme.conf").arg(theme_); + auto themeConfig = + QStringLiteral("/fcitx5/themes/%1/theme.conf").arg(theme_); themeConfigPath_ = QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) .append(themeConfig); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/fcitx5-qt-5.1.8/qt6/quickphrase-editor/model.cpp new/fcitx5-qt-5.1.9/qt6/quickphrase-editor/model.cpp --- old/fcitx5-qt-5.1.8/qt6/quickphrase-editor/model.cpp 2024-10-18 02:39:59.000000000 +0200 +++ new/fcitx5-qt-5.1.9/qt6/quickphrase-editor/model.cpp 2025-01-23 00:27:37.000000000 +0100 @@ -225,8 +225,8 @@ } void QuickPhraseModel::saveDataToStream(QTextStream &dev) { - for (int i = 0; i < list_.size(); i++) { - dev << list_[i].first << "\t" << escapeValue(list_[i].second) << "\n"; + for (const auto &item : list_) { + dev << item.first << "\t" << escapeValue(item.second) << "\n"; } } @@ -263,10 +263,10 @@ if (!tempFile.open(fd, QIODevice::WriteOnly)) { return false; } - for (int i = 0; i < list.size(); i++) { - tempFile.write(list[i].first.toUtf8()); + for (const auto &item : list) { + tempFile.write(item.first.toUtf8()); tempFile.write("\t"); - tempFile.write(escapeValue(list[i].second).toUtf8()); + tempFile.write(escapeValue(item.second).toUtf8()); tempFile.write("\n"); } tempFile.close();
