Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package openQA for openSUSE:Factory checked
in at 2025-03-05 13:40:55
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/openQA (Old)
and /work/SRC/openSUSE:Factory/.openQA.new.19136 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "openQA"
Wed Mar 5 13:40:55 2025 rev:679 rq:1250257 version:5.1741096950.1f5cdabd
Changes:
--------
--- /work/SRC/openSUSE:Factory/openQA/openQA.changes 2025-03-04
18:33:00.126979146 +0100
+++ /work/SRC/openSUSE:Factory/.openQA.new.19136/openQA.changes 2025-03-05
13:42:02.128358767 +0100
@@ -1,0 +2,12 @@
+Tue Mar 04 18:14:12 UTC 2025 - ok...@suse.com
+
+- Update to version 5.1741096950.1f5cdabd:
+ * Remove Try::Tiny from dependencies
+ * Avoid error when emiting an AMQP job event when the job does not exist
+ * Add check to enforce Feature::Compat::Try
+ * Use Feature::Compat::Try in openqa-load-templates script
+ * Update migration script using Feature::Compat::Try
+ * Remove unused dependency from SeleniumTest.pm
+ * Use Test::Exception in deploy.t
+
+-------------------------------------------------------------------
Old:
----
openQA-5.1741014912.a69a2ecf.obscpio
New:
----
openQA-5.1741096950.1f5cdabd.obscpio
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ openQA-client-test.spec ++++++
--- /var/tmp/diff_new_pack.51MyJw/_old 2025-03-05 13:42:04.916475770 +0100
+++ /var/tmp/diff_new_pack.51MyJw/_new 2025-03-05 13:42:04.928476274 +0100
@@ -18,7 +18,7 @@
%define short_name openQA-client
Name: %{short_name}-test
-Version: 5.1741014912.a69a2ecf
+Version: 5.1741096950.1f5cdabd
Release: 0
Summary: Test package for %{short_name}
License: GPL-2.0-or-later
++++++ openQA-devel-test.spec ++++++
--- /var/tmp/diff_new_pack.51MyJw/_old 2025-03-05 13:42:05.268490543 +0100
+++ /var/tmp/diff_new_pack.51MyJw/_new 2025-03-05 13:42:05.284491214 +0100
@@ -18,7 +18,7 @@
%define short_name openQA-devel
Name: %{short_name}-test
-Version: 5.1741014912.a69a2ecf
+Version: 5.1741096950.1f5cdabd
Release: 0
Summary: Test package for %{short_name}
License: GPL-2.0-or-later
++++++ openQA-test.spec ++++++
--- /var/tmp/diff_new_pack.51MyJw/_old 2025-03-05 13:42:05.596504308 +0100
+++ /var/tmp/diff_new_pack.51MyJw/_new 2025-03-05 13:42:05.612504979 +0100
@@ -18,7 +18,7 @@
%define short_name openQA
Name: %{short_name}-test
-Version: 5.1741014912.a69a2ecf
+Version: 5.1741096950.1f5cdabd
Release: 0
Summary: Test package for openQA
License: GPL-2.0-or-later
++++++ openQA-worker-test.spec ++++++
--- /var/tmp/diff_new_pack.51MyJw/_old 2025-03-05 13:42:05.868515723 +0100
+++ /var/tmp/diff_new_pack.51MyJw/_new 2025-03-05 13:42:05.896516898 +0100
@@ -18,7 +18,7 @@
%define short_name openQA-worker
Name: %{short_name}-test
-Version: 5.1741014912.a69a2ecf
+Version: 5.1741096950.1f5cdabd
Release: 0
Summary: Test package for %{short_name}
License: GPL-2.0-or-later
++++++ openQA.spec ++++++
--- /var/tmp/diff_new_pack.51MyJw/_old 2025-03-05 13:42:06.224530663 +0100
+++ /var/tmp/diff_new_pack.51MyJw/_new 2025-03-05 13:42:06.240531335 +0100
@@ -59,7 +59,7 @@
# The following line is generated from dependencies.yaml
%define assetpack_requires perl(CSS::Minifier::XS) >= 0.01
perl(JavaScript::Minifier::XS) >= 0.11 perl(Mojolicious)
perl(Mojolicious::Plugin::AssetPack) >= 1.36 perl(YAML::PP) >= 0.026
# The following line is generated from dependencies.yaml
-%define common_requires ntp-daemon perl >= 5.20.0 perl(Carp::Always) >=
0.14.02 perl(Config::IniFiles) perl(Config::Tiny) perl(Cpanel::JSON::XS) >=
4.09 perl(Cwd) perl(Data::Dump) perl(Data::Dumper) perl(Digest::MD5)
perl(Feature::Compat::Try) perl(Filesys::Df) perl(Getopt::Long) perl(Minion) >=
10.25 perl(Mojolicious) >= 9.340.0 perl(Regexp::Common) perl(Storable)
perl(Text::Glob) perl(Time::Moment) perl(Try::Tiny)
+%define common_requires ntp-daemon perl >= 5.20.0 perl(Carp::Always) >=
0.14.02 perl(Config::IniFiles) perl(Config::Tiny) perl(Cpanel::JSON::XS) >=
4.09 perl(Cwd) perl(Data::Dump) perl(Data::Dumper) perl(Digest::MD5)
perl(Feature::Compat::Try) perl(Filesys::Df) perl(Getopt::Long) perl(Minion) >=
10.25 perl(Mojolicious) >= 9.340.0 perl(Regexp::Common) perl(Storable)
perl(Text::Glob) perl(Time::Moment)
# runtime requirements for the main package that are not required by other
sub-packages
# The following line is generated from dependencies.yaml
%define main_requires %assetpack_requires bsdtar git-core hostname
perl(BSD::Resource) perl(Carp) perl(CommonMark) perl(Config::Tiny)
perl(DBD::Pg) >= 3.7.4 perl(DBI) >= 1.632 perl(DBIx::Class) >= 0.082801
perl(DBIx::Class::DeploymentHandler) perl(DBIx::Class::DynamicDefault)
perl(DBIx::Class::OptimisticLocking)
perl(DBIx::Class::ResultClass::HashRefInflator)
perl(DBIx::Class::Schema::Config) perl(DBIx::Class::Storage::Statistics)
perl(Date::Format) perl(DateTime) perl(DateTime::Duration)
perl(DateTime::Format::Pg) perl(Exporter) perl(Fcntl) perl(File::Basename)
perl(File::Copy) perl(File::Copy::Recursive) perl(File::Path) perl(File::Spec)
perl(FindBin) perl(Getopt::Long::Descriptive) perl(IO::Handle) perl(IPC::Run)
perl(JSON::Validator) perl(LWP::UserAgent) perl(Module::Load::Conditional)
perl(Module::Pluggable) perl(Mojo::Base) perl(Mojo::ByteStream)
perl(Mojo::IOLoop) perl(Mojo::JSON) perl(Mojo::Pg) perl(Mojo::RabbitMQ::Client)
>= 0.2 perl(Mojo::URL) perl(Mojo::Util) perl(Mojolic
ious::Commands) perl(Mojolicious::Plugin) perl(Mojolicious::Plugin::OAuth2)
perl(Mojolicious::Static) perl(Net::OpenID::Consumer) perl(POSIX)
perl(Pod::POM) perl(SQL::Translator) perl(Scalar::Util) perl(Sort::Versions)
perl(Text::Diff) perl(Time::HiRes) perl(Time::ParseDate) perl(Time::Piece)
perl(Time::Seconds) perl(URI::Escape) perl(YAML::PP) >= 0.026 perl(YAML::XS)
perl(aliased) perl(base) perl(constant) perl(diagnostics) perl(strict)
perl(warnings)
@@ -90,7 +90,7 @@
%define devel_requires %devel_no_selenium_requires chromedriver
Name: openQA
-Version: 5.1741014912.a69a2ecf
+Version: 5.1741096950.1f5cdabd
Release: 0
Summary: The openQA web-frontend, scheduler and tools
License: GPL-2.0-or-later
++++++ openQA-5.1741014912.a69a2ecf.obscpio ->
openQA-5.1741096950.1f5cdabd.obscpio ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/openQA-5.1741014912.a69a2ecf/cpanfile
new/openQA-5.1741096950.1f5cdabd/cpanfile
--- old/openQA-5.1741014912.a69a2ecf/cpanfile 2025-03-03 16:15:12.000000000
+0100
+++ new/openQA-5.1741096950.1f5cdabd/cpanfile 2025-03-04 15:02:30.000000000
+0100
@@ -86,7 +86,6 @@
requires 'Time::ParseDate';
requires 'Time::Piece';
requires 'Time::Seconds';
-requires 'Try::Tiny';
requires 'URI::Escape';
requires 'YAML::PP', '>= 0.026';
requires 'YAML::XS';
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/openQA-5.1741014912.a69a2ecf/dbicdh/_common/upgrade/76-77/001-migrate-audit-events-to-scheduled-products.pl
new/openQA-5.1741096950.1f5cdabd/dbicdh/_common/upgrade/76-77/001-migrate-audit-events-to-scheduled-products.pl
---
old/openQA-5.1741014912.a69a2ecf/dbicdh/_common/upgrade/76-77/001-migrate-audit-events-to-scheduled-products.pl
2025-03-03 16:15:12.000000000 +0100
+++
new/openQA-5.1741096950.1f5cdabd/dbicdh/_common/upgrade/76-77/001-migrate-audit-events-to-scheduled-products.pl
2025-03-04 15:02:30.000000000 +0100
@@ -10,7 +10,7 @@
use OpenQA::Log qw(log_info log_warning);
use OpenQA::Utils;
use Mojo::JSON qw(decode_json encode_json);
-use Try::Tiny;
+use Feature::Compat::Try;
sub {
my ($schema) = @_;
@@ -26,8 +26,8 @@
my $settings;
try {
$settings = decode_json($event->event_data);
- };
- if (!$settings) {
+ }
+ catch ($e) {
log_warning(
"Unable to read settings from 'iso_create' audit event with ID
$event_id. Skipping its migration.");
next;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/openQA-5.1741014912.a69a2ecf/dependencies.yaml
new/openQA-5.1741096950.1f5cdabd/dependencies.yaml
--- old/openQA-5.1741014912.a69a2ecf/dependencies.yaml 2025-03-03
16:15:12.000000000 +0100
+++ new/openQA-5.1741096950.1f5cdabd/dependencies.yaml 2025-03-04
15:02:30.000000000 +0100
@@ -50,7 +50,6 @@
perl(Storable):
perl(Text::Glob):
perl(Time::Moment):
- perl(Try::Tiny):
perl(Config::Tiny):
ntp-daemon:
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/openQA-5.1741014912.a69a2ecf/dist/rpm/openQA.spec
new/openQA-5.1741096950.1f5cdabd/dist/rpm/openQA.spec
--- old/openQA-5.1741014912.a69a2ecf/dist/rpm/openQA.spec 2025-03-03
16:15:12.000000000 +0100
+++ new/openQA-5.1741096950.1f5cdabd/dist/rpm/openQA.spec 2025-03-04
15:02:30.000000000 +0100
@@ -59,7 +59,7 @@
# The following line is generated from dependencies.yaml
%define assetpack_requires perl(CSS::Minifier::XS) >= 0.01
perl(JavaScript::Minifier::XS) >= 0.11 perl(Mojolicious)
perl(Mojolicious::Plugin::AssetPack) >= 1.36 perl(YAML::PP) >= 0.026
# The following line is generated from dependencies.yaml
-%define common_requires ntp-daemon perl >= 5.20.0 perl(Carp::Always) >=
0.14.02 perl(Config::IniFiles) perl(Config::Tiny) perl(Cpanel::JSON::XS) >=
4.09 perl(Cwd) perl(Data::Dump) perl(Data::Dumper) perl(Digest::MD5)
perl(Feature::Compat::Try) perl(Filesys::Df) perl(Getopt::Long) perl(Minion) >=
10.25 perl(Mojolicious) >= 9.340.0 perl(Regexp::Common) perl(Storable)
perl(Text::Glob) perl(Time::Moment) perl(Try::Tiny)
+%define common_requires ntp-daemon perl >= 5.20.0 perl(Carp::Always) >=
0.14.02 perl(Config::IniFiles) perl(Config::Tiny) perl(Cpanel::JSON::XS) >=
4.09 perl(Cwd) perl(Data::Dump) perl(Data::Dumper) perl(Digest::MD5)
perl(Feature::Compat::Try) perl(Filesys::Df) perl(Getopt::Long) perl(Minion) >=
10.25 perl(Mojolicious) >= 9.340.0 perl(Regexp::Common) perl(Storable)
perl(Text::Glob) perl(Time::Moment)
# runtime requirements for the main package that are not required by other
sub-packages
# The following line is generated from dependencies.yaml
%define main_requires %assetpack_requires bsdtar git-core hostname
perl(BSD::Resource) perl(Carp) perl(CommonMark) perl(Config::Tiny)
perl(DBD::Pg) >= 3.7.4 perl(DBI) >= 1.632 perl(DBIx::Class) >= 0.082801
perl(DBIx::Class::DeploymentHandler) perl(DBIx::Class::DynamicDefault)
perl(DBIx::Class::OptimisticLocking)
perl(DBIx::Class::ResultClass::HashRefInflator)
perl(DBIx::Class::Schema::Config) perl(DBIx::Class::Storage::Statistics)
perl(Date::Format) perl(DateTime) perl(DateTime::Duration)
perl(DateTime::Format::Pg) perl(Exporter) perl(Fcntl) perl(File::Basename)
perl(File::Copy) perl(File::Copy::Recursive) perl(File::Path) perl(File::Spec)
perl(FindBin) perl(Getopt::Long::Descriptive) perl(IO::Handle) perl(IPC::Run)
perl(JSON::Validator) perl(LWP::UserAgent) perl(Module::Load::Conditional)
perl(Module::Pluggable) perl(Mojo::Base) perl(Mojo::ByteStream)
perl(Mojo::IOLoop) perl(Mojo::JSON) perl(Mojo::Pg) perl(Mojo::RabbitMQ::Client)
>= 0.2 perl(Mojo::URL) perl(Mojo::Util) perl(Mojolic
ious::Commands) perl(Mojolicious::Plugin) perl(Mojolicious::Plugin::OAuth2)
perl(Mojolicious::Static) perl(Net::OpenID::Consumer) perl(POSIX)
perl(Pod::POM) perl(SQL::Translator) perl(Scalar::Util) perl(Sort::Versions)
perl(Text::Diff) perl(Time::HiRes) perl(Time::ParseDate) perl(Time::Piece)
perl(Time::Seconds) perl(URI::Escape) perl(YAML::PP) >= 0.026 perl(YAML::XS)
perl(aliased) perl(base) perl(constant) perl(diagnostics) perl(strict)
perl(warnings)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/openQA-5.1741014912.a69a2ecf/lib/OpenQA/WebAPI/Plugin/AMQP.pm
new/openQA-5.1741096950.1f5cdabd/lib/OpenQA/WebAPI/Plugin/AMQP.pm
--- old/openQA-5.1741014912.a69a2ecf/lib/OpenQA/WebAPI/Plugin/AMQP.pm
2025-03-03 16:15:12.000000000 +0100
+++ new/openQA-5.1741096950.1f5cdabd/lib/OpenQA/WebAPI/Plugin/AMQP.pm
2025-03-04 15:02:30.000000000 +0100
@@ -87,8 +87,7 @@
my ($user_id, $connection_id, $event, $event_data) = @$args;
my $jobs = $self->{app}->schema->resultset('Jobs');
- my $job = $jobs->find({id => $event_data->{id}})
- or die "Could not find job '$event_data->{id}' in database";
+ return undef unless my $job = $jobs->find({id => $event_data->{id}});
# find count of pending jobs for the same build to know whether all tests
for a build are done
$event_data->{remaining} = $jobs->search(
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/openQA-5.1741014912.a69a2ecf/script/openqa-load-templates
new/openQA-5.1741096950.1f5cdabd/script/openqa-load-templates
--- old/openQA-5.1741014912.a69a2ecf/script/openqa-load-templates
2025-03-03 16:15:12.000000000 +0100
+++ new/openQA-5.1741096950.1f5cdabd/script/openqa-load-templates
2025-03-04 15:02:30.000000000 +0100
@@ -54,7 +54,7 @@
use FindBin;
use lib "$FindBin::RealBin/../lib";
use File::Basename qw(dirname);
-use Try::Tiny;
+use Feature::Compat::Try;
use Data::Dump 'dd';
use Mojo::Util qw(decamelize);
use Mojo::URL;
@@ -86,10 +86,10 @@
$info = Cpanel::JSON::XS->new->relaxed->decode($datafile);
dd $info;
}
-catch {
+catch ($e) {
$info = eval $datafile;
if (my $error = $@) { die "Error in data file: $error\n" }
-};
+}
$options{'host'} ||= 'localhost';
$options{apibase} ||= '/api/v1';
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/openQA-5.1741014912.a69a2ecf/t/01-style.t
new/openQA-5.1741096950.1f5cdabd/t/01-style.t
--- old/openQA-5.1741014912.a69a2ecf/t/01-style.t 2025-03-03
16:15:12.000000000 +0100
+++ new/openQA-5.1741096950.1f5cdabd/t/01-style.t 2025-03-04
15:02:30.000000000 +0100
@@ -22,6 +22,8 @@
is qx{git grep -I -l '^\\(throws\\|dies\\|lives\\)_ok.*\<sub\>' t/**.t}, '',
'Only use simplified prototyped Test::Exception functions';
is qx{git grep -I -l 'like.*\$\@' t/**.t}, '', 'Use throws_ok instead of
manual checks of exceptions';
+is qx{git grep -I -l '^use \\(Try::Tiny\\|TryCatch\\)'}, '',
+ 'No Try::Tiny or TryCatch necessary, use Feature::Compat::Try and later
native Perl';
is qx{git grep -I -l 'sub [a-z_A-Z0-9]\\+()' ':!docs/'}, '',
'Consistent space before function signatures (this is not ensured by
perltidy)';
done_testing;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/openQA-5.1741014912.a69a2ecf/t/deploy.t
new/openQA-5.1741096950.1f5cdabd/t/deploy.t
--- old/openQA-5.1741014912.a69a2ecf/t/deploy.t 2025-03-03 16:15:12.000000000
+0100
+++ new/openQA-5.1741096950.1f5cdabd/t/deploy.t 2025-03-04 15:02:30.000000000
+0100
@@ -19,7 +19,6 @@
use OpenQA::Test::Case;
use Mojo::File 'path';
use List::Util 'min';
-use Try::Tiny;
plan skip_all => 'set TEST_PG to e.g. "DBI:Pg:dbname=test" to enable this
test' unless $ENV{TEST_PG};
@@ -46,11 +45,8 @@
databases => 'PostgreSQL',
force_overwrite => 0,
});
-my $deployed_version;
-try {
- $deployed_version = $dh->version_storage->database_version;
-};
-ok(!$deployed_version, 'DB not deployed by plain schema connection with deploy
=> 0');
+throws_ok { $dh->version_storage->database_version } 'DBIx::Class::Exception',
+ 'DB not deployed by plain schema connection with deploy => 0';
my $ret = $schema->deploy;
ok($dh->version_storage->database_version, 'DB deployed');
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/openQA-5.1741014912.a69a2ecf/t/lib/OpenQA/SeleniumTest.pm
new/openQA-5.1741096950.1f5cdabd/t/lib/OpenQA/SeleniumTest.pm
--- old/openQA-5.1741014912.a69a2ecf/t/lib/OpenQA/SeleniumTest.pm
2025-03-03 16:15:12.000000000 +0100
+++ new/openQA-5.1741096950.1f5cdabd/t/lib/OpenQA/SeleniumTest.pm
2025-03-04 15:02:30.000000000 +0100
@@ -19,7 +19,6 @@
use IPC::Run qw(start);
use Mojo::IOLoop::Server;
use Mojo::Server::Daemon;
-use Try::Tiny;
use Time::HiRes qw(time sleep);
use OpenQA::WebAPI;
use OpenQA::Log 'log_info';
++++++ openQA.obsinfo ++++++
--- /var/tmp/diff_new_pack.51MyJw/_old 2025-03-05 13:42:22.573215700 +0100
+++ /var/tmp/diff_new_pack.51MyJw/_new 2025-03-05 13:42:22.577215867 +0100
@@ -1,5 +1,5 @@
name: openQA
-version: 5.1741014912.a69a2ecf
-mtime: 1741014912
-commit: a69a2ecf077374acdd39126cb688150d59899ffb
+version: 5.1741096950.1f5cdabd
+mtime: 1741096950
+commit: 1f5cdabdb0a0191ff1eea7b1030a6cd481fc4331
