Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package os-autoinst for openSUSE:Factory
checked in at 2025-03-25 22:10:19
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/os-autoinst (Old)
and /work/SRC/openSUSE:Factory/.os-autoinst.new.2696 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "os-autoinst"
Tue Mar 25 22:10:19 2025 rev:509 rq:1255615 version:5.1742623603.20c141b
Changes:
--------
--- /work/SRC/openSUSE:Factory/os-autoinst/os-autoinst.changes 2025-03-19
22:33:41.450042771 +0100
+++ /work/SRC/openSUSE:Factory/.os-autoinst.new.2696/os-autoinst.changes
2025-03-25 22:18:54.122745602 +0100
@@ -1,0 +2,11 @@
+Mon Mar 24 12:31:32 UTC 2025 - ok...@suse.com
+
+- Update to version 5.1742623603.20c141b:
+ * Consistently use try/catch instead of 'if ' everywhere
+ * Enable validation of resumed asset downloads in svirt backend
+ * Avoid leftover rsync processes on svirt host
+ * Check for correct git warning when cloning an empty repository
+ * Adapt check for git error message to new version
+ * Ensure full coverage in the project
+
+-------------------------------------------------------------------
Old:
----
os-autoinst-5.1742240999.4ad1bd8.obscpio
New:
----
os-autoinst-5.1742623603.20c141b.obscpio
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ os-autoinst-devel-test.spec ++++++
--- /var/tmp/diff_new_pack.YDYA1g/_old 2025-03-25 22:18:54.894777564 +0100
+++ /var/tmp/diff_new_pack.YDYA1g/_new 2025-03-25 22:18:54.894777564 +0100
@@ -18,7 +18,7 @@
%define short_name os-autoinst-devel
Name: %{short_name}-test
-Version: 5.1742240999.4ad1bd8
+Version: 5.1742623603.20c141b
Release: 0
Summary: Test package for %{short_name}
License: GPL-2.0-or-later
++++++ os-autoinst-openvswitch-test.spec ++++++
--- /var/tmp/diff_new_pack.YDYA1g/_old 2025-03-25 22:18:54.918778558 +0100
+++ /var/tmp/diff_new_pack.YDYA1g/_new 2025-03-25 22:18:54.922778723 +0100
@@ -19,7 +19,7 @@
%define name_ext -test
%define short_name os-autoinst-openvswitch
Name: %{short_name}%{?name_ext}
-Version: 5.1742240999.4ad1bd8
+Version: 5.1742623603.20c141b
Release: 0
Summary: test package for %{short_name}
License: GPL-2.0-or-later
++++++ os-autoinst-test.spec ++++++
--- /var/tmp/diff_new_pack.YDYA1g/_old 2025-03-25 22:18:54.946779717 +0100
+++ /var/tmp/diff_new_pack.YDYA1g/_new 2025-03-25 22:18:54.950779883 +0100
@@ -19,7 +19,7 @@
%define name_ext -test
%define short_name os-autoinst
Name: %{short_name}%{?name_ext}
-Version: 5.1742240999.4ad1bd8
+Version: 5.1742623603.20c141b
Release: 0
Summary: test package for os-autoinst
License: GPL-2.0-or-later
++++++ os-autoinst.spec ++++++
--- /var/tmp/diff_new_pack.YDYA1g/_old 2025-03-25 22:18:54.978781042 +0100
+++ /var/tmp/diff_new_pack.YDYA1g/_new 2025-03-25 22:18:54.982781207 +0100
@@ -17,7 +17,7 @@
Name: os-autoinst
-Version: 5.1742240999.4ad1bd8
+Version: 5.1742623603.20c141b
Release: 0
Summary: OS-level test automation
License: GPL-2.0-or-later
++++++ os-autoinst-5.1742240999.4ad1bd8.obscpio ->
os-autoinst-5.1742623603.20c141b.obscpio ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/os-autoinst-5.1742240999.4ad1bd8/autotest.pm
new/os-autoinst-5.1742623603.20c141b/autotest.pm
--- old/os-autoinst-5.1742240999.4ad1bd8/autotest.pm 2025-03-17
20:49:59.000000000 +0100
+++ new/os-autoinst-5.1742623603.20c141b/autotest.pm 2025-03-22
07:06:43.000000000 +0100
@@ -151,8 +151,8 @@
eval $code;
if (my $err = $@) {
if ($is_python) {
- eval "use Inline Python => 'sys.stderr.flush()';";
- bmwqemu::fctwarn("Unable to flush Python's stderr, error message
from Python might be missing: $@") if $@; # uncoverable statement
+ try { require Inline; import Inline Python =>
'sys.stderr.flush()'; }
+ catch ($e) { bmwqemu::fctwarn("Unable to flush Python's stderr,
error message from Python might be missing: $e") } # uncoverable statement
}
my $msg = "error on $script: $err";
bmwqemu::fctwarn($msg);
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/os-autoinst-5.1742240999.4ad1bd8/consoles/sshVirtsh.pm
new/os-autoinst-5.1742623603.20c141b/consoles/sshVirtsh.pm
--- old/os-autoinst-5.1742240999.4ad1bd8/consoles/sshVirtsh.pm 2025-03-17
20:49:59.000000000 +0100
+++ new/os-autoinst-5.1742623603.20c141b/consoles/sshVirtsh.pm 2025-03-22
07:06:43.000000000 +0100
@@ -384,7 +384,7 @@
sub _copy_image_else ($self, $file, $file_basename, $basedir) {
my $download_timeout_s = ONE_MINUTE *
($bmwqemu::vars{SVIRT_ASSET_DOWNLOAD_TIMEOUT_M} // 15);
my $inactivity_timeout_s = ONE_MINUTE *
($bmwqemu::vars{SVIRT_ASSET_DOWNLOAD_INACTIVITY_TIMEOUT_M} // 2.5);
- my $rsync_args = "--timeout='$inactivity_timeout_s' --stats --partial -av";
+ my $rsync_args = "--timeout='$inactivity_timeout_s' --stats --partial
--append-verify -av";
# utilize asset possibly cached by openQA worker, otherwise sync locally
on svirt host (usually relying on NFS mount)
if (($bmwqemu::vars{SVIRT_WORKER_CACHE} // 0) && -e $file_basename &&
defined which 'rsync') {
@@ -676,7 +676,7 @@
}
sub run_cmd_retrying_on_timeouts ($self, $command, @args) {
- my $attempts = $bmwqemu::vars{SVIRT_ASSET_DOWNLOAD_ATTEMPTS} // 3;
+ my $attempts = $bmwqemu::vars{SVIRT_ASSET_DOWNLOAD_ATTEMPTS} // 1;
for (my $attempt = 1;;) {
try {
return $self->run_cmd($command, @args);
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/os-autoinst-5.1742240999.4ad1bd8/t/22-svirt.t
new/os-autoinst-5.1742623603.20c141b/t/22-svirt.t
--- old/os-autoinst-5.1742240999.4ad1bd8/t/22-svirt.t 2025-03-17
20:49:59.000000000 +0100
+++ new/os-autoinst-5.1742623603.20c141b/t/22-svirt.t 2025-03-22
07:06:43.000000000 +0100
@@ -451,6 +451,7 @@
};
subtest 'running command with retry on ssh timeout' => sub {
+ local $bmwqemu::vars{SVIRT_ASSET_DOWNLOAD_ATTEMPTS} = 3;
%ssh_expect = ();
$run_ssh_cmd_return = 42;
$fake_timeouts = 2;
@@ -952,7 +953,7 @@
@last_ssh_commands = ();
@ssh_cmd_return = (0, 0);
$svirt->add_disk({cdrom => 1, dev_id => $dev_id, file =>
$file_path});
- is $last_system_calls[0], "sshpass -p 'password_svirt' rsync -e
'ssh -o StrictHostKeyChecking=no' --timeout='150' --stats --partial -av
'$dir/$file' 'root\@hostname_svirt:$basedir/$file'", 'file copied with rsync';
+ is $last_system_calls[0], "sshpass -p 'password_svirt' rsync -e
'ssh -o StrictHostKeyChecking=no' --timeout='150' --stats --partial
--append-verify -av '$dir/$file' 'root\@hostname_svirt:$basedir/$file'", 'file
copied with rsync';
like $last_ssh_commands[0], qr%unxz%, 'file uncompressed with
unxz';
svirt_xml_validate($svirt,
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/os-autoinst-5.1742240999.4ad1bd8/t/data/tests/tests/assert_screen_fail_test.pm
new/os-autoinst-5.1742623603.20c141b/t/data/tests/tests/assert_screen_fail_test.pm
---
old/os-autoinst-5.1742240999.4ad1bd8/t/data/tests/tests/assert_screen_fail_test.pm
2025-03-17 20:49:59.000000000 +0100
+++
new/os-autoinst-5.1742623603.20c141b/t/data/tests/tests/assert_screen_fail_test.pm
2025-03-22 07:06:43.000000000 +0100
@@ -2,16 +2,16 @@
# SPDX-License-Identifier: GPL-2.0-or-later
use Mojo::Base 'basetest', -signatures;
+use Feature::Compat::Try;
use testapi;
sub run ($) {
# Test done this way, because:
- eval { assert_screen ['no_tag', 'no_tag2'], timeout => 1, no_wait => 1; };
- bmwqemu::diag($@) if $@;
-
- eval { assert_screen 'no_tag3', timeout => 1, no_wait => 1; };
- bmwqemu::diag($@) if $@;
+ try { assert_screen ['no_tag', 'no_tag2'], timeout => 1, no_wait => 1 }
+ catch ($e) { bmwqemu::diag($e) }
+ try { assert_screen 'no_tag3', timeout => 1, no_wait => 1 }
+ catch ($e) { bmwqemu::diag($e) }
}
1;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/os-autoinst-5.1742240999.4ad1bd8/xt/01-style.t
new/os-autoinst-5.1742623603.20c141b/xt/01-style.t
--- old/os-autoinst-5.1742240999.4ad1bd8/xt/01-style.t 2025-03-17
20:49:59.000000000 +0100
+++ new/os-autoinst-5.1742623603.20c141b/xt/01-style.t 2025-03-22
07:06:43.000000000 +0100
@@ -15,6 +15,7 @@
is qx{git grep -I -l '^use Test::\\(Exception\\|Fatal\\)' t/**.t}, '',
'Test::Most already includes Test::Exception, no need to use Test::Exception or
Test::Fatal';
is qx{git grep -I -l '^\\(throws\\|dies\\|lives\\)_ok.*\<sub\>' t/**.t}, '',
'Only use simplified prototyped Test::Exception functions';
is qx{git grep -I -l 'like.*\$\@' t/**.t}, '', 'Use throws_ok instead of
manual checks of exceptions';
+is qx{git grep -I -l ' if \$\@'}, '', 'Use try/catch instead of manual \$\@
checks';
is qx{git grep -I -l '^use \\(Try::Tiny\\|TryCatch\\)'}, '', 'No Try::Tiny or
TryCatch necessary, use Feature::Compat::Try and later native Perl';
is qx{git grep -I -l '^use testapi' backend/ consoles/}, '', 'No backend or
console files use external facing testapi';
is qx{git grep -l -e '^sub \\S\\+ [^(]\\+' --and --not -e 'sub [(\{]' --and
--not -e 'sub \\S\\+(' --and --not -e 'sub \\S\\+;' --and --not -e '#
no:style:signatures' ':!external/'}, '', 'All files use sub signatures
everywhere (nameless and in-place definitions still allowed)';
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/os-autoinst-5.1742240999.4ad1bd8/xt/06-pod-coverage.t
new/os-autoinst-5.1742623603.20c141b/xt/06-pod-coverage.t
--- old/os-autoinst-5.1742240999.4ad1bd8/xt/06-pod-coverage.t 2025-03-17
20:49:59.000000000 +0100
+++ new/os-autoinst-5.1742623603.20c141b/xt/06-pod-coverage.t 2025-03-22
07:06:43.000000000 +0100
@@ -1,6 +1,7 @@
#!/usr/bin/perl
use Test::Most;
+use Feature::Compat::Try;
use FindBin '$Bin';
use Test::Warnings ':report_warnings';
@@ -15,8 +16,8 @@
chdir $Bin . '/..';
# Pod::Coverage does not reveal the actual error message
-eval { require testapi };
-diag "Error requiring testapi: $@" if $@;
+try { require testapi }
+catch ($e) { diag "Error requiring testapi: $e" }
my $pc = Pod::Coverage->new(
package => 'testapi',
++++++ os-autoinst.obsinfo ++++++
--- /var/tmp/diff_new_pack.YDYA1g/_old 2025-03-25 22:18:56.778855566 +0100
+++ /var/tmp/diff_new_pack.YDYA1g/_new 2025-03-25 22:18:56.782855731 +0100
@@ -1,5 +1,5 @@
name: os-autoinst
-version: 5.1742240999.4ad1bd8
-mtime: 1742240999
-commit: 4ad1bd8ce5aabe01198d40f2a0dc0c97d046927d
+version: 5.1742623603.20c141b
+mtime: 1742623603
+commit: 20c141b152647720653a58846fbf5ed61563daa3
