Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package spiel for openSUSE:Factory checked in at 2025-03-26 21:18:11 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/spiel (Old) and /work/SRC/openSUSE:Factory/.spiel.new.2696 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "spiel" Wed Mar 26 21:18:11 2025 rev:3 rq:1255945 version:1.0.1 Changes: -------- --- /work/SRC/openSUSE:Factory/spiel/spiel.changes 2024-05-20 18:12:13.283641211 +0200 +++ /work/SRC/openSUSE:Factory/.spiel.new.2696/spiel.changes 2025-03-26 21:19:48.629517125 +0100 @@ -1,0 +2,6 @@ +Mon Mar 24 16:51:39 UTC 2025 - Michael Gorse <mgo...@suse.com> + +- Add 42ad1741.patch: prevent crash when the host has no voice + provider installed. + +------------------------------------------------------------------- New: ---- 42ad1741.patch BETA DEBUG BEGIN: New: - Add 42ad1741.patch: prevent crash when the host has no voice provider installed. BETA DEBUG END: ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ spiel.spec ++++++ --- /var/tmp/diff_new_pack.tWYWYU/_old 2025-03-26 21:19:49.593557141 +0100 +++ /var/tmp/diff_new_pack.tWYWYU/_new 2025-03-26 21:19:49.593557141 +0100 @@ -1,7 +1,7 @@ # # spec file for package spiel # -# Copyright (c) 2024 SUSE LLC +# Copyright (c) 2025 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -23,6 +23,8 @@ License: LGPL-2.1-or-later URL: https://eeejay.github.io/spiel/ Source: %{name}-%{version}.tar.zst +# PATCH-FIX-UPSTREAM https://github.com/project-spiel/libspiel/commit/42ad1741.patch boo#1239950 mgo...@suse.com -- prevent crash when the host has no voice provider installed. +Patch0: https://github.com/project-spiel/libspiel/commit/42ad1741.patch BuildRequires: meson >= 0.64.0 BuildRequires: pkgconfig BuildRequires: pkgconfig(gi-docgen) @@ -82,7 +84,7 @@ It consists of two parts, a speech provider interface specification and a client library. %prep -%autosetup +%autosetup -p1 %build %meson ++++++ 42ad1741.patch ++++++ >From 42ad1741875e5b0ab1a1cfbc34e4ffaabc029e2f Mon Sep 17 00:00:00 2001 From: Philippe Normand <ph...@igalia.com> Date: Wed, 18 Sep 2024 11:28:41 +0100 Subject: [PATCH] spiel-registry: Prevent crash when the host has no voice provider installed The error was not propagated from the providers collector to the registry which then was attempting to use a NULL providers hash table. The `object == G_OBJECT (sRegistry)` assert was removed from spiel_registry_finalize() because sRegistry is set only when the initialization succeeded, which is not the case when no provider was found. --- libspiel/spiel-collect-providers.c | 2 +- libspiel/spiel-registry.c | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/libspiel/spiel-collect-providers.c b/libspiel/spiel-collect-providers.c index 6817ca6..a03aba5 100644 --- a/libspiel/spiel-collect-providers.c +++ b/libspiel/spiel-collect-providers.c @@ -158,7 +158,7 @@ _on_list_names (GObject *source, GAsyncResult *result, gpointer user_data) if (!closure->providers_to_process) { - g_task_return_pointer (task, NULL, NULL); + g_task_return_new_error (task, G_IO_ERROR, G_IO_ERROR_FAILED, "No voice provider found"); g_object_unref (task); } else diff --git a/libspiel/spiel-registry.c b/libspiel/spiel-registry.c index ff33f91..cc46277 100644 --- a/libspiel/spiel-registry.c +++ b/libspiel/spiel-registry.c @@ -432,7 +432,6 @@ spiel_registry_finalize (GObject *object) } G_OBJECT_CLASS (spiel_registry_parent_class)->finalize (object); - g_assert (object == G_OBJECT (sRegistry)); sRegistry = NULL; }
