Script 'mail_helper' called by obssrc
Hello community,

here is the log from the commit of package celluloid for openSUSE:Factory 
checked in at 2025-03-27 22:33:20
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/celluloid (Old)
 and      /work/SRC/openSUSE:Factory/.celluloid.new.2696 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "celluloid"

Thu Mar 27 22:33:20 2025 rev:16 rq:1256418 version:0.27

Changes:
--------
--- /work/SRC/openSUSE:Factory/celluloid/celluloid.changes      2024-06-24 
20:57:56.062460753 +0200
+++ /work/SRC/openSUSE:Factory/.celluloid.new.2696/celluloid.changes    
2025-03-27 22:33:48.168335311 +0100
@@ -1,0 +2,6 @@
+Thu Mar 27 09:13:10 UTC 2025 - Luigi Baldoni <aloi...@gmx.com>
+
+- Add celluloid-fix_segfault_gnome48.patch to prevent segmentation
+  fault upon exit when using gnome 48 (fixes boo#1239802)
+
+-------------------------------------------------------------------

New:
----
  celluloid-fix_segfault_gnome48.patch

BETA DEBUG BEGIN:
  New:
- Add celluloid-fix_segfault_gnome48.patch to prevent segmentation
  fault upon exit when using gnome 48 (fixes boo#1239802)
BETA DEBUG END:

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ celluloid.spec ++++++
--- /var/tmp/diff_new_pack.OcvZmb/_old  2025-03-27 22:33:48.612353690 +0100
+++ /var/tmp/diff_new_pack.OcvZmb/_new  2025-03-27 22:33:48.612353690 +0100
@@ -1,7 +1,7 @@
 #
 # spec file for package celluloid
 #
-# Copyright (c) 2024 SUSE LLC
+# Copyright (c) 2025 SUSE LLC
 #
 # All modifications and additions to the file contributed by third parties
 # remain the property of their copyright owners, unless otherwise agreed
@@ -24,6 +24,8 @@
 License:        GPL-3.0-or-later
 URL:            https://celluloid-player.github.io/
 Source:         
https://github.com/celluloid-player/celluloid/archive/refs/tags/v%{version}.tar.gz#/%{name}-%{version}.tar.gz
+# PATCH-FIX-UPSTREAM celluloid-fix_segfault_gnome48.patch
+Patch0:         celluloid-fix_segfault_gnome48.patch
 BuildRequires:  hicolor-icon-theme
 BuildRequires:  intltool >= 0.40.6
 BuildRequires:  meson >= 0.49.0

++++++ celluloid-fix_segfault_gnome48.patch ++++++
>From 6e7f9531b01eb85db432b3206dca7f5c8c55d2c9 Mon Sep 17 00:00:00 2001
From: Colin Kinloch <colin.kinl...@collabora.com>
Date: Sun, 23 Feb 2025 23:40:08 +0000
Subject: [PATCH] controller: Check model is not NULL on notify::is-active

For some reason with GTK 4.17.4 this causes a NULL dereference on window
close.

Co-authored-by: gnome-mpv <gnome-mpv@nowhere>
---
 src/celluloid-controller.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/celluloid-controller.c b/src/celluloid-controller.c
index a124f57d..4a2fdd6d 100644
--- a/src/celluloid-controller.c
+++ b/src/celluloid-controller.c
@@ -571,6 +571,9 @@ is_active_handler(GObject *gobject, GParamSpec *pspec, 
gpointer data)
        CelluloidView *view = CELLULOID_VIEW(gobject);
        gboolean is_active = TRUE;
 
+       // As of GTK 4.17.4 controller->model may be NULL on window close.
+       g_return_if_fail(controller->model);
+
        g_object_get(view, "is-active", &is_active, NULL);
 
        if(!is_active)

Reply via email to