Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package virt-manager for openSUSE:Factory
checked in at 2025-04-11 16:45:38
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/virt-manager (Old)
and /work/SRC/openSUSE:Factory/.virt-manager.new.1907 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "virt-manager"
Fri Apr 11 16:45:38 2025 rev:273 rq:1268604 version:5.0.0
Changes:
--------
--- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes
2025-04-10 21:57:24.311982299 +0200
+++ /work/SRC/openSUSE:Factory/.virt-manager.new.1907/virt-manager.changes
2025-04-11 16:46:18.122021027 +0200
@@ -1,0 +2,18 @@
+Fri Apr 11 06:05:21 MDT 2025 - carn...@suse.com
+
+- Upstream features and bug fixes (bsc#1027942) (jsc#PED-8910)
+ 040-virtinst-add-pstore-backend-support.patch
+ 041-tests-add-pstore-test.patch
+ 042-man-virt-install-Document-pstore-device.patch
+ 043-tests-Increase-virtio-mem-block-size.patch
+ 044-tests-test_urls-fix-dead-URL.patch
+ 045-urlfetcher-add-riscv64-architecture-for-Debian.patch
+
046-virt-manager-list-virtual-networks-when-creating-new-QEMU-Session-VM.patch
+ 047-virt-install-add-support-for-vDPA-network-device.patch
+ 048-virt-manager-add-support-for-vDPA-network-device.patch
+ 049-virt-install-detect-wayland-in-order-to-start-virt-viewer.patch
+- bsc#1241082 - [Build 20250410] virt_install fails to launch:
+ missing dependencies.
+ Spec file modifications
+
+-------------------------------------------------------------------
New:
----
040-virtinst-add-pstore-backend-support.patch
041-tests-add-pstore-test.patch
042-man-virt-install-Document-pstore-device.patch
043-tests-Increase-virtio-mem-block-size.patch
044-tests-test_urls-fix-dead-URL.patch
045-urlfetcher-add-riscv64-architecture-for-Debian.patch
046-virt-manager-list-virtual-networks-when-creating-new-QEMU-Session-VM.patch
047-virt-install-add-support-for-vDPA-network-device.patch
048-virt-manager-add-support-for-vDPA-network-device.patch
049-virt-install-detect-wayland-in-order-to-start-virt-viewer.patch
BETA DEBUG BEGIN:
New:- Upstream features and bug fixes (bsc#1027942) (jsc#PED-8910)
040-virtinst-add-pstore-backend-support.patch
041-tests-add-pstore-test.patch
New: 040-virtinst-add-pstore-backend-support.patch
041-tests-add-pstore-test.patch
042-man-virt-install-Document-pstore-device.patch
New: 041-tests-add-pstore-test.patch
042-man-virt-install-Document-pstore-device.patch
043-tests-Increase-virtio-mem-block-size.patch
New: 042-man-virt-install-Document-pstore-device.patch
043-tests-Increase-virtio-mem-block-size.patch
044-tests-test_urls-fix-dead-URL.patch
New: 043-tests-Increase-virtio-mem-block-size.patch
044-tests-test_urls-fix-dead-URL.patch
045-urlfetcher-add-riscv64-architecture-for-Debian.patch
New: 044-tests-test_urls-fix-dead-URL.patch
045-urlfetcher-add-riscv64-architecture-for-Debian.patch
046-virt-manager-list-virtual-networks-when-creating-new-QEMU-Session-VM.patch
New: 045-urlfetcher-add-riscv64-architecture-for-Debian.patch
046-virt-manager-list-virtual-networks-when-creating-new-QEMU-Session-VM.patch
047-virt-install-add-support-for-vDPA-network-device.patch
New:
046-virt-manager-list-virtual-networks-when-creating-new-QEMU-Session-VM.patch
047-virt-install-add-support-for-vDPA-network-device.patch
048-virt-manager-add-support-for-vDPA-network-device.patch
New: 047-virt-install-add-support-for-vDPA-network-device.patch
048-virt-manager-add-support-for-vDPA-network-device.patch
049-virt-install-detect-wayland-in-order-to-start-virt-viewer.patch
New: 048-virt-manager-add-support-for-vDPA-network-device.patch
049-virt-install-detect-wayland-in-order-to-start-virt-viewer.patch
- bsc#1241082 - [Build 20250410] virt_install fails to launch:
BETA DEBUG END:
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ virt-manager.spec ++++++
--- /var/tmp/diff_new_pack.ZQcrS9/_old 2025-04-11 16:46:19.766090145 +0200
+++ /var/tmp/diff_new_pack.ZQcrS9/_new 2025-04-11 16:46:19.770090314 +0200
@@ -71,6 +71,16 @@
Patch32:
032-cli-Add-features-hyperv.tlbflush.extended.state-on-off.patch
Patch33: 033-createvm-prioritize-riscv64.patch
Patch34: 034-tests-uitests-handle-linux2020-going-EOL.patch
+Patch40: 040-virtinst-add-pstore-backend-support.patch
+Patch41: 041-tests-add-pstore-test.patch
+Patch42: 042-man-virt-install-Document-pstore-device.patch
+Patch43: 043-tests-Increase-virtio-mem-block-size.patch
+Patch44: 044-tests-test_urls-fix-dead-URL.patch
+Patch45: 045-urlfetcher-add-riscv64-architecture-for-Debian.patch
+Patch46:
046-virt-manager-list-virtual-networks-when-creating-new-QEMU-Session-VM.patch
+Patch47: 047-virt-install-add-support-for-vDPA-network-device.patch
+Patch48: 048-virt-manager-add-support-for-vDPA-network-device.patch
+Patch49:
049-virt-install-detect-wayland-in-order-to-start-virt-viewer.patch
Patch100:
revert-363fca41-virt-install-Require-osinfo-for-non-x86-HVM-case-too.patch
# SUSE Only
Patch150: virtman-desktop.patch
@@ -132,6 +142,10 @@
Requires: virt-manager-common = %{verrel}
Requires: vte
Requires: typelib(LibvirtGLib)
+%if 0%{?suse_version} >= 1699
+Requires: typelib(GtkVnc)
+Requires: typelib(Vte)
+%endif
Recommends: gtksourceview4
Recommends: libvirt-daemon-config-network
@@ -149,7 +163,6 @@
BuildRequires: virt-install = %{version}
BuildRequires: virt-manager = %{version}
BuildRequires: pkgconfig(vte-2.91)
-BuildRequires: typelib(Libosinfo)
%endif
%description
@@ -183,6 +196,7 @@
Requires: libvirt-client
Requires: virt-manager-common = %{verrel}
+Requires: typelib(Libosinfo)
Provides: python3-virtinst
Provides: virt-clone
++++++ 040-virtinst-add-pstore-backend-support.patch ++++++
Subject: virtinst: add --pstore backend=acpi-erst,path=XX,size=YY support
From: Lin Ma l...@suse.de Tue Feb 11 10:54:53 2025 +0800
Date: Mon Mar 3 12:01:09 2025 -0500:
Git: b5f6569bc0e24a4557ac43f7b9a7eeae0399c337
Libvirt since v10.6.0 introduces pstore pci device for storing oops/panic
logs in nvram storage.
Let's add it into virt-install, It has 3 suboptions:
* backend: The desired backend, by far only 'acpi-erst' is accepted.
* path: Represents a path in the host that backs the pstore device in
the guest. It is optional, If not specified the libvirt will
auto generates one.
* size: Configures the size of the persistent storage available to the
guest. It is mandatory, unit is kilobytes.
Eg:
virt-install --pstore backend=acpi-erst,path=/tmp/guest_acpi_esrt,size=8
Signed-off-by: Lin Ma <l...@suse.de>
--- a/virtinst/cli.py
+++ b/virtinst/cli.py
@@ -826,6 +826,16 @@ def add_device_options(devg, sound_back_
devg.add_argument("--iommu", action="append",
help=_("Configure an IOMMU device. Ex:\n"
"--iommu model=intel,driver.aw_bits=48"))
+ ParserPstore.register()
+ devg.add_argument(
+ "--pstore",
+ action="append",
+ help=_(
+ "Configure a nvram storage device.\n"
+ "It's for guest kernel to record oops/panic logs. Ex:\n"
+ "--pstore backend=acpi-erst,size=8"
+ ),
+ )
def add_guest_xml_options(geng):
@@ -4859,6 +4869,19 @@ class ParserAudio(VirtCLIParser):
cls.add_arg("id", "id")
+class ParserPstore(VirtCLIParser):
+ cli_arg_name = "pstore"
+ guest_propname = "devices.pstore"
+
+ @classmethod
+ def _virtcli_class_init(cls):
+ VirtCLIParser._virtcli_class_init_common(cls)
+
+ cls.add_arg("backend", "backend")
+ cls.add_arg("path", "path")
+ cls.add_arg("size", "size")
+
+
#####################
# --hostdev parsing #
#####################
--- a/virtinst/devices/__init__.py
+++ b/virtinst/devices/__init__.py
@@ -27,6 +27,7 @@ from .tpm import DeviceTpm
from .video import DeviceVideo
from .vsock import DeviceVsock
from .watchdog import DeviceWatchdog
+from .pstore import DevicePstore
__all__ = [l for l in locals() if l.startswith("Device")]
--- a/virtinst/devices/meson.build
+++ b/virtinst/devices/meson.build
@@ -23,6 +23,7 @@ virtinst_devices_sources = files(
'video.py',
'vsock.py',
'watchdog.py',
+ 'pstore.py',
)
install_data(
--- /dev/null
+++ b/virtinst/devices/pstore.py
@@ -0,0 +1,13 @@
+# This work is licensed under the GNU GPLv2 or later.
+# See the COPYING file in the top-level directory.
+
+from .device import Device
+from ..xmlbuilder import XMLProperty
+
+
+class DevicePstore(Device):
+ XML_NAME = "pstore"
+
+ backend = XMLProperty("./@backend")
+ path = XMLProperty("./path")
+ size = XMLProperty("./size", is_int=True)
--- a/virtinst/guest.py
+++ b/virtinst/guest.py
@@ -27,7 +27,7 @@ class _DomainDevices(XMLBuilder):
'smartcard', 'serial', 'parallel', 'console', 'channel',
'input', 'tpm', 'graphics', 'sound', 'audio', 'video', 'hostdev',
'redirdev', 'watchdog', 'memballoon', 'rng', 'panic',
- 'shmem', 'memory', 'vsock', 'iommu']
+ 'shmem', 'memory', 'vsock', 'iommu', 'pstore']
disk = XMLChildProperty(DeviceDisk)
@@ -55,6 +55,7 @@ class _DomainDevices(XMLBuilder):
memory = XMLChildProperty(DeviceMemory)
vsock = XMLChildProperty(DeviceVsock)
iommu = XMLChildProperty(DeviceIommu)
+ pstore = XMLChildProperty(DevicePstore)
def get_all(self):
retlist = []
++++++ 041-tests-add-pstore-test.patch ++++++
Subject: tests: add pstore test
From: Lin Ma l...@suse.de Tue Feb 11 10:56:12 2025 +0800
Date: Mon Mar 3 12:01:09 2025 -0500:
Git: 6c43ab38630a710e4de66cb59cbadd5e11569b68
Signed-off-by: Lin Ma <l...@suse.de>
--- a/tests/data/cli/compare/virt-install-many-devices.xml
+++ b/tests/data/cli/compare/virt-install-many-devices.xml
@@ -1025,6 +1025,10 @@
<iommu model="intel">
<driver aw_bits="48" intremap="off" caching_mode="on" eim="off"
iotlb="off"/>
</iommu>
+ <pstore backend="acpi-erst">
+ <path>/tmp/guest_acpi_esrt</path>
+ <size>8</size>
+ </pstore>
</devices>
<launchSecurity type="sev" kernelHashes="yes">
<cbitpos>47</cbitpos>
--- a/tests/test_cli.py
+++ b/tests/test_cli.py
@@ -803,6 +803,9 @@ source.reservations.managed=no,source.re
--vsock cid=17
+--pstore backend=acpi-erst,path=/tmp/guest_acpi_esrt,size=8
+
+
--tpm
passthrough,model=tpm-crb,path=/dev/tpm0,backend.encryption.secret=11111111-2222-3333-4444-5555555555,backend.persistent_state=yes,backend.active_pcr_banks.sha1=on,backend.active_pcr_banks.sha256=yes,backend.active_pcr_banks.sha384=yes,backend.active_pcr_banks.sha512=yes,version=2.0
--tpm
model=tpm-tis,backend.type=emulator,backend.version=2.0,backend.debug=3,backend.source.type=dir,backend.source.path=/some/dir,backend.profile.source=local:mytest,backend.profile.removeDisabled=check
++++++ 042-man-virt-install-Document-pstore-device.patch ++++++
Subject: man/virt-install: Document pstore device
From: Lin Ma l...@suse.de Tue Feb 11 10:56:43 2025 +0800
Date: Mon Mar 3 12:01:09 2025 -0500:
Git: a0e390b1b63ea3c6b53cf49e8f70a7d214452610
Signed-off-by: Lin Ma <l...@suse.de>
diff --git a/man/virt-install.rst b/man/virt-install.rst
index dc0b6d9cc..b6c48c3fe 100644
--- a/man/virt-install.rst
+++ b/man/virt-install.rst
@@ -2052,6 +2052,18 @@ Complete details at
https://libvirt.org/formatdomain.html#iommu-devices
+``--pstore``
+^^^^^^^^^^^^
+
+**Syntax:** ``--pstore`` OPT=VAL,[...]
+
+Add a pstore device to a guest for storing oops/panic logs before it crashes.
+
+Use --pstore=? to see a list of all available options.
+Complete details at https://libvirt.org/formatdomain.html#pstore
+
+
+
MISCELLANEOUS OPTIONS
=====================
++++++ 043-tests-Increase-virtio-mem-block-size.patch ++++++
Subject: tests: Increase virtio-mem block size
From: Akihiko Odaki akihiko.od...@daynix.com Sun Mar 2 15:47:29 2025 +0900
Date: Mon Mar 3 12:19:33 2025 -0500:
Git: fb54f37b6067f88b46acc0d1d7a11884a659279a
virtio-mem block size must be equal to or greater than the transparent
huge page size; otherwise, libvirt raises an error and a test will
fail. For example, on Asahi Linux, the transparent huge page size is 32
MiB, which is greater than 2 MiB, the specified virtio-mem block size.
On Linux 6.13, the configuration with the maximum transparent huge page
size is Arm64 with 64 KiB, and it has 512 MiB transparent huge pages.
Increase the block size to 512 MiB so that the test passes on every
Linux configuration.
Signed-off-by: Akihiko Odaki <akihiko.od...@daynix.com>
--- a/tests/data/cli/compare/virt-install-memory-hotplug.xml
+++ b/tests/data/cli/compare/virt-install-memory-hotplug.xml
@@ -126,7 +126,7 @@
<target dynamicMemslots="yes">
<size>524288</size>
<node>0</node>
- <block>2048</block>
+ <block>524288</block>
<requested>524288</requested>
<address base="0x180000000"/>
</target>
@@ -270,7 +270,7 @@
<target dynamicMemslots="yes">
<size>524288</size>
<node>0</node>
- <block>2048</block>
+ <block>524288</block>
<requested>524288</requested>
<address base="0x180000000"/>
</target>
--- a/tests/test_cli.py
+++ b/tests/test_cli.py
@@ -936,7 +936,7 @@ c.add_compare("--pxe "
"address.type=dimm,address.base=0x100000000,address.slot=1,"
"source.pmem=on,source.alignsize=2048,target.readonly=on "
-"--memdev
virtio-mem,target_node=0,target.block=2048,target.dynamicMemslots=yes,"
+"--memdev
virtio-mem,target_node=0,target.block=524288,target.dynamicMemslots=yes,"
"target_size=512,target.requested=524288,target.address_base=0x180000000 "
"--memdev virtio-pmem,source.path=/tmp/virtio_pmem,"
++++++ 044-tests-test_urls-fix-dead-URL.patch ++++++
Subject: tests: test_urls: fix dead URL
From: Cole Robinson crobi...@redhat.com Mon Mar 3 12:40:21 2025 -0500
Date: Mon Mar 3 12:40:36 2025 -0500:
Git: ef41638f5eb0b390cbf74281c508fbfef42f73e5
Signed-off-by: Cole Robinson <crobi...@redhat.com>
diff --git a/tests/data/test_urls.ini b/tests/data/test_urls.ini
index df0d52fa5..29a794feb 100644
--- a/tests/data/test_urls.ini
+++ b/tests/data/test_urls.ini
@@ -197,5 +197,5 @@ distro = ubuntu20.04
# Devel tree
[mageiacauldron]
-url = http://distro.ibiblio.org/mageia/distrib/cauldron/x86_64/
+url = https://mageia.ip-connect.info/distrib/cauldron/x86_64/
distro = none
++++++ 045-urlfetcher-add-riscv64-architecture-for-Debian.patch ++++++
Subject: urlfetcher: add riscv64 architecture for Debian
From: Heinrich Schuchardt heinrich.schucha...@canonical.com Mon Mar 3 11:52:58
2025 +0100
Date: Sat Mar 8 12:59:18 2025 +0100:
Git: ccfe4a0abc0dc37f6ecd367d2c3b3bb1f55649f7
Add riscv64 to the list of Debian architectures.
Signed-off-by: Heinrich Schuchardt <heinrich.schucha...@canonical.com>
--- a/virtinst/install/urldetect.py
+++ b/virtinst/install/urldetect.py
@@ -692,7 +692,7 @@ class _DebianDistro(_DistroTree):
# Check for standard arch strings which will be
# in the URI name for --location $ISO mounts
- for arch in ["i386", "amd64", "x86_64", "arm64"]:
+ for arch in ["i386", "amd64", "x86_64", "arm64", "riscv64"]:
if arch in self.uri:
log.debug("Found treearch=%s in uri", arch)
if arch == "x86_64":
++++++
046-virt-manager-list-virtual-networks-when-creating-new-QEMU-Session-VM.patch
++++++
Subject: virt-manager: list virtual networks when creating new QEMU Session VM
From: Pavel Hrdina phrd...@redhat.com Mon Mar 10 19:26:44 2025 +0100
Date: Tue Mar 18 20:33:33 2025 +0100:
Git: 714d5f1afdd58d5e908d420c4fbd8183edf47aa7
Using qemu-bridge-helper QEMU Session VMs are now able to use host
bridge interfaces. Currently only interface named virbr0 is allowed by
default but it is possible to change it in `/etc/qemu/bridge.conf`.
We will still keep the usermode network as default.
Resolves: https://github.com/virt-manager/virt-manager/issues/863
Signed-off-by: Pavel Hrdina <phrd...@redhat.com>
--- a/virtManager/device/netlist.py
+++ b/virtManager/device/netlist.py
@@ -149,7 +149,6 @@ class vmmNetworkList(vmmGObjectUI):
add_usermode = False
if self.conn.is_qemu_unprivileged():
log.debug("Using unprivileged qemu, adding usermode net")
- vnets = []
default_bridge = None
add_usermode = True
++++++ 047-virt-install-add-support-for-vDPA-network-device.patch ++++++
Subject: virt-install: add support for vDPA network device
From: Joren joren.re...@curtin.edu.au Tue Mar 18 17:09:29 2025 +0800
Date: Tue Mar 18 20:34:22 2025 +0100:
Git: e5142f28fe30f434bde2eb96afdc1de93a38f478
--- a/tests/data/cli/compare/virt-install-many-devices.xml
+++ b/tests/data/cli/compare/virt-install-many-devices.xml
@@ -618,6 +618,12 @@
<model type="virtio"/>
<address type="pci" domain="0" bus="0" slot="16" function="0"/>
</interface>
+ <interface type="vdpa">
+ <source dev="/dev/vhost-vdpa-0"/>
+ <mac address="12:34:56:78:9a:bc"/>
+ <model type="virtio"/>
+ <driver page_per_vq="on" queues="16"/>
+ </interface>
<interface type="user">
<mac address="00:11:22:33:44:55"/>
<model type="virtio"/>
--- a/tests/test_cli.py
+++ b/tests/test_cli.py
@@ -655,6 +655,7 @@ source.reservations.managed=no,source.re
--network
type=direct,source=eth5,source_mode=vepa,source.mode=vepa,target=mytap12,virtualport_type=802.1Qbg,virtualport_managerid=12,virtualport_typeid=1193046,virtualport_typeidversion=1,virtualport_instanceid=09b11c53-8b5c-4eeb-8f00-d84eaa0aaa3b,boot_order=1,trustGuestRxFilters=yes,mtu.size=1500,virtualport.parameters.managerid=12,virtualport.parameters.typeid=1193046,virtualport.parameters.typeidversion=1,virtualport.parameters.instanceid=09b11c53-8b5c-4eeb-8f00-d84eaa0aaa3b,boot_order=1,trustGuestRxFilters=yes,mtu.size=1500
--network
user,model=virtio,address.type=spapr-vio,address.reg=0x500,link.state=no
--network
vhostuser,source_type=unix,source_path=/tmp/vhost1.sock,source_mode=server,model=virtio,source.type=unix,source.path=/tmp/vhost1.sock,address.type=pci,address.bus=0x00,address.slot=0x10,address.function=0x0,address.domain=0x0000
+--network
type=vdpa,source=/dev/vhost-vdpa-0,mac=12:34:56:78:9a:bc,driver.queues=16,driver.page_per_vq=on
--network
user,address.type=ccw,address.cssid=0xfe,address.ssid=0,address.devno=01,boot.order=15,boot.loadparm=SYSTEM1
--network model=vmxnet3
--network
backend.type=passt,backend.logFile=/tmp/foo.log,portForward0.proto=tcp,portForward0.address=192.168.10.10,portForward0.dev=eth0,portForward0.range0.start=4000,portForward0.range0.end=5000,portForward0.range0.to=10000,portForward0.range0.exclude=no,portForward0.range1.start=6000,portForward1.proto=tcp,portForward1.range0.start=2022,portForward1.range0.to=22
--- a/virtinst/devices/interface.py
+++ b/virtinst/devices/interface.py
@@ -181,6 +181,7 @@ class DeviceInterface(Device):
TYPE_VHOSTUSER = "vhostuser"
TYPE_ETHERNET = "ethernet"
TYPE_DIRECT = "direct"
+ TYPE_VDPA = "vdpa"
@staticmethod
def generate_mac(conn):
@@ -242,7 +243,7 @@ class DeviceInterface(Device):
return self.network
if self.type == self.TYPE_BRIDGE:
return self.bridge
- if self.type == self.TYPE_DIRECT:
+ if self.type == self.TYPE_DIRECT or self.type == self.TYPE_VDPA:
return self.source_dev
return None
def _set_source(self, newsource):
@@ -258,7 +259,7 @@ class DeviceInterface(Device):
self.network = newsource
elif self.type == self.TYPE_BRIDGE:
self.bridge = newsource
- elif self.type == self.TYPE_DIRECT:
+ elif self.type == self.TYPE_DIRECT or self.type == self.TYPE_VDPA:
self.source_dev = newsource
source = property(_get_source, _set_source)
++++++ 048-virt-manager-add-support-for-vDPA-network-device.patch ++++++
Subject: virt-manager: add support for vDPA network device
From: Pavel Hrdina phrd...@redhat.com Tue Mar 18 20:01:22 2025 +0100
Date: Tue Mar 18 20:34:22 2025 +0100:
Git: e39e0ad5f06fb080f0042090d97e47e11f11dcab
Signed-off-by: Pavel Hrdina <phrd...@redhat.com>
--- a/virtManager/device/netlist.py
+++ b/virtManager/device/netlist.py
@@ -142,6 +142,11 @@ class vmmNetworkList(vmmGObjectUI):
_nettype = virtinst.DeviceInterface.TYPE_DIRECT
model.append(_build_manual_row(_nettype, _label))
+ def _add_manual_vdpa_row():
+ _label = _("vDPA device...")
+ _nettype = virtinst.DeviceInterface.TYPE_VDPA
+ model.append(_build_manual_row(_nettype, _label))
+
vnets = self._find_virtual_networks()
default_bridge = virtinst.DeviceInterface.default_bridge(
self.conn.get_backend())
@@ -165,6 +170,7 @@ class vmmNetworkList(vmmGObjectUI):
bridgeidx = _add_manual_bridge_row()
_add_manual_macvtap_row()
+ _add_manual_vdpa_row()
# If there is a bridge device, default to that
if default_bridge:
@@ -248,8 +254,11 @@ class vmmNetworkList(vmmGObjectUI):
# If this is a bridge or macvtap device, show the
# manual source mode
- if nettype in [virtinst.DeviceInterface.TYPE_BRIDGE,
- virtinst.DeviceInterface.TYPE_DIRECT]:
+ if nettype in [
+ virtinst.DeviceInterface.TYPE_BRIDGE,
+ virtinst.DeviceInterface.TYPE_DIRECT,
+ virtinst.DeviceInterface.TYPE_VDPA,
+ ]:
rowiter = _find_row(nettype, None, True)
self.widget("net-manual-source").set_text(source or "")
if rowiter:
++++++ 049-virt-install-detect-wayland-in-order-to-start-virt-viewer.patch
++++++
Subject: virt-install: detect wayland in order to start virt-viewer
From: Pavel Hrdina phrd...@redhat.com Mon Mar 24 12:11:23 2025 +0100
Date: Mon Mar 24 15:32:28 2025 +0100:
Git: 4f9618289f279f86994a5d2f1aada8a6524f5a6f
When running virt-install using waypipe the DISPLAY variable is not
defined and virt-install will complain that it cannot start virt-viewer.
Check for WAYLAND_DISPLAY as well, DISPLAY is defined only when xwayland
is used. In case of waypipe it configures only WAYLAND_DISPLAY.
Move the check before we check for virt-viewer as without display there
is no point to check if virt-viewer is installed or not.
Fixes: https://github.com/virt-manager/virt-manager/issues/884
Signed-off-by: Pavel Hrdina <phrd...@redhat.com>
--- a/virtinst/cli.py
+++ b/virtinst/cli.py
@@ -1999,18 +1999,20 @@ def _determine_default_autoconsole_type(
log.debug("No viewer to launch for graphics type '%s'", gtype)
return None
+ if (
+ not os.environ.get("DISPLAY", "")
+ and not os.environ.get("DISPLAY_WAYLAND")
+ and not xmlutil.in_testsuite()
+ ): # pragma: no cover
+ log.warning(_("No display detected. Not running virt-viewer."))
+ return None
+
if not HAS_VIRTVIEWER and not xmlutil.in_testsuite(): # pragma: no cover
log.warning(_("Unable to connect to graphical console: "
"virt-viewer not installed. Please install "
"the 'virt-viewer' package."))
return None
- if (not os.environ.get("DISPLAY", "") and
- not xmlutil.in_testsuite()): # pragma: no cover
- log.warning(_("Graphics requested but DISPLAY is not set. "
- "Not running virt-viewer."))
- return None
-
return "graphical"
++++++
revert-363fca41-virt-install-Require-osinfo-for-non-x86-HVM-case-too.patch
++++++
--- /var/tmp/diff_new_pack.ZQcrS9/_old 2025-04-11 16:46:20.082103431 +0200
+++ /var/tmp/diff_new_pack.ZQcrS9/_new 2025-04-11 16:46:20.082103431 +0200
@@ -33,7 +33,7 @@
===================================================================
--- virt-manager-5.0.0.orig/tests/test_cli.py
+++ virt-manager-5.0.0/tests/test_cli.py
-@@ -1251,7 +1251,6 @@ c.add_compare("--connect %(URI-KVM-ARMV7
+@@ -1255,7 +1255,6 @@ c.add_compare("--connect %(URI-KVM-ARMV7
#################
c.add_valid("--arch aarch64 --osinfo fedora19 --nodisks --pxe --connect " +
utils.URIs.kvm_x86_nodomcaps, grep="Libvirt version does not support UEFI") #
attempt to default to aarch64 UEFI, but it fails, but should only print warnings
++++++ virtinst-s390x-disable-graphics.patch ++++++
--- /var/tmp/diff_new_pack.ZQcrS9/_old 2025-04-11 16:46:20.186107804 +0200
+++ /var/tmp/diff_new_pack.ZQcrS9/_new 2025-04-11 16:46:20.190107971 +0200
@@ -4,7 +4,7 @@
===================================================================
--- virt-manager-5.0.0.orig/virtinst/guest.py
+++ virt-manager-5.0.0/virtinst/guest.py
-@@ -211,7 +211,10 @@ class Guest(XMLBuilder):
+@@ -212,7 +212,10 @@ class Guest(XMLBuilder):
self.skip_default_channel = False
self.skip_default_sound = False
self.skip_default_usbredir = False
@@ -16,7 +16,7 @@
self.skip_default_rng = False
self.skip_default_tpm = False
self.skip_default_input = False
-@@ -364,7 +367,7 @@ class Guest(XMLBuilder):
+@@ -365,7 +368,7 @@ class Guest(XMLBuilder):
if not os_support:
return False
@@ -25,7 +25,7 @@
return True
return False # pragma: no cover
-@@ -1152,7 +1155,7 @@ class Guest(XMLBuilder):
+@@ -1153,7 +1156,7 @@ class Guest(XMLBuilder):
self.add_device(dev)
def _add_default_video_device(self):
++++++ virtinst-set-default-nic.patch ++++++
--- /var/tmp/diff_new_pack.ZQcrS9/_old 2025-04-11 16:46:20.206108644 +0200
+++ /var/tmp/diff_new_pack.ZQcrS9/_new 2025-04-11 16:46:20.218109149 +0200
@@ -1,11 +1,11 @@
References: bsc#1172356, bsc#1177620
Libvirt doesn't accept "Hypervisor default" as a model name
-Index: virt-manager-4.2.0/virtinst/devices/interface.py
+Index: virt-manager-5.0.0/virtinst/devices/interface.py
===================================================================
---- virt-manager-4.2.0.orig/virtinst/devices/interface.py
-+++ virt-manager-4.2.0/virtinst/devices/interface.py
-@@ -365,6 +365,9 @@ class DeviceInterface(Device):
+--- virt-manager-5.0.0.orig/virtinst/devices/interface.py
++++ virt-manager-5.0.0/virtinst/devices/interface.py
+@@ -366,6 +366,9 @@ class DeviceInterface(Device):
return "e1000e"
if not guest.os.is_x86():
return None
++++++ virtinst-set-qemu-emulator.patch ++++++
--- /var/tmp/diff_new_pack.ZQcrS9/_old 2025-04-11 16:46:20.234109821 +0200
+++ /var/tmp/diff_new_pack.ZQcrS9/_new 2025-04-11 16:46:20.238109990 +0200
@@ -5,7 +5,7 @@
===================================================================
--- virt-manager-5.0.0.orig/virtinst/guest.py
+++ virt-manager-5.0.0/virtinst/guest.py
-@@ -994,6 +994,10 @@ class Guest(XMLBuilder):
+@@ -995,6 +995,10 @@ class Guest(XMLBuilder):
self._add_default_tpm()
self.clock.set_defaults(self)
++++++ virtinst-smbios-unsupported-for-xenpv.patch ++++++
--- /var/tmp/diff_new_pack.ZQcrS9/_old 2025-04-11 16:46:20.250110495 +0200
+++ /var/tmp/diff_new_pack.ZQcrS9/_new 2025-04-11 16:46:20.250110495 +0200
@@ -4,7 +4,7 @@
===================================================================
--- virt-manager-5.0.0.orig/virtinst/guest.py
+++ virt-manager-5.0.0/virtinst/guest.py
-@@ -740,6 +740,8 @@ class Guest(XMLBuilder):
+@@ -741,6 +741,8 @@ class Guest(XMLBuilder):
self.type != "kvm"):
log.warning( # pragma: no cover
"KVM acceleration not available, using '%s'", self.type)
++++++ virtman-add-sev-memory-support.patch ++++++
--- /var/tmp/diff_new_pack.ZQcrS9/_old 2025-04-11 16:46:20.286112008 +0200
+++ /var/tmp/diff_new_pack.ZQcrS9/_new 2025-04-11 16:46:20.290112176 +0200
@@ -190,7 +190,7 @@
===================================================================
--- virt-manager-5.0.0.orig/virtinst/devices/interface.py
+++ virt-manager-5.0.0/virtinst/devices/interface.py
-@@ -310,6 +310,9 @@ class DeviceInterface(Device):
+@@ -311,6 +311,9 @@ class DeviceInterface(Device):
portForward = XMLChildProperty(_PortForward)
