Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package aws-c-io for openSUSE:Factory checked in at 2025-04-16 20:39:27 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/aws-c-io (Old) and /work/SRC/openSUSE:Factory/.aws-c-io.new.30101 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "aws-c-io" Wed Apr 16 20:39:27 2025 rev:21 rq:1269945 version:0.18.1 Changes: -------- --- /work/SRC/openSUSE:Factory/aws-c-io/aws-c-io.changes 2025-04-04 17:34:23.485212528 +0200 +++ /work/SRC/openSUSE:Factory/.aws-c-io.new.30101/aws-c-io.changes 2025-04-20 19:49:58.271886453 +0200 @@ -1,0 +2,7 @@ +Tue Apr 15 10:31:28 UTC 2025 - John Paul Adrian Glaubitz <adrian.glaub...@suse.com> + +- Update to verson 0.18.1 + * Correct public key naming in pem utils by @DmitriyMusatkin in (#721) + * Revert error code ordering by @sbSteveK in (#723) + +------------------------------------------------------------------- Old: ---- v0.18.0.tar.gz New: ---- v0.18.1.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ aws-c-io.spec ++++++ --- /var/tmp/diff_new_pack.jFH1Xf/_old 2025-04-20 19:49:58.767907096 +0200 +++ /var/tmp/diff_new_pack.jFH1Xf/_new 2025-04-20 19:49:58.771907263 +0200 @@ -21,7 +21,7 @@ %define library_version 1.0.0 %define library_soversion 0unstable Name: aws-c-io -Version: 0.18.0 +Version: 0.18.1 Release: 0 Summary: I/O and TLS package AWS SDK for C License: Apache-2.0 ++++++ v0.18.0.tar.gz -> v0.18.1.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-c-io-0.18.0/include/aws/io/io.h new/aws-c-io-0.18.1/include/aws/io/io.h --- old/aws-c-io-0.18.0/include/aws/io/io.h 2025-03-28 18:43:29.000000000 +0100 +++ new/aws-c-io-0.18.1/include/aws/io/io.h 2025-04-09 16:33:10.000000000 +0200 @@ -99,6 +99,13 @@ AWS_IO_CHANNEL_READ_WOULD_EXCEED_WINDOW, AWS_IO_EVENT_LOOP_ALREADY_ASSIGNED, AWS_IO_EVENT_LOOP_SHUTDOWN, + AWS_IO_TLS_ERROR_NEGOTIATION_FAILURE, + AWS_IO_TLS_ERROR_NOT_NEGOTIATED, + AWS_IO_TLS_ERROR_WRITE_FAILURE, + AWS_IO_TLS_ERROR_ALERT_RECEIVED, + AWS_IO_TLS_CTX_ERROR, + AWS_IO_TLS_VERSION_UNSUPPORTED, + AWS_IO_TLS_CIPHER_PREF_UNSUPPORTED, AWS_IO_MISSING_ALPN_MESSAGE, AWS_IO_UNHANDLED_ALPN_PROTOCOL_MESSAGE, AWS_IO_FILE_VALIDATION_FAILURE, @@ -121,7 +128,6 @@ AWS_IO_SOCKET_INVALID_ADDRESS, AWS_IO_SOCKET_ILLEGAL_OPERATION_FOR_STATE, AWS_IO_SOCKET_CONNECT_ABORTED, - AWS_IO_SOCKET_MISSING_EVENT_LOOP, AWS_IO_DNS_QUERY_FAILED, AWS_IO_DNS_INVALID_NAME, AWS_IO_DNS_NO_ADDRESS_FOR_HOST, @@ -131,35 +137,12 @@ DEPRECATED_AWS_IO_INVALID_FILE_HANDLE, AWS_IO_SHARED_LIBRARY_LOAD_FAILURE, AWS_IO_SHARED_LIBRARY_FIND_SYMBOL_FAILURE, - AWS_IO_MAX_RETRIES_EXCEEDED, - AWS_IO_RETRY_PERMISSION_DENIED, - - AWS_IO_TLS_ERROR_NEGOTIATION_FAILURE, - AWS_IO_TLS_ERROR_NOT_NEGOTIATED, - AWS_IO_TLS_ERROR_WRITE_FAILURE, - AWS_IO_TLS_ERROR_ALERT_RECEIVED, - AWS_IO_TLS_CTX_ERROR, - AWS_IO_TLS_VERSION_UNSUPPORTED, - AWS_IO_TLS_CIPHER_PREF_UNSUPPORTED, AWS_IO_TLS_NEGOTIATION_TIMEOUT, AWS_IO_TLS_ALERT_NOT_GRACEFUL, + AWS_IO_MAX_RETRIES_EXCEEDED, + AWS_IO_RETRY_PERMISSION_DENIED, AWS_IO_TLS_DIGEST_ALGORITHM_UNSUPPORTED, AWS_IO_TLS_SIGNATURE_ALGORITHM_UNSUPPORTED, - AWS_IO_TLS_ERROR_READ_FAILURE, - AWS_IO_TLS_UNKNOWN_ROOT_CERTIFICATE, - AWS_IO_TLS_NO_ROOT_CERTIFICATE_FOUND, - AWS_IO_TLS_CERTIFICATE_EXPIRED, - AWS_IO_TLS_CERTIFICATE_NOT_YET_VALID, - AWS_IO_TLS_BAD_CERTIFICATE, - AWS_IO_TLS_PEER_CERTIFICATE_EXPIRED, - AWS_IO_TLS_BAD_PEER_CERTIFICATE, - AWS_IO_TLS_PEER_CERTIFICATE_REVOKED, - AWS_IO_TLS_PEER_CERTIFICATE_UNKNOWN, - AWS_IO_TLS_INTERNAL_ERROR, - AWS_IO_TLS_CLOSED_GRACEFUL, - AWS_IO_TLS_CLOSED_ABORT, - AWS_IO_TLS_INVALID_CERTIFICATE_CHAIN, - AWS_IO_TLS_HOST_NAME_MISSMATCH, AWS_ERROR_PKCS11_VERSION_UNSUPPORTED, AWS_ERROR_PKCS11_TOKEN_NOT_FOUND, @@ -271,9 +254,26 @@ AWS_IO_STREAM_GET_LENGTH_FAILED, AWS_IO_STREAM_SEEK_UNSUPPORTED, AWS_IO_STREAM_GET_LENGTH_UNSUPPORTED, + AWS_IO_TLS_ERROR_READ_FAILURE, AWS_ERROR_PEM_MALFORMED, + AWS_IO_SOCKET_MISSING_EVENT_LOOP, + AWS_IO_TLS_UNKNOWN_ROOT_CERTIFICATE, + AWS_IO_TLS_NO_ROOT_CERTIFICATE_FOUND, + AWS_IO_TLS_CERTIFICATE_EXPIRED, + AWS_IO_TLS_CERTIFICATE_NOT_YET_VALID, + AWS_IO_TLS_BAD_CERTIFICATE, + AWS_IO_TLS_PEER_CERTIFICATE_EXPIRED, + AWS_IO_TLS_BAD_PEER_CERTIFICATE, + AWS_IO_TLS_PEER_CERTIFICATE_REVOKED, + AWS_IO_TLS_PEER_CERTIFICATE_UNKNOWN, + AWS_IO_TLS_INTERNAL_ERROR, + AWS_IO_TLS_CLOSED_GRACEFUL, + AWS_IO_TLS_CLOSED_ABORT, + AWS_IO_TLS_INVALID_CERTIFICATE_CHAIN, + AWS_IO_TLS_HOST_NAME_MISMATCH, + AWS_IO_ERROR_END_RANGE = AWS_ERROR_ENUM_END_RANGE(AWS_C_IO_PACKAGE_ID), AWS_IO_INVALID_FILE_HANDLE = AWS_ERROR_INVALID_FILE_HANDLE, }; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-c-io-0.18.0/include/aws/io/pem.h new/aws-c-io-0.18.1/include/aws/io/pem.h --- old/aws-c-io-0.18.0/include/aws/io/pem.h 2025-03-28 18:43:29.000000000 +0100 +++ new/aws-c-io-0.18.1/include/aws/io/pem.h 2025-04-09 16:33:10.000000000 +0200 @@ -22,7 +22,7 @@ AWS_PEM_TYPE_X509_REQ, /* CERTIFICATE REQUEST */ AWS_PEM_TYPE_X509_CRL, /* X509 CRL */ AWS_PEM_TYPE_EVP_PKEY, /* ANY PRIVATE KEY */ - AWS_PEM_TYPE_PUBLIC_PKCS8, /* PUBLIC KEY */ + AWS_PEM_TYPE_PUBLIC_KEY, /* PUBLIC KEY */ AWS_PEM_TYPE_PRIVATE_RSA_PKCS1, /* RSA PRIVATE KEY */ AWS_PEM_TYPE_PUBLIC_RSA_PKCS1, /* RSA PUBLIC KEY */ AWS_PEM_TYPE_PRIVATE_DSA_PKCS1, /* RSA PRIVATE KEY */ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-c-io-0.18.0/source/darwin/nw_socket.c new/aws-c-io-0.18.1/source/darwin/nw_socket.c --- old/aws-c-io-0.18.0/source/darwin/nw_socket.c 2025-03-28 18:43:29.000000000 +0100 +++ new/aws-c-io-0.18.1/source/darwin/nw_socket.c 2025-04-09 16:33:10.000000000 +0200 @@ -73,7 +73,7 @@ case errSSLXCertChainInvalid: return AWS_IO_TLS_INVALID_CERTIFICATE_CHAIN; case errSSLHostNameMismatch: - return AWS_IO_TLS_HOST_NAME_MISSMATCH; + return AWS_IO_TLS_HOST_NAME_MISMATCH; case errSecNotTrusted: case errSSLPeerProtocolVersion: return AWS_IO_TLS_ERROR_NEGOTIATION_FAILURE; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-c-io-0.18.0/source/io.c new/aws-c-io-0.18.1/source/io.c --- old/aws-c-io-0.18.0/source/io.c 2025-03-28 18:43:29.000000000 +0100 +++ new/aws-c-io-0.18.1/source/io.c 2025-04-09 16:33:10.000000000 +0200 @@ -33,6 +33,30 @@ AWS_IO_EVENT_LOOP_SHUTDOWN, "Event loop has shutdown and a resource was still using it, the resource has been removed from the loop."), AWS_DEFINE_ERROR_INFO_IO( + AWS_IO_TLS_ERROR_NEGOTIATION_FAILURE, + "TLS (SSL) negotiation failed"), + AWS_DEFINE_ERROR_INFO_IO( + AWS_IO_TLS_ERROR_NOT_NEGOTIATED, + "Attempt to read/write, but TLS (SSL) hasn't been negotiated"), + AWS_DEFINE_ERROR_INFO_IO( + AWS_IO_TLS_ERROR_WRITE_FAILURE, + "Failed to write to TLS handler"), + AWS_DEFINE_ERROR_INFO_IO( + AWS_IO_TLS_ERROR_ALERT_RECEIVED, + "Fatal TLS Alert was received"), + AWS_DEFINE_ERROR_INFO_IO( + AWS_IO_TLS_CTX_ERROR, + "Failed to create tls context"), + AWS_DEFINE_ERROR_INFO_IO( + AWS_IO_TLS_VERSION_UNSUPPORTED, + "A TLS version was specified that is currently not supported. Consider using AWS_IO_TLS_VER_SYS_DEFAULTS, " + " and when this lib or the operating system is updated, it will automatically be used."), + AWS_DEFINE_ERROR_INFO_IO( + AWS_IO_TLS_CIPHER_PREF_UNSUPPORTED, + "A TLS Cipher Preference was specified that is currently not supported by the current platform. Consider " + " using AWS_IO_TLS_CIPHER_SYSTEM_DEFAULT, and when this lib or the operating system is updated, it will " + "automatically be used."), + AWS_DEFINE_ERROR_INFO_IO( AWS_IO_MISSING_ALPN_MESSAGE, "An ALPN message was expected but not received"), AWS_DEFINE_ERROR_INFO_IO( @@ -98,9 +122,6 @@ AWS_DEFINE_ERROR_INFO_IO( AWS_IO_SOCKET_CONNECT_ABORTED, "Incoming connection was aborted."), - AWS_DEFINE_ERROR_INFO_IO( - AWS_IO_SOCKET_MISSING_EVENT_LOOP, - "Socket is missing its event loop."), AWS_DEFINE_ERROR_INFO_IO ( AWS_IO_DNS_QUERY_FAILED, "A query to dns failed to resolve."), @@ -129,92 +150,23 @@ AWS_IO_SHARED_LIBRARY_FIND_SYMBOL_FAILURE, "System call error during attempt to find shared library symbol"), AWS_DEFINE_ERROR_INFO_IO( - AWS_IO_MAX_RETRIES_EXCEEDED, - "Retry cannot be attempted because the maximum number of retries has been exceeded."), - AWS_DEFINE_ERROR_INFO_IO( - AWS_IO_RETRY_PERMISSION_DENIED, - "Retry cannot be attempted because the retry strategy has prevented the operation."), - AWS_DEFINE_ERROR_INFO_IO( - AWS_IO_TLS_ERROR_NEGOTIATION_FAILURE, - "TLS (SSL) negotiation failed"), - AWS_DEFINE_ERROR_INFO_IO( - AWS_IO_TLS_ERROR_NOT_NEGOTIATED, - "Attempt to read/write, but TLS (SSL) hasn't been negotiated"), - AWS_DEFINE_ERROR_INFO_IO( - AWS_IO_TLS_ERROR_WRITE_FAILURE, - "Failed to write to TLS handler"), - AWS_DEFINE_ERROR_INFO_IO( - AWS_IO_TLS_ERROR_ALERT_RECEIVED, - "Fatal TLS Alert was received"), - AWS_DEFINE_ERROR_INFO_IO( - AWS_IO_TLS_CTX_ERROR, - "Failed to create tls context"), - AWS_DEFINE_ERROR_INFO_IO( - AWS_IO_TLS_VERSION_UNSUPPORTED, - "A TLS version was specified that is currently not supported. Consider using AWS_IO_TLS_VER_SYS_DEFAULTS, " - " and when this lib or the operating system is updated, it will automatically be used."), - AWS_DEFINE_ERROR_INFO_IO( - AWS_IO_TLS_CIPHER_PREF_UNSUPPORTED, - "A TLS Cipher Preference was specified that is currently not supported by the current platform. Consider " - " using AWS_IO_TLS_CIPHER_SYSTEM_DEFAULT, and when this lib or the operating system is updated, it will " - "automatically be used."), - AWS_DEFINE_ERROR_INFO_IO( AWS_IO_TLS_NEGOTIATION_TIMEOUT, "Channel shutdown due to tls negotiation timeout"), AWS_DEFINE_ERROR_INFO_IO( AWS_IO_TLS_ALERT_NOT_GRACEFUL, "Channel shutdown due to tls alert. The alert was not for a graceful shutdown."), AWS_DEFINE_ERROR_INFO_IO( + AWS_IO_MAX_RETRIES_EXCEEDED, + "Retry cannot be attempted because the maximum number of retries has been exceeded."), + AWS_DEFINE_ERROR_INFO_IO( + AWS_IO_RETRY_PERMISSION_DENIED, + "Retry cannot be attempted because the retry strategy has prevented the operation."), + AWS_DEFINE_ERROR_INFO_IO( AWS_IO_TLS_DIGEST_ALGORITHM_UNSUPPORTED, "TLS digest was created with an unsupported algorithm"), AWS_DEFINE_ERROR_INFO_IO( AWS_IO_TLS_SIGNATURE_ALGORITHM_UNSUPPORTED, "TLS signature algorithm is currently unsupported."), - AWS_DEFINE_ERROR_INFO_IO( - AWS_IO_TLS_ERROR_READ_FAILURE, - "Failure during TLS read."), - AWS_DEFINE_ERROR_INFO_IO( - AWS_IO_TLS_UNKNOWN_ROOT_CERTIFICATE, - "Channel shutdown due to tls unknown root certificate."), - AWS_DEFINE_ERROR_INFO_IO( - AWS_IO_TLS_NO_ROOT_CERTIFICATE_FOUND, - "Channel shutdown due to tls no root certificate found."), - AWS_DEFINE_ERROR_INFO_IO( - AWS_IO_TLS_CERTIFICATE_EXPIRED, - "Channel shutdown due to tls certificate expired."), - AWS_DEFINE_ERROR_INFO_IO( - AWS_IO_TLS_CERTIFICATE_NOT_YET_VALID, - "Channel shutdown due to tls certificate not yet valid."), - AWS_DEFINE_ERROR_INFO_IO( - AWS_IO_TLS_BAD_CERTIFICATE, - "Channel shutdown due to tls certificate is malformed or not correctly formatted."), - AWS_DEFINE_ERROR_INFO_IO( - AWS_IO_TLS_PEER_CERTIFICATE_EXPIRED, - "Channel shutdown due to peer tls certificate is malformed or not correctly formatted."), - AWS_DEFINE_ERROR_INFO_IO( - AWS_IO_TLS_BAD_PEER_CERTIFICATE, - "Channel shutdown due to peer tls certificate is malformed or not correctly formatted."), - AWS_DEFINE_ERROR_INFO_IO( - AWS_IO_TLS_PEER_CERTIFICATE_REVOKED, - "Channel shutdown due to peer tls certificate has been revoked."), - AWS_DEFINE_ERROR_INFO_IO( - AWS_IO_TLS_PEER_CERTIFICATE_UNKNOWN, - "Channel shutdown due to peer tls certificate is unknown."), - AWS_DEFINE_ERROR_INFO_IO( - AWS_IO_TLS_INTERNAL_ERROR, - "Channel shutdown due to internal SSL error."), - AWS_DEFINE_ERROR_INFO_IO( - AWS_IO_TLS_CLOSED_GRACEFUL, - "Channel shutdown due to connection closed gracefully."), - AWS_DEFINE_ERROR_INFO_IO( - AWS_IO_TLS_CLOSED_ABORT, - "Channel shutdown due to connection closed due to an error."), - AWS_DEFINE_ERROR_INFO_IO( - AWS_IO_TLS_INVALID_CERTIFICATE_CHAIN, - "Channel shutdown due to invalid certificate chain."), - AWS_DEFINE_ERROR_INFO_IO( - AWS_IO_TLS_HOST_NAME_MISSMATCH, - "Channel shutdown due to certificate's host name does not match the endpoint host name."), AWS_DEFINE_ERROR_INFO_IO( AWS_ERROR_PKCS11_VERSION_UNSUPPORTED, @@ -350,7 +302,55 @@ AWS_DEFINE_ERROR_INFO_IO( AWS_IO_STREAM_GET_LENGTH_UNSUPPORTED, "Get length is not supported in the underlying I/O source."), + AWS_DEFINE_ERROR_INFO_IO( + AWS_IO_TLS_ERROR_READ_FAILURE, + "Failure during TLS read."), AWS_DEFINE_ERROR_INFO_IO(AWS_ERROR_PEM_MALFORMED, "Malformed PEM object encountered."), + AWS_DEFINE_ERROR_INFO_IO( + AWS_IO_SOCKET_MISSING_EVENT_LOOP, + "Socket is missing its event loop."), + AWS_DEFINE_ERROR_INFO_IO( + AWS_IO_TLS_UNKNOWN_ROOT_CERTIFICATE, + "Channel shutdown due to tls unknown root certificate."), + AWS_DEFINE_ERROR_INFO_IO( + AWS_IO_TLS_NO_ROOT_CERTIFICATE_FOUND, + "Channel shutdown due to tls no root certificate found."), + AWS_DEFINE_ERROR_INFO_IO( + AWS_IO_TLS_CERTIFICATE_EXPIRED, + "Channel shutdown due to tls certificate expired."), + AWS_DEFINE_ERROR_INFO_IO( + AWS_IO_TLS_CERTIFICATE_NOT_YET_VALID, + "Channel shutdown due to tls certificate not yet valid."), + AWS_DEFINE_ERROR_INFO_IO( + AWS_IO_TLS_BAD_CERTIFICATE, + "Channel shutdown due to tls certificate is malformed or not correctly formatted."), + AWS_DEFINE_ERROR_INFO_IO( + AWS_IO_TLS_PEER_CERTIFICATE_EXPIRED, + "Channel shutdown due to peer tls certificate is malformed or not correctly formatted."), + AWS_DEFINE_ERROR_INFO_IO( + AWS_IO_TLS_BAD_PEER_CERTIFICATE, + "Channel shutdown due to peer tls certificate is malformed or not correctly formatted."), + AWS_DEFINE_ERROR_INFO_IO( + AWS_IO_TLS_PEER_CERTIFICATE_REVOKED, + "Channel shutdown due to peer tls certificate has been revoked."), + AWS_DEFINE_ERROR_INFO_IO( + AWS_IO_TLS_PEER_CERTIFICATE_UNKNOWN, + "Channel shutdown due to peer tls certificate is unknown."), + AWS_DEFINE_ERROR_INFO_IO( + AWS_IO_TLS_INTERNAL_ERROR, + "Channel shutdown due to internal SSL error."), + AWS_DEFINE_ERROR_INFO_IO( + AWS_IO_TLS_CLOSED_GRACEFUL, + "Channel shutdown due to connection closed gracefully."), + AWS_DEFINE_ERROR_INFO_IO( + AWS_IO_TLS_CLOSED_ABORT, + "Channel shutdown due to connection closed due to an error."), + AWS_DEFINE_ERROR_INFO_IO( + AWS_IO_TLS_INVALID_CERTIFICATE_CHAIN, + "Channel shutdown due to invalid certificate chain."), + AWS_DEFINE_ERROR_INFO_IO( + AWS_IO_TLS_HOST_NAME_MISMATCH, + "Channel shutdown due to certificate's host name does not match the endpoint host name."), }; /* clang-format on */ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-c-io-0.18.0/source/pem.c new/aws-c-io-0.18.1/source/pem.c --- old/aws-c-io-0.18.0/source/pem.c 2025-03-28 18:43:29.000000000 +0100 +++ new/aws-c-io-0.18.1/source/pem.c 2025-04-09 16:33:10.000000000 +0200 @@ -114,7 +114,7 @@ static struct aws_byte_cursor s_pem_type_x509_req_cur = AWS_BYTE_CUR_INIT_FROM_STRING_LITERAL("CERTIFICATE REQUEST"); static struct aws_byte_cursor s_pem_type_x509_crl_cur = AWS_BYTE_CUR_INIT_FROM_STRING_LITERAL("X509 CRL"); static struct aws_byte_cursor s_pem_type_evp_pkey_cur = AWS_BYTE_CUR_INIT_FROM_STRING_LITERAL("ANY PRIVATE KEY"); -static struct aws_byte_cursor s_pem_type_public_pkcs8_cur = AWS_BYTE_CUR_INIT_FROM_STRING_LITERAL("PUBLIC KEY"); +static struct aws_byte_cursor s_pem_type_public_key_cur = AWS_BYTE_CUR_INIT_FROM_STRING_LITERAL("PUBLIC KEY"); static struct aws_byte_cursor s_pem_type_private_rsa_pkcs1_cur = AWS_BYTE_CUR_INIT_FROM_STRING_LITERAL("RSA PRIVATE KEY"); static struct aws_byte_cursor s_pem_type_public_rsa_pkcs1_cur = AWS_BYTE_CUR_INIT_FROM_STRING_LITERAL("RSA PUBLIC KEY"); @@ -178,8 +178,8 @@ return AWS_PEM_TYPE_X509_CRL; } else if (aws_byte_cursor_eq(&type_cur, &s_pem_type_evp_pkey_cur)) { return AWS_PEM_TYPE_EVP_PKEY; - } else if (aws_byte_cursor_eq(&type_cur, &s_pem_type_public_pkcs8_cur)) { - return AWS_PEM_TYPE_PUBLIC_PKCS8; + } else if (aws_byte_cursor_eq(&type_cur, &s_pem_type_public_key_cur)) { + return AWS_PEM_TYPE_PUBLIC_KEY; } else if (aws_byte_cursor_eq(&type_cur, &s_pem_type_private_rsa_pkcs1_cur)) { return AWS_PEM_TYPE_PRIVATE_RSA_PKCS1; } else if (aws_byte_cursor_eq(&type_cur, &s_pem_type_public_rsa_pkcs1_cur)) { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-c-io-0.18.0/source/tls_channel_handler.c new/aws-c-io-0.18.1/source/tls_channel_handler.c --- old/aws-c-io-0.18.0/source/tls_channel_handler.c 2025-03-28 18:43:29.000000000 +0100 +++ new/aws-c-io-0.18.1/source/tls_channel_handler.c 2025-04-09 16:33:10.000000000 +0200 @@ -957,7 +957,7 @@ case AWS_IO_TLS_CLOSED_GRACEFUL: case AWS_IO_TLS_CLOSED_ABORT: case AWS_IO_TLS_INVALID_CERTIFICATE_CHAIN: - case AWS_IO_TLS_HOST_NAME_MISSMATCH: + case AWS_IO_TLS_HOST_NAME_MISMATCH: return true; default: return false; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-c-io-0.18.0/tests/CMakeLists.txt new/aws-c-io-0.18.1/tests/CMakeLists.txt --- old/aws-c-io-0.18.0/tests/CMakeLists.txt 2025-03-28 18:43:29.000000000 +0100 +++ new/aws-c-io-0.18.1/tests/CMakeLists.txt 2025-04-09 16:33:10.000000000 +0200 @@ -16,6 +16,7 @@ add_test_case(io_library_init) add_test_case(io_library_init_cleanup_init_cleanup) +add_test_case(io_library_error_order) # Dispatch Queue does not support pipe if(NOT AWS_USE_APPLE_NETWORK_FRAMEWORK) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-c-io-0.18.0/tests/io_lib_test.c new/aws-c-io-0.18.1/tests/io_lib_test.c --- old/aws-c-io-0.18.0/tests/io_lib_test.c 2025-03-28 18:43:29.000000000 +0100 +++ new/aws-c-io-0.18.1/tests/io_lib_test.c 2025-04-09 16:33:10.000000000 +0200 @@ -35,3 +35,24 @@ return AWS_OP_SUCCESS; } AWS_TEST_CASE(io_library_init_cleanup_init_cleanup, s_test_io_library_init_cleanup_init_cleanup) + +/* Make sure that new error codes are being added to the end instead of in the middle. */ +static int s_test_io_library_error_order(struct aws_allocator *allocator, void *ctx) { + (void)allocator; + (void)ctx; + + aws_io_library_init(allocator); + // Checking against expected int values of the error codes. + // The checked error codes are the first, somewhere in the middle, and last as of this commit. + int error_code_initial = 1024; + int error_code_mid = 1067; + int error_code_end = 1194; + + ASSERT_TRUE(error_code_initial == AWS_IO_CHANNEL_ERROR_ERROR_CANT_ACCEPT_INPUT); + ASSERT_TRUE(error_code_mid == AWS_IO_TLS_NEGOTIATION_TIMEOUT); + ASSERT_TRUE(error_code_end == AWS_IO_TLS_HOST_NAME_MISMATCH); + aws_io_library_clean_up(); + return AWS_OP_SUCCESS; +} + +AWS_TEST_CASE(io_library_error_order, s_test_io_library_error_order) \ No newline at end of file