Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package NetworkManager-openvpn for
openSUSE:Leap:16.0 checked in at 2025-04-16 16:17:07
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Leap:16.0/NetworkManager-openvpn (Old)
and /work/SRC/openSUSE:Leap:16.0/.NetworkManager-openvpn.new.30101 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "NetworkManager-openvpn"
Wed Apr 16 16:17:07 2025 rev:2 rq:1269799 version:1.12.0
Changes:
--------
---
/work/SRC/openSUSE:Leap:16.0/NetworkManager-openvpn/NetworkManager-openvpn.changes
2025-03-19 11:38:06.183984200 +0100
+++
/work/SRC/openSUSE:Leap:16.0/.NetworkManager-openvpn.new.30101/NetworkManager-openvpn.changes
2025-04-20 20:13:23.434748230 +0200
@@ -1,0 +2,15 @@
+Tue Mar 4 06:10:20 UTC 2025 - Jonathan Kang <songchuan.k...@suse.com>
+
+- Add nm-openvpn-fix-crash.patch: service: fix a crash when empty
+ password is provided (glgo#GNOME/NetworkManager-openvpn!92,
+ bsc#1237570).
+
+-------------------------------------------------------------------
+Mon Jun 24 09:01:48 UTC 2024 - Dominique Leuenberger <dims...@opensuse.org>
+
+- Update to version 1.12.0:
+ + Adapt to the new way of handling the 2FA secret by the daemon,
+ needed by it to fix a bug with certain clients.
+ + Updated translations.
+
+-------------------------------------------------------------------
Old:
----
NetworkManager-openvpn-1.10.2.tar.xz
New:
----
NetworkManager-openvpn-1.12.0.tar.xz
nm-openvpn-fix-crash.patch
BETA DEBUG BEGIN:
New:
- Add nm-openvpn-fix-crash.patch: service: fix a crash when empty
password is provided (glgo#GNOME/NetworkManager-openvpn!92,
BETA DEBUG END:
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ NetworkManager-openvpn.spec ++++++
--- /var/tmp/diff_new_pack.nF0xbC/_old 2025-04-20 20:13:23.750761459 +0200
+++ /var/tmp/diff_new_pack.nF0xbC/_new 2025-04-20 20:13:23.754761627 +0200
@@ -1,7 +1,7 @@
#
# spec file for package NetworkManager-openvpn
#
-# Copyright (c) 2024 SUSE LLC
+# Copyright (c) 2025 SUSE LLC
#
# All modifications and additions to the file contributed by third parties
# remain the property of their copyright owners, unless otherwise agreed
@@ -17,16 +17,18 @@
Name: NetworkManager-openvpn
-Version: 1.10.2
+Version: 1.12.0
Release: 0
Summary: NetworkManager VPN support for OpenVPN
License: GPL-2.0-or-later
Group: Productivity/Networking/System
URL: https://www.gnome.org/projects/NetworkManager
-Source0:
https://download.gnome.org/sources/NetworkManager-openvpn/1.10/%{name}-%{version}.tar.xz
+Source0:
https://download.gnome.org/sources/NetworkManager-openvpn/1.12/%{name}-%{version}.tar.xz
Source1: system-user-nm-openvpn.conf
# PATCH-FIX-OPENSUSE fix-for-missing-whirlpool-hmac-authentication.patch
boo#1132946
Patch0: fix-for-missing-whirlpool-hmac-authentication.patch
+# PATCH-FIX-UPSTREAM nm-openvpn-fix-crash.patch
glgo#GNOME/NetworkManager-openvpn!92, bsc#1237570 sck...@suse.com -- service:
fix a crash when empty password is provided
+Patch1: nm-openvpn-fix-crash.patch
BuildRequires: libxml2-tools
BuildRequires: pkgconfig
@@ -34,11 +36,11 @@
BuildRequires: pkgconfig(dbus-glib-1)
BuildRequires: pkgconfig(gtk+-3.0)
BuildRequires: pkgconfig(gtk4) >= 4.0
-BuildRequires: pkgconfig(libnm) >= 1.2.0
-BuildRequires: pkgconfig(libnma) >= 1.2.0
+BuildRequires: pkgconfig(libnm) >= 1.46.2
+BuildRequires: pkgconfig(libnma) >= 1.8.0
BuildRequires: pkgconfig(libnma-gtk4) >= 1.8.33
BuildRequires: pkgconfig(libsecret-1) >= 0.18
-Requires: NetworkManager >= 1.2.0
+Requires: NetworkManager >= 1.46.2
Requires: openvpn
Supplements: (NetworkManager and openvpn)
%sysusers_requires
++++++ NetworkManager-openvpn-1.10.2.tar.xz ->
NetworkManager-openvpn-1.12.0.tar.xz ++++++
++++ 39530 lines of diff (skipped)
++++++ nm-openvpn-fix-crash.patch ++++++
>From a65f66d2de6f259f08be30a3a9e03827674acdcf Mon Sep 17 00:00:00 2001
From: Jonathan Kang <jonathank...@gnome.org>
Date: Mon, 3 Mar 2025 13:52:27 +0800
Subject: [PATCH] service: fix a crash when empty password is provided
When activating a VPN connection with the following command, if no
password is provided, nm-openvpn-service crashes.
> nmcli --ask connection up $vpn-connection
Fix that by additionally checking for empty password to avoid passing
NULL to strlen().
https://bugzilla.suse.com/show_bug.cgi?id=1237570
---
src/nm-openvpn-service.c | 25 ++++++++++++++++---------
1 file changed, 16 insertions(+), 9 deletions(-)
diff --git a/src/nm-openvpn-service.c b/src/nm-openvpn-service.c
index a58124d..b01671d 100644
--- a/src/nm-openvpn-service.c
+++ b/src/nm-openvpn-service.c
@@ -781,18 +781,25 @@ nm_openvpn_disconnect_management_socket (NMOpenvpnPlugin
*plugin)
static char *
ovpn_quote_string (const char *unquoted)
{
- char *quoted = NULL, *q;
- char *u = (char *) unquoted;
+ char *quoted = NULL;
g_return_val_if_fail (unquoted != NULL, NULL);
- /* FIXME: use unpaged memory */
- quoted = q = g_malloc0 (strlen (unquoted) * 2);
- while (*u) {
- /* Escape certain characters */
- if (*u == ' ' || *u == '\\' || *u == '"')
- *q++ = '\\';
- *q++ = *u++;
+ /* Check empty password to avoid segmentation fault. */
+ if (g_strcmp0 (unquoted, "") == 0)
+ quoted = g_strdup (unquoted);
+ else {
+ char *q;
+ char *u = (char *) unquoted;
+
+ /* FIXME: use unpaged memory */
+ quoted = q = g_malloc0 (strlen (unquoted) * 2);
+ while (*u) {
+ /* Escape certain characters */
+ if (*u == ' ' || *u == '\\' || *u == '"')
+ *q++ = '\\';
+ *q++ = *u++;
+ }
}
return quoted;
--
2.48.1
