Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package gsasl for openSUSE:Factory checked in at 2025-06-02 21:59:08 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/gsasl (Old) and /work/SRC/openSUSE:Factory/.gsasl.new.16005 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "gsasl" Mon Jun 2 21:59:08 2025 rev:3 rq:1281550 version:2.2.1 Changes: -------- --- /work/SRC/openSUSE:Factory/gsasl/gsasl.changes 2024-12-17 19:22:48.460036295 +0100 +++ /work/SRC/openSUSE:Factory/.gsasl.new.16005/gsasl.changes 2025-06-02 21:59:30.814615834 +0200 @@ -1,0 +2,14 @@ +Tue May 27 09:43:28 UTC 2025 - Samuel Cabrero <[email protected]> + +- Rename patch uninitialized_x.patch to 0001-uninitialized_x.patch + and update it for version 2.2.1 +- Reenable compilation warnings. Add patches + * 0002-Fix-calloc-transposed-arguments.patch + * 0003-Fix-more-transposed-calloc-arguments.patch + +------------------------------------------------------------------- +Thu Mar 27 13:14:47 UTC 2025 - Bernhard Wiedemann <[email protected]> + +- Use %autosetup to work with rpm-4.20 (bsc#1240154) + +------------------------------------------------------------------- @@ -34,0 +49 @@ +- uninitialized_x.patch: fixes compilation on s390x New: ---- 0001-uninitialized_x.patch 0002-Fix-calloc-transposed-arguments.patch 0003-Fix-more-transposed-calloc-arguments.patch BETA DEBUG BEGIN: New: - Rename patch uninitialized_x.patch to 0001-uninitialized_x.patch and update it for version 2.2.1 New:- Reenable compilation warnings. Add patches * 0002-Fix-calloc-transposed-arguments.patch * 0003-Fix-more-transposed-calloc-arguments.patch New: * 0002-Fix-calloc-transposed-arguments.patch * 0003-Fix-more-transposed-calloc-arguments.patch BETA DEBUG END: ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ gsasl.spec ++++++ --- /var/tmp/diff_new_pack.ENm25t/_old 2025-06-02 21:59:31.390639724 +0200 +++ /var/tmp/diff_new_pack.ENm25t/_new 2025-06-02 21:59:31.390639724 +0200 @@ -1,7 +1,7 @@ # # spec file for package gsasl # -# Copyright (c) 2024 SUSE LLC +# Copyright (c) 2025 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -27,6 +27,9 @@ Source2: https://ftp.gnu.org/gnu/gsasl/%{name}-%{version}.tar.gz.sig # https://josefsson.org/54265e8c.txt#/libgsasl.keyring Source3: %{name}.keyring +Patch1: 0001-uninitialized_x.patch +Patch2: 0002-Fix-calloc-transposed-arguments.patch +Patch3: 0003-Fix-more-transposed-calloc-arguments.patch BuildRequires: gcc-c++ BuildRequires: gettext-devel >= 0.19.8 BuildRequires: pkgconfig @@ -77,6 +80,7 @@ --disable-static \ --disable-ntlm \ --with-gssapi-impl=mit \ + --enable-gcc-warnings=error \ # %make_build ++++++ 0001-uninitialized_x.patch ++++++ Fixes this warning make[2]: Entering directory '/home/abuild/rpmbuild/BUILD/libgsasl-1.10.0/digest-md5' /usr/bin/bash ../libtool --tag=CC --mode=link gcc -Werror -fanalyzer -fno-common -Wall -Warith-conversion -Wbad-function-cast -Wcast-align=strict -Wdate-time -Wdisabled-optimization -Wdouble-promotion -Wduplicated-branches -Wduplicated-cond -Wextra -Wformat-signedness -Winit-self -Winline -Winvalid-pch -Wlogical-op -Wmissing-declarations -Wmissing-include-dirs -Wmissing-prototypes -Wnested-externs -Wnull-dereference -Wold-style-definition -Wopenmp-simd -Woverlength-strings -Wpacked -Wpointer-arith -Wshadow -Wstack-protector -Wstrict-overflow -Wstrict-prototypes -Wsuggest-attribute=cold -Wsuggest-attribute=format -Wsuggest-attribute=malloc -Wsuggest-attribute=noreturn -Wsuggest-final-methods -Wsuggest-final-types -Wsync-nand -Wtrampolines -Wuninitialized -Wunknown-pragmas -Wunsafe-loop-optimizations -Wunused-macros -Wvariadic-macros -Wvector-operation-performance -Wvla -Wwrite-strings -Warray-bounds=2 -Wattribute-alias=2 -Wformat-overflow=2 -Wformat=2 -Wformat-truncation=2 -Wimplic it-fallthrough=5 -Wshift-overflow=2 -Wunused-const-variable=2 -Wvla-larger-than=4031 -Wno-analyzer-double-free -Wno-analyzer-malloc-leak -Wno-analyzer-null-dereference -Wno-analyzer-use-after-free -O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -flto=auto -o test-parser test_parser-test-parser.o libgsasl-digest_md5.la ../gl/libgl.la libtool: link: gcc -Werror -fanalyzer -fno-common -Wall -Warith-conversion -Wbad-function-cast -Wcast-align=strict -Wdate-time -Wdisabled-optimization -Wdouble-promotion -Wduplicated-branches -Wduplicated-cond -Wextra -Wformat-signedness -Winit-self -Winline -Winvalid-pch -Wlogical-op -Wmissing-declarations -Wmissing-include-dirs -Wmissing-prototypes -Wnested-externs -Wnull-dereference -Wold-style-definition -Wopenmp-simd -Woverlength-strings -Wpacked -Wpointer-arith -Wshadow -Wstack-protector -Wstrict-overflow -Wstrict-prototypes -Wsuggest-attribute=cold -Wsuggest-attribute=format -Wsuggest-attribute=malloc -Wsuggest-attribute=noreturn -Wsuggest-final-methods -Wsuggest-final-types -Wsync-nand -Wtrampolines -Wuninitialized -Wunknown-pragmas -Wunsafe-loop-optimizations -Wunused-macros -Wvariadic-macros -Wvector-operation-performance -Wvla -Wwrite-strings -Warray-bounds=2 -Wattribute-alias=2 -Wformat-overflow=2 -Wformat=2 -Wformat-truncation=2 -Wimplicit-fallthrough=5 -Wshift-overflow= 2 -Wunused-const-variable=2 -Wvla-larger-than=4031 -Wno-analyzer-double-free -Wno-analyzer-malloc-leak -Wno-analyzer-null-dereference -Wno-analyzer-use-after-free -O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -flto=auto -o test-parser test_parser-test-parser.o ./.libs/libgsasl-digest_md5.a ../gl/.libs/libgl.a -lgssapi_krb5 -lkrb5 -lk5crypto -lcom_err ../gl/sha256.c: In function 'sha256_process_block': ../gl/sha256.c:462:7: error: use of uninitialized value 'x[1]' [CWE-457] [-Werror=analyzer-use-of-uninitialized-value] 462 | R( h, a, b, c, d, e, f, g, K( 1), x[ 1] ); | ^ 'hmac_sha256': events 1-2 | |../gl/hmac.c:59:1: | 59 | GL_HMAC_FN (const void *key, size_t keylen, | | ^ | | | | | (1) entry to 'hmac_sha256' |...... | 81 | hmac_hash (key, keylen, in, inlen, IPAD, innerhash); | | ~ | | | | | (2) calling 'hmac_hash' from 'hmac_sha256' | +--> 'hmac_hash': events 3-4 | | 42 | hmac_hash (const void *key, size_t keylen, | | ^ | | | | | (3) entry to 'hmac_hash' |...... | 50 | memxor (block, key, keylen); | | ~ | | | | | (4) calling 'memxor' from 'hmac_hash' | +--> 'memxor': events 5-9 | |../gl/memxor.c:25:1: | 25 | memxor (void *restrict dest, const void *restrict src, size_t n) | | ^ | | | | | (5) entry to 'memxor' |...... | 30 | for (; n > 0; n--) | | ~ | | | | | (6) following 'true' branch (when 'n_3 != 0')... | | (8) following 'false' branch (when 'n_3 == 0')... | 31 | *d++ ^= *s++; | | ~ | | | | | (7) ...to here | 32 | | 33 | return dest; | | ~ | | | | | (9) ...to here | <------+ | 'hmac_hash': events 10-11 | |../gl/hmac.c:50:3: | 50 | memxor (block, key, keylen); | | ^ | | | | | (10) returning to 'hmac_hash' from 'memxor' |...... | 53 | GL_HMAC_FN_BLOC (block, sizeof block, &hmac_ctx); | | ~ | | | | | (11) calling 'sha256_process_block' from 'hmac_hash' | +--> 'sha256_process_block': events 12-14 | |../gl/sha256.c:409:1: | 409 | sha256_process_block (const void *buffer, size_t len, struct sha256_ctx *ctx) | | ^ | | | | | (12) entry to 'sha256_process_block' |...... | 414 | uint32_t x[16]; | | ~ | | | | | (13) region created on stack here |...... | 449 | while (words < endp) | | ~ | | | | | (14) following 'true' branch (when 'words_1902 < endp_1916')... | 'sha256_process_block': event 15 | |lto1: | (15): ...to here | 'sha256_process_block': events 16-20 | | 455 | for (t = 0; t < 16; t++) | | ^ | | | | | (16) following 'true' branch (when 't_1911 != 16')... | | (18) following 'false' branch (when 't_1911 == 16')... | 456 | { | 457 | x[t] = SWAP (*words); | | ~ | | | | | (17) ...to here |...... | 461 | R( a, b, c, d, e, f, g, h, K( 0), x[ 0] ); | | ~ | | | | | (19) ...to here | 462 | R( h, a, b, c, d, e, f, g, K( 1), x[ 1] ); | | ~ | | | | | (20) use of uninitialized value 'x[1]' here | lto1: all warnings being treated as errors Index: gsasl-2.2.1/lib/gl/sha256.c =================================================================== --- gsasl-2.2.1.orig/lib/gl/sha256.c +++ gsasl-2.2.1/lib/gl/sha256.c @@ -446,6 +446,8 @@ sha256_process_block (const void *buffer D += t1; H = t0 + t1; \ } while(0) + memset(x, 0, sizeof(x)); + while (words < endp) { uint32_t tm; ++++++ 0002-Fix-calloc-transposed-arguments.patch ++++++ >From f1dc65bc2a4dce23be43f0b5f12b7a133eb18c94 Mon Sep 17 00:00:00 2001 From: Simon Josefsson <[email protected]> Date: Thu, 27 Mar 2025 09:44:48 +0100 Subject: [PATCH] Fix calloc transposed arguments. --- lib/scram/client.c | 2 +- lib/scram/server.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/scram/client.c b/lib/scram/client.c index a0070051..078cba97 100644 --- a/lib/scram/client.c +++ b/lib/scram/client.c @@ -65,7 +65,7 @@ scram_start (Gsasl_session *sctx _GL_UNUSED, char buf[CNONCE_ENTROPY_BYTES]; int rc; - state = (struct scram_client_state *) calloc (sizeof (*state), 1); + state = (struct scram_client_state *) calloc (1, sizeof (*state)); if (state == NULL) return GSASL_MALLOC_ERROR; diff --git a/lib/scram/server.c b/lib/scram/server.c index e178638e..aabfa772 100644 --- a/lib/scram/server.c +++ b/lib/scram/server.c @@ -77,7 +77,7 @@ scram_start (Gsasl_session *sctx _GL_UNUSED, void **mech_data, char buf[MAX (SNONCE_ENTROPY_BYTES, DEFAULT_SALT_BYTES)]; int rc; - state = (struct scram_server_state *) calloc (sizeof (*state), 1); + state = (struct scram_server_state *) calloc (1, sizeof (*state)); if (state == NULL) return GSASL_MALLOC_ERROR; -- 2.49.0 ++++++ 0003-Fix-more-transposed-calloc-arguments.patch ++++++ >From 8efefe297268a4775504b3bf4c48fed09b231a49 Mon Sep 17 00:00:00 2001 From: Simon Josefsson <[email protected]> Date: Thu, 27 Mar 2025 10:12:40 +0100 Subject: [PATCH] Fix more transposed calloc arguments. --- lib/openid20/client.c | 2 +- lib/openid20/server.c | 2 +- lib/saml20/client.c | 2 +- lib/saml20/server.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/openid20/client.c b/lib/openid20/client.c index fa1a6f67..9d9b34f4 100644 --- a/lib/openid20/client.c +++ b/lib/openid20/client.c @@ -47,7 +47,7 @@ _gsasl_openid20_client_start (Gsasl_session *sctx _GL_UNUSED, { struct openid20_client_state *state; - state = (struct openid20_client_state *) calloc (sizeof (*state), 1); + state = (struct openid20_client_state *) calloc (1, sizeof (*state)); if (state == NULL) return GSASL_MALLOC_ERROR; diff --git a/lib/openid20/server.c b/lib/openid20/server.c index 8a244ca7..55bbb7e1 100644 --- a/lib/openid20/server.c +++ b/lib/openid20/server.c @@ -45,7 +45,7 @@ _gsasl_openid20_server_start (Gsasl_session *sctx _GL_UNUSED, { struct openid20_server_state *state; - state = (struct openid20_server_state *) calloc (sizeof (*state), 1); + state = (struct openid20_server_state *) calloc (1, sizeof (*state)); if (state == NULL) return GSASL_MALLOC_ERROR; diff --git a/lib/saml20/client.c b/lib/saml20/client.c index 47dbca6a..142ede1a 100644 --- a/lib/saml20/client.c +++ b/lib/saml20/client.c @@ -46,7 +46,7 @@ _gsasl_saml20_client_start (Gsasl_session *sctx _GL_UNUSED, void **mech_data) { struct saml20_client_state *state; - state = (struct saml20_client_state *) calloc (sizeof (*state), 1); + state = (struct saml20_client_state *) calloc (1, sizeof (*state)); if (state == NULL) return GSASL_MALLOC_ERROR; diff --git a/lib/saml20/server.c b/lib/saml20/server.c index 7b285374..fe92f31e 100644 --- a/lib/saml20/server.c +++ b/lib/saml20/server.c @@ -43,7 +43,7 @@ _gsasl_saml20_server_start (Gsasl_session *sctx _GL_UNUSED, void **mech_data) { struct saml20_server_state *state; - state = (struct saml20_server_state *) calloc (sizeof (*state), 1); + state = (struct saml20_server_state *) calloc (1, sizeof (*state)); if (state == NULL) return GSASL_MALLOC_ERROR; -- 2.49.0
