Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package aws-crt-cpp for openSUSE:Factory checked in at 2025-06-06 22:44:33 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/aws-crt-cpp (Old) and /work/SRC/openSUSE:Factory/.aws-crt-cpp.new.19631 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "aws-crt-cpp" Fri Jun 6 22:44:33 2025 rev:30 rq:1283614 version:0.32.8 Changes: -------- --- /work/SRC/openSUSE:Factory/aws-crt-cpp/aws-crt-cpp.changes 2025-06-02 22:01:50.076391450 +0200 +++ /work/SRC/openSUSE:Factory/.aws-crt-cpp.new.19631/aws-crt-cpp.changes 2025-06-06 22:45:10.822084133 +0200 @@ -1,0 +2,9 @@ +Tue Jun 3 09:08:38 UTC 2025 - John Paul Adrian Glaubitz <adrian.glaub...@suse.com> + +- Update to version 0.32.8 + * Replace std::make_shared with Crt::MakeShared by @sfod in (#740) + * Fix warnings for latest LLVM compiler update by @xiazhvera in (#743) +- from version 0.32.7 + * Update submodules by @sfod in (#739) + +------------------------------------------------------------------- Old: ---- v0.32.6.tar.gz New: ---- v0.32.8.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ aws-crt-cpp.spec ++++++ --- /var/tmp/diff_new_pack.cAZMcI/_old 2025-06-06 22:45:12.774165033 +0200 +++ /var/tmp/diff_new_pack.cAZMcI/_new 2025-06-06 22:45:12.782165364 +0200 @@ -20,7 +20,7 @@ %define library_soversion 1 Name: aws-crt-cpp -Version: 0.32.6 +Version: 0.32.8 Release: 0 Summary: AWS C++ wrapper for AWS SDK C libraries License: Apache-2.0 ++++++ v0.32.6.tar.gz -> v0.32.8.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-crt-cpp-0.32.6/VERSION new/aws-crt-cpp-0.32.8/VERSION --- old/aws-crt-cpp-0.32.6/VERSION 2025-05-22 00:19:49.000000000 +0200 +++ new/aws-crt-cpp-0.32.8/VERSION 2025-05-30 02:07:25.000000000 +0200 @@ -1 +1 @@ -0.32.6 +0.32.8 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-crt-cpp-0.32.6/bin/elasticurl_cpp/main.cpp new/aws-crt-cpp-0.32.8/bin/elasticurl_cpp/main.cpp --- old/aws-crt-cpp-0.32.6/bin/elasticurl_cpp/main.cpp 2025-05-22 00:19:49.000000000 +0200 +++ new/aws-crt-cpp-0.32.8/bin/elasticurl_cpp/main.cpp 2025-05-30 02:07:25.000000000 +0200 @@ -146,12 +146,12 @@ break; case 'd': { - ctx.InputBody = std::make_shared<std::stringstream>(aws_cli_optarg); + ctx.InputBody = Aws::Crt::MakeShared<std::stringstream>(ctx.allocator, aws_cli_optarg); break; } case 'g': { - ctx.InputBody = std::make_shared<std::ifstream>(aws_cli_optarg, std::ios::in); + ctx.InputBody = Aws::Crt::MakeShared<std::ifstream>(ctx.allocator, aws_cli_optarg, std::ios::in); if (!ctx.InputBody->good()) { std::cerr << "unable to open file " << aws_cli_optarg << std::endl; @@ -228,7 +228,7 @@ if (ctx.InputBody == nullptr) { - ctx.InputBody = std::make_shared<std::stringstream>(""); + ctx.InputBody = Aws::Crt::MakeShared<std::stringstream>(ctx.allocator, ""); } if (!ctx.uri) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-crt-cpp-0.32.6/bin/mqtt5_app/main.cpp new/aws-crt-cpp-0.32.8/bin/mqtt5_app/main.cpp --- old/aws-crt-cpp-0.32.6/bin/mqtt5_app/main.cpp 2025-05-22 00:19:49.000000000 +0200 +++ new/aws-crt-cpp-0.32.8/bin/mqtt5_app/main.cpp 2025-05-30 02:07:25.000000000 +0200 @@ -294,7 +294,7 @@ std::cout << "**********************************************************" << std::endl; std::cout << "MQTT5: Start ConnectPacket...." << std::endl; std::cout << "**********************************************************" << std::endl; - std::shared_ptr<Mqtt5::ConnectPacket> packet_connect = std::make_shared<Mqtt5::ConnectPacket>(); + std::shared_ptr<Mqtt5::ConnectPacket> packet_connect = Aws::Crt::MakeShared<Mqtt5::ConnectPacket>(allocator); packet_connect->WithReceiveMaximum(9); packet_connect->WithMaximumPacketSizeBytes(128 * 1024); @@ -444,7 +444,8 @@ subscriptionList.push_back(data2); subscriptionList.push_back(data3); - std::shared_ptr<Mqtt5::SubscribePacket> subscribe = std::make_shared<Mqtt5::SubscribePacket>(app_ctx.allocator); + std::shared_ptr<Mqtt5::SubscribePacket> subscribe = + Aws::Crt::MakeShared<Mqtt5::SubscribePacket>(app_ctx.allocator, app_ctx.allocator); subscribe->WithSubscriptions(subscriptionList); bool subscribeSuccess = mqtt5Client->Subscribe( subscribe, @@ -487,7 +488,8 @@ **********************************************************/ ByteCursor payload = Aws::Crt::ByteCursorFromCString("mqtt5 publish test"); - std::shared_ptr<Mqtt5::PublishPacket> publish = std::make_shared<Mqtt5::PublishPacket>(app_ctx.allocator); + std::shared_ptr<Mqtt5::PublishPacket> publish = + Aws::Crt::MakeShared<Mqtt5::PublishPacket>(app_ctx.allocator, app_ctx.allocator); publish->WithTopic("test/topic/test1"); publish->WithPayload(payload); @@ -543,7 +545,8 @@ Vector<String> topics; topics.push_back(topic1); topics.push_back(topic2); - std::shared_ptr<Mqtt5::UnsubscribePacket> unsub = std::make_shared<Mqtt5::UnsubscribePacket>(app_ctx.allocator); + std::shared_ptr<Mqtt5::UnsubscribePacket> unsub = + Aws::Crt::MakeShared<Mqtt5::UnsubscribePacket>(app_ctx.allocator, app_ctx.allocator); unsub->WithTopicFilters(topics); if (!mqtt5Client->Unsubscribe(unsub)) { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-crt-cpp-0.32.6/bin/mqtt5_canary/main.cpp new/aws-crt-cpp-0.32.8/bin/mqtt5_canary/main.cpp --- old/aws-crt-cpp-0.32.6/bin/mqtt5_canary/main.cpp 2025-05-22 00:19:49.000000000 +0200 +++ new/aws-crt-cpp-0.32.8/bin/mqtt5_canary/main.cpp 2025-05-30 02:07:25.000000000 +0200 @@ -435,7 +435,7 @@ .WithRetainHandlingType(Mqtt5::RetainHandlingType::AWS_MQTT5_RHT_SEND_ON_SUBSCRIBE) .WithRetainAsPublished(false); - std::shared_ptr<Mqtt5::SubscribePacket> packet = std::make_shared<Mqtt5::SubscribePacket>(allocator); + std::shared_ptr<Mqtt5::SubscribePacket> packet = Aws::Crt::MakeShared<Mqtt5::SubscribePacket>(allocator, allocator); packet->WithSubscription(std::move(subscription1)); packet->WithSubscription(std::move(subscription2)); @@ -479,7 +479,8 @@ Vector<Aws::Crt::String> topics; topics.push_back(Aws::Crt::String(topicArray)); - std::shared_ptr<Mqtt5::UnsubscribePacket> unsubscription = std::make_shared<Mqtt5::UnsubscribePacket>(allocator); + std::shared_ptr<Mqtt5::UnsubscribePacket> unsubscription = + Aws::Crt::MakeShared<Mqtt5::UnsubscribePacket>(allocator, allocator); unsubscription->WithTopicFilters(topics); ++g_statistic.totalOperations; @@ -527,7 +528,8 @@ Vector<Aws::Crt::String> topics; topics.push_back(Aws::Crt::String(topicArray)); - std::shared_ptr<Mqtt5::UnsubscribePacket> unsubscription = std::make_shared<Mqtt5::UnsubscribePacket>(allocator); + std::shared_ptr<Mqtt5::UnsubscribePacket> unsubscription = + Aws::Crt::MakeShared<Mqtt5::UnsubscribePacket>(allocator, allocator); unsubscription->WithTopicFilters(topics); ++g_statistic.totalOperations; @@ -574,7 +576,8 @@ } ByteCursor payload = ByteCursorFromArray(payload_data, payload_size); - std::shared_ptr<Mqtt5::PublishPacket> packetPublish = std::make_shared<Mqtt5::PublishPacket>(allocator); + std::shared_ptr<Mqtt5::PublishPacket> packetPublish = + Aws::Crt::MakeShared<Mqtt5::PublishPacket>(allocator, allocator); packetPublish->WithTopic(topicFilter) .WithQOS(qos) .WithRetain(false) @@ -878,7 +881,8 @@ uint16_t receive_maximum = 9; uint32_t maximum_packet_size = 128 * 1024; - std::shared_ptr<Mqtt5::ConnectPacket> packetConnect = std::make_shared<Mqtt5::ConnectPacket>(allocator); + std::shared_ptr<Mqtt5::ConnectPacket> packetConnect = + Aws::Crt::MakeShared<Mqtt5::ConnectPacket>(allocator, allocator); packetConnect->WithKeepAliveIntervalSec(30) .WithMaximumPacketSizeBytes(maximum_packet_size) .WithReceiveMaximum(receive_maximum); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-crt-cpp-0.32.6/include/aws/crt/mqtt/Mqtt5Client.h new/aws-crt-cpp-0.32.8/include/aws/crt/mqtt/Mqtt5Client.h --- old/aws-crt-cpp-0.32.6/include/aws/crt/mqtt/Mqtt5Client.h 2025-05-22 00:19:49.000000000 +0200 +++ new/aws-crt-cpp-0.32.8/include/aws/crt/mqtt/Mqtt5Client.h 2025-05-30 02:07:25.000000000 +0200 @@ -433,7 +433,7 @@ */ const Mqtt5ClientOperationStatistics &GetOperationStatistics() noexcept; - virtual ~Mqtt5Client(); + ~Mqtt5Client(); struct aws_mqtt5_client *GetUnderlyingHandle() const noexcept; @@ -696,7 +696,7 @@ */ bool initializeRawOptions(aws_mqtt5_client_options &raw_options) const noexcept; - virtual ~Mqtt5ClientOptions(); + ~Mqtt5ClientOptions(); Mqtt5ClientOptions(const Mqtt5ClientOptions &) = delete; Mqtt5ClientOptions(Mqtt5ClientOptions &&) = delete; Mqtt5ClientOptions &operator=(const Mqtt5ClientOptions &) = delete; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-crt-cpp-0.32.6/include/aws/crt/mqtt/private/Mqtt5ClientCore.h new/aws-crt-cpp-0.32.8/include/aws/crt/mqtt/private/Mqtt5ClientCore.h --- old/aws-crt-cpp-0.32.6/include/aws/crt/mqtt/private/Mqtt5ClientCore.h 2025-05-22 00:19:49.000000000 +0200 +++ new/aws-crt-cpp-0.32.8/include/aws/crt/mqtt/private/Mqtt5ClientCore.h 2025-05-30 02:07:25.000000000 +0200 @@ -107,7 +107,7 @@ */ void Close() noexcept; - virtual ~Mqtt5ClientCore(); + ~Mqtt5ClientCore(); struct aws_mqtt5_client *GetUnderlyingHandle() const noexcept { return m_client; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-crt-cpp-0.32.6/include/aws/iot/Mqtt5Client.h new/aws-crt-cpp-0.32.8/include/aws/iot/Mqtt5Client.h --- old/aws-crt-cpp-0.32.6/include/aws/iot/Mqtt5Client.h 2025-05-22 00:19:49.000000000 +0200 +++ new/aws-crt-cpp-0.32.8/include/aws/iot/Mqtt5Client.h 2025-05-30 02:07:25.000000000 +0200 @@ -474,7 +474,7 @@ */ int LastError() const noexcept { return m_lastError ? m_lastError : AWS_ERROR_UNKNOWN; } - virtual ~Mqtt5ClientBuilder() + ~Mqtt5ClientBuilder() { if (m_options) { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-crt-cpp-0.32.6/source/iot/Mqtt5Client.cpp new/aws-crt-cpp-0.32.8/source/iot/Mqtt5Client.cpp --- old/aws-crt-cpp-0.32.6/source/iot/Mqtt5Client.cpp 2025-05-22 00:19:49.000000000 +0200 +++ new/aws-crt-cpp-0.32.8/source/iot/Mqtt5Client.cpp 2025-05-30 02:07:25.000000000 +0200 @@ -536,7 +536,7 @@ } else { - m_connectOptions = std::make_shared<ConnectPacket>(m_allocator); + m_connectOptions = Aws::Crt::MakeShared<ConnectPacket>(m_allocator, m_allocator); } if (m_customAuthConfig.has_value()) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-crt-cpp-0.32.6/source/mqtt/Mqtt5ClientCore.cpp new/aws-crt-cpp-0.32.8/source/mqtt/Mqtt5ClientCore.cpp --- old/aws-crt-cpp-0.32.6/source/mqtt/Mqtt5ClientCore.cpp 2025-05-22 00:19:49.000000000 +0200 +++ new/aws-crt-cpp-0.32.8/source/mqtt/Mqtt5ClientCore.cpp 2025-05-30 02:07:25.000000000 +0200 @@ -185,8 +185,8 @@ { if (publish != nullptr) { - std::shared_ptr<PublishPacket> packet = - std::make_shared<PublishPacket>(*publish, client_core->m_allocator); + std::shared_ptr<PublishPacket> packet = Aws::Crt::MakeShared<PublishPacket>( + client_core->m_allocator, *publish, client_core->m_allocator); PublishReceivedEventData eventData; eventData.publishPacket = packet; client_core->onPublishReceived(eventData); @@ -235,9 +235,12 @@ { if (publishCompletionPacket != nullptr) { - std::shared_ptr<PubAckPacket> packet = std::make_shared<PubAckPacket>( - *(aws_mqtt5_packet_puback_view *)publishCompletionPacket, callbackData->allocator); - publish = std::make_shared<PublishResult>(std::move(packet)); + std::shared_ptr<PubAckPacket> packet = Aws::Crt::MakeShared<PubAckPacket>( + callbackData->allocator, + *(aws_mqtt5_packet_puback_view *)publishCompletionPacket, + callbackData->allocator); + publish = + Aws::Crt::MakeShared<PublishResult>(callbackData->allocator, std::move(packet)); } else /* This should never happened. */ { @@ -248,13 +251,13 @@ } case aws_mqtt5_packet_type::AWS_MQTT5_PT_NONE: { - publish = std::make_shared<PublishResult>(error_code); + publish = Aws::Crt::MakeShared<PublishResult>(callbackData->allocator, error_code); break; } default: /* Invalid packet type */ { AWS_LOGF_INFO(AWS_LS_MQTT5_CLIENT, "Invalid Packet Type."); - publish = std::make_shared<PublishResult>(AWS_ERROR_UNKNOWN); + publish = Aws::Crt::MakeShared<PublishResult>(callbackData->allocator, AWS_ERROR_UNKNOWN); break; } } @@ -342,7 +345,8 @@ std::shared_ptr<SubAckPacket> packet = nullptr; if (suback != nullptr) { - packet = std::make_shared<SubAckPacket>(*suback, callbackData->allocator); + packet = Aws::Crt::MakeShared<SubAckPacket>( + callbackData->allocator, *suback, callbackData->allocator); } if (error_code != 0) @@ -391,7 +395,8 @@ std::shared_ptr<UnSubAckPacket> packet = nullptr; if (unsuback != nullptr) { - packet = std::make_shared<UnSubAckPacket>(*unsuback, callbackData->allocator); + packet = Aws::Crt::MakeShared<UnSubAckPacket>( + callbackData->allocator, *unsuback, callbackData->allocator); } if (error_code != 0) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-crt-cpp-0.32.6/tests/HttpRequestTest.cpp new/aws-crt-cpp-0.32.8/tests/HttpRequestTest.cpp --- old/aws-crt-cpp-0.32.6/tests/HttpRequestTest.cpp 2025-05-22 00:19:49.000000000 +0200 +++ new/aws-crt-cpp-0.32.8/tests/HttpRequestTest.cpp 2025-05-30 02:07:25.000000000 +0200 @@ -24,10 +24,12 @@ request.SetMethod(aws_byte_cursor_from_c_str("GET")); request.SetPath(aws_byte_cursor_from_c_str("/index")); - std::shared_ptr<Aws::Crt::Io::IStream> stream = std::make_shared<std::stringstream>("TestContent"); + std::shared_ptr<Aws::Crt::Io::IStream> stream = + Aws::Crt::MakeShared<std::stringstream>(allocator, "TestContent"); request.SetBody(stream); - std::shared_ptr<Aws::Crt::Io::IStream> stream2 = std::make_shared<std::stringstream>("SomeOtherContent"); + std::shared_ptr<Aws::Crt::Io::IStream> stream2 = + Aws::Crt::MakeShared<std::stringstream>(allocator, "SomeOtherContent"); request.SetBody(stream2); HttpHeader header1 = {aws_byte_cursor_from_c_str("Host"), aws_byte_cursor_from_c_str("www.test.com")}; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-crt-cpp-0.32.6/tests/Mqtt5ClientTest.cpp new/aws-crt-cpp-0.32.8/tests/Mqtt5ClientTest.cpp --- old/aws-crt-cpp-0.32.6/tests/Mqtt5ClientTest.cpp 2025-05-22 00:19:49.000000000 +0200 +++ new/aws-crt-cpp-0.32.8/tests/Mqtt5ClientTest.cpp 2025-05-30 02:07:25.000000000 +0200 @@ -96,10 +96,11 @@ // Setup will const Aws::Crt::String TEST_TOPIC = "test/MQTT5_Binding_CPP/s_TestMqtt5NewClientFull"; ByteBuf will_payload = Aws::Crt::ByteBufFromCString("Will Test"); - std::shared_ptr<Mqtt5::PublishPacket> will = std::make_shared<Mqtt5::PublishPacket>( - TEST_TOPIC, ByteCursorFromByteBuf(will_payload), Mqtt5::QOS::AWS_MQTT5_QOS_AT_LEAST_ONCE, allocator); + std::shared_ptr<Mqtt5::PublishPacket> will = Aws::Crt::MakeShared<Mqtt5::PublishPacket>( + allocator, TEST_TOPIC, ByteCursorFromByteBuf(will_payload), Mqtt5::QOS::AWS_MQTT5_QOS_AT_LEAST_ONCE, allocator); - std::shared_ptr<Aws::Crt::Mqtt5::ConnectPacket> packetConnect = std::make_shared<Aws::Crt::Mqtt5::ConnectPacket>(); + std::shared_ptr<Aws::Crt::Mqtt5::ConnectPacket> packetConnect = + Aws::Crt::MakeShared<Aws::Crt::Mqtt5::ConnectPacket>(allocator); packetConnect->WithClientId("s_TestMqtt5DirectConnectionFull" + Aws::Crt::UUID().ToString()) .WithKeepAliveIntervalSec(1000) .WithMaximumPacketSizeBytes(1000L) @@ -530,7 +531,8 @@ mqtt5Options.WithHostName(mqtt5TestVars.m_hostname_string); mqtt5Options.WithPort(mqtt5TestVars.m_port_value); - std::shared_ptr<Aws::Crt::Mqtt5::ConnectPacket> packetConnect = std::make_shared<Aws::Crt::Mqtt5::ConnectPacket>(); + std::shared_ptr<Aws::Crt::Mqtt5::ConnectPacket> packetConnect = + Aws::Crt::MakeShared<Aws::Crt::Mqtt5::ConnectPacket>(allocator); packetConnect->WithUserName(mqtt5TestVars.m_username_string); packetConnect->WithPassword(mqtt5TestVars.m_password_cursor); mqtt5Options.WithConnectOptions(packetConnect); @@ -726,10 +728,11 @@ const Aws::Crt::String TEST_TOPIC = "test/MQTT5_Binding_CPP/s_TestMqtt5DirectConnectionFull" + Aws::Crt::UUID().ToString(); ByteBuf will_payload = Aws::Crt::ByteBufFromCString("Will Test"); - std::shared_ptr<Mqtt5::PublishPacket> will = std::make_shared<Mqtt5::PublishPacket>( - TEST_TOPIC, ByteCursorFromByteBuf(will_payload), Mqtt5::QOS::AWS_MQTT5_QOS_AT_LEAST_ONCE, allocator); + std::shared_ptr<Mqtt5::PublishPacket> will = Aws::Crt::MakeShared<Mqtt5::PublishPacket>( + allocator, TEST_TOPIC, ByteCursorFromByteBuf(will_payload), Mqtt5::QOS::AWS_MQTT5_QOS_AT_LEAST_ONCE, allocator); - std::shared_ptr<Aws::Crt::Mqtt5::ConnectPacket> packetConnect = std::make_shared<Aws::Crt::Mqtt5::ConnectPacket>(); + std::shared_ptr<Aws::Crt::Mqtt5::ConnectPacket> packetConnect = + Aws::Crt::MakeShared<Aws::Crt::Mqtt5::ConnectPacket>(allocator); packetConnect->WithClientId("s_TestMqtt5DirectConnectionFull" + Aws::Crt::UUID().ToString()) .WithKeepAliveIntervalSec(1000) .WithMaximumPacketSizeBytes(1000L) @@ -850,7 +853,8 @@ mqtt5Options.WithHostName(mqtt5TestVars.m_hostname_string); mqtt5Options.WithPort(mqtt5TestVars.m_port_value); - std::shared_ptr<Aws::Crt::Mqtt5::ConnectPacket> packetConnect = std::make_shared<Aws::Crt::Mqtt5::ConnectPacket>(); + std::shared_ptr<Aws::Crt::Mqtt5::ConnectPacket> packetConnect = + Aws::Crt::MakeShared<Aws::Crt::Mqtt5::ConnectPacket>(allocator); packetConnect->WithUserName(mqtt5TestVars.m_username_string); packetConnect->WithPassword(mqtt5TestVars.m_password_cursor); mqtt5Options.WithConnectOptions(packetConnect); @@ -1134,10 +1138,11 @@ const Aws::Crt::String TEST_TOPIC = "test/MQTT5_Binding_CPP/s_TestMqtt5WSConnectionFull" + Aws::Crt::UUID().ToString(); ByteBuf will_payload = Aws::Crt::ByteBufFromCString("Will Test"); - std::shared_ptr<Mqtt5::PublishPacket> will = std::make_shared<Mqtt5::PublishPacket>( - TEST_TOPIC, ByteCursorFromByteBuf(will_payload), Mqtt5::QOS::AWS_MQTT5_QOS_AT_LEAST_ONCE, allocator); + std::shared_ptr<Mqtt5::PublishPacket> will = Aws::Crt::MakeShared<Mqtt5::PublishPacket>( + allocator, TEST_TOPIC, ByteCursorFromByteBuf(will_payload), Mqtt5::QOS::AWS_MQTT5_QOS_AT_LEAST_ONCE, allocator); - std::shared_ptr<Aws::Crt::Mqtt5::ConnectPacket> packetConnect = std::make_shared<Aws::Crt::Mqtt5::ConnectPacket>(); + std::shared_ptr<Aws::Crt::Mqtt5::ConnectPacket> packetConnect = + Aws::Crt::MakeShared<Aws::Crt::Mqtt5::ConnectPacket>(allocator); packetConnect->WithClientId("s_TestMqtt5WSConnectionFull" + Aws::Crt::UUID().ToString()) .WithKeepAliveIntervalSec(1000) .WithMaximumPacketSizeBytes(1000L) @@ -1394,7 +1399,8 @@ mqtt5Options.WithHostName(mqtt5TestVars.m_hostname_string); mqtt5Options.WithPort(mqtt5TestVars.m_port_value); - std::shared_ptr<Aws::Crt::Mqtt5::ConnectPacket> packetConnect = std::make_shared<Aws::Crt::Mqtt5::ConnectPacket>(); + std::shared_ptr<Aws::Crt::Mqtt5::ConnectPacket> packetConnect = + Aws::Crt::MakeShared<Aws::Crt::Mqtt5::ConnectPacket>(allocator); packetConnect->WithUserName("WRONG_USERNAME"); packetConnect->WithPassword(ByteCursorFromCString("WRONG_PASSWORD")); mqtt5Options.WithConnectOptions(packetConnect); @@ -1478,7 +1484,8 @@ mqtt5Options.WithHostName(mqtt5TestVars.m_hostname_string); mqtt5Options.WithPort(mqtt5TestVars.m_port_value); - std::shared_ptr<Aws::Crt::Mqtt5::ConnectPacket> packetConnect = std::make_shared<Aws::Crt::Mqtt5::ConnectPacket>(); + std::shared_ptr<Aws::Crt::Mqtt5::ConnectPacket> packetConnect = + Aws::Crt::MakeShared<Aws::Crt::Mqtt5::ConnectPacket>(allocator); packetConnect->WithClientId("TestMqtt5DoubleClientIDFailure" + Aws::Crt::UUID().ToString()); mqtt5Options.WithConnectOptions(packetConnect); @@ -1558,7 +1565,8 @@ mqtt5Options.WithHostName(mqtt5TestVars.m_hostname_string); mqtt5Options.WithPort(mqtt5TestVars.m_port_value); - std::shared_ptr<Aws::Crt::Mqtt5::ConnectPacket> packetConnect = std::make_shared<Aws::Crt::Mqtt5::ConnectPacket>(); + std::shared_ptr<Aws::Crt::Mqtt5::ConnectPacket> packetConnect = + Aws::Crt::MakeShared<Aws::Crt::Mqtt5::ConnectPacket>(allocator); packetConnect->WithSessionExpiryIntervalSec(SESSION_EXPIRY_INTERVAL_SEC); mqtt5Options.WithConnectOptions(packetConnect); @@ -1612,7 +1620,7 @@ mqtt5Options.WithPort(mqtt5TestVars.m_port_value); std::shared_ptr<Aws::Crt::Mqtt5::ConnectPacket> packetConnect = - std::make_shared<Aws::Crt::Mqtt5::ConnectPacket>(allocator); + Aws::Crt::MakeShared<Aws::Crt::Mqtt5::ConnectPacket>(allocator, allocator); packetConnect->WithSessionExpiryIntervalSec(SESSION_EXPIRY_INTERVAL_SEC) .WithClientId(CLIENT_ID) .WithReceiveMaximum(RECEIVE_MAX) @@ -1672,7 +1680,8 @@ mqtt5Options.WithHostName(mqtt5TestVars.m_hostname_string); mqtt5Options.WithPort(mqtt5TestVars.m_port_value); - std::shared_ptr<Aws::Crt::Mqtt5::ConnectPacket> packetConnect = std::make_shared<Aws::Crt::Mqtt5::ConnectPacket>(); + std::shared_ptr<Aws::Crt::Mqtt5::ConnectPacket> packetConnect = + Aws::Crt::MakeShared<Aws::Crt::Mqtt5::ConnectPacket>(allocator); packetConnect->WithSessionExpiryIntervalSec(SESSION_EXPIRY_INTERVAL_SEC) .WithReceiveMaximum(RECEIVE_MAX) .WithMaximumPacketSizeBytes(PACKET_MAX) @@ -1730,7 +1739,8 @@ mqtt5Options.WithHostName(mqtt5TestVars.m_hostname_string); mqtt5Options.WithPort(mqtt5TestVars.m_port_value); - std::shared_ptr<Aws::Crt::Mqtt5::ConnectPacket> packetConnect = std::make_shared<Aws::Crt::Mqtt5::ConnectPacket>(); + std::shared_ptr<Aws::Crt::Mqtt5::ConnectPacket> packetConnect = + Aws::Crt::MakeShared<Aws::Crt::Mqtt5::ConnectPacket>(allocator); packetConnect->WithSessionExpiryIntervalSec(SESSION_EXPIRY_INTERVAL_SEC); packetConnect->WithClientId(Aws::Crt::UUID().ToString()); mqtt5Options.WithConnectOptions(packetConnect); @@ -1833,14 +1843,15 @@ /* Subscribe to test topic */ Mqtt5::Subscription subscription(TEST_TOPIC, Mqtt5::QOS::AWS_MQTT5_QOS_AT_LEAST_ONCE, allocator); subscription.WithNoLocal(false); - std::shared_ptr<Mqtt5::SubscribePacket> subscribe = std::make_shared<Mqtt5::SubscribePacket>(allocator); + std::shared_ptr<Mqtt5::SubscribePacket> subscribe = + Aws::Crt::MakeShared<Mqtt5::SubscribePacket>(allocator, allocator); subscribe->WithSubscription(std::move(subscription)); ASSERT_TRUE(mqtt5Client->Subscribe(subscribe)); /* Publish message 1 to test topic */ ByteBuf payload = Aws::Crt::ByteBufFromCString("Hello World"); - std::shared_ptr<Mqtt5::PublishPacket> publish = std::make_shared<Mqtt5::PublishPacket>( - TEST_TOPIC, ByteCursorFromByteBuf(payload), Mqtt5::QOS::AWS_MQTT5_QOS_AT_LEAST_ONCE, allocator); + std::shared_ptr<Mqtt5::PublishPacket> publish = Aws::Crt::MakeShared<Mqtt5::PublishPacket>( + allocator, TEST_TOPIC, ByteCursorFromByteBuf(payload), Mqtt5::QOS::AWS_MQTT5_QOS_AT_LEAST_ONCE, allocator); ASSERT_TRUE(mqtt5Client->Publish(publish)); // Sleep and wait for message recieved @@ -1849,7 +1860,8 @@ /* Unsubscribe to test topic */ Vector<String> topics; topics.push_back(TEST_TOPIC); - std::shared_ptr<Mqtt5::UnsubscribePacket> unsub = std::make_shared<Mqtt5::UnsubscribePacket>(allocator); + std::shared_ptr<Mqtt5::UnsubscribePacket> unsub = + Aws::Crt::MakeShared<Mqtt5::UnsubscribePacket>(allocator, allocator); unsub->WithTopicFilters(topics); ASSERT_TRUE(mqtt5Client->Unsubscribe(unsub)); @@ -1910,10 +1922,11 @@ ASSERT_TRUE(subscriber); /* Set will for client option */ - std::shared_ptr<Aws::Crt::Mqtt5::ConnectPacket> packetConnect = std::make_shared<Aws::Crt::Mqtt5::ConnectPacket>(); + std::shared_ptr<Aws::Crt::Mqtt5::ConnectPacket> packetConnect = + Aws::Crt::MakeShared<Aws::Crt::Mqtt5::ConnectPacket>(allocator); ByteBuf will_payload = Aws::Crt::ByteBufFromCString("Will Test"); - std::shared_ptr<Mqtt5::PublishPacket> will = std::make_shared<Mqtt5::PublishPacket>( - TEST_TOPIC, ByteCursorFromByteBuf(will_payload), Mqtt5::QOS::AWS_MQTT5_QOS_AT_LEAST_ONCE, allocator); + std::shared_ptr<Mqtt5::PublishPacket> will = Aws::Crt::MakeShared<Mqtt5::PublishPacket>( + allocator, TEST_TOPIC, ByteCursorFromByteBuf(will_payload), Mqtt5::QOS::AWS_MQTT5_QOS_AT_LEAST_ONCE, allocator); packetConnect->WithWill(will); mqtt5Options.WithConnectOptions(packetConnect); @@ -1930,7 +1943,8 @@ /* Subscribe to test topic */ Mqtt5::Subscription subscription(TEST_TOPIC, Mqtt5::QOS::AWS_MQTT5_QOS_AT_LEAST_ONCE, allocator); - std::shared_ptr<Mqtt5::SubscribePacket> subscribe = std::make_shared<Mqtt5::SubscribePacket>(allocator); + std::shared_ptr<Mqtt5::SubscribePacket> subscribe = + Aws::Crt::MakeShared<Mqtt5::SubscribePacket>(allocator, allocator); subscribe->WithSubscription(std::move(subscription)); @@ -1940,7 +1954,8 @@ subscribed.get_future().get(); - std::shared_ptr<Mqtt5::DisconnectPacket> disconnect = std::make_shared<Mqtt5::DisconnectPacket>(allocator); + std::shared_ptr<Mqtt5::DisconnectPacket> disconnect = + Aws::Crt::MakeShared<Mqtt5::DisconnectPacket>(allocator, allocator); disconnect->WithReasonCode(AWS_MQTT5_DRC_DISCONNECT_WITH_WILL_MESSAGE); ASSERT_TRUE(publisher->Stop(disconnect)); publisherStoppedPromise.get_future().get(); @@ -2036,7 +2051,8 @@ std::promise<bool> connectionPromise3; std::promise<void> stoppedPromise3; - std::shared_ptr<Aws::Crt::Mqtt5::ConnectPacket> packetConnect = std::make_shared<Aws::Crt::Mqtt5::ConnectPacket>(); + std::shared_ptr<Aws::Crt::Mqtt5::ConnectPacket> packetConnect = + Aws::Crt::MakeShared<Aws::Crt::Mqtt5::ConnectPacket>(allocator); /* first subscriber */ /* set a different client id so we are not disconnected from the server */ @@ -2074,12 +2090,14 @@ /* Subscribe to test topic */ Mqtt5::Subscription subscription(sharedTopicFilter, Mqtt5::QOS::AWS_MQTT5_QOS_AT_MOST_ONCE, allocator); - std::shared_ptr<Mqtt5::SubscribePacket> subscribe = std::make_shared<Mqtt5::SubscribePacket>(allocator); + std::shared_ptr<Mqtt5::SubscribePacket> subscribe = + Aws::Crt::MakeShared<Mqtt5::SubscribePacket>(allocator, allocator); subscribe->WithSubscription(std::move(subscription)); /* Subscribe to test topic */ Mqtt5::Subscription subscription2(sharedTopicFilter, Mqtt5::QOS::AWS_MQTT5_QOS_AT_MOST_ONCE, allocator); - std::shared_ptr<Mqtt5::SubscribePacket> subscribe2 = std::make_shared<Mqtt5::SubscribePacket>(allocator); + std::shared_ptr<Mqtt5::SubscribePacket> subscribe2 = + Aws::Crt::MakeShared<Mqtt5::SubscribePacket>(allocator, allocator); subscribe2->WithSubscription(std::move(subscription2)); std::promise<void> suback; @@ -2099,8 +2117,12 @@ for (int i = 0; i < MESSAGE_COUNT; i++) { std::string payload = std::to_string(i); - std::shared_ptr<Mqtt5::PublishPacket> publish = std::make_shared<Mqtt5::PublishPacket>( - TEST_TOPIC, ByteCursorFromCString(payload.c_str()), Mqtt5::QOS::AWS_MQTT5_QOS_AT_LEAST_ONCE, allocator); + std::shared_ptr<Mqtt5::PublishPacket> publish = Aws::Crt::MakeShared<Mqtt5::PublishPacket>( + allocator, + TEST_TOPIC, + ByteCursorFromCString(payload.c_str()), + Mqtt5::QOS::AWS_MQTT5_QOS_AT_LEAST_ONCE, + allocator); ASSERT_TRUE(mqtt5Publisher->Publish(publish)); } @@ -2168,8 +2190,8 @@ // Invalid publish packet with empty topic ByteBuf payload = Aws::Crt::ByteBufFromCString("Mqtt5 Null Publish Test"); - std::shared_ptr<Mqtt5::PublishPacket> publish = std::make_shared<Mqtt5::PublishPacket>( - "", ByteCursorFromByteBuf(payload), Mqtt5::QOS::AWS_MQTT5_QOS_AT_LEAST_ONCE, allocator); + std::shared_ptr<Mqtt5::PublishPacket> publish = Aws::Crt::MakeShared<Mqtt5::PublishPacket>( + allocator, "", ByteCursorFromByteBuf(payload), Mqtt5::QOS::AWS_MQTT5_QOS_AT_LEAST_ONCE, allocator); /* Publish message 1 to test topic */ ASSERT_FALSE(mqtt5Client->Publish(publish)); @@ -2213,7 +2235,8 @@ /* Subscribe to empty subscribe packet*/ Vector<Mqtt5::Subscription> subscriptionList; subscriptionList.clear(); - std::shared_ptr<Mqtt5::SubscribePacket> subscribe = std::make_shared<Mqtt5::SubscribePacket>(allocator); + std::shared_ptr<Mqtt5::SubscribePacket> subscribe = + Aws::Crt::MakeShared<Mqtt5::SubscribePacket>(allocator, allocator); subscribe->WithSubscriptions(subscriptionList); ASSERT_FALSE(mqtt5Client->Subscribe(subscribe)); @@ -2257,7 +2280,8 @@ /* Subscribe to empty subscribe packet*/ Vector<String> unsubList; unsubList.clear(); - std::shared_ptr<Mqtt5::UnsubscribePacket> unsubscribe = std::make_shared<Mqtt5::UnsubscribePacket>(allocator); + std::shared_ptr<Mqtt5::UnsubscribePacket> unsubscribe = + Aws::Crt::MakeShared<Mqtt5::UnsubscribePacket>(allocator, allocator); unsubscribe->WithTopicFilters(unsubList); ASSERT_FALSE(mqtt5Client->Unsubscribe(unsubscribe)); @@ -2284,7 +2308,8 @@ ASSERT_TRUE(mqtt5Client); Vector<String> unsubList{TEST_TOPIC}; - std::shared_ptr<Mqtt5::UnsubscribePacket> unsubscribe = std::make_shared<Mqtt5::UnsubscribePacket>(allocator); + std::shared_ptr<Mqtt5::UnsubscribePacket> unsubscribe = + Aws::Crt::MakeShared<Mqtt5::UnsubscribePacket>(allocator, allocator); unsubscribe->WithTopicFilters(unsubList); ASSERT_TRUE(mqtt5Client->Unsubscribe(unsubscribe)); /* Unsubscribe once again using the same UnsubscribePacket. */ @@ -2364,7 +2389,7 @@ /* Subscribe to test topic */ Mqtt5::Subscription subscription(TEST_TOPIC, Mqtt5::QOS::AWS_MQTT5_QOS_AT_LEAST_ONCE, allocator); - std::shared_ptr<Mqtt5::SubscribePacket> subscribe = std::make_shared<Mqtt5::SubscribePacket>(allocator); + std::shared_ptr<Mqtt5::SubscribePacket> subscribe = Aws::Crt::MakeShared<Mqtt5::SubscribePacket>(allocator); subscribe->WithSubscription(std::move(subscription)); std::promise<void> subscribed; @@ -2377,8 +2402,12 @@ for (int i = 0; i < MESSAGE_NUMBER; i++) { std::string payload = std::to_string(i); - std::shared_ptr<Mqtt5::PublishPacket> publish = std::make_shared<Mqtt5::PublishPacket>( - TEST_TOPIC, ByteCursorFromCString(payload.c_str()), Mqtt5::QOS::AWS_MQTT5_QOS_AT_LEAST_ONCE, allocator); + std::shared_ptr<Mqtt5::PublishPacket> publish = Aws::Crt::MakeShared<Mqtt5::PublishPacket>( + allocator, + TEST_TOPIC, + ByteCursorFromCString(payload.c_str()), + Mqtt5::QOS::AWS_MQTT5_QOS_AT_LEAST_ONCE, + allocator); ASSERT_TRUE(publisher->Publish(publish)); } @@ -2475,7 +2504,8 @@ // 1. client1 start and publish a retian message ASSERT_TRUE(mqtt5Client1->Start()); ASSERT_TRUE(connection1Promise.get_future().get()); - std::shared_ptr<Mqtt5::PublishPacket> setRetainPacket = std::make_shared<Mqtt5::PublishPacket>(allocator); + std::shared_ptr<Mqtt5::PublishPacket> setRetainPacket = + Aws::Crt::MakeShared<Mqtt5::PublishPacket>(allocator, allocator); setRetainPacket->WithTopic(TEST_TOPIC).WithPayload(ByteCursorFromString(RETAIN_MESSAGE)).WithRetain(true); ASSERT_TRUE(mqtt5Client1->Publish(setRetainPacket)); @@ -2484,7 +2514,8 @@ ASSERT_TRUE(connection2Promise.get_future().get()); // 3. client2 subscribe to retain topic Mqtt5::Subscription subscription(TEST_TOPIC, Mqtt5::QOS::AWS_MQTT5_QOS_AT_LEAST_ONCE, allocator); - std::shared_ptr<Mqtt5::SubscribePacket> subscribe = std::make_shared<Mqtt5::SubscribePacket>(allocator); + std::shared_ptr<Mqtt5::SubscribePacket> subscribe = + Aws::Crt::MakeShared<Mqtt5::SubscribePacket>(allocator, allocator); subscribe->WithSubscription(std::move(subscription)); ASSERT_TRUE(mqtt5Client2->Subscribe(subscribe)); @@ -2495,7 +2526,8 @@ stopped2Promise.get_future().get(); // 4. client1 reset retian message - std::shared_ptr<Mqtt5::PublishPacket> clearRetainPacket = std::make_shared<Mqtt5::PublishPacket>(allocator); + std::shared_ptr<Mqtt5::PublishPacket> clearRetainPacket = + Aws::Crt::MakeShared<Mqtt5::PublishPacket>(allocator, allocator); clearRetainPacket->WithTopic(TEST_TOPIC).WithRetain(true); ASSERT_TRUE(mqtt5Client1->Publish(clearRetainPacket)); @@ -2554,7 +2586,8 @@ const Aws::Crt::String TEST_TOPIC = "test/s_TestMqtt5InterruptSub" + Aws::Crt::UUID().ToString(); /* Subscribe to test topic */ Mqtt5::Subscription subscription(TEST_TOPIC, Mqtt5::QOS::AWS_MQTT5_QOS_AT_MOST_ONCE, allocator); - std::shared_ptr<Mqtt5::SubscribePacket> subscribe = std::make_shared<Mqtt5::SubscribePacket>(allocator); + std::shared_ptr<Mqtt5::SubscribePacket> subscribe = + Aws::Crt::MakeShared<Mqtt5::SubscribePacket>(allocator, allocator); subscribe->WithSubscription(std::move(subscription)); ASSERT_TRUE(mqtt5Client->Subscribe(subscribe)); @@ -2603,7 +2636,8 @@ /* Unsub from topic*/ Vector<String> topics; topics.push_back(TEST_TOPIC); - std::shared_ptr<Mqtt5::UnsubscribePacket> unsub = std::make_shared<Mqtt5::UnsubscribePacket>(allocator); + std::shared_ptr<Mqtt5::UnsubscribePacket> unsub = + Aws::Crt::MakeShared<Mqtt5::UnsubscribePacket>(allocator, allocator); unsub->WithTopicFilters(topics); ASSERT_TRUE(mqtt5Client->Unsubscribe(unsub)); @@ -2652,8 +2686,8 @@ /* Publish QOS1 to test topic */ ByteBuf payload = Aws::Crt::ByteBufFromCString("Hello World"); - std::shared_ptr<Mqtt5::PublishPacket> publish = std::make_shared<Mqtt5::PublishPacket>( - TEST_TOPIC, ByteCursorFromByteBuf(payload), Mqtt5::QOS::AWS_MQTT5_QOS_AT_LEAST_ONCE, allocator); + std::shared_ptr<Mqtt5::PublishPacket> publish = Aws::Crt::MakeShared<Mqtt5::PublishPacket>( + allocator, TEST_TOPIC, ByteCursorFromByteBuf(payload), Mqtt5::QOS::AWS_MQTT5_QOS_AT_LEAST_ONCE, allocator); ASSERT_TRUE(mqtt5Client->Publish(publish)); /* Stop immediately */ @@ -2707,8 +2741,8 @@ /* Publish message 1 to test topic */ ByteBuf payload = Aws::Crt::ByteBufFromCString("Hello World"); - std::shared_ptr<Mqtt5::PublishPacket> publish = std::make_shared<Mqtt5::PublishPacket>( - TEST_TOPIC, ByteCursorFromByteBuf(payload), Mqtt5::QOS::AWS_MQTT5_QOS_AT_LEAST_ONCE, allocator); + std::shared_ptr<Mqtt5::PublishPacket> publish = Aws::Crt::MakeShared<Mqtt5::PublishPacket>( + allocator, TEST_TOPIC, ByteCursorFromByteBuf(payload), Mqtt5::QOS::AWS_MQTT5_QOS_AT_LEAST_ONCE, allocator); ASSERT_TRUE(mqtt5Client->Publish(publish)); // Sleep and wait for message received @@ -2848,10 +2882,11 @@ // Setup will const Aws::Crt::String TEST_TOPIC = "test/MQTT5_Binding_CPP/s_TestMqtt5NewClientFull"; ByteBuf will_payload = Aws::Crt::ByteBufFromCString("Will Test"); - std::shared_ptr<Mqtt5::PublishPacket> will = std::make_shared<Mqtt5::PublishPacket>( - TEST_TOPIC, ByteCursorFromByteBuf(will_payload), Mqtt5::QOS::AWS_MQTT5_QOS_AT_LEAST_ONCE, allocator); + std::shared_ptr<Mqtt5::PublishPacket> will = Aws::Crt::MakeShared<Mqtt5::PublishPacket>( + allocator, TEST_TOPIC, ByteCursorFromByteBuf(will_payload), Mqtt5::QOS::AWS_MQTT5_QOS_AT_LEAST_ONCE, allocator); - std::shared_ptr<Aws::Crt::Mqtt5::ConnectPacket> packetConnect = std::make_shared<Aws::Crt::Mqtt5::ConnectPacket>(); + std::shared_ptr<Aws::Crt::Mqtt5::ConnectPacket> packetConnect = + Aws::Crt::MakeShared<Aws::Crt::Mqtt5::ConnectPacket>(allocator); packetConnect->WithClientId("s_TestMqtt5DirectConnectionFull" + Aws::Crt::UUID().ToString()) .WithKeepAliveIntervalSec(1000) .WithMaximumPacketSizeBytes(1000L)