Script 'mail_helper' called by obssrc
Hello community,

here is the log from the commit of package roast for openSUSE:Factory checked 
in at 2025-06-18 17:59:01
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/roast (Old)
 and      /work/SRC/openSUSE:Factory/.roast.new.19631 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "roast"

Wed Jun 18 17:59:01 2025 rev:10 rq:1286700 version:8.1.0

Changes:
--------
--- /work/SRC/openSUSE:Factory/roast/roast.changes      2025-06-16 
11:12:08.042439135 +0200
+++ /work/SRC/openSUSE:Factory/.roast.new.19631/roast.changes   2025-06-18 
17:59:22.484120429 +0200
@@ -1,0 +2,18 @@
+Sun Jun 15 13:21:52 UTC 2025 - Soc Virnyl Estela 
<uncomfyhaloma...@opensuse.org>
+
+- Update to version 8.1.0:
+  * chore(release): bump to v8.1.0
+  * docs: update README.md to reflect new behaviour
+  * ci: add a note for why tests are separated.
+  * improvement: feature obs will just call `set_version_in_specfile`.
+  * format: run `cargo +nightly fmt`
+  * fix: more clap fix workarounds. `changesauthor` is required if 
`changesgenerate` is set to true.
+  * fix: "prepend" -> "it prepends"
+  * fix: word should be prepend and not append.
+  * fix: `requires_if` to `required_if_eq`
+  * docs: fix typos and inconsistencies in README.md
+  * docs: update README
+  * docs: update README.md
+  * docs: update README.md
+
+-------------------------------------------------------------------
@@ -313,0 +332 @@
+

Old:
----
  roast-8.0.0.tar.zst

New:
----
  roast-8.1.0.tar.zst

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ roast.spec ++++++
--- /var/tmp/diff_new_pack.FTVIwQ/_old  2025-06-18 17:59:23.584165386 +0200
+++ /var/tmp/diff_new_pack.FTVIwQ/_new  2025-06-18 17:59:23.588165553 +0200
@@ -17,7 +17,7 @@
 
 
 Name:           roast
-Version:        8.0.0
+Version:        8.1.0
 Release:        0
 Summary:        Simpler tar archiver and extractor
 License:        MPL-2.0

++++++ _service ++++++
--- /var/tmp/diff_new_pack.FTVIwQ/_old  2025-06-18 17:59:23.636167551 +0200
+++ /var/tmp/diff_new_pack.FTVIwQ/_new  2025-06-18 17:59:23.644167884 +0200
@@ -1,7 +1,7 @@
 <services>
   <service name="cargo_vendor" mode="manual">
      <param name="url">https://codeberg.org/Rusty-Geckos/roast</param>
-     <param name="revision">main</param>
+     <param name="revision">v8.1.0</param>
      <param name="versionrewriteregex">v(.*)</param>
      <param name="versionrewritepattern">${1}</param>
      <param name="changesgenerate">true</param>

++++++ roast-8.0.0.tar.zst -> roast-8.1.0.tar.zst ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/roast-8.0.0/.woodpecker/build.yml 
new/roast-8.1.0/.woodpecker/build.yml
--- old/roast-8.0.0/.woodpecker/build.yml       1970-01-01 01:00:00.000000000 
+0100
+++ new/roast-8.1.0/.woodpecker/build.yml       1970-01-01 01:00:00.000000000 
+0100
@@ -24,6 +24,6 @@
       - cargo +nightly fmt -- --check
       - cargo clippy --tests
       - cargo test --release -- --test-threads=1
-      - cargo test -F obs --test obs_scm --release -- --test-threads=1
+      - cargo test -F obs --test obs_scm --release -- --test-threads=1  # 
Tests are separated here because apparently, envs are shared between threads.
 
 runs_on: [ success, failure ]
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/roast-8.0.0/CHANGELOG.md new/roast-8.1.0/CHANGELOG.md
--- old/roast-8.0.0/CHANGELOG.md        1970-01-01 01:00:00.000000000 +0100
+++ new/roast-8.1.0/CHANGELOG.md        1970-01-01 01:00:00.000000000 +0100
@@ -2,6 +2,35 @@
 
 All notable changes to this project will be documented in this file.
 
+## [8.1.0] - 2025-06-15
+
+### Bug Fixes
+
+- More clap fix workarounds. `changesauthor` is required if `changesgenerate` 
is set to true. 
[ef52077](https://codeberg.org/Rusty-Geckos/roast/commit/ef5207761a92349942303e04cc7dd8964abb0733)
+- "prepend" -> "it prepends" 
[43e746d](https://codeberg.org/Rusty-Geckos/roast/commit/43e746dcbde4981f7d3d25727ae13b02fc0033d7)
+- Word should be prepend and not append. 
[4545613](https://codeberg.org/Rusty-Geckos/roast/commit/4545613dcbc2585f7a17f96364dfc3b681a2fc4c)
+- `requires_if` to `required_if_eq` 
[314d477](https://codeberg.org/Rusty-Geckos/roast/commit/314d4775aed252b92057fca3ed64a41ac4e092d2)
+
+### Continuous Integrations
+
+- Add a note for why tests are separated. 
[71b8c53](https://codeberg.org/Rusty-Geckos/roast/commit/71b8c533a0b6379a3608e74c1866de720c576657)
+
+### Documentation
+
+- Update README.md to reflect new behaviour 
[26fd6a7](https://codeberg.org/Rusty-Geckos/roast/commit/26fd6a750d9f406bd93df4190835804380b0b81e)
+- Fix typos and inconsistencies in README.md 
[9642839](https://codeberg.org/Rusty-Geckos/roast/commit/96428394f127b7c2077337d2e2cb05f151e8a6c4)
+- Update README 
[4d81469](https://codeberg.org/Rusty-Geckos/roast/commit/4d81469104009537c63d6e0243858f920eb06555)
+- Update README.md 
[27c27c6](https://codeberg.org/Rusty-Geckos/roast/commit/27c27c661464515acab768c389c55879256ae870)
+- Update README.md 
[8d08ddb](https://codeberg.org/Rusty-Geckos/roast/commit/8d08ddbbe87e86101f6cfe9061435e853f3299c2)
+
+### Improvements
+
+- Feature obs will just call `set_version_in_specfile`. 
[2cee767](https://codeberg.org/Rusty-Geckos/roast/commit/2cee7671bc5fd132c4ed31fd1df5ce351d42c54e)
+
+### Other
+
+- Run `cargo +nightly fmt` 
[75fe51a](https://codeberg.org/Rusty-Geckos/roast/commit/75fe51acfdd3f7d35d6ebdd12a14a52a2244308f)
+
 ## [8.0.0] - 2025-06-13
 
 ### Continuous Integrations
@@ -18,6 +47,7 @@
 
 ### Miscellaneous Tasks
 
+- Bump to v8.0.0 
[2ac2c36](https://codeberg.org/Rusty-Geckos/roast/commit/2ac2c36d7b63b8dfcd00343ea49e9b03f172929b)
 - Make the warning clear if renaming fails because of wrong file extension 
[551fdba](https://codeberg.org/Rusty-Geckos/roast/commit/551fdbaba6bcc7835bdefce6189a69fb89686452)
 
 ### Refactor
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/roast-8.0.0/Cargo.lock new/roast-8.1.0/Cargo.lock
--- old/roast-8.0.0/Cargo.lock  1970-01-01 01:00:00.000000000 +0100
+++ new/roast-8.1.0/Cargo.lock  1970-01-01 01:00:00.000000000 +0100
@@ -655,9 +655,9 @@
 
 [[package]]
 name = "libc"
-version = "0.2.172"
+version = "0.2.173"
 source = "registry+https://github.com/rust-lang/crates.io-index";
-checksum = "d750af042f7ef4f724306de029d18836c26c1765a54a6a3f094cbd23a7267ffa"
+checksum = "d8cfeafaffdbc32176b64fb251369d52ea9f0a8fbc6f8759edffef7b525d64bb"
 
 [[package]]
 name = "libgit2-sys"
@@ -692,7 +692,7 @@
 
 [[package]]
 name = "libroast"
-version = "8.0.0"
+version = "8.1.0"
 dependencies = [
  "bzip2",
  "clap",
@@ -1055,7 +1055,7 @@
 
 [[package]]
 name = "roast-cli"
-version = "8.0.0"
+version = "8.1.0"
 dependencies = [
  "clap",
  "libroast",
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/roast-8.0.0/Cargo.toml new/roast-8.1.0/Cargo.toml
--- old/roast-8.0.0/Cargo.toml  1970-01-01 01:00:00.000000000 +0100
+++ new/roast-8.1.0/Cargo.toml  1970-01-01 01:00:00.000000000 +0100
@@ -1,6 +1,6 @@
 [workspace.package]
 authors = ["Soc Virnyl Estela"]
-version = "8.0.0"
+version = "8.1.0"
 edition = "2024"
 license = "MPL-2.0"
 repository = "https://codeberg.org/Rusty-Geckos/roast";
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/roast-8.0.0/README.md new/roast-8.1.0/README.md
--- old/roast-8.0.0/README.md   1970-01-01 01:00:00.000000000 +0100
+++ new/roast-8.1.0/README.md   1970-01-01 01:00:00.000000000 +0100
@@ -80,9 +80,76 @@
 `roast_scm` is an extended utility of `roast`. Its purpose is to create 
tarballs from a
 remote repository. The behaviour is similar to `roast` but only at some point.
 
-As of now, the filename MUST INCLUDE the extension. We might want to change 
this behaviour since
-`--outfile` has a type `Option<PathBuf>`. Hence, if not provided, it will try 
to base
-the output file's filename from the project name and the revision (i.e. commit 
hash or tag).
+### With OBS Feature enabled
+
+> [!NOTE]
+> This feature is to be used only for [OBS](https://openbuildservice.org/) and 
only affects
+> the `roast_scm` library and binary.
+>
+> Do remember that `raw`, `roast`, and `recomprizz` can be used for OBS even 
without the feature flag.
+
+If `roast-cli` was compiled with `obs` feature, you can *rewrite* the 
"revision" part
+of the filename. Since versions in a specfile should be in this format, 
`a.b.c`, where
+`a` must be a numeric string while `b` and `c` can be alphanumeric, a revision 
such
+as a tag with names like `v7.0.0` is not considered a valid version string, 
despite
+that it obviously indicates a version.
+
+To make it a valid version string for a specfile, the `versionrewriteregex`
+must have a value like `^v?(.*)` (cause sometimes, the developer forgots to 
add a letter "v").
+Then rearrange the string based on the regex by indicating the capture groups. 
You can pass
+this pattern of rearrangement to replace the old string value to 
`versionrewritepattern`.
+The value for `versionrewritepattern` is "$1".
+
+> [!IMPORTANT]
+> This regex replacement format for the `--versionrewritepattern` is based on 
the
+> [regex crate](https://docs.rs/crate/regex/latest)
+> [example](https://docs.rs/regex/latest/regex/struct.Regex.html#example-10).
+>
+> Capture groups are denoted by `$` and a number based on their position
+> from other capture groups starting from the left-most side of the string.
+
+Since `roast_scm` is intended to be an OBS Service,
+an example `_service` file for this scenario will look like this.
+
+```xml
+<services>
+  <service name="roast_scm" mode="manual">
+    <param 
name="src">https://github.com/openSUSE-Rust/obs-service-cargo</param>
+    <param name="versionrewriteregex">^v?(.*)</param>
+    <param name="versionrewritepattern">${1}</param>
+    <param name="revision">v7.0.0</param>
+  </service>
+</services>
+```
+
+In case that it is impossible to create a valid version, you can hard-code it
+using the `set-version` flag. There is also a `set-name` flag to hard-code
+the filename. This will only rename the filename excluding the file extension.
+
+> [!NOTE]
+> One can use `outfile` flag to hard code the FULL filename.
+
+#### Changelog generation
+
+Optionally, you can pass a value to `changesgenerate`, either `true` or 
`false`.
+
+If set to `true`, one must provide a value to `changesauthor`. This is to 
create
+a timestamp + author as a changelog header. This contains a record of who 
generated
+the tarball. There is an optional `changesemail` flag that you can use to pass
+an email address as well.
+
+Just below the changelog header are the list of commit summaries from the git
+repository. The list starts from the target revision until the most recent
+tag. If there is no tag at all, it starts from the target revision until
+the first initial commit.
+
+The resulting changelog filename is based on the resulting filename of the
+generated tarball e.g. `source.tar.zst` will have a changelog filename of
+`source.changes`. You can hard-code a full filename by passing a value to
+`changesoutfile`.
+
+If the destination `.changes` file exists, the new changelog will be prepended
+with the old contents of the file.
 
 ## Raw - How it works
 
@@ -95,18 +162,61 @@
 target tarball before it creates a new tarball of a different compression 
option e.g. `source.tar.gz`
 to `source.tar.zst`. The renaming scheme is too dumb and simple though, and 
not perfect—see note below.
 
-> [!NOTE]
-> When using `recomprizz`, files with filenames like `package-1.2.3.tar.gz` 
will have
-> the number parts of their names preserved i.e. `package-1.2.3.tar.gz` -> 
`package-1.2.3.tar.zst`.
-> However, filenames with letters after the numbers will be removed especially 
for version part
-> of the filenames are tagged as `alpha` or `beta`. For example, 
`package-1.2.3.alpha.tar.gz` will
-> turn into `package-1.2.3.tar.zst`. This is a limitation with the renaming 
logic. The solution is
-> to use the `-R` or `--rename` flag to hardcode the new name. So a command 
like
-> ```
-> recomprizz -t package-1.2.3.alpha.tar.gz -R package-1.2.3.alpha
-> ```
-> should fix the issue. **However, I think the better option is to just 
hardcode it, regardless**.
+You might want to _rename_ the resulting output file with `recomprizz`. There 
are two flags you should
+know:
+- `--rename`
+- `--renamepattern`
+
+The `--rename` flag can be used to either hard-code a filename or use a valid 
regex which can be used
+for `--renamepattern`.
+
+The `--renamepattern` should be a string that contains the *capture groups* 
based on the regex you
+passed to `--rename`.
+
+For example, you want to rename `roast.tar.zst` to `raw.tar.zst`, then
+you can just hard-code it by just passing "raw" to `--rename`. In another
+example, you want to rename `source.tar.zst` to `marvelous-source.tar.zst`,
+then you must first pass a valid regex to `--rename` like `(.*).tar.zst`,
+and the `--renamepattern` should be `marvelous-${1}.tar.zst`. Of course,
+since you are going to use some form of shell like bash to run the commands,
+you must escape `$` like so -> `\${1}`.
+
+> [!IMPORTANT]
+> This regex replacement format for the `--renamepattern` is based on the
+> [regex crate](https://docs.rs/crate/regex/latest)
+> [example](https://docs.rs/regex/latest/regex/struct.Regex.html#example-10).
+>
+> Capture groups are denoted by `$` and a number based on their position
+> from other capture groups starting from the left-most side of the string.
+
+The difference between hard-coded vs regex is that when hard-coded, you just
+need to pass a desired name EXCLUDING the file extensions. However, if the
+target file has no file extension, the recompressed output file will have
+a file extension based on the compression option which defaults to `.tar.zst`.
+
+If `--rename` has a regex, then `--renamepattern` should have a value. **The
+constructed regex should encompass the whole filename** e.g. a filename of 
`vendor.tar.zst`
+with a `--rename` regex value of `(.*)` and `--compression` of "gz" will have 
an output
+filename of `vendor.tar.zst.tar.gz`. Hence, be careful on how you construct 
your regex.
+
+
+> [!WARNING]
+> If you accidentally pass a string with no regex to `--rename` flag
+> and then pass a string as well with `--renamepattern`, the rename might 
result
+> in an undesirable output. That is NOT A BUG.
+
+> [!IMPORTANT]
+> Since `recomprizz` can be used without the `--rename` flag, filenames that
+> do not follow the usual file extensions with their supported formats
+> will be forced to retain its old filename but with a new file extension
+> based on the value of the compression option e.g.
+> a target file `vendor.tar.wrong.ext` will have an output file
+> `vendor.tar.wrong.ext.tar.gz`. A zstd compressed tarball with filename
+> `vendor.tar.gz` that is recompressed as a gz file will have an output 
filename
+> of `vendor.tar.gz.tar.gz`.
 >
+> Files with the correct file extension and mime-type will have a desired
+> output filename.
 
 # Service files are in the following with descriptions.
 
@@ -116,7 +226,8 @@
 - [roast.service](./roast.service)
 
 > [!NOTE]
-> The options will differ `roast_scm.service` in the service file since those 
options only exist if the `obs` feature was enabled.
+> The behaviours might differ in `roast_scm.service` if roast was compiled 
with `obs` feature. This additional feature flag
+> will update the version from a target specfile.
 
 It maps when you run the following commands
 - `raw -h`
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/roast-8.0.0/libroast/src/operations/cli.rs 
new/roast-8.1.0/libroast/src/operations/cli.rs
--- old/roast-8.0.0/libroast/src/operations/cli.rs      1970-01-01 
01:00:00.000000000 +0100
+++ new/roast-8.1.0/libroast/src/operations/cli.rs      1970-01-01 
01:00:00.000000000 +0100
@@ -216,7 +216,6 @@
     pub ignore_hidden: bool,
 }
 
-#[cfg(not(feature = "obs"))]
 #[derive(Debug, Parser)]
 #[command(
     name = "roast-scm",
@@ -231,132 +230,29 @@
 )]
 pub struct RoastScmArgs
 {
-    #[arg(long, short = 'C', action = clap::ArgAction::Set, default_value_t = 
false, help = "Whether to generate or update a changelog file or not.")]
+    #[arg(long, requires_if("true", "changesauthor"), short = 'C', action = 
clap::ArgAction::Set, default_value_t = false, help = "Whether to generate or 
update a changelog file or not.")]
     pub changesgenerate: bool,
     #[arg(
         long,
         short = 'A',
-        requires_if("changesgenerate", "true"),
+        requires = "changesgenerate",
         help = "Author to include during the changelog generation."
     )]
     pub changesauthor: Option<String>,
-    #[arg(long, short = 'e', help = "Email of author to include during the 
changelog generation.")]
-    pub changesemail: Option<String>,
-    #[arg(
-        long,
-        alias = "caof",
-        requires_if("changesgenerate", "true"),
-        help = "Whether to specify a path to the changes file. Otherwise, it 
is the current \
-                directory and the filename is the same filename prefix of the 
generated tarball \
-                e.g. `source.tar.xz` will have `source.changes` file. If file 
exists, append the \
-                newest changes to the top-most part of the text file."
-    )]
-    pub changesoutfile: Option<PathBuf>,
-    #[arg(long, short = 'U', help = "Remote URL to the git repository.", alias 
= "url")]
-    pub git_repository_url: String,
-    #[arg(
-        long,
-        short = 'E',
-        help = "Additional paths such as files or directories from within 
target repository's \
-                work directory to exclude when generating the archive."
-    )]
-    pub exclude: Option<Vec<PathBuf>>,
-    #[arg(
-        long,
-        help = "Revision or tag. It can also be a specific commit hash or 
branch. Supports 
<https://git-scm.com/docs/git-rev-parse.html#_specifying_revisions>."
-    )]
-    pub revision: String,
     #[arg(
         long,
-        help = "Pass a regex with capture groups. Required by 
`versionrewritepattern` flag. Each \
-                capture group is labelled through increments of 1.",
-        requires = "versionrewritepattern"
+        requires = "changesauthor",
+        short = 'e',
+        help = "Email of author to include during the changelog generation."
     )]
-    pub versionrewriteregex: Option<String>,
-    #[arg(long, help = "Pass a pattern from the capture groups from 
`versionrewriteregex` flag.")]
-    pub versionrewritepattern: Option<String>,
-    #[arg(
-        long, default_value_t = 0,
-        action = clap::ArgAction::Set,
-        help = "The depth of cloning the repository.")]
-    pub depth: i32,
-    #[arg(
-        long, default_value_t = true,
-        action = clap::ArgAction::Set,
-        help = "Whether the cloned repository should be deleted or not after 
the operation."
-    )]
-    pub is_temporary: bool,
-    #[arg(
-        long,
-        short = 'f',
-        help = "Output file of the generated archive with path. If not 
provided, attempts to \
-                write the filename based on project name and revision based on 
<https://en.opensuse.org/openSUSE:Package_versioning_guidelines>."
-    )]
-    pub outfile: Option<PathBuf>,
-    #[arg(long, short = 'd', help = "Output path of the generated archive.")]
-    pub outdir: Option<PathBuf>,
-    #[arg(
-        long,
-        short = 'r',
-        help = "Allow reproducibility for Reproducible Builds.",
-        default_value_t = false,
-        action = clap::ArgAction::Set
-    )]
-    pub reproducible: bool,
-    #[arg(
-        long,
-        short = 'g',
-        help = "Whether to ignore git related metadata, files and 
directories.",
-        default_value_t = true,
-        action = clap::ArgAction::Set
-    )]
-    pub ignore_git: bool,
-    #[arg(
-        long,
-        short = 'I',
-        help = "Whether to ignore hidden directories and files or what we call 
dotfiles. Does not affect `--ignore-git`.",
-        default_value_t = false,
-        action = clap::ArgAction::Set
-    )]
-    pub ignore_hidden: bool,
-    #[arg(long, short = 'c', help = "Compression to use.", default_value_t)]
-    pub compression: Compression,
-}
-
-#[cfg(feature = "obs")]
-#[derive(Debug, Parser)]
-#[command(
-    name = "roast-scm",
-    author = "Soc Virnyl Estela",
-    about = "Create archive tarballs from remote git repositories.",
-    after_long_help = "Set verbosity and tracing through `RUST_LOG` 
environmental variable e.g. \
-                       `RUST_LOG=trace`",
-    help_template = "{name} {version} - \
-                     
{about}\n\n{usage}\n\n{all-args}\n{after-help}\nMaintained by {author} \
-                     <cont...@uncomfyhalomacro.pl>.",
-    version
-)]
-pub struct RoastScmArgs
-{
-    #[arg(long, short = 'C', action = clap::ArgAction::Set, default_value_t = 
false, help = "Whether to generate or update a changelog file or not.")]
-    pub changesgenerate: bool,
-    #[arg(
-        long,
-        short = 'A',
-        requires_if("changesgenerate", "true"),
-        help = "Author to include during the changelog generation."
-    )]
-    pub changesauthor: Option<String>,
-    #[arg(long, short = 'e', help = "Email of author to include during the 
changelog generation.")]
     pub changesemail: Option<String>,
     #[arg(
         long,
         alias = "caof",
-        requires_if("changesgenerate", "true"),
         help = "Whether to specify a path to the changes file. Otherwise, it 
is the current \
                 directory and the filename is the same filename prefix of the 
generated tarball \
-                e.g. `source.tar.xz` will have `source.changes` file. If file 
exists, append the \
-                newest changes to the top-most part of the text file."
+                e.g. `source.tar.xz` will have `source.changes` file. If file 
exists, it prepends \
+                the newest changes to the top-most part of the text file."
     )]
     pub changesoutfile: Option<PathBuf>,
     #[arg(
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/roast-8.0.0/libroast/src/operations/roast_scm/mod.rs 
new/roast-8.1.0/libroast/src/operations/roast_scm/mod.rs
--- old/roast-8.0.0/libroast/src/operations/roast_scm/mod.rs    1970-01-01 
01:00:00.000000000 +0100
+++ new/roast-8.1.0/libroast/src/operations/roast_scm/mod.rs    1970-01-01 
01:00:00.000000000 +0100
@@ -892,7 +892,6 @@
     Ok(())
 }
 
-#[cfg(feature = "obs")]
 fn set_version_in_specfile(
     hard_coded_version: &Option<String>,
     from_formatted_revision: &str,
@@ -1033,13 +1032,6 @@
     let final_revision_format =
         rewrite_version_or_revision_from_changelog_details(&changelog_details, 
roast_scm_args)?;
 
-    #[cfg(not(feature = "obs"))]
-    let filename_prefix = process_filename_from_url_and_revision(
-        &roast_scm_args.git_repository_url,
-        &final_revision_format,
-    )?;
-
-    #[cfg(feature = "obs")]
     let filename_prefix = if let Some(set_name) = &roast_scm_args.set_name
     {
         if let Some(set_version) = &roast_scm_args.set_version
@@ -1098,8 +1090,10 @@
         .map(|_| {
             generate_changelog_file(roast_scm_args, &changelog_details, 
&final_revision_format)?;
 
-            #[cfg(feature = "obs")]
-            set_version_in_specfile(&roast_scm_args.set_version, 
&final_revision_format)?;
+            if cfg!(feature = "obs")
+            {
+                set_version_in_specfile(&roast_scm_args.set_version, 
&final_revision_format)?;
+            }
 
             if !roast_scm_args.is_temporary
             {
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/roast-8.0.0/libroast/tests/scm.rs 
new/roast-8.1.0/libroast/tests/scm.rs
--- old/roast-8.0.0/libroast/tests/scm.rs       1970-01-01 01:00:00.000000000 
+0100
+++ new/roast-8.1.0/libroast/tests/scm.rs       1970-01-01 01:00:00.000000000 
+0100
@@ -36,6 +36,8 @@
     let mut hasher2 = Keccak256::new();
     let outdir = tmp_binding.path();
     let r1 = RoastScmArgs {
+        set_version: None,
+        set_name: None,
         changesgenerate: false,
         changesauthor: None,
         changesemail: None,
@@ -58,6 +60,8 @@
     let buf1 = read(outdir.join("r1.tar.zst"))?;
     hasher1.update(buf1);
     let r2 = RoastScmArgs {
+        set_version: None,
+        set_name: None,
         changesgenerate: false,
         changesauthor: None,
         changesemail: None,
@@ -99,6 +103,8 @@
     let outdir1 = tmp_binding1.path();
     let outdir2 = tmp_binding2.path();
     let r1 = RoastScmArgs {
+        set_version: None,
+        set_name: None,
         changesgenerate: false,
         changesauthor: None,
         changesemail: None,
@@ -119,6 +125,8 @@
     };
     libroast::operations::roast_scm::roast_scm_opts(None, &r1, false)?;
     let r2 = RoastScmArgs {
+        set_version: None,
+        set_name: None,
         changesgenerate: false,
         changesauthor: None,
         changesemail: None,
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/roast-8.0.0/roast_scm.service 
new/roast-8.1.0/roast_scm.service
--- old/roast-8.0.0/roast_scm.service   1970-01-01 01:00:00.000000000 +0100
+++ new/roast-8.1.0/roast_scm.service   1970-01-01 01:00:00.000000000 +0100
@@ -19,7 +19,7 @@
    <parameter name="changesoutfile">
       <description> Whether to specify a path to the changes file. Otherwise, 
it is the current directory and the
       filename is the same filename prefix of the generated tarball e.g. 
`source.tar.xz` will have `source.changes`
-      file. If file exists, append the newest changes to the top-most part of 
the text file.</description>
+      file. If file exists, it prepends the newest changes to the top-most 
part of the text file.</description>
    </parameter>
    <parameter name="set-version">
       <description>Whether to hard code the version or not. Set it to hard 
code one, otherwise, it will use the generated version internally.</description>

++++++ vendor.tar.zst ++++++
/work/SRC/openSUSE:Factory/roast/vendor.tar.zst 
/work/SRC/openSUSE:Factory/.roast.new.19631/vendor.tar.zst differ: char 7, line 
1

Reply via email to