Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package yast2-iscsi-client for
openSUSE:Factory checked in at 2025-07-25 17:04:19
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-iscsi-client (Old)
and /work/SRC/openSUSE:Factory/.yast2-iscsi-client.new.13279 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-iscsi-client"
Fri Jul 25 17:04:19 2025 rev:151 rq:1295530 version:5.0.9
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-iscsi-client/yast2-iscsi-client.changes
2025-07-06 17:00:30.880576614 +0200
+++
/work/SRC/openSUSE:Factory/.yast2-iscsi-client.new.13279/yast2-iscsi-client.changes
2025-07-25 17:04:50.104042188 +0200
@@ -1,0 +2,12 @@
+Wed Jul 23 10:38:00 UTC 2025 - Stefan Hundhammer <shundham...@suse.com>
+
+- Ensure to hide passwords (bsc#1246833)
+- 5.0.9
+
+-------------------------------------------------------------------
+Wed Jul 23 10:00:00 UTC 2025 - Knut Alejandro Anderssen González
<kanders...@suse.com>
+
+- Do not filter netcard cards by iscsioffload feature as for example
+ it is not present in qede/qedi devices (bsc#1236433).
+
+-------------------------------------------------------------------
Old:
----
yast2-iscsi-client-5.0.8.tar.bz2
New:
----
yast2-iscsi-client-5.0.9.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-iscsi-client.spec ++++++
--- /var/tmp/diff_new_pack.xxmcRQ/_old 2025-07-25 17:04:50.536060114 +0200
+++ /var/tmp/diff_new_pack.xxmcRQ/_new 2025-07-25 17:04:50.540060280 +0200
@@ -17,7 +17,7 @@
Name: yast2-iscsi-client
-Version: 5.0.8
+Version: 5.0.9
Release: 0
Summary: YaST2 - iSCSI Client Configuration
License: GPL-2.0-only
++++++ yast2-iscsi-client-5.0.8.tar.bz2 -> yast2-iscsi-client-5.0.9.tar.bz2
++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-iscsi-client-5.0.8/package/yast2-iscsi-client.changes
new/yast2-iscsi-client-5.0.9/package/yast2-iscsi-client.changes
--- old/yast2-iscsi-client-5.0.8/package/yast2-iscsi-client.changes
2025-07-03 16:12:40.000000000 +0200
+++ new/yast2-iscsi-client-5.0.9/package/yast2-iscsi-client.changes
2025-07-24 13:21:09.000000000 +0200
@@ -1,4 +1,16 @@
-------------------------------------------------------------------
+Wed Jul 23 10:38:00 UTC 2025 - Stefan Hundhammer <shundham...@suse.com>
+
+- Ensure to hide passwords (bsc#1246833)
+- 5.0.9
+
+-------------------------------------------------------------------
+Wed Jul 23 10:00:00 UTC 2025 - Knut Alejandro Anderssen González
<kanders...@suse.com>
+
+- Do not filter netcard cards by iscsioffload feature as for example
+ it is not present in qede/qedi devices (bsc#1236433).
+
+-------------------------------------------------------------------
Thu Jul 3 13:24:33 UTC 2025 - José Iván López González <jlo...@suse.com>
- Avoid exception if discovering from a portal fails (related to
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-iscsi-client-5.0.8/package/yast2-iscsi-client.spec
new/yast2-iscsi-client-5.0.9/package/yast2-iscsi-client.spec
--- old/yast2-iscsi-client-5.0.8/package/yast2-iscsi-client.spec
2025-07-03 16:12:40.000000000 +0200
+++ new/yast2-iscsi-client-5.0.9/package/yast2-iscsi-client.spec
2025-07-24 13:21:09.000000000 +0200
@@ -17,7 +17,7 @@
Name: yast2-iscsi-client
-Version: 5.0.8
+Version: 5.0.9
Release: 0
Summary: YaST2 - iSCSI Client Configuration
License: GPL-2.0-only
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-iscsi-client-5.0.8/src/modules/IscsiClientLib.rb
new/yast2-iscsi-client-5.0.9/src/modules/IscsiClientLib.rb
--- old/yast2-iscsi-client-5.0.8/src/modules/IscsiClientLib.rb 2025-07-03
16:12:40.000000000 +0200
+++ new/yast2-iscsi-client-5.0.9/src/modules/IscsiClientLib.rb 2025-07-24
13:21:09.000000000 +0200
@@ -287,7 +287,7 @@
def hidePassword(orig)
hidden = deep_copy(orig)
hidden.each do |key, _value|
- next unless key.include?("PASS")
+ next unless key =~ /pass/i
hidden[key] = "*****"
end
hidden
@@ -1435,7 +1435,12 @@
#
# @return [Boolean]
def iscsiuio_relevant?
- (ISCSIUIO_MODULES & GetOffloadModules()).any?
+ # qedi devices could not have any network device associated with it
therefore reading the
+ # system netcard could be wrong and in that case we will check also the
configured iscsi
+ # ifaces (bsc#1236433).
+ configured = (@iface_file || {}).values.map { |i| i[:transport] }.uniq
+
+ (ISCSIUIO_MODULES & (GetOffloadModules() | configured)).any?
end
# Loads the kernel modules needed to configure the iscsi client
@@ -1544,7 +1549,7 @@
def potential_offload_cards
# Store into hw_mods information about all the cards in the system
cards = SCR.Read(path(".probe.netcard"))
- hw_mods = cards.select { |c| c["iscsioffload"] }.map do |c|
+ hw_mods = cards.map do |c|
log.info "GetOffloadItems card:#{c}"
hw_mod = {
"modules" => netcard_modules(c),
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-iscsi-client-5.0.8/test/iscsi_client_lib_test.rb
new/yast2-iscsi-client-5.0.9/test/iscsi_client_lib_test.rb
--- old/yast2-iscsi-client-5.0.8/test/iscsi_client_lib_test.rb 2025-07-03
16:12:40.000000000 +0200
+++ new/yast2-iscsi-client-5.0.9/test/iscsi_client_lib_test.rb 2025-07-24
13:21:09.000000000 +0200
@@ -1060,4 +1060,23 @@
end
end
end
+
+ describe "#hidePassword" do
+ let(:orig) do
+ {
+ "node.name" => "my.node",
+ "harm.less" => "harmless",
+ "auth.password" => "s3cr3t",
+ "auth.PASSWORD" => "s3cr3t"
+ }
+ end
+
+ it "hides passwords and only passwords" do
+ hidden = Yast::IscsiClientLib.hidePassword(orig)
+
+ expect(hidden["harm.less"]).to eq("harmless")
+ expect(hidden["auth.PASSWORD"]).not_to include("s3cr3t")
+ expect(hidden["auth.password"]).not_to include("s3cr3t")
+ end
+ end
end
