Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package kf6-kcodecs for openSUSE:Factory checked in at 2025-08-09 19:57:40 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/kf6-kcodecs (Old) and /work/SRC/openSUSE:Factory/.kf6-kcodecs.new.1085 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "kf6-kcodecs" Sat Aug 9 19:57:40 2025 rev:18 rq:1298524 version:6.17.0 Changes: -------- --- /work/SRC/openSUSE:Factory/kf6-kcodecs/kf6-kcodecs.changes 2025-07-14 10:52:25.770444589 +0200 +++ /work/SRC/openSUSE:Factory/.kf6-kcodecs.new.1085/kf6-kcodecs.changes 2025-08-09 20:02:32.225040558 +0200 @@ -1,0 +2,22 @@ +Mon Aug 4 06:57:22 UTC 2025 - Christophe Marin <christo...@krop.fr> + +- Update to 6.17.0 + * New feature release + * For more details please see: + * https://kde.org/announcements/frameworks/6/6.17.0 +- Changes since 6.16.0: + * Update dependency version to 6.17.0 + * [KEncodingProberTest] Add more test cases for UTF-16 + * [KEncodingProber] Remove bogus global static state from UTF-16 probing + * [KEncodingProberTest] Document UTF-16 BOM probing is broken + * It compiles fine without qt 6.10 deprecated methods + * [KEncodingProber] Fix typo from automatic mass edit + * [KEncodingProber] Remove unused member variables + * [KEncodingProber] Remove unused, private `SetOp(t)ion` method from probers + * [KEncodingProberTest] Make probertest data driven + * [KEncodingProberTest] Embed small binary data test case + * [KEncodingProberTest] Remove unnecessary static variable, setup code + * [KEncodingProberTest] Move class declaration to implementation file + * Update version to 6.17.0 + +------------------------------------------------------------------- Old: ---- kcodecs-6.16.0.tar.xz kcodecs-6.16.0.tar.xz.sig New: ---- kcodecs-6.17.0.tar.xz kcodecs-6.17.0.tar.xz.sig ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ kf6-kcodecs.spec ++++++ --- /var/tmp/diff_new_pack.ut7W9k/_old 2025-08-09 20:02:33.117077613 +0200 +++ /var/tmp/diff_new_pack.ut7W9k/_new 2025-08-09 20:02:33.121077778 +0200 @@ -1,7 +1,7 @@ # # spec file for package kf6-kcodecs # -# Copyright (c) 2025 SUSE LLC +# Copyright (c) 2025 SUSE LLC and contributors # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -19,11 +19,11 @@ %define qt6_version 6.8.0 %define rname kcodecs -# Full KF6 version (e.g. 6.16.0) +# Full KF6 version (e.g. 6.17.0) %{!?_kf6_version: %global _kf6_version %{version}} %bcond_without released Name: kf6-kcodecs -Version: 6.16.0 +Version: 6.17.0 Release: 0 Summary: Method collection to manipulate strings using various encodings License: LGPL-2.1-or-later ++++++ kcodecs-6.16.0.tar.xz -> kcodecs-6.17.0.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kcodecs-6.16.0/CMakeLists.txt new/kcodecs-6.17.0/CMakeLists.txt --- old/kcodecs-6.16.0/CMakeLists.txt 2025-07-04 17:10:09.000000000 +0200 +++ new/kcodecs-6.17.0/CMakeLists.txt 2025-08-01 12:30:22.000000000 +0200 @@ -1,10 +1,10 @@ cmake_minimum_required(VERSION 3.16) -set(KF_VERSION "6.16.0") # handled by release scripts +set(KF_VERSION "6.17.0") # handled by release scripts project(KCodecs VERSION ${KF_VERSION}) include(FeatureSummary) -find_package(ECM 6.16.0 NO_MODULE) +find_package(ECM 6.17.0 NO_MODULE) set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake Modules." URL "https://commits.kde.org/extra-cmake-modules";) feature_summary(WHAT REQUIRED_PACKAGES_NOT_FOUND FATAL_ON_MISSING_REQUIRED_PACKAGES) @@ -40,7 +40,7 @@ ecm_install_po_files_as_qm(poqm) ecm_set_disabled_deprecation_versions( - QT 6.9.0 + QT 6.10.0 ) add_subdirectory(src) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kcodecs-6.16.0/autotests/codectest.cpp new/kcodecs-6.17.0/autotests/codectest.cpp --- old/kcodecs-6.16.0/autotests/codectest.cpp 2025-07-04 17:10:10.000000000 +0200 +++ new/kcodecs-6.17.0/autotests/codectest.cpp 2025-08-01 12:30:22.000000000 +0200 @@ -29,9 +29,9 @@ QTest::addColumn<QString>("tag"); QTest::addColumn<Mode>("mode"); - QString dataDir = QFINDTESTDATA("data/binary_data"); + QString dataDir = QFINDTESTDATA("data/codec_b"); QVERIFY(!dataDir.isEmpty()); - dataDir.chop(QByteArrayView("binary_data").size()); + dataDir.chop(QByteArrayView("codec_b").size()); QDir codecBaseDir(dataDir); const QStringList lst = codecBaseDir.entryList(QStringList(), QDir::Dirs | QDir::NoDotAndDotDot, QDir::NoSort); for (const QString &dir : lst) { Binary files old/kcodecs-6.16.0/autotests/data/binary_data and new/kcodecs-6.17.0/autotests/data/binary_data differ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kcodecs-6.16.0/autotests/kencodingprobertest.cpp new/kcodecs-6.17.0/autotests/kencodingprobertest.cpp --- old/kcodecs-6.16.0/autotests/kencodingprobertest.cpp 2025-07-04 17:10:10.000000000 +0200 +++ new/kcodecs-6.17.0/autotests/kencodingprobertest.cpp 2025-08-01 12:30:22.000000000 +0200 @@ -4,32 +4,21 @@ SPDX-License-Identifier: GPL-2.0-or-later */ -#include "kencodingprobertest.h" - -#include <QDir> #include <QTest> #include <kencodingprober.h> -static KEncodingProber *ep = nullptr; - -void KEncodingProberTest::initTestCase() -{ - ep = new KEncodingProber; -} - -void KEncodingProberTest::cleanupTestCase() +class KEncodingProberTest : public QObject { - delete ep; - ep = nullptr; -} - -void KEncodingProberTest::cleanup() -{ - ep->reset(); -} + Q_OBJECT +private Q_SLOTS: + void testReset(); + void testProbe(); + void testProbe_data(); +}; void KEncodingProberTest::testReset() { + auto ep = std::make_unique<KEncodingProber>(); ep->feed(QByteArray("some random data @*@#&jd")); ep->reset(); QCOMPARE(ep->state(), KEncodingProber::Probing); @@ -38,42 +27,83 @@ void KEncodingProberTest::testProbe() { - // utf-8 - ep->setProberType(KEncodingProber::Universal); - ep->feed(QByteArray::fromHex("e998bfe5b094e58d91e696afe5b1b1e88489")); - QCOMPARE(ep->encoding().toLower(), QByteArray("utf-8")); - ep->reset(); - - // gb18030 - ep->setProberType(KEncodingProber::ChineseSimplified); - ep->feed(QByteArray::fromHex("d7d4d3c9b5c4b0d9bfc6c8abcae9")); - QCOMPARE(ep->encoding().toLower(), QByteArray("gb18030")); - ep->reset(); - - // shift_jis - ep->setProberType(KEncodingProber::Japanese); - ep->feed(QByteArray::fromHex("8374838a815b955389c88e969354")); - QCOMPARE(ep->encoding().toLower(), QByteArray("shift_jis")); - ep->reset(); + QFETCH(QByteArray, data); + QFETCH(KEncodingProber::ProberType, proberType); + QFETCH(QByteArray, encoding); + + KEncodingProber ep(proberType); + QCOMPARE(ep.proberType(), proberType); + ep.feed(data); + + QEXPECT_FAIL("BOM UTF-16LE", "BOM detected but ignored", Continue); + QEXPECT_FAIL("BOM UTF-16BE", "BOM detected but ignored", Continue); + QEXPECT_FAIL("UTF-16LE Unicode", "UTF-16BE preferred unless erroneous", Continue); + QEXPECT_FAIL("UTF-16LE Unicode definite 1", "UTF-16BE invalid surrogate ignored", Continue); + QEXPECT_FAIL("UTF-16BE Unicode definite 2", "UTF-16BE valid code misdetected", Continue); + QEXPECT_FAIL("UTF-16LE Unicode definite 2", "UTF-16LE valid code misdetected", Continue); + QCOMPARE(ep.encoding().toLower(), encoding); +} - // big5 - ep->setProberType(KEncodingProber::ChineseTraditional); - ep->feed(QByteArray::fromHex("aefcafc7a6caa474a141a6b3ae65a444a46a")); - QCOMPARE(ep->encoding().toLower(), QByteArray("big5")); - ep->reset(); +void KEncodingProberTest::testProbe_data() +{ + QTest::addColumn<QByteArray>("data"); + QTest::addColumn<KEncodingProber::ProberType>("proberType"); + QTest::addColumn<QByteArray>("encoding"); + + QTest::addRow("utf-8") // + << QByteArray::fromHex("e998bfe5b094e58d91e696afe5b1b1e88489") // + << KEncodingProber::Universal << QByteArray("utf-8"); + + QTest::addRow("gb18030") // + << QByteArray::fromHex("d7d4d3c9b5c4b0d9bfc6c8abcae9") // + << KEncodingProber::ChineseSimplified << QByteArray("gb18030"); + + QTest::addRow("shift_jis") // + << QByteArray::fromHex("8374838a815b955389c88e969354") // + << KEncodingProber::Japanese << QByteArray("shift_jis"); + + QTest::addRow("big5") // + << QByteArray::fromHex("aefcafc7a6caa474a141a6b3ae65a444a46a") // + << KEncodingProber::ChineseTraditional << QByteArray("big5"); // binary data, just make sure we do not crash (cf. crash in bug #357341) - const QString binaryFile = QFINDTESTDATA("data/binary_data"); - QVERIFY(!binaryFile.isEmpty()); - QFile file(binaryFile); - QVERIFY(file.open(QIODevice::ReadOnly)); - QByteArray binaryData(file.readAll()); - ep->setProberType(KEncodingProber::Universal); - ep->feed(binaryData); - QCOMPARE(ep->encoding().toLower(), QByteArray("utf-8")); - ep->reset(); + const auto binaryData = QByteArray::fromBase64( // + "4QEAAAAOAAAAgVBYVIp1X0cQSZ67QGBARKLmgwFdRqxVgwJbyCougwNVrEZdiARNdogFmAScBkph" + "Y2sgQXVkaW9DRIEHK4JhWg0OvPK2SjYuwNZv1ogI/xOICf8TgxUZjO5WiREAnBJIZWxsbyB2MC41" + "MGGIE1DD"); + QTest::addRow("binaryData") // + << binaryData << KEncodingProber::Universal << QByteArray("utf-8"); + + QTest::addRow("BOM UTF-8") // + << QByteArray("\xef\xbb\xbfZ", 4) // "<UTF-8 BOM>Z" + << KEncodingProber::Universal << QByteArray("utf-8"); + QTest::addRow("BOM UTF-16BE") // + << QByteArray("\xfe\xff\x00Z", 4) // "<UTF-16BE BOM>Z" + << KEncodingProber::Universal << QByteArray("utf-16be"); + QTest::addRow("BOM UTF-16LE") // + << QByteArray("\xff\xfeZ\x00", 4) // "<UTF-16LE BOM>Z" + << KEncodingProber::Universal << QByteArray("utf-16le"); + + QTest::addRow("UTF-16BE Unicode") // + << QByteArray("\x00\x0a\x00\xc4\x00\xd6", 6) // "\nÄÖ" + << KEncodingProber::Unicode << QByteArray("utf-16be"); + QTest::addRow("UTF-16LE Unicode") // + << QByteArray("\x0a\x00\xc4\x00\xd6\x00", 6) // "\nÄÖ" + << KEncodingProber::Unicode << QByteArray("utf-16le"); + QTest::addRow("UTF-16BE Unicode definite 1") // + << QByteArray("\x00\xdc\x00\x20", 4) // "Ü " + << KEncodingProber::Unicode << QByteArray("utf-16be"); + QTest::addRow("UTF-16LE Unicode definite 1") // + << QByteArray("\xdc\x00\x20\x00", 4) // "Ü " + << KEncodingProber::Unicode << QByteArray("utf-16le"); + QTest::addRow("UTF-16BE Unicode definite 2") // + << QByteArray("\xc4\x00\x2a\x00\x00\xdc", 6) // "Ä*<inv>" or "쐀⨀Ü" + << KEncodingProber::Unicode << QByteArray("utf-16be"); + QTest::addRow("UTF-16LE Unicode definite 2") // + << QByteArray("\x00\xc4\x00\x2a\xdc\x00", 6) // "Ä*<inv>" or "쐀⨀Ü" + << KEncodingProber::Unicode << QByteArray("utf-16le"); } QTEST_MAIN(KEncodingProberTest) -#include "moc_kencodingprobertest.cpp" +#include "kencodingprobertest.moc" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kcodecs-6.16.0/autotests/kencodingprobertest.h new/kcodecs-6.17.0/autotests/kencodingprobertest.h --- old/kcodecs-6.16.0/autotests/kencodingprobertest.h 2025-07-04 17:10:10.000000000 +0200 +++ new/kcodecs-6.17.0/autotests/kencodingprobertest.h 1970-01-01 01:00:00.000000000 +0100 @@ -1,23 +0,0 @@ -/* - SPDX-FileCopyrightText: 2012 Ni Hui <shuizhuyuan...@126.com> - - SPDX-License-Identifier: GPL-2.0-or-later -*/ - -#ifndef KENCODINGPROBERTEST_H -#define KENCODINGPROBERTEST_H - -#include <QObject> - -class KEncodingProberTest : public QObject -{ - Q_OBJECT -private Q_SLOTS: - void initTestCase(); - void cleanupTestCase(); - void cleanup(); - void testReset(); - void testProbe(); -}; - -#endif // KENCODINGPROBERTEST_H diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kcodecs-6.16.0/src/probers/CharDistribution.h new/kcodecs-6.17.0/src/probers/CharDistribution.h --- old/kcodecs-6.16.0/src/probers/CharDistribution.h 2025-07-04 17:10:10.000000000 +0200 +++ new/kcodecs-6.17.0/src/probers/CharDistribution.h 2025-08-01 12:30:22.000000000 +0200 @@ -61,12 +61,6 @@ mFreqChars = 0; } - // This function is for future extension. Caller can use this function to control - // analyser's behavior - void SetOpion() - { - } - // It is not necessary to receive all data to draw conclusion. For charset detection, // certain amount of data is enough bool GotEnoughData() diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kcodecs-6.16.0/src/probers/ChineseGroupProber.h new/kcodecs-6.17.0/src/probers/ChineseGroupProber.h --- old/kcodecs-6.16.0/src/probers/ChineseGroupProber.h 2025-07-04 17:10:10.000000000 +0200 +++ new/kcodecs-6.17.0/src/probers/ChineseGroupProber.h 2025-08-01 12:30:22.000000000 +0200 @@ -25,9 +25,6 @@ } void Reset(void) override; float GetConfidence(void) override; - void SetOpion() override - { - } #ifdef DEBUG_PROBE void DumpStatus() override; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kcodecs-6.16.0/src/probers/JapaneseGroupProber.h new/kcodecs-6.17.0/src/probers/JapaneseGroupProber.h --- old/kcodecs-6.16.0/src/probers/JapaneseGroupProber.h 2025-07-04 17:10:10.000000000 +0200 +++ new/kcodecs-6.17.0/src/probers/JapaneseGroupProber.h 2025-08-01 12:30:22.000000000 +0200 @@ -28,9 +28,6 @@ } void Reset(void) override; float GetConfidence(void) override; - void SetOpion() override - { - } #ifdef DEBUG_PROBE void DumpStatus() override; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kcodecs-6.16.0/src/probers/JpCntx.h new/kcodecs-6.17.0/src/probers/JpCntx.h --- old/kcodecs-6.16.0/src/probers/JpCntx.h 2025-07-04 17:10:10.000000000 +0200 +++ new/kcodecs-6.17.0/src/probers/JpCntx.h 2025-08-01 12:30:22.000000000 +0200 @@ -57,9 +57,6 @@ float GetConfidence(); void Reset(void); - void SetOpion() - { - } bool GotEnoughData() { return mTotalRel > ENOUGH_REL_THRESHOLD; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kcodecs-6.16.0/src/probers/UnicodeGroupProber.cpp new/kcodecs-6.17.0/src/probers/UnicodeGroupProber.cpp --- old/kcodecs-6.16.0/src/probers/UnicodeGroupProber.cpp 2025-07-04 17:10:10.000000000 +0200 +++ new/kcodecs-6.17.0/src/probers/UnicodeGroupProber.cpp 2025-08-01 12:30:22.000000000 +0200 @@ -41,46 +41,12 @@ nsProbingState UnicodeGroupProber::HandleData(const char *aBuf, unsigned int aLen) { nsSMState codingState; - static bool disableUTF16LE = false; - static bool disableUTF16BE = false; if (mActiveSM == 0 || aLen < 2) { mState = eNotMe; return mState; } - if (!(disableUTF16LE || disableUTF16BE)) { - if (aLen % 2 != 0) { - disableUTF16LE = true; - disableUTF16BE = true; - } - const uint weight_BOM = sqrt((double)aLen) + aLen / 10.0; - uint counts[5] = {0, 0, 0, 0, 0}; - for (uint i = 0; i < 5; i++) { - counts[i] = std::count(aBuf, aBuf + aLen, char(i)); - } - const double weight_zero = (2.0 * (counts[0] + counts[1] + counts[2] + counts[3] + counts[4]) + weight_BOM) / aLen; - if (weight_zero < log(1.4142)) { - disableUTF16LE = true; - disableUTF16BE = true; - } - if (4 >= aBuf[1] && aBuf[1] >= 0 && QChar::isPrint(static_cast<uint>(aBuf[0]))) { - disableUTF16BE = true; - } else { - disableUTF16LE = true; - } - if (disableUTF16BE) { - mActiveSM--; - } - if (disableUTF16LE) { - nsCodingStateMachine *t; - t = mCodingSM[1]; - mCodingSM[1] = mCodingSM[2]; - mCodingSM[2] = t; - mActiveSM--; - } - } - for (uint i = 0; i < aLen; ++i) { for (int j = mActiveSM - 1; j >= 0; --j) { // byte is feed to all active state machine diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kcodecs-6.16.0/src/probers/UnicodeGroupProber.h new/kcodecs-6.17.0/src/probers/UnicodeGroupProber.h --- old/kcodecs-6.16.0/src/probers/UnicodeGroupProber.h 2025-07-04 17:10:10.000000000 +0200 +++ new/kcodecs-6.17.0/src/probers/UnicodeGroupProber.h 2025-08-01 12:30:22.000000000 +0200 @@ -29,9 +29,6 @@ } void Reset(void) override; float GetConfidence() override; - void SetOpion() override - { - } #ifdef DEBUG_PROBE void DumpStatus() override; #endif diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kcodecs-6.16.0/src/probers/nsBig5Prober.h new/kcodecs-6.17.0/src/probers/nsBig5Prober.h --- old/kcodecs-6.16.0/src/probers/nsBig5Prober.h 2025-07-04 17:10:10.000000000 +0200 +++ new/kcodecs-6.17.0/src/probers/nsBig5Prober.h 2025-08-01 12:30:22.000000000 +0200 @@ -35,9 +35,6 @@ } void Reset(void) override; float GetConfidence(void) override; - void SetOpion() override - { - } protected: void GetDistribution(unsigned int aCharLen, const char *aStr); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kcodecs-6.16.0/src/probers/nsCharSetProber.h new/kcodecs-6.17.0/src/probers/nsCharSetProber.h --- old/kcodecs-6.16.0/src/probers/nsCharSetProber.h 2025-07-04 17:10:10.000000000 +0200 +++ new/kcodecs-6.17.0/src/probers/nsCharSetProber.h 2025-08-01 12:30:22.000000000 +0200 @@ -30,7 +30,6 @@ virtual nsProbingState GetState(void) = 0; virtual void Reset(void) = 0; virtual float GetConfidence(void) = 0; - virtual void SetOpion() = 0; #ifdef DEBUG_PROBE void DumpStatus() override diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kcodecs-6.16.0/src/probers/nsCodingStateMachine.h new/kcodecs-6.17.0/src/probers/nsCodingStateMachine.h --- old/kcodecs-6.16.0/src/probers/nsCodingStateMachine.h 2025-07-04 17:10:10.000000000 +0200 +++ new/kcodecs-6.17.0/src/probers/nsCodingStateMachine.h 2025-08-01 12:30:22.000000000 +0200 @@ -42,13 +42,13 @@ } nsSMState NextState(char c) { - // for each byte we get its class KCODECS_NO_EXPORT , if it is first byte, we also get byte length + // for each byte we get its class, if it is first byte, we also get byte length unsigned int byteCls = GETCLASS(c); if (mCurrentState == eStart) { mCurrentBytePos = 0; mCurrentCharLen = mModel->charLenTable[byteCls]; } - // from byte's class KCODECS_NO_EXPORT and stateTable, we get its next state + // from byte's class and stateTable, we get its next state mCurrentState = GETFROMPCK(mCurrentState * (mModel->classFactor) + byteCls, mModel->stateTable); mCurrentBytePos++; return mCurrentState; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kcodecs-6.16.0/src/probers/nsEUCJPProber.h new/kcodecs-6.17.0/src/probers/nsEUCJPProber.h --- old/kcodecs-6.16.0/src/probers/nsEUCJPProber.h 2025-07-04 17:10:10.000000000 +0200 +++ new/kcodecs-6.17.0/src/probers/nsEUCJPProber.h 2025-08-01 12:30:22.000000000 +0200 @@ -41,9 +41,6 @@ } void Reset(void) override; float GetConfidence(void) override; - void SetOpion() override - { - } protected: nsCodingStateMachine *mCodingSM; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kcodecs-6.16.0/src/probers/nsEUCKRProber.h new/kcodecs-6.17.0/src/probers/nsEUCKRProber.h --- old/kcodecs-6.16.0/src/probers/nsEUCKRProber.h 2025-07-04 17:10:10.000000000 +0200 +++ new/kcodecs-6.17.0/src/probers/nsEUCKRProber.h 2025-08-01 12:30:22.000000000 +0200 @@ -35,9 +35,6 @@ } void Reset(void) override; float GetConfidence(void) override; - void SetOpion() override - { - } protected: void GetDistribution(unsigned int aCharLen, const char *aStr); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kcodecs-6.16.0/src/probers/nsEscCharsetProber.h new/kcodecs-6.17.0/src/probers/nsEscCharsetProber.h --- old/kcodecs-6.16.0/src/probers/nsEscCharsetProber.h 2025-07-04 17:10:10.000000000 +0200 +++ new/kcodecs-6.17.0/src/probers/nsEscCharsetProber.h 2025-08-01 12:30:22.000000000 +0200 @@ -32,9 +32,6 @@ { return (float)0.99; } - void SetOpion() override - { - } protected: void GetDistribution(unsigned int aCharLen, const char *aStr); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kcodecs-6.16.0/src/probers/nsGB2312Prober.h new/kcodecs-6.17.0/src/probers/nsGB2312Prober.h --- old/kcodecs-6.16.0/src/probers/nsGB2312Prober.h 2025-07-04 17:10:10.000000000 +0200 +++ new/kcodecs-6.17.0/src/probers/nsGB2312Prober.h 2025-08-01 12:30:22.000000000 +0200 @@ -37,9 +37,6 @@ } void Reset(void) override; float GetConfidence(void) override; - void SetOpion() override - { - } protected: void GetDistribution(unsigned int aCharLen, const char *aStr); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kcodecs-6.16.0/src/probers/nsHebrewProber.h new/kcodecs-6.17.0/src/probers/nsHebrewProber.h --- old/kcodecs-6.16.0/src/probers/nsHebrewProber.h 2025-07-04 17:10:10.000000000 +0200 +++ new/kcodecs-6.17.0/src/probers/nsHebrewProber.h 2025-08-01 12:30:22.000000000 +0200 @@ -35,9 +35,6 @@ { return (float)0.0; } - void SetOpion() override - { - } void SetModelProbers(nsCharSetProber *logicalPrb, nsCharSetProber *visualPrb) { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kcodecs-6.16.0/src/probers/nsLatin1Prober.h new/kcodecs-6.17.0/src/probers/nsLatin1Prober.h --- old/kcodecs-6.16.0/src/probers/nsLatin1Prober.h 2025-07-04 17:10:10.000000000 +0200 +++ new/kcodecs-6.17.0/src/probers/nsLatin1Prober.h 2025-08-01 12:30:22.000000000 +0200 @@ -33,9 +33,6 @@ } void Reset(void) override; float GetConfidence(void) override; - void SetOpion() override - { - } #ifdef DEBUG_PROBE void DumpStatus() override; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kcodecs-6.16.0/src/probers/nsMBCSGroupProber.h new/kcodecs-6.17.0/src/probers/nsMBCSGroupProber.h --- old/kcodecs-6.16.0/src/probers/nsMBCSGroupProber.h 2025-07-04 17:10:10.000000000 +0200 +++ new/kcodecs-6.17.0/src/probers/nsMBCSGroupProber.h 2025-08-01 12:30:22.000000000 +0200 @@ -30,9 +30,6 @@ } void Reset(void) override; float GetConfidence(void) override; - void SetOpion() override - { - } #ifdef DEBUG_PROBE void DumpStatus() override; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kcodecs-6.16.0/src/probers/nsSBCSGroupProber.h new/kcodecs-6.17.0/src/probers/nsSBCSGroupProber.h --- old/kcodecs-6.16.0/src/probers/nsSBCSGroupProber.h 2025-07-04 17:10:10.000000000 +0200 +++ new/kcodecs-6.17.0/src/probers/nsSBCSGroupProber.h 2025-08-01 12:30:22.000000000 +0200 @@ -29,9 +29,6 @@ } void Reset(void) override; float GetConfidence(void) override; - void SetOpion() override - { - } #ifdef DEBUG_PROBE void DumpStatus() override; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kcodecs-6.16.0/src/probers/nsSBCharSetProber.h new/kcodecs-6.17.0/src/probers/nsSBCharSetProber.h --- old/kcodecs-6.16.0/src/probers/nsSBCharSetProber.h 2025-07-04 17:10:10.000000000 +0200 +++ new/kcodecs-6.17.0/src/probers/nsSBCharSetProber.h 2025-08-01 12:30:22.000000000 +0200 @@ -54,9 +54,6 @@ } void Reset(void) override; float GetConfidence(void) override; - void SetOpion() override - { - } // This feature is not implemented yet. any current language model // contain this parameter as false. No one is looking at this diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kcodecs-6.16.0/src/probers/nsSJISProber.h new/kcodecs-6.17.0/src/probers/nsSJISProber.h --- old/kcodecs-6.16.0/src/probers/nsSJISProber.h 2025-07-04 17:10:10.000000000 +0200 +++ new/kcodecs-6.17.0/src/probers/nsSJISProber.h 2025-08-01 12:30:22.000000000 +0200 @@ -44,9 +44,6 @@ } void Reset(void) override; float GetConfidence(void) override; - void SetOpion() override - { - } protected: nsCodingStateMachine *mCodingSM; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kcodecs-6.16.0/src/probers/nsUniversalDetector.cpp new/kcodecs-6.17.0/src/probers/nsUniversalDetector.cpp --- old/kcodecs-6.16.0/src/probers/nsUniversalDetector.cpp 2025-07-04 17:10:10.000000000 +0200 +++ new/kcodecs-6.17.0/src/probers/nsUniversalDetector.cpp 2025-08-01 12:30:22.000000000 +0200 @@ -18,10 +18,8 @@ { mDone = false; mBestGuess = -1; // illegal value as signal - mInTag = false; mEscCharSetProber = nullptr; - mStart = true; mDetectedCharset = nullptr; mGotData = false; mInputState = ePureAscii; @@ -45,9 +43,7 @@ { mDone = false; mBestGuess = -1; // illegal value as signal - mInTag = false; - mStart = true; mDetectedCharset = nullptr; mGotData = false; mInputState = ePureAscii; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kcodecs-6.16.0/src/probers/nsUniversalDetector.h new/kcodecs-6.17.0/src/probers/nsUniversalDetector.h --- old/kcodecs-6.16.0/src/probers/nsUniversalDetector.h 2025-07-04 17:10:10.000000000 +0200 +++ new/kcodecs-6.17.0/src/probers/nsUniversalDetector.h 2025-08-01 12:30:22.000000000 +0200 @@ -30,15 +30,10 @@ void Reset(void) override; float GetConfidence(void) override; nsProbingState GetState() override; - void SetOpion() override - { - } protected: nsInputState mInputState; bool mDone; - bool mInTag; - bool mStart; bool mGotData; char mLastChar; const char *mDetectedCharset;
