Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package yast2-metapackage-handler for
openSUSE:Factory checked in at 2021-04-19 21:05:39
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-metapackage-handler (Old)
and /work/SRC/openSUSE:Factory/.yast2-metapackage-handler.new.12324 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-metapackage-handler"
Mon Apr 19 21:05:39 2021 rev:54 rq:886116 version:4.4.0
Changes:
--------
---
/work/SRC/openSUSE:Factory/yast2-metapackage-handler/yast2-metapackage-handler.changes
2020-07-24 09:53:47.613268734 +0200
+++
/work/SRC/openSUSE:Factory/.yast2-metapackage-handler.new.12324/yast2-metapackage-handler.changes
2021-04-19 21:05:47.792011128 +0200
@@ -1,0 +2,7 @@
+Wed Apr 7 19:16:18 UTC 2021 - Dirk M??ller <[email protected]>
+
+- stop packaging directories owned by filesystem (bsc#1184787)
+- spec cleanup
+- 4.4.0
+
+-------------------------------------------------------------------
Old:
----
yast2-metapackage-handler-4.3.0.tar.bz2
New:
----
yast2-metapackage-handler-4.4.0.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-metapackage-handler.spec ++++++
--- /var/tmp/diff_new_pack.t1daSy/_old 2021-04-19 21:05:48.288011872 +0200
+++ /var/tmp/diff_new_pack.t1daSy/_new 2021-04-19 21:05:48.292011877 +0200
@@ -1,7 +1,7 @@
#
# spec file for package yast2-metapackage-handler
#
-# Copyright (c) 2020 SUSE LINUX GmbH, Nuernberg, Germany.
+# Copyright (c) 2021 SUSE LLC
#
# All modifications and additions to the file contributed by third parties
# remain the property of their copyright owners, unless otherwise agreed
@@ -12,43 +12,39 @@
# license that conforms to the Open Source Definition (Version 1.9)
# published by the Open Source Initiative.
-# Please submit bugfixes or comments via http://bugs.opensuse.org/
+# Please submit bugfixes or comments via https://bugs.opensuse.org/
#
Name: yast2-metapackage-handler
-Version: 4.3.0
+Version: 4.4.0
Release: 0
Summary: YaST2 - Easy Installation of Add-on RPMs using Metapackages
License: GPL-2.0-or-later
Group: System/YaST
-Url: https://github.com/yast/yast-metapackage-handler
-
+URL: https://github.com/yast/yast-metapackage-handler
Source0: %{name}-%{version}.tar.bz2
-
# should be required by devtools
BuildRequires: pkgconfig
-# y2tool
-BuildRequires: yast2-devtools >= 3.1.10
-# ycpc
+# desktop files
+BuildRequires: update-desktop-files
BuildRequires: yast2
+# ycpc
BuildRequires: yast2-core
BuildRequires: yast2-country-data
+# y2tool
+BuildRequires: yast2-devtools >= 3.1.10
BuildRequires: yast2-packager
BuildRequires: yast2-transfer
-# desktop files
-BuildRequires: update-desktop-files
-BuildRequires: rubygem(%rb_default_ruby_abi:yast-rake)
-
+BuildRequires: rubygem(%{rb_default_ruby_abi}:yast-rake)
+# needed at runtime for invoking root mode
+Requires: %{_bindir}/xdg-su
Requires: yast2
-Requires: yast2-packager
-Requires: yast2-transfer
# Language
Requires: yast2-country-data
-# needed at runtime for invoking root mode
-Requires: /usr/bin/xdg-su
+Requires: yast2-packager
Requires: yast2-ruby-bindings >= 1.0.0
-
+Requires: yast2-transfer
BuildArch: noarch
%description
@@ -68,7 +64,7 @@
%files
%doc %{yast_docdir}
%license COPYING
-%{_bindir}/
+%{_bindir}/OneClickInstall*
%{yast_clientdir}
%{yast_moduledir}
%{yast_icondir}
++++++ yast2-metapackage-handler-4.3.0.tar.bz2 ->
yast2-metapackage-handler-4.4.0.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-metapackage-handler-4.3.0/.github/workflows/ci.yml
new/yast2-metapackage-handler-4.4.0/.github/workflows/ci.yml
--- old/yast2-metapackage-handler-4.3.0/.github/workflows/ci.yml
1970-01-01 01:00:00.000000000 +0100
+++ new/yast2-metapackage-handler-4.4.0/.github/workflows/ci.yml
2021-04-16 21:54:03.000000000 +0200
@@ -0,0 +1,70 @@
+
+# See
https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions
+
+name: CI
+
+on: [push, pull_request]
+
+jobs:
+ Tests:
+ runs-on: ubuntu-latest
+ container: registry.opensuse.org/yast/head/containers/yast-ruby:latest
+
+ steps:
+
+ - name: Git Checkout
+ uses: actions/checkout@v2
+
+ # just for easier debugging...
+ - name: Inspect Installed Packages
+ run: rpm -qa | sort
+
+ - name: Unit Tests
+ run: rake test:unit
+ # enable code coverage reporting
+ env:
+ COVERAGE: 1
+
+ # send the coverage report to coveralls.io
+ - name: Coveralls Report
+ uses: coverallsapp/github-action@master
+ with:
+ github-token: ${{ secrets.GITHUB_TOKEN }}
+
+ Package:
+ runs-on: ubuntu-latest
+ container: registry.opensuse.org/yast/head/containers/yast-ruby:latest
+
+ steps:
+
+ - name: Git Checkout
+ uses: actions/checkout@v2
+
+ - name: Package Build
+ run: yast-ci-ruby -o package
+
+ Yardoc:
+ runs-on: ubuntu-latest
+ container: registry.opensuse.org/yast/head/containers/yast-ruby:latest
+
+ steps:
+
+ - name: Git Checkout
+ uses: actions/checkout@v2
+
+ - name: Yardoc
+ run: rake check:doc
+
+ # downloading the Docker image takes some time so bundling several fast
+ # checks into one job avoids that overhead
+ Checks:
+ runs-on: ubuntu-latest
+ container: registry.opensuse.org/yast/head/containers/yast-ruby:latest
+
+ steps:
+
+ - name: Git Checkout
+ uses: actions/checkout@v2
+
+ - name: POT Check
+ run: rake check:pot
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-metapackage-handler-4.3.0/.rspec
new/yast2-metapackage-handler-4.4.0/.rspec
--- old/yast2-metapackage-handler-4.3.0/.rspec 1970-01-01 01:00:00.000000000
+0100
+++ new/yast2-metapackage-handler-4.4.0/.rspec 2021-04-16 21:54:03.000000000
+0200
@@ -0,0 +1,3 @@
+--color
+--require spec_helper
+--format documentation
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-metapackage-handler-4.3.0/.travis.yml
new/yast2-metapackage-handler-4.4.0/.travis.yml
--- old/yast2-metapackage-handler-4.3.0/.travis.yml 2020-07-21
21:29:29.000000000 +0200
+++ new/yast2-metapackage-handler-4.4.0/.travis.yml 1970-01-01
01:00:00.000000000 +0100
@@ -1,11 +0,0 @@
-sudo: required
-language: bash
-services:
- - docker
-
-before_install:
- - docker build -t yast-metapackage-handler-image .
-script:
- # the "yast-travis-ruby" script is included in the base yastdevel/ruby image
- # see https://github.com/yast/docker-yast-ruby/blob/master/yast-travis-ruby
- - docker run -it -e TRAVIS=1 -e TRAVIS_JOB_ID="$TRAVIS_JOB_ID"
yast-metapackage-handler-image yast-travis-ruby
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-metapackage-handler-4.3.0/Dockerfile
new/yast2-metapackage-handler-4.4.0/Dockerfile
--- old/yast2-metapackage-handler-4.3.0/Dockerfile 2020-07-21
21:29:29.000000000 +0200
+++ new/yast2-metapackage-handler-4.4.0/Dockerfile 1970-01-01
01:00:00.000000000 +0100
@@ -1,5 +0,0 @@
-FROM registry.opensuse.org/yast/head/containers/yast-ruby:latest
-RUN zypper --gpg-auto-import-keys --non-interactive in --no-recommends \
- perl-XML-XPath
-COPY . /usr/src/app
-
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-metapackage-handler-4.3.0/README.md
new/yast2-metapackage-handler-4.4.0/README.md
--- old/yast2-metapackage-handler-4.3.0/README.md 2020-07-21
21:29:29.000000000 +0200
+++ new/yast2-metapackage-handler-4.4.0/README.md 2021-04-16
21:54:03.000000000 +0200
@@ -1,5 +1,8 @@
# YaST - The One Click Installer Module #
-[](https://travis-ci.org/yast/yast-metapackage-handler)
-[](https://ci.opensuse.org/view/Yast/job/yast-metapackage-handler-master/)
-
+[](
+https://github.com/yast/yast-metapackage-handler/actions?query=branch%3Amaster)
+[](
+https://ci.opensuse.org/view/Yast/job/yast-yast-metapackage-handler-master/)
+[](https://coveralls.io/r/yast/yast-metapackage-handler?branch=master)
+[](http://inch-ci.org/github/yast/yast-metapackage-handler)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-metapackage-handler-4.3.0/package/yast2-metapackage-handler.changes
new/yast2-metapackage-handler-4.4.0/package/yast2-metapackage-handler.changes
---
old/yast2-metapackage-handler-4.3.0/package/yast2-metapackage-handler.changes
2020-07-21 21:29:29.000000000 +0200
+++
new/yast2-metapackage-handler-4.4.0/package/yast2-metapackage-handler.changes
2021-04-16 21:54:03.000000000 +0200
@@ -1,4 +1,11 @@
-------------------------------------------------------------------
+Wed Apr 7 19:16:18 UTC 2021 - Dirk M??ller <[email protected]>
+
+- stop packaging directories owned by filesystem (bsc#1184787)
+- spec cleanup
+- 4.4.0
+
+-------------------------------------------------------------------
Tue Jul 21 10:57:39 UTC 2020 - Ancor Gonzalez Sosa <[email protected]>
- Fixed a crash when ~/.y2usersettings is missing (bsc#1173781)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-metapackage-handler-4.3.0/package/yast2-metapackage-handler.spec
new/yast2-metapackage-handler-4.4.0/package/yast2-metapackage-handler.spec
--- old/yast2-metapackage-handler-4.3.0/package/yast2-metapackage-handler.spec
2020-07-21 21:29:29.000000000 +0200
+++ new/yast2-metapackage-handler-4.4.0/package/yast2-metapackage-handler.spec
2021-04-16 21:54:03.000000000 +0200
@@ -1,7 +1,7 @@
#
# spec file for package yast2-metapackage-handler
#
-# Copyright (c) 2015 SUSE LINUX GmbH, Nuernberg, Germany.
+# Copyright (c) 2021 SUSE LLC
#
# All modifications and additions to the file contributed by third parties
# remain the property of their copyright owners, unless otherwise agreed
@@ -17,38 +17,34 @@
Name: yast2-metapackage-handler
-Version: 4.3.0
+Version: 4.4.0
Release: 0
Summary: YaST2 - Easy Installation of Add-on RPMs using Metapackages
License: GPL-2.0-or-later
Group: System/YaST
-Url: https://github.com/yast/yast-metapackage-handler
-
+URL: https://github.com/yast/yast-metapackage-handler
Source0: %{name}-%{version}.tar.bz2
-
# should be required by devtools
BuildRequires: pkgconfig
-# y2tool
-BuildRequires: yast2-devtools >= 3.1.10
+# desktop files
+BuildRequires: update-desktop-files
+BuildRequires: yast2
# ycpc
BuildRequires: yast2-core
-BuildRequires: yast2
BuildRequires: yast2-country-data
+# y2tool
+BuildRequires: yast2-devtools >= 3.1.10
BuildRequires: yast2-packager
BuildRequires: yast2-transfer
-# desktop files
-BuildRequires: update-desktop-files
-BuildRequires: rubygem(%rb_default_ruby_abi:yast-rake)
-
+BuildRequires: rubygem(%{rb_default_ruby_abi}:yast-rake)
+# needed at runtime for invoking root mode
+Requires: %{_bindir}/xdg-su
Requires: yast2
-Requires: yast2-packager
-Requires: yast2-transfer
# Language
Requires: yast2-country-data
-# needed at runtime for invoking root mode
-Requires: /usr/bin/xdg-su
+Requires: yast2-packager
Requires: yast2-ruby-bindings >= 1.0.0
-
+Requires: yast2-transfer
BuildArch: noarch
%description
@@ -68,7 +64,7 @@
%files
%doc %{yast_docdir}
%license COPYING
-%{_bindir}/
+%{_bindir}/OneClickInstall*
%{yast_clientdir}
%{yast_moduledir}
%{yast_icondir}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-metapackage-handler-4.3.0/spec/OneClickInstallWorkerFunctions_spec.rb
new/yast2-metapackage-handler-4.4.0/spec/OneClickInstallWorkerFunctions_spec.rb
---
old/yast2-metapackage-handler-4.3.0/spec/OneClickInstallWorkerFunctions_spec.rb
1970-01-01 01:00:00.000000000 +0100
+++
new/yast2-metapackage-handler-4.4.0/spec/OneClickInstallWorkerFunctions_spec.rb
2021-04-16 21:54:03.000000000 +0200
@@ -0,0 +1,120 @@
+#! /usr/bin/env rspec
+
+# Copyright (c) [2021] SUSE LLC
+#
+# All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or modify it
+# under the terms of version 2 of the GNU General Public License as published
+# by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful, but WITHOUT
+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
+# more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with this program; if not, contact SUSE LLC.
+#
+# To contact SUSE LLC about this file by physical or electronic mail, you may
+# find current contact information at www.suse.com.
+
+require_relative "spec_helper"
+
+require "yast"
+
+Yast.import "OneClickInstallWorkerFunctions"
+
+describe Yast::OneClickInstallWorkerFunctions do
+
+ let(:urls) { %w[http://example.com/repo1 http://example.com/repo2
http://example.com/repo3] }
+
+ describe "#DeDupe" do
+ before do
+ allow(Yast::Pkg).to receive(:SourceStartCache).and_return([1])
+ end
+ context "when receives repository that is not subscribed on" do
+ it "does not filter the repository" do
+ allow(Yast::Pkg).to receive(:SourceGeneralData).and_return({})
+ allow(Yast::OneClickInstall).to
receive(:GetRepositoryName).and_return("test-name")
+
+ expect(subject.DeDupe(urls)).to contain_exactly(urls[0], urls[1],
urls[2])
+ end
+ end
+
+ context "when receives repository that is already subscribed on" do
+ it "removes repository if it is duplicated by 'url'" do
+ allow(Yast::Pkg).to receive(:SourceGeneralData).and_return("url" =>
urls[1])
+ allow(Yast::OneClickInstall).to
receive(:GetRepositoryName).and_return("test-name")
+
+ expect(subject.DeDupe(urls)).to contain_exactly(urls[0], urls[2])
+ end
+
+ it "removes repository if it is duplicated by 'name'" do
+ allow(Yast::Pkg).to receive(:SourceGeneralData).and_return({ "name" =>
"oss" }, {}, {})
+ allow(Yast::OneClickInstall).to
receive(:GetRepositoryName).and_return("oss")
+
+ expect(subject.DeDupe(urls)).to contain_exactly(urls[1], urls[2])
+ end
+
+ it "removes repository if it is duplicated by 'alias'" do
+ allow(Yast::Pkg).to receive(:SourceGeneralData).and_return({}, {},
"alias" => "oss")
+ allow(Yast::OneClickInstall).to
receive(:GetRepositoryName).and_return("oss")
+
+ expect(subject.DeDupe(urls)).to contain_exactly(urls[0], urls[1])
+ end
+ end
+ end
+
+ describe '#AddRepositories' do
+ before do
+ allow(subject).to receive(:DeDupe).and_return(urls)
+ end
+ context "when metadata can be downloaded for all repositories" do
+ before do
+ allow(Yast::Pkg).to receive(:SourceRefreshNow).and_return(true)
+ end
+ it "successfully adds the repositories" do
+ expect(subject.AddRepositories(urls)).to be true
+ end
+ end
+
+ context "when metadata can NOT be downloaded" do
+ context "for all repositories" do
+ before do
+ allow(Yast::Pkg).to receive(:SourceRefreshNow).and_return(false)
+ end
+ it "does NOT add all the repositories" do
+ expect(subject.AddRepositories(urls)).to be false
+ end
+ end
+ context "for at least one repository" do
+ before do
+ allow(Yast::Pkg).to receive(:SourceRefreshNow).and_return(false,
true, true)
+ end
+ it "does NOT add all the repositories" do
+ expect(subject.AddRepositories(urls)).to be false
+ end
+ end
+ end
+ end
+
+ describe '#RemoveAddedRepositories' do
+ context "when metadata cached on disk is removed" do
+ before do
+ allow(Yast::Pkg).to receive(:SourceDelete).and_return(true)
+ end
+ it "removes added repositories" do
+ expect(subject.RemoveAddedRepositories).to be true
+ end
+ end
+ context "when metadata cached on disk is NOT removed" do
+ before do
+ allow(Yast::Pkg).to receive(:SourceDelete).and_return(false)
+ end
+ it "does not remove added repositories" do
+ expect(subject.RemoveAddedRepositories).to be false
+ end
+ end
+ end
+end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-metapackage-handler-4.3.0/spec/OneClickInstall_spec.rb
new/yast2-metapackage-handler-4.4.0/spec/OneClickInstall_spec.rb
--- old/yast2-metapackage-handler-4.3.0/spec/OneClickInstall_spec.rb
1970-01-01 01:00:00.000000000 +0100
+++ new/yast2-metapackage-handler-4.4.0/spec/OneClickInstall_spec.rb
2021-04-16 21:54:03.000000000 +0200
@@ -0,0 +1,64 @@
+#! /usr/bin/env rspec
+
+# Copyright (c) [2020] SUSE LLC
+#
+# All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or modify it
+# under the terms of version 2 of the GNU General Public License as published
+# by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful, but WITHOUT
+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
+# more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with this program; if not, contact SUSE LLC.
+#
+# To contact SUSE LLC about this file by physical or electronic mail, you may
+# find current contact information at www.suse.com.
+
+require_relative "spec_helper"
+
+require "yast"
+
+Yast.import "OneClickInstall"
+
+describe Yast::OneClickInstall do
+ let(:filepath) { File.join(DATA_PATH, "vim.ymp") }
+ let(:output) { "" }
+
+ describe "#xml_from_file" do
+ context "ymp file parsed" do
+ it "parses the XML file" do
+ doc = subject.xml_from_file(filepath)
+ expect(doc).to be_instance_of(REXML::Document)
+ doc.write(output)
+ expect(output).to include("vim")
+ end
+ end
+ end
+
+ describe "#xpath_match" do
+ context "matching node" do
+ it "returns and array of elements, matching xpath" do
+ doc = REXML::Document.new(File.read(filepath))
+ expect(subject.xpath_match(doc, "metapackage//url").first.text).to
eq("http://download.opensuse.org/tumbleweed/repo/oss/")
+ end
+ end
+ end
+
+ describe "#SetRequiredRepository" do
+ context "set repository to recommended" do
+ it "Ensures that the repository with the specified URL is selected for
addition" do
+ url = "http://download.opensuse.org/tumbleweed/repo/oss/"
+ subject.instance_variable_set(:@repositories, { url => { "name" =>
"vim" , "recommended" => "false" }})
+ subject.SetRequiredRepository(url)
+ repos = subject.instance_variable_get(:@repositories)
+ expect(repos[url]["name"]).to eql("vim")
+ expect(repos[url]["recommended"]).to eql("true")
+ end
+ end
+ end
+end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-metapackage-handler-4.3.0/spec/data/vim.ymp
new/yast2-metapackage-handler-4.4.0/spec/data/vim.ymp
--- old/yast2-metapackage-handler-4.3.0/spec/data/vim.ymp 1970-01-01
01:00:00.000000000 +0100
+++ new/yast2-metapackage-handler-4.4.0/spec/data/vim.ymp 2021-04-16
21:54:03.000000000 +0200
@@ -0,0 +1,29 @@
+<metapackage xmlns:os="http://opensuse.org/Standards/One_Click_Install"
xmlns="http://opensuse.org/Standards/One_Click_Install">
+ <group distversion="openSUSE Tumbleweed">
+ <repositories>
+ <repository recommended="true">
+ <name>openSUSE:Factory</name>
+ <summary>The next openSUSE distribution</summary>
+ <description>Any user who wishes to have the newest packages that
include, but are not limited to, the Linux kernel, SAMBA, git, desktops, office
applications and many other packages, will want Tumbleweed. Tumbleweed appeals
to Power Users, Software Developers and openSUSE Contributors. If you require
the latest software stacks and Integrated Development Environment or need a
stable platform closest to bleeding edge Linux, Tumbleweed is the best choice
for you.
+
+Staging dashboard is located at:
https://build.opensuse.org/project/show/openSUSE:Factory
+
+List of known devel projects:
https://build.opensuse.org/package/view_file/openSUSE:Factory:Staging/dashboard/devel_projects
+
+Have a look at http://en.opensuse.org/Portal:Factory for more
details.</description>
+ <url>http://download.opensuse.org/tumbleweed/repo/oss/</url>
+ </repository>
+ </repositories>
+ <software>
+ <item>
+ <name>vim</name>
+ <summary>Vi IMproved</summary>
+ <description>Vim (Vi IMproved) is an almost compatible version of the
UNIX editor
+vi. Almost every possible command can be performed using only ASCII
+characters. Only the 'Q' command is missing (you do not need it). Many
+new features have been added: multilevel undo, command line history,
+file name completion, block operations, and editing of binary
data.</description>
+ </item>
+ </software>
+ </group>
+</metapackage>
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-metapackage-handler-4.3.0/spec/spec_helper.rb
new/yast2-metapackage-handler-4.4.0/spec/spec_helper.rb
--- old/yast2-metapackage-handler-4.3.0/spec/spec_helper.rb 1970-01-01
01:00:00.000000000 +0100
+++ new/yast2-metapackage-handler-4.4.0/spec/spec_helper.rb 2021-04-16
21:54:03.000000000 +0200
@@ -0,0 +1,70 @@
+# Copyright (c) [2020] SUSE LLC
+#
+# All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or modify it
+# under the terms of version 2 of the GNU General Public License as published
+# by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful, but WITHOUT
+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
+# more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with this program; if not, contact SUSE LLC.
+#
+# To contact SUSE LLC about this file by physical or electronic mail, you may
+# find current contact information at www.suse.com.
+
+SRC_PATH = File.expand_path("../src", __dir__)
+DATA_PATH = File.expand_path("data", __dir__)
+TEST_PATH = File.expand_path(__dir__)
+ENV["Y2DIR"] = SRC_PATH
+
+
+# Ensure the tests runs with english locales
+ENV["LC_ALL"] = "en_US.UTF-8"
+ENV["LANG"] = "en_US.UTF-8"
+
+require "yast"
+require "yast/rspec"
+
+RSpec.configure do |config|
+ config.mock_with :rspec do |mocks|
+ # If you misremember a method name both in code and in tests,
+ # will save you.
+ #
https://relishapp.com/rspec/rspec-mocks/v/3-0/docs/verifying-doubles/partial-doubles
+ #
+ # With graceful degradation for RSpec 2
+ mocks.verify_partial_doubles = true if
mocks.respond_to?(:verify_partial_doubles=)
+ end
+end
+
+if ENV["COVERAGE"]
+ require "simplecov"
+ SimpleCov.start do
+ add_filter "/test/"
+ end
+
+ src_location = File.expand_path("../src", __dir__)
+ # track all ruby files under src
+ SimpleCov.track_files("#{src_location}/**/*.rb")
+
+ # additionally use the LCOV format for on-line code coverage reporting at CI
+ if ENV["CI"] || ENV["COVERAGE_LCOV"]
+ require "simplecov-lcov"
+
+ SimpleCov::Formatter::LcovFormatter.config do |c|
+ c.report_with_single_file = true
+ # this is the default Coveralls GitHub Action location
+ # https://github.com/marketplace/actions/coveralls-github-action
+ c.single_report_path = "coverage/lcov.info"
+ end
+
+ SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
+ SimpleCov::Formatter::HTMLFormatter,
+ SimpleCov::Formatter::LcovFormatter
+ ]
+ end
+end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-metapackage-handler-4.3.0/src/modules/OneClickInstall.rb
new/yast2-metapackage-handler-4.4.0/src/modules/OneClickInstall.rb
--- old/yast2-metapackage-handler-4.3.0/src/modules/OneClickInstall.rb
2020-07-21 21:29:29.000000000 +0200
+++ new/yast2-metapackage-handler-4.4.0/src/modules/OneClickInstall.rb
2021-04-16 21:54:03.000000000 +0200
@@ -348,7 +348,7 @@
end
# Ensures the software with the specified name is selected for
installation or removal.
- # @param the name of the software to ensure is selected for installation.
+ # @param name [String] the name of the software to ensure is selected for
installation.
#
def SetRequiredSoftware(name)
softwareDetails = Ops.get(@software, name)
@@ -386,7 +386,7 @@
end
# Ensures the software with the specified name is NOT selected for
installation or removal.
- # @param the name of the software to ensure is NOT selected for
installation.
+ # @param name [String] the name of the software to ensure is NOT selected
for installation.
#
def SetNonRequiredSoftware(name)
softwareDetails = Ops.get(@software, name)
@@ -399,7 +399,7 @@
# Ensures that the repositories with specified URLs are selected for
addition, and all others are not.
# Invalid pluralisation due to lack of proper overloading :(
- # @param the names of the software to ensure is selected for installation.
+ # @param names [Array<String>] the names of the software to ensure is
selected for installation.
#
def SetRequiredSoftwares(names)
names = deep_copy(names)
@@ -437,7 +437,7 @@
# <region name="Processing"> *
# Specify whether the user should remain subscribed to the repositories
after installation of this software is complete.
- # @param the boolean value indicating whether the user should remain
subscribed.
+ # @param value [Boolean] indicating whether the user should remain
subscribed.
#
def SetRemainSubscribed(value)
@remainSubscribed = value
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-metapackage-handler-4.3.0/src/modules/OneClickInstallWorkerResponse.rb
new/yast2-metapackage-handler-4.4.0/src/modules/OneClickInstallWorkerResponse.rb
---
old/yast2-metapackage-handler-4.3.0/src/modules/OneClickInstallWorkerResponse.rb
2020-07-21 21:29:29.000000000 +0200
+++
new/yast2-metapackage-handler-4.4.0/src/modules/OneClickInstallWorkerResponse.rb
2021-04-16 21:54:03.000000000 +0200
@@ -28,7 +28,8 @@
def GetSuccess
@success == "true"
end
- # @param the success status to set.
+
+ # @param value [Boolean] the success status to set.
#
def SetSuccess(value)
if value