Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package intel-metee for openSUSE:Factory checked in at 2025-09-26 22:25:46 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/intel-metee (Old) and /work/SRC/openSUSE:Factory/.intel-metee.new.11973 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "intel-metee" Fri Sep 26 22:25:46 2025 rev:3 rq:1307385 version:6.0.2 Changes: -------- --- /work/SRC/openSUSE:Factory/intel-metee/intel-metee.changes 2025-06-23 15:03:51.686200801 +0200 +++ /work/SRC/openSUSE:Factory/.intel-metee.new.11973/intel-metee.changes 2025-09-26 22:27:39.169930359 +0200 @@ -1,0 +2,7 @@ +Fri Sep 26 12:19:23 UTC 2025 - Patrik Jakobsson <[email protected]> + +- Update to version 6.0.2 + * Windows: drop un-needed assert + * EFI: do not send disconnect when not connected + +------------------------------------------------------------------- Old: ---- 6.0.0.tar.gz New: ---- 6.0.2.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ intel-metee.spec ++++++ --- /var/tmp/diff_new_pack.n91Blt/_old 2025-09-26 22:27:39.733954147 +0200 +++ /var/tmp/diff_new_pack.n91Blt/_new 2025-09-26 22:27:39.737954316 +0200 @@ -15,10 +15,10 @@ # Please submit bugfixes or comments via https://bugs.opensuse.org/ # -%define SONAME libmetee6_0_0_0 +%define SONAME libmetee6_0_2_0 Name: intel-metee -Version: 6.0.0 +Version: 6.0.2 Release: 0 Summary: Library to access CSE/CSME/GSC firmware via a MEI interface License: Apache-2.0 ++++++ 6.0.0.tar.gz -> 6.0.2.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/metee-6.0.0/CHANGELOG.md new/metee-6.0.2/CHANGELOG.md --- old/metee-6.0.0/CHANGELOG.md 2025-06-17 15:59:18.000000000 +0200 +++ new/metee-6.0.2/CHANGELOG.md 2025-09-11 14:03:44.000000000 +0200 @@ -1,3 +1,11 @@ +## [6.0.2] + - Windows: drop un-needed assert + - EFI: do not send disconnect when not connected + +## [6.0.1] + - EFI: prefix internal function + - Windows: add newlines to error messages + ## [6.0.0] **Note:** Backward incompatible ABI change: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/metee-6.0.0/VERSION new/metee-6.0.2/VERSION --- old/metee-6.0.0/VERSION 2025-06-17 15:59:18.000000000 +0200 +++ new/metee-6.0.2/VERSION 2025-09-11 14:03:44.000000000 +0200 @@ -1 +1 @@ -6.0.0 +6.0.2 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/metee-6.0.0/src/Windows/metee_win.c new/metee-6.0.2/src/Windows/metee_win.c --- old/metee-6.0.0/src/Windows/metee_win.c 2025-06-17 15:59:18.000000000 +0200 +++ new/metee-6.0.2/src/Windows/metee_win.c 2025-09-11 14:03:44.000000000 +0200 @@ -2,7 +2,6 @@ /* * Copyright (C) 2014-2025 Intel Corporation */ -#include <assert.h> #include <windows.h> #include <initguid.h> #include <winioctl.h> @@ -141,7 +140,7 @@ impl_handle = (struct METEE_WIN_IMPL*)malloc(sizeof(*impl_handle)); if (impl_handle == NULL) { status = TEE_INTERNAL_ERROR; - ERRPRINT(handle, "Can't allocate memory for internal struct"); + ERRPRINT(handle, "Can't allocate memory for internal struct\n"); goto Cleanup; } memset(impl_handle, 0, sizeof(*impl_handle)); @@ -407,7 +406,7 @@ if (NULL == impl_handle || NULL == buffer || 0 == bufferSize) { status = TEE_INVALID_PARAMETER; - ERRPRINT(handle, "One of the parameters was illegal"); + ERRPRINT(handle, "One of the parameters was illegal\n"); goto Cleanup; } @@ -419,7 +418,7 @@ if (impl_handle->state != METEE_CLIENT_STATE_CONNECTED) { status = TEE_DISCONNECTED; - ERRPRINT(handle, "The client is not connected"); + ERRPRINT(handle, "The client is not connected\n"); goto Cleanup; } @@ -468,12 +467,12 @@ if (NULL == impl_handle || NULL == fwStatus) { status = TEE_INVALID_PARAMETER; - ERRPRINT(handle, "One of the parameters was illegal"); + ERRPRINT(handle, "One of the parameters was illegal\n"); goto Cleanup; } if (fwStatusNum > 5) { status = TEE_INVALID_PARAMETER; - ERRPRINT(handle, "fwStatusNum should be 0..5"); + ERRPRINT(handle, "fwStatusNum should be 0..5\n"); goto Cleanup; } @@ -510,7 +509,7 @@ if (!impl_handle || !trc_val) { status = TEE_INVALID_PARAMETER; - ERRPRINT(handle, "One of the parameters was illegal"); + ERRPRINT(handle, "One of the parameters was illegal\n"); goto Cleanup; } @@ -617,7 +616,7 @@ if (NULL == impl_handle || NULL == driverVersion) { status = TEE_INVALID_PARAMETER; - ERRPRINT(handle, "One of the parameters was illegal"); + ERRPRINT(handle, "One of the parameters was illegal\n"); goto Cleanup; } @@ -687,7 +686,7 @@ if (NULL == impl_handle) { status = TEE_INVALID_PARAMETER; - ERRPRINT(handle, "One of the parameters was illegal"); + ERRPRINT(handle, "One of the parameters was illegal\n"); goto Cleanup; } if (handle->log_callback2) { @@ -717,7 +716,7 @@ if (NULL == impl_handle) { status = TEE_INVALID_PARAMETER; - ERRPRINT(handle, "One of the parameters was illegal"); + ERRPRINT(handle, "One of the parameters was illegal\n"); goto Cleanup; } if (handle->log_callback) { @@ -764,7 +763,7 @@ if (NULL == impl_handle || NULL == kindSize) { status = TEE_INVALID_PARAMETER; - ERRPRINT(handle, "One of the parameters was illegal"); + ERRPRINT(handle, "One of the parameters was illegal\n"); goto Cleanup; } status = GetDeviceKind(handle, kind, kindSize); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/metee-6.0.0/src/Windows/metee_winhelpers.c new/metee-6.0.2/src/Windows/metee_winhelpers.c --- old/metee-6.0.0/src/Windows/metee_winhelpers.c 2025-06-17 15:59:18.000000000 +0200 +++ new/metee-6.0.2/src/Windows/metee_winhelpers.c 2025-09-11 14:03:44.000000000 +0200 @@ -2,7 +2,6 @@ /* * Copyright (C) 2014-2025 Intel Corporation */ -#include <assert.h> #include <windows.h> #include <initguid.h> #include "helpers.h" @@ -13,7 +12,6 @@ #include <Devpkey.h> #include <Strsafe.h> - /********************************************************************* ** Windows Helper Functions ** **********************************************************************/ @@ -63,7 +61,7 @@ if (INVALID_HANDLE_VALUE == impl_handle->handle || NULL == buffer || 0 == bufferSize || NULL == evt) { status = TEE_INVALID_PARAMETER; - ERRPRINT(handle, "One of the parameters was illegal"); + ERRPRINT(handle, "One of the parameters was illegal\n"); goto Cleanup; } @@ -129,7 +127,6 @@ } if (err != WAIT_OBJECT_0) { - assert(WAIT_FAILED == err); err = GetLastError(); status = Win32ErrorToTee(err); @@ -180,7 +177,7 @@ if (InterfaceGuid == NULL || path == NULL || pathSize < 1) { status = TEE_INTERNAL_ERROR; - ERRPRINT(handle, "One of the parameters was illegal"); + ERRPRINT(handle, "One of the parameters was illegal\n"); goto Cleanup; } @@ -199,7 +196,7 @@ if (deviceInterfaceListLength <= 1) { status = TEE_DEVICE_NOT_FOUND; - ERRPRINT(handle, "SetupDiGetClassDevs returned status %d", GetLastError()); + ERRPRINT(handle, "SetupDiGetClassDevs returned status %d\n", GetLastError()); goto Cleanup; } @@ -226,7 +223,7 @@ hr = StringCchCopyA(path, pathSize, deviceInterfaceList); if (FAILED(hr)) { status = TEE_INTERNAL_ERROR; - ERRPRINT(handle, "Error: StringCchCopy failed with HRESULT 0x%x", hr); + ERRPRINT(handle, "Error: StringCchCopy failed with HRESULT 0x%x\n", hr); goto Cleanup; } @@ -384,7 +381,7 @@ if (INVALID_HANDLE_VALUE == impl_handle->handle || NULL == pBytesRetuned) { status = ERROR_INVALID_PARAMETER; - ERRPRINT(handle, "One of the parameters was illegal"); + ERRPRINT(handle, "One of the parameters was illegal\n"); goto Cleanup; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/metee-6.0.0/src/uefi/heci_efi.c new/metee-6.0.2/src/uefi/heci_efi.c --- old/metee-6.0.0/src/uefi/heci_efi.c 2025-06-17 15:59:18.000000000 +0200 +++ new/metee-6.0.2/src/uefi/heci_efi.c 2025-09-11 14:03:44.000000000 +0200 @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: Apache-2.0 */ /* - * Copyright (C) 2024 Intel Corporation + * Copyright (C) 2024-2025 Intel Corporation */ #include <Uefi.h> @@ -207,7 +207,7 @@ } EFI_STATUS -HeciFwStatus( +EfiTeeHeciFwStatus( IN struct METEE_EFI_IMPL *Handle, IN UINT32 fwStatusNum, OUT UINT32 *fwStatus) @@ -245,7 +245,7 @@ } EFI_STATUS -HeciGetTrc( +EfiTeeHeciGetTrc( IN struct METEE_EFI_IMPL *Handle, OUT UINT32 *trcVal) { @@ -271,7 +271,7 @@ } EFI_STATUS -HeciUninitialize( +EfiTeeHeciUninitialize( IN struct METEE_EFI_IMPL *Handle) { EFI_STATUS status = EFI_UNSUPPORTED; @@ -299,6 +299,13 @@ goto End; } + if (client->connected == FALSE) + { + DBGPRINT(Handle->TeeHandle, "Handle is not connected\n"); + status = EFI_SUCCESS; + goto End; + } + SetMem(&disconnectMsg, sizeof(disconnectMsg), 0x0); SetMem(&disconnectMsgReply, sizeof(disconnectMsgReply), 0x0); @@ -317,7 +324,7 @@ status = heciReadMsg(Handle, BLOCKING, (UINT32 *)&disconnectMsgReply, sizeof(disconnectMsgReply), &msgReplyLen); if (EFI_ERROR(status)) { - DBGPRINT(Handle->TeeHandle, "####HeciUninitialize failed with ReadMsg, Status: %d.\n", status); + DBGPRINT(Handle->TeeHandle, "####Failed with ReadMsg, Status: %d.\n", status); goto End; } DBGPRINT(Handle->TeeHandle, "#### disconnectMsgReply Command %02X , Status: %02X.\n", disconnectMsgReply.Command, disconnectMsgReply.Status); @@ -580,7 +587,7 @@ EFI_STATUS -HeciConnectClient( +EfiTeeHeciConnectClient( IN struct METEE_EFI_IMPL *Handle) { EFI_STATUS status = EFI_UNSUPPORTED; @@ -734,7 +741,7 @@ } EFI_STATUS -HeciSendMessage( +EfiTeeHeciSendMessage( IN struct METEE_EFI_IMPL *Handle, IN const UINT8 *buffer, IN UINT32 bufferLength, @@ -815,7 +822,7 @@ } EFI_STATUS -HeciReceiveMessage( +EfiTeeHeciReceiveMessage( IN struct METEE_EFI_IMPL *Handle, OUT UINT8 *Buffer, IN UINT32 BufferSize, diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/metee-6.0.0/src/uefi/heci_efi.h new/metee-6.0.2/src/uefi/heci_efi.h --- old/metee-6.0.0/src/uefi/heci_efi.h 2025-06-17 15:59:18.000000000 +0200 +++ new/metee-6.0.2/src/uefi/heci_efi.h 2025-09-11 14:03:44.000000000 +0200 @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: Apache-2.0 */ /* - * Copyright (C) 2024 Intel Corporation + * Copyright (C) 2024-2025 Intel Corporation */ #ifndef HECI_EFI_H_ #define HECI_EFI_H_ @@ -8,11 +8,11 @@ #include "metee_efi.h" EFI_STATUS -HeciConnectClient( +EfiTeeHeciConnectClient( IN struct METEE_EFI_IMPL *Handle); EFI_STATUS -HeciReceiveMessage( +EfiTeeHeciReceiveMessage( IN struct METEE_EFI_IMPL *Handle, OUT UINT8 *Buffer, IN UINT32 BufferSize, @@ -20,7 +20,7 @@ IN UINT32 timeout); EFI_STATUS -HeciSendMessage( +EfiTeeHeciSendMessage( IN struct METEE_EFI_IMPL *Handle, IN const UINT8 *buffer, IN UINT32 bufferLength, @@ -28,18 +28,18 @@ IN UINT32 timeout); EFI_STATUS -HeciFwStatus( +EfiTeeHeciFwStatus( IN struct METEE_EFI_IMPL *Handle, IN UINT32 fwStatusNum, OUT UINT32 *fwStatus); EFI_STATUS -HeciGetTrc( +EfiTeeHeciGetTrc( IN struct METEE_EFI_IMPL *Handle, OUT UINT32 *trcVal); EFI_STATUS -HeciUninitialize( +EfiTeeHeciUninitialize( IN struct METEE_EFI_IMPL *Handle); #endif // HECI_EFI_H_ \ No newline at end of file diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/metee-6.0.0/src/uefi/metee_efi.c new/metee-6.0.2/src/uefi/metee_efi.c --- old/metee-6.0.0/src/uefi/metee_efi.c 2025-06-17 15:59:18.000000000 +0200 +++ new/metee-6.0.2/src/uefi/metee_efi.c 2025-09-11 14:03:44.000000000 +0200 @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: Apache-2.0 */ /* - * Copyright (C) 2024 Intel Corporation + * Copyright (C) 2024-2025 Intel Corporation */ #include <Uefi.h> #include <Library/UefiLib.h> @@ -346,7 +346,7 @@ goto Cleanup; } - efi_status = HeciConnectClient(impl_handle); + efi_status = EfiTeeHeciConnectClient(impl_handle); if (EFI_ERROR(efi_status)) { switch (efi_status) @@ -407,7 +407,7 @@ FUNC_ENTRY(handle); - // HeciReceiveMessage works only with uint32_t + // EfiTeeHeciReceiveMessage works only with uint32_t if (NULL == impl_handle || NULL == buffer || 0 == bufferSize || bufferSize > 0xFFFFFFFF) { status = TEE_INVALID_PARAMETER; @@ -421,7 +421,7 @@ ERRPRINT(handle, "The client is not connected\n"); goto End; } - efi_status = HeciReceiveMessage(impl_handle, buffer, (UINT32)bufferSize, &bytesRead, timeout); + efi_status = EfiTeeHeciReceiveMessage(impl_handle, buffer, (UINT32)bufferSize, &bytesRead, timeout); if (EFI_ERROR(efi_status)) { @@ -471,7 +471,7 @@ FUNC_ENTRY(handle); - // HeciSendMessage works only with uint32_t + // EfiTeeHeciSendMessage works only with uint32_t if (NULL == impl_handle || NULL == buffer || 0 == bufferSize || bufferSize > 0xFFFFFFFF) { status = TEE_INVALID_PARAMETER; @@ -486,7 +486,7 @@ goto End; } - efi_status = HeciSendMessage(impl_handle, buffer, (UINT32)bufferSize, &bytesWritten, timeout); + efi_status = EfiTeeHeciSendMessage(impl_handle, buffer, (UINT32)bufferSize, &bytesWritten, timeout); if (EFI_ERROR(efi_status)) { @@ -538,7 +538,7 @@ status = TEE_INVALID_PARAMETER; goto End; } - efi_status = HeciFwStatus(impl_handle, fwStatusNum, fwStatus); + efi_status = EfiTeeHeciFwStatus(impl_handle, fwStatusNum, fwStatus); if (EFI_ERROR(efi_status)) { @@ -581,7 +581,7 @@ goto End; } - efi_status = HeciGetTrc(impl_handle, trc_val); + efi_status = EfiTeeHeciGetTrc(impl_handle, trc_val); if (EFI_ERROR(efi_status)) { @@ -615,7 +615,7 @@ goto Cleanup; } - HeciUninitialize(impl_handle); + EfiTeeHeciUninitialize(impl_handle); FreePool(impl_handle); impl_handle = NULL; @@ -825,7 +825,7 @@ } if (impl_handle->HwType == HECI_HW_TYPE_PCH) { - efi_status = HeciFwStatus(impl_handle, HECI1_FW_STS3, &fw_sts3); + efi_status = EfiTeeHeciFwStatus(impl_handle, HECI1_FW_STS3, &fw_sts3); if (EFI_ERROR(efi_status)) { ERRPRINT(handle, "Failed to retrieve FW Status %d\n", efi_status);
