Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package yast2-fcoe-client for openSUSE:Factory checked in at 2021-04-23 17:50:27 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2-fcoe-client (Old) and /work/SRC/openSUSE:Factory/.yast2-fcoe-client.new.12324 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-fcoe-client" Fri Apr 23 17:50:27 2021 rev:55 rq:887208 version:4.4.1 Changes: -------- --- /work/SRC/openSUSE:Factory/yast2-fcoe-client/yast2-fcoe-client.changes 2020-08-14 13:10:07.809228507 +0200 +++ /work/SRC/openSUSE:Factory/.yast2-fcoe-client.new.12324/yast2-fcoe-client.changes 2021-04-23 17:50:34.674789251 +0200 @@ -1,0 +2,13 @@ +Tue Apr 20 18:14:05 UTC 2021 - Dirk M??ller <[email protected]> + +- stop packaging docdir, it only contained the license which + is now in licensedir (bsc#1184897) +- spec file cleanups +- 4.4.1 + +------------------------------------------------------------------- +Tue Apr 20 13:51:55 UTC 2021 - Ladislav Slez??k <[email protected]> + +- 4.4.0 + +------------------------------------------------------------------- Old: ---- yast2-fcoe-client-4.3.0.tar.bz2 New: ---- yast2-fcoe-client-4.4.1.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-fcoe-client.spec ++++++ --- /var/tmp/diff_new_pack.3SF05l/_old 2021-04-23 17:50:35.122790021 +0200 +++ /var/tmp/diff_new_pack.3SF05l/_new 2021-04-23 17:50:35.126790028 +0200 @@ -1,7 +1,7 @@ # # spec file for package yast2-fcoe-client # -# Copyright (c) 2020 SUSE LINUX GmbH, Nuernberg, Germany. +# Copyright (c) 2021 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -12,33 +12,28 @@ # license that conforms to the Open Source Definition (Version 1.9) # published by the Open Source Initiative. -# Please submit bugfixes or comments via http://bugs.opensuse.org/ +# Please submit bugfixes or comments via https://bugs.opensuse.org/ # Name: yast2-fcoe-client -Version: 4.3.0 +Version: 4.4.1 Release: 0 Summary: YaST2 - Configuration of Fibre Channel over Ethernet License: GPL-2.0-only Group: System/YaST -Url: https://github.com/yast/yast-fcoe-client - +URL: https://github.com/yast/yast-fcoe-client Source0: %{name}-%{version}.tar.bz2 - BuildRequires: perl-XML-Writer BuildRequires: update-desktop-files BuildRequires: yast2 -BuildRequires: yast2-devtools >= 4.2.2 +BuildRequires: yast2-devtools >= 4.4.0 BuildRequires: rubygem(%{rb_default_ruby_abi}:rspec) - # Yast2::Systemd::Service Requires: fcoe-utils Requires: yast2 >= 4.1.3 Requires: yast2-ruby-bindings >= 1.0.0 - Supplements: autoyast(fcoe-client) - BuildArch: noarch %description @@ -56,14 +51,13 @@ %yast_metainfo %files +%license COPYING %{yast_yncludedir} %{yast_clientdir} %{yast_moduledir} %{yast_desktopdir} %{yast_metainfodir} %{yast_scrconfdir} -%doc %{yast_docdir} %{yast_icondir} -%license COPYING %changelog ++++++ yast2-fcoe-client-4.3.0.tar.bz2 -> yast2-fcoe-client-4.4.1.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-fcoe-client-4.3.0/.coveralls.yml new/yast2-fcoe-client-4.4.1/.coveralls.yml --- old/yast2-fcoe-client-4.3.0/.coveralls.yml 2020-08-12 13:50:40.000000000 +0200 +++ new/yast2-fcoe-client-4.4.1/.coveralls.yml 1970-01-01 01:00:00.000000000 +0100 @@ -1 +0,0 @@ -service_name: travis-ci diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-fcoe-client-4.3.0/.github/workflows/ci.yml new/yast2-fcoe-client-4.4.1/.github/workflows/ci.yml --- old/yast2-fcoe-client-4.3.0/.github/workflows/ci.yml 1970-01-01 01:00:00.000000000 +0100 +++ new/yast2-fcoe-client-4.4.1/.github/workflows/ci.yml 2021-04-21 09:32:39.000000000 +0200 @@ -0,0 +1,83 @@ + +# See https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions + +name: CI + +on: [push, pull_request] + +jobs: + Tests: + runs-on: ubuntu-latest + container: registry.opensuse.org/yast/head/containers/yast-ruby:latest + + steps: + + - name: Git Checkout + uses: actions/checkout@v2 + + # just for easier debugging... + - name: Inspect Installed Packages + run: rpm -qa | sort + + - name: Unit Tests + run: rake test:unit + # enable code coverage reporting + env: + COVERAGE: 1 + + # send the coverage report to coveralls.io + - name: Coveralls Report + uses: coverallsapp/github-action@master + with: + github-token: ${{ secrets.GITHUB_TOKEN }} + +# FIXME: Rubocop is not used here + # Rubocop: + # runs-on: ubuntu-latest + # container: registry.opensuse.org/yast/head/containers/yast-ruby:latest + + # steps: + + # - name: Git Checkout + # uses: actions/checkout@v2 + + # - name: Rubocop + # run: rake check:rubocop + + Package: + runs-on: ubuntu-latest + container: registry.opensuse.org/yast/head/containers/yast-ruby:latest + + steps: + + - name: Git Checkout + uses: actions/checkout@v2 + + - name: Package Build + run: yast-ci-ruby -o package + + Yardoc: + runs-on: ubuntu-latest + container: registry.opensuse.org/yast/head/containers/yast-ruby:latest + + steps: + + - name: Git Checkout + uses: actions/checkout@v2 + + - name: Yardoc + run: rake check:doc + + # downloading the Docker image takes some time so bundling several fast + # checks into one job avoids that overhead + Checks: + runs-on: ubuntu-latest + container: registry.opensuse.org/yast/head/containers/yast-ruby:latest + + steps: + + - name: Git Checkout + uses: actions/checkout@v2 + + - name: POT Check + run: rake check:pot diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-fcoe-client-4.3.0/.travis.yml new/yast2-fcoe-client-4.4.1/.travis.yml --- old/yast2-fcoe-client-4.3.0/.travis.yml 2020-08-12 13:50:40.000000000 +0200 +++ new/yast2-fcoe-client-4.4.1/.travis.yml 1970-01-01 01:00:00.000000000 +0100 @@ -1,14 +0,0 @@ -sudo: required -language: bash -services: - - docker - -before_install: - - docker build -t yast-fcoe-client-image . - # list the installed packages (just for easier debugging) - - docker run --rm -it yast-fcoe-client-image rpm -qa | sort - -script: - # the "yast-travis-ruby" script is included in the base yastdevel/ruby image - # see https://github.com/yast/docker-yast-ruby/blob/master/yast-travis-ruby - - docker run -it -e TRAVIS=1 -e TRAVIS_JOB_ID="$TRAVIS_JOB_ID" --privileged yast-fcoe-client-image yast-travis-ruby diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-fcoe-client-4.3.0/Dockerfile new/yast2-fcoe-client-4.4.1/Dockerfile --- old/yast2-fcoe-client-4.3.0/Dockerfile 2020-08-12 13:50:40.000000000 +0200 +++ new/yast2-fcoe-client-4.4.1/Dockerfile 1970-01-01 01:00:00.000000000 +0100 @@ -1,3 +0,0 @@ -FROM registry.opensuse.org/yast/head/containers/yast-ruby:latest -COPY . /usr/src/app - diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-fcoe-client-4.3.0/README.md new/yast2-fcoe-client-4.4.1/README.md --- old/yast2-fcoe-client-4.3.0/README.md 2020-08-12 13:50:40.000000000 +0200 +++ new/yast2-fcoe-client-4.4.1/README.md 2021-04-21 09:32:39.000000000 +0200 @@ -1,5 +1,6 @@ # YaST - The FCoE Client Module # -[](https://travis-ci.org/yast/yast-fcoe-client) -[](https://ci.opensuse.org/view/Yast/job/yast-fcoe-client-master/) - +[]( +https://github.com/yast/yast-fcoe-client/actions?query=branch%3Amaster) +[]( +https://ci.opensuse.org/view/Yast/job/yast-yast-fcoe-client-master/) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-fcoe-client-4.3.0/package/yast2-fcoe-client.changes new/yast2-fcoe-client-4.4.1/package/yast2-fcoe-client.changes --- old/yast2-fcoe-client-4.3.0/package/yast2-fcoe-client.changes 2020-08-12 13:50:40.000000000 +0200 +++ new/yast2-fcoe-client-4.4.1/package/yast2-fcoe-client.changes 2021-04-21 09:32:39.000000000 +0200 @@ -1,4 +1,17 @@ ------------------------------------------------------------------- +Tue Apr 20 18:14:05 UTC 2021 - Dirk M??ller <[email protected]> + +- stop packaging docdir, it only contained the license which + is now in licensedir (bsc#1184897) +- spec file cleanups +- 4.4.1 + +------------------------------------------------------------------- +Tue Apr 20 13:51:55 UTC 2021 - Ladislav Slez??k <[email protected]> + +- 4.4.0 + +------------------------------------------------------------------- Mon Aug 10 17:49:50 CEST 2020 - [email protected] - AutoYaST: Added supplements: autoyast(fcoe-client) into the spec file diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-fcoe-client-4.3.0/package/yast2-fcoe-client.spec new/yast2-fcoe-client-4.4.1/package/yast2-fcoe-client.spec --- old/yast2-fcoe-client-4.3.0/package/yast2-fcoe-client.spec 2020-08-12 13:50:40.000000000 +0200 +++ new/yast2-fcoe-client-4.4.1/package/yast2-fcoe-client.spec 2021-04-21 09:32:39.000000000 +0200 @@ -1,7 +1,7 @@ # # spec file for package yast2-fcoe-client # -# Copyright (c) 2013 SUSE LINUX Products GmbH, Nuernberg, Germany. +# Copyright (c) 2021 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -17,26 +17,23 @@ Name: yast2-fcoe-client -Version: 4.3.0 +Version: 4.4.1 Release: 0 Summary: YaST2 - Configuration of Fibre Channel over Ethernet -Group: System/YaST License: GPL-2.0-only -Url: https://github.com/yast/yast-fcoe-client - +Group: System/YaST +URL: https://github.com/yast/yast-fcoe-client Source0: %{name}-%{version}.tar.bz2 - -BuildRequires: perl-XML-Writer update-desktop-files yast2 -BuildRequires: yast2-devtools >= 4.2.2 +BuildRequires: perl-XML-Writer +BuildRequires: update-desktop-files +BuildRequires: yast2 +BuildRequires: yast2-devtools >= 4.4.0 BuildRequires: rubygem(%{rb_default_ruby_abi}:rspec) - # Yast2::Systemd::Service -Requires: yast2 >= 4.1.3 Requires: fcoe-utils +Requires: yast2 >= 4.1.3 Requires: yast2-ruby-bindings >= 1.0.0 - Supplements: autoyast(fcoe-client) - BuildArch: noarch %description @@ -54,14 +51,13 @@ %yast_metainfo %files +%license COPYING %{yast_yncludedir} %{yast_clientdir} %{yast_moduledir} %{yast_desktopdir} %{yast_metainfodir} %{yast_scrconfdir} -%doc %{yast_docdir} %{yast_icondir} -%license COPYING %changelog diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-fcoe-client-4.3.0/test/DetectNetworkCards_spec.rb new/yast2-fcoe-client-4.4.1/test/DetectNetworkCards_spec.rb --- old/yast2-fcoe-client-4.3.0/test/DetectNetworkCards_spec.rb 2020-08-12 13:50:40.000000000 +0200 +++ new/yast2-fcoe-client-4.4.1/test/DetectNetworkCards_spec.rb 2021-04-21 09:32:39.000000000 +0200 @@ -3,37 +3,34 @@ Yast.import "FcoeClient" describe Yast::FcoeClientClass do - before :each do - @fcoe = Yast::FcoeClientClass.new - @fcoe.main() - - @test_class = @fcoe + subject { Yast::FcoeClient } - @test_class.stub(:GetVlanInterfaces).and_return({ "eth1" => [{ "vlan" => "400", "fcf" => "00:0d:ec:a2:ef:00" }, + before :each do + allow(subject).to receive(:GetVlanInterfaces).and_return({ "eth1" => [{ "vlan" => "400", "fcf" => "00:0d:ec:a2:ef:00" }, { "vlan" => "300", "fcf" => "00:0d:ec:a2:ef:01" }], "eth2" => [{ "vlan" => "200", "fcf" => "00:0d:ec:a2:ef:02" }]}) - @test_class.stub(:GetFcoeVlanInterface).with("eth1", "400").and_return("eth1.400") - @test_class.stub(:GetFcoeVlanInterface).with("eth1", "300").and_return("") - @test_class.stub(:GetFcoeVlanInterface).with("eth2", "200").and_return("") + allow(subject).to receive(:GetFcoeVlanInterface).with("eth1", "400").and_return("eth1.400") + allow(subject).to receive(:GetFcoeVlanInterface).with("eth1", "300").and_return("") + allow(subject).to receive(:GetFcoeVlanInterface).with("eth2", "200").and_return("") - @test_class.stub(:FcoeOnOnterface?).and_return(false) + allow(subject).to receive(:FcoeOnInterface?).and_return(false) - @test_class.stub(:GetFcoeStatus).with("eth1.400", "eth1").and_return({ + allow(subject).to receive(:GetFcoeStatus).with("eth1.400", "eth1").and_return({ "AUTO_VLAN" => "no", "DCB_REQUIRED"=>"yes", "FCOE_ENABLE" => "yes", "cfg_device" => "eth1.400" }) - @test_class.stub(:GetFcoeStatus).with("eth1.300", "eth1").and_return({}) - @test_class.stub(:GetFcoeStatus).with("eth2.200", "eth2").and_return({}) + allow(subject).to receive(:GetFcoeStatus).with("eth1.300", "eth1").and_return({}) + allow(subject).to receive(:GetFcoeStatus).with("eth2.200", "eth2").and_return({}) - @test_class.stub(:DCBCapable).and_return("no") + allow(subject).to receive(:DCBCapable).and_return("no") end context "with valid argument (a list of maps containing hwinfo about netcards)" do it "#DetectNetworkCards returns a list of maps containing card info extended by vlan/fcoe info" do - answer = @test_class.DetectNetworkCards([ + answer = subject.DetectNetworkCards([ { "bus" => "PCI", "bus_hwcfg" => "pci", @@ -59,7 +56,7 @@ "iscsioffload"=> false } ]) - answer.should eq([ + expect(answer). to eq([ { "auto_vlan" => "yes", "cfg_device"=> "", @@ -109,8 +106,7 @@ context "with empty list as argument" do it "#DetectNetworkCards returns empty list" do - answer = @test_class.DetectNetworkCards([]) - answer.should eq([]) + expect(subject.DetectNetworkCards([])).to eq([]) end end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-fcoe-client-4.3.0/test/test_helper.rb new/yast2-fcoe-client-4.4.1/test/test_helper.rb --- old/yast2-fcoe-client-4.3.0/test/test_helper.rb 2020-08-12 13:50:40.000000000 +0200 +++ new/yast2-fcoe-client-4.4.1/test/test_helper.rb 2021-04-21 09:32:39.000000000 +0200 @@ -5,6 +5,14 @@ require "yast" require "yast/rspec" +RSpec.configure do |config| + config.mock_with :rspec do |c| + # make sure we mock only the existing methods + # https://relishapp.com/rspec/rspec-mocks/v/3-0/docs/verifying-doubles/partial-doubles + c.verify_partial_doubles = true + end +end + if ENV["COVERAGE"] require "simplecov" SimpleCov.start do @@ -14,12 +22,20 @@ # track all ruby files under src SimpleCov.track_files("#{srcdir}/**/*.rb") - # use coveralls for on-line code coverage reporting at Travis CI - if ENV["TRAVIS"] - require "coveralls" - SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new [ + # additionally use the LCOV format for on-line code coverage reporting at CI + if ENV["CI"] || ENV["COVERAGE_LCOV"] + require "simplecov-lcov" + + SimpleCov::Formatter::LcovFormatter.config do |c| + c.report_with_single_file = true + # this is the default Coveralls GitHub Action location + # https://github.com/marketplace/actions/coveralls-github-action + c.single_report_path = "coverage/lcov.info" + end + + SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[ SimpleCov::Formatter::HTMLFormatter, - Coveralls::SimpleCov::Formatter + SimpleCov::Formatter::LcovFormatter ] end end
