Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package steamos-powerbuttond for
openSUSE:Factory checked in at 2026-01-22 15:19:02
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/steamos-powerbuttond (Old)
and /work/SRC/openSUSE:Factory/.steamos-powerbuttond.new.1928 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "steamos-powerbuttond"
Thu Jan 22 15:19:02 2026 rev:2 rq:1328650 version:3.3
Changes:
--------
---
/work/SRC/openSUSE:Factory/steamos-powerbuttond/steamos-powerbuttond.changes
2025-10-21 11:18:06.043030227 +0200
+++
/work/SRC/openSUSE:Factory/.steamos-powerbuttond.new.1928/steamos-powerbuttond.changes
2026-01-22 15:20:06.621057660 +0100
@@ -1,0 +2,17 @@
+Mon Oct 20 11:13:55 UTC 2025 - Matthias Gerstner <[email protected]>
+
+- add fix-cmdline-overflow.patch: this fixes memory corruption if more than
+ MAX_DEVS command line arguments are passed.
+
+ An invocation like:
+
+ /usr/lib/hwsupport/steamos-powerbuttond /dev/input/event0 /dev/input/event1
/dev/input/event2 /dev/input/event3 /dev/input/event4 /dev/input/event5
/dev/input/event0
+
+ otherwise ends up in a segmentation fault or similar issues.
+
+ Finding in the context of the review bug bsc#1249602.
+
+ The upstream repository is only a mirror from semi-public Valve sources, so
+ submitting it there doesn't seem to make sense at the moment.
+
+-------------------------------------------------------------------
New:
----
fix-cmdline-overflow.patch
----------(New B)----------
New:
- add fix-cmdline-overflow.patch: this fixes memory corruption if more than
MAX_DEVS command line arguments are passed.
----------(New E)----------
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ steamos-powerbuttond.spec ++++++
--- /var/tmp/diff_new_pack.gOeP9O/_old 2026-01-22 15:20:08.213123884 +0100
+++ /var/tmp/diff_new_pack.gOeP9O/_new 2026-01-22 15:20:08.217124051 +0100
@@ -23,6 +23,7 @@
URL: https://gitlab.com/evlaV/powerbuttond
Source: %{name}-%{version}.tar.xz
Patch0: steamos-powerbuttond-service.patch
+Patch1: fix-cmdline-overflow.patch
BuildRequires: gcc
BuildRequires: make
++++++ fix-cmdline-overflow.patch ++++++
Index: steamos-powerbuttond-3.3/powerbuttond.c
===================================================================
--- steamos-powerbuttond-3.3.orig/powerbuttond.c
+++ steamos-powerbuttond-3.3/powerbuttond.c
@@ -134,7 +134,9 @@ int main(int argc, char* argv[]) {
struct pollfd pfds[MAX_DEVS] = {0};
size_t num_devs = 0;
- if (argc >= 2) {
+ if (argc > MAX_DEVS)
+ return 1;
+ else if (argc >= 2) {
int i;
for (i = 0; i < argc - 1; ++i) {
devs[num_devs] = open_dev(argv[i + 1]);
