Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2026-03-13 21:15:43 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.8177 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "virt-manager" Fri Mar 13 21:15:43 2026 rev:289 rq:1338392 version:5.1.0 Changes: -------- --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2026-03-08 17:25:54.568402370 +0100 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.8177/virt-manager.changes 2026-03-13 21:15:59.163298091 +0100 @@ -1,0 +2,7 @@ +Tue Mar 10 14:51:39 MDT 2026 - [email protected] + +- Simplify how we detect if an OS recommends efi as the preferred + firmware. + virtinst-query-recommended-firmware.patch + +------------------------------------------------------------------- ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ virtinst-query-recommended-firmware.patch ++++++ --- /var/tmp/diff_new_pack.x5py6G/_old 2026-03-13 21:16:01.239381273 +0100 +++ /var/tmp/diff_new_pack.x5py6G/_new 2026-03-13 21:16:01.243381433 +0100 @@ -5,37 +5,31 @@ =================================================================== --- virt-manager-5.1.0.orig/virtinst/osdict.py +++ virt-manager-5.1.0/virtinst/osdict.py -@@ -445,21 +445,27 @@ class _OsVariant: +@@ -443,6 +443,17 @@ class _OsVariant: + return self._os.get_complete_firmware_list().get_elements() + return [] # pragma: no cover ++ def _recommends_uefi(self, arch): ++ if hasattr(Libosinfo.Firmware, "is_recommended"): ++ firmwares = self._get_firmware_list() ++ for firmware in firmwares: # pragma: no cover ++ if firmware.get_architecture() != arch: ++ continue ++ if firmware.get_firmware_type() == "efi": ++ return firmware.is_recommended() ++ ++ return False ++ def _supports_firmware_type(self, name, arch, default): firmwares = self._get_firmware_list() -+ is_supported = default -+ is_recommended = False - - for firmware in firmwares: # pragma: no cover - if firmware.get_architecture() != arch: - continue - if firmware.get_firmware_type() == name: -- return firmware.is_supported() -+ is_supported = firmware.is_supported() -+ if hasattr(firmware, "is_recommended"): -+ is_recommended = firmware.is_recommended() - -- return default -+ return (is_supported, is_recommended) +@@ -457,6 +468,8 @@ class _OsVariant: def requires_firmware_efi(self, arch): ret = False try: -- supports_efi = self._supports_firmware_type("efi", arch, False) -- supports_bios = self._supports_firmware_type("bios", arch, True) -- ret = supports_efi and not supports_bios -+ supports_efi, recommended_efi = self._supports_firmware_type("efi", arch, False) -+ supports_bios, recommended_bios = self._supports_firmware_type("bios", arch, True) -+ if supports_efi: -+ if not supports_bios or recommended_efi: -+ ret = True - except Exception: # pragma: no cover - log.debug("Error checking osinfo firmware support", exc_info=True) - ++ if self._recommends_uefi(arch): ++ return True + supports_efi = self._supports_firmware_type("efi", arch, False) + supports_bios = self._supports_firmware_type("bios", arch, True) + ret = supports_efi and not supports_bios
