Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package os-autoinst for openSUSE:Factory checked in at 2026-03-24 18:48:35 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/os-autoinst (Old) and /work/SRC/openSUSE:Factory/.os-autoinst.new.8177 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "os-autoinst" Tue Mar 24 18:48:35 2026 rev:577 rq:1342080 version:5.1774283485.5af53fe Changes: -------- --- /work/SRC/openSUSE:Factory/os-autoinst/os-autoinst.changes 2026-03-23 17:15:24.686773154 +0100 +++ /work/SRC/openSUSE:Factory/.os-autoinst.new.8177/os-autoinst.changes 2026-03-24 18:49:19.255575116 +0100 @@ -1,0 +2,12 @@ +Mon Mar 23 17:02:21 UTC 2026 - [email protected] + +- Update to version 5.1774283485.5af53fe: + * Revert "style: Remove local Perl::Critic::Policy::HashKeyQuotes" + * style: Remove local Perl::Critic::Policy::HashKeyQuotes + * style: Add xt/02-perlcritic.t + * style: Fix Community::WhileDiamondDefaultAssignment + * fix(ci): correct import of commit-message-checker + * style: Fix various no strict / no critic violations + * style: Fix OpenQA::HashKeyQuotes + +------------------------------------------------------------------- Old: ---- os-autoinst-5.1774101470.e82b4cb.obscpio New: ---- os-autoinst-5.1774283485.5af53fe.obscpio ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ os-autoinst-devel-test.spec ++++++ --- /var/tmp/diff_new_pack.7b13IZ/_old 2026-03-24 18:49:21.363662098 +0100 +++ /var/tmp/diff_new_pack.7b13IZ/_new 2026-03-24 18:49:21.379662758 +0100 @@ -18,7 +18,7 @@ %define short_name os-autoinst-devel Name: %{short_name}-test -Version: 5.1774101470.e82b4cb +Version: 5.1774283485.5af53fe Release: 0 Summary: Test package for %{short_name} License: GPL-2.0-or-later ++++++ os-autoinst-openvswitch-test.spec ++++++ --- /var/tmp/diff_new_pack.7b13IZ/_old 2026-03-24 18:49:21.699675962 +0100 +++ /var/tmp/diff_new_pack.7b13IZ/_new 2026-03-24 18:49:21.727677117 +0100 @@ -19,7 +19,7 @@ %define name_ext -test %define short_name os-autoinst-openvswitch Name: %{short_name}%{?name_ext} -Version: 5.1774101470.e82b4cb +Version: 5.1774283485.5af53fe Release: 0 Summary: test package for %{short_name} License: GPL-2.0-or-later ++++++ os-autoinst-test.spec ++++++ --- /var/tmp/diff_new_pack.7b13IZ/_old 2026-03-24 18:49:21.991688010 +0100 +++ /var/tmp/diff_new_pack.7b13IZ/_new 2026-03-24 18:49:22.011688836 +0100 @@ -19,7 +19,7 @@ %define name_ext -test %define short_name os-autoinst Name: %{short_name}%{?name_ext} -Version: 5.1774101470.e82b4cb +Version: 5.1774283485.5af53fe Release: 0 Summary: test package for os-autoinst License: GPL-2.0-or-later ++++++ os-autoinst.spec ++++++ --- /var/tmp/diff_new_pack.7b13IZ/_old 2026-03-24 18:49:22.415705506 +0100 +++ /var/tmp/diff_new_pack.7b13IZ/_new 2026-03-24 18:49:22.435706331 +0100 @@ -17,7 +17,7 @@ Name: os-autoinst -Version: 5.1774101470.e82b4cb +Version: 5.1774283485.5af53fe Release: 0 Summary: OS-level test automation License: GPL-2.0-or-later ++++++ os-autoinst-5.1774101470.e82b4cb.obscpio -> os-autoinst-5.1774283485.5af53fe.obscpio ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/os-autoinst-5.1774101470.e82b4cb/.github/workflows/commit-message-checker.yml new/os-autoinst-5.1774283485.5af53fe/.github/workflows/commit-message-checker.yml --- old/os-autoinst-5.1774101470.e82b4cb/.github/workflows/commit-message-checker.yml 2026-03-24 18:49:26.051855537 +0100 +++ new/os-autoinst-5.1774283485.5af53fe/.github/workflows/commit-message-checker.yml 2026-03-23 17:31:25.000000000 +0100 @@ -1 +1,13 @@ -symbolic link to ../../external/os-autoinst-common/.github/workflows/commit-message-checker.yml +--- +name: 'Commit message check' + +on: + pull_request: + push: + branches: + # we must not fix commit messages when they already reached master + - '!master' + +jobs: + check-commit-message: + uses: os-autoinst/os-autoinst-common/.github/workflows/base-commit-message-checker.yml@master diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/os-autoinst-5.1774101470.e82b4cb/autotest.pm new/os-autoinst-5.1774283485.5af53fe/autotest.pm --- old/os-autoinst-5.1774101470.e82b4cb/autotest.pm 2026-03-21 14:57:50.000000000 +0100 +++ new/os-autoinst-5.1774283485.5af53fe/autotest.pm 2026-03-23 17:31:25.000000000 +0100 @@ -129,7 +129,7 @@ eval "use $perlmod ()"; if ($@) { die "Could not load '$perlmod': $@" } my %exports; - no strict 'refs'; + no strict 'refs'; ## no critic (TestingAndDebugging::ProhibitNoStrict, TestingAndDebugging::ProhibitProlongedStrictureOverride) my @export = @{"${perlmod}::EXPORT"}; my @export_ok = @{"${perlmod}::EXPORT_OK"}; @exports{@export, @export_ok} = (); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/os-autoinst-5.1774101470.e82b4cb/backend/console_proxy.pm new/os-autoinst-5.1774283485.5af53fe/backend/console_proxy.pm --- old/os-autoinst-5.1774101470.e82b4cb/backend/console_proxy.pm 2026-03-21 14:57:50.000000000 +0100 +++ new/os-autoinst-5.1774283485.5af53fe/backend/console_proxy.pm 2026-03-23 17:31:25.000000000 +0100 @@ -30,7 +30,7 @@ $function =~ s,.*::,,; # allow symbolic references - no strict 'refs'; + no strict 'refs'; ## no critic (TestingAndDebugging::ProhibitNoStrict) *$AUTOLOAD = sub { # no:style:signatures my $self = shift; my $args = \@_; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/os-autoinst-5.1774101470.e82b4cb/backend/generalhw.pm new/os-autoinst-5.1774283485.5af53fe/backend/generalhw.pm --- old/os-autoinst-5.1774101470.e82b4cb/backend/generalhw.pm 2026-03-21 14:57:50.000000000 +0100 +++ new/os-autoinst-5.1774283485.5af53fe/backend/generalhw.pm 2026-03-23 17:31:25.000000000 +0100 @@ -35,7 +35,7 @@ 'GENERAL_HW_EJECT_CMD' => 'GENERAL_HW_EJECT_ARGS', 'GENERAL_HW_IS_SHUTDOWN_CMD' => 'GENERAL_HW_IS_SHUTDOWN_ARGS', ); - my $args = $bmwqemu::vars{$GENERAL_HW_ARG_VARIABLES_BY_CMD{$cmd}} if $bmwqemu::vars{$GENERAL_HW_ARG_VARIABLES_BY_CMD{$cmd}}; + my $args = $bmwqemu::vars{$GENERAL_HW_ARG_VARIABLES_BY_CMD{$cmd}}; $cmd = $bmwqemu::vars{$cmd} or die "Need test variable '$cmd'"; $cmd = "$dir/" . basename($cmd); @@ -88,7 +88,7 @@ } } -sub eject_cd($self, $args = {}) { +sub eject_cd ($self, $args = {}) { my @extra_args; push @extra_args, "--id=$args->{id}" if ($args->{id}); push @extra_args, '--force' if ($args->{force}); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/os-autoinst-5.1774101470.e82b4cb/backend/qemu.pm new/os-autoinst-5.1774283485.5af53fe/backend/qemu.pm --- old/os-autoinst-5.1774101470.e82b4cb/backend/qemu.pm 2026-03-21 14:57:50.000000000 +0100 +++ new/os-autoinst-5.1774283485.5af53fe/backend/qemu.pm 2026-03-23 17:31:25.000000000 +0100 @@ -670,7 +670,7 @@ sp('device', "${device}${options}"); } -sub determine_qemu_version($self, $qemubin) { +sub determine_qemu_version ($self, $qemubin) { my $qemu_version = qx{$qemubin -version}; $qemu_version =~ /([0-9]+([.][0-9]+)+)/; $qemu_version = $1; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/os-autoinst-5.1774101470.e82b4cb/cmake/test-targets.cmake new/os-autoinst-5.1774283485.5af53fe/cmake/test-targets.cmake --- old/os-autoinst-5.1774101470.e82b4cb/cmake/test-targets.cmake 2026-03-21 14:57:50.000000000 +0100 +++ new/os-autoinst-5.1774283485.5af53fe/cmake/test-targets.cmake 2026-03-23 17:31:25.000000000 +0100 @@ -102,18 +102,6 @@ message(STATUS "Set SHELLCHECK_PATH to the path of shellcheck to enable Shell style checks.") endif () -# add test for Perl syntax/style issues -find_program(PERLCRITIC_PATH perlcritic) -if (PERLCRITIC_PATH) - add_test( - NAME test-local-perl-style - COMMAND "${CMAKE_CURRENT_SOURCE_DIR}/tools/check-perl-style" "${PERLCRITIC_PATH}" - WORKING_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}" - ) -else () - message(STATUS "Set PERLCRITIC_PATH to the path of the perlcritic executable to enable Perl syntax/style checks.") -endif () - # add test for bash script syntax find_program(SH_PATH shfmt) if (SH_PATH) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/os-autoinst-5.1774101470.e82b4cb/consoles/video_stream.pm new/os-autoinst-5.1774283485.5af53fe/consoles/video_stream.pm --- old/os-autoinst-5.1774101470.e82b4cb/consoles/video_stream.pm 2026-03-21 14:57:50.000000000 +0100 +++ new/os-autoinst-5.1774283485.5af53fe/consoles/video_stream.pm 2026-03-23 17:31:25.000000000 +0100 @@ -123,9 +123,8 @@ } sub _get_ffmpeg_cmd ($self, $url) { - my $fps = $1 if ($url =~ s/[\?&]fps=([0-9]+)//); + my $fps = $url =~ s/[\?&]fps=([0-9]+)// ? $1 : 4; die 'ffmpeg url does not support format=' if ($url =~ s/[\?&]format=([A-Z0-9]+)//); - $fps //= 4; my @cmd; @cmd = split(/ /, $self->{args}->{video_cmd_prefix}) if $self->{args}->{video_cmd_prefix}; push(@cmd, ('ffmpeg', '-loglevel', 'fatal', '-i', $url)); @@ -134,10 +133,8 @@ } sub _get_ustreamer_cmd ($self, $url, $sink_name) { - my $fps = $1 if ($url =~ s/[\?&]fps=([0-9]+)//); - my $format = $1 if ($url =~ s/[\?&]format=([A-Z0-9]+(swap)?)//); - $fps //= 5; - $format //= 'UYVY'; + my $fps = $url =~ s/[\?&]fps=([0-9]+)// ? $1 : 5; + my $format = $url =~ s/[\?&]format=([A-Z0-9]+(swap)?)// ? $1 : 'UYVY'; my $swap = ($format =~ /swap$/); $format =~ s/swap$//; my $cmd = [ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/os-autoinst-5.1774101470.e82b4cb/external/os-autoinst-common/.perlcriticrc new/os-autoinst-5.1774283485.5af53fe/external/os-autoinst-common/.perlcriticrc --- old/os-autoinst-5.1774101470.e82b4cb/external/os-autoinst-common/.perlcriticrc 2026-03-21 14:57:50.000000000 +0100 +++ new/os-autoinst-5.1774283485.5af53fe/external/os-autoinst-common/.perlcriticrc 2026-03-23 17:31:25.000000000 +0100 @@ -1,6 +1,7 @@ theme = community + openqa severity = 4 include = strict ValuesAndExpressions::ProhibitInterpolationOfLiterals +exclude = OpenQA::RedundantStrictWarning verbose = ::warning file=%f,line=%l,col=%c,title=%m - severity %s::[%p] %e\n diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/os-autoinst-5.1774101470.e82b4cb/myjsonrpc.pm new/os-autoinst-5.1774283485.5af53fe/myjsonrpc.pm --- old/os-autoinst-5.1774101470.e82b4cb/myjsonrpc.pm 2026-03-21 14:57:50.000000000 +0100 +++ new/os-autoinst-5.1774283485.5af53fe/myjsonrpc.pm 2026-03-23 17:31:25.000000000 +0100 @@ -17,7 +17,7 @@ # hash for keeping state our $sockets; -sub _syswrite($to_fd, $json, $length = undef, $offset = undef) { syswrite($to_fd, $json, $length, $offset) } +sub _syswrite ($to_fd, $json, $length = undef, $offset = undef) { syswrite($to_fd, $json, $length, $offset) } sub is_debug () { DEBUG_JSON || $bmwqemu::vars{DEBUG_JSON_RPC} } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/os-autoinst-5.1774101470.e82b4cb/ppmclibs/tinycv.pm new/os-autoinst-5.1774283485.5af53fe/ppmclibs/tinycv.pm --- old/os-autoinst-5.1774101470.e82b4cb/ppmclibs/tinycv.pm 2026-03-21 14:57:50.000000000 +0100 +++ new/os-autoinst-5.1774283485.5af53fe/ppmclibs/tinycv.pm 2026-03-23 17:31:25.000000000 +0100 @@ -123,7 +123,7 @@ # if match is equal quality prefer workaround needle to non-workaround # the name doesn't matter, but we prefer alphabetic order sub cmp_by_error_type_ { # no:style:signatures - ## no critic ($a/$b outside of sort block) + ## no critic (Community::DollarAB) my $okay = $b->{ok} <=> $a->{ok}; return $okay if $okay; my $error = $a->{error} <=> $b->{error}; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/os-autoinst-5.1774101470.e82b4cb/script/imgsearch new/os-autoinst-5.1774283485.5af53fe/script/imgsearch --- old/os-autoinst-5.1774101470.e82b4cb/script/imgsearch 2026-03-21 14:57:50.000000000 +0100 +++ new/os-autoinst-5.1774283485.5af53fe/script/imgsearch 2026-03-23 17:31:25.000000000 +0100 @@ -66,7 +66,7 @@ usage(1) unless @needle_image_paths && @image_paths; # stop opencv logging messages polluting stdout -$ENV{'OPENCV_LOG_LEVEL'} ||= 'SILENT'; +$ENV{OPENCV_LOG_LEVEL} ||= 'SILENT'; # initialize logging, tinycv and parameters my $log = Mojo::Log->new; $log->level($verbose ? 'debug' : 'info'); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/os-autoinst-5.1774101470.e82b4cb/script/os-autoinst-generate-needle-preview new/os-autoinst-5.1774283485.5af53fe/script/os-autoinst-generate-needle-preview --- old/os-autoinst-5.1774101470.e82b4cb/script/os-autoinst-generate-needle-preview 2026-03-21 14:57:50.000000000 +0100 +++ new/os-autoinst-5.1774283485.5af53fe/script/os-autoinst-generate-needle-preview 2026-03-23 17:31:25.000000000 +0100 @@ -122,8 +122,8 @@ my $has_error = 0; if ($ARGV[0] eq '-') { # Read a list of files to process from stdin - while (<STDIN>) { - $has_error |= process_file $_; + while (my $line = <STDIN>) { + $has_error |= process_file $line; } } else { for (@ARGV) { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/os-autoinst-5.1774101470.e82b4cb/script/os-autoinst-openvswitch new/os-autoinst-5.1774283485.5af53fe/script/os-autoinst-openvswitch --- old/os-autoinst-5.1774101470.e82b4cb/script/os-autoinst-openvswitch 2026-03-21 14:57:50.000000000 +0100 +++ new/os-autoinst-5.1774283485.5af53fe/script/os-autoinst-openvswitch 2026-03-23 17:31:25.000000000 +0100 @@ -283,7 +283,7 @@ sub usage ($r) { require Pod::Usage; Pod::Usage::pod2usage($r) } -sub run_dbus($bus = Net::DBus->system, $reactor_main = Net::DBus::Reactor->main) { +sub run_dbus ($bus = Net::DBus->system, $reactor_main = Net::DBus::Reactor->main) { say 'Initializing D-Bus service and Open vSwitch'; my $service = $bus->export_service('org.opensuse.os_autoinst.switch'); my $object = OVS->new($service); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/os-autoinst-5.1774101470.e82b4cb/t/03-testapi.t new/os-autoinst-5.1774283485.5af53fe/t/03-testapi.t --- old/os-autoinst-5.1774101470.e82b4cb/t/03-testapi.t 2026-03-21 14:57:50.000000000 +0100 +++ new/os-autoinst-5.1774283485.5af53fe/t/03-testapi.t 2026-03-23 17:31:25.000000000 +0100 @@ -789,9 +789,9 @@ $mock_testapi->redefine(is_serial_terminal => sub { return $is_serial_terminal }); $mock_testapi->redefine(wait_serial => "XXXfoo\nSCRIPT_FINISHEDXXX-0-"); - $bmwqemu::vars{'OFFLINE_SUT'} = 1; + $bmwqemu::vars{OFFLINE_SUT} = 1; is(script_output('echo foo'), 'foo', 'sucessfull retrieves output of script'); - $bmwqemu::vars{'OFFLINE_SUT'} = 0; + $bmwqemu::vars{OFFLINE_SUT} = 0; $mock_testapi->redefine(wait_serial => 'SCRIPT_FINISHEDXXX-0-'); is(script_output('foo'), '', 'calling script_output does not fail if script returns with success'); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/os-autoinst-5.1774101470.e82b4cb/tools/check-perl-style new/os-autoinst-5.1774283485.5af53fe/tools/check-perl-style --- old/os-autoinst-5.1774101470.e82b4cb/tools/check-perl-style 2026-03-21 14:57:50.000000000 +0100 +++ new/os-autoinst-5.1774283485.5af53fe/tools/check-perl-style 1970-01-01 01:00:00.000000000 +0100 @@ -1,3 +0,0 @@ -#!/bin/sh -e -export PERL5LIB=tools/lib/perlcritic:"$PERL5LIB" -"${1:-perlcritic}" --gentle --include Perl::Critic::Policy::HashKeyQuote "${2:-$PWD}" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/os-autoinst-5.1774101470.e82b4cb/xt/02-perlcritic.t new/os-autoinst-5.1774283485.5af53fe/xt/02-perlcritic.t --- old/os-autoinst-5.1774101470.e82b4cb/xt/02-perlcritic.t 1970-01-01 01:00:00.000000000 +0100 +++ new/os-autoinst-5.1774283485.5af53fe/xt/02-perlcritic.t 2026-03-23 17:31:25.000000000 +0100 @@ -0,0 +1,11 @@ +# Copyright SUSE LLC +# SPDX-License-Identifier: GPL-2.0-or-later + +use Test::Most; +use FindBin '$Bin'; +use lib "$Bin/../external/os-autoinst-common/lib/perlcritic"; +use Test::Perl::Critic; +use Perl::Critic::Utils qw(all_perl_files); + +my @files = grep { not m{^(?:t/fake|t/data)} } all_perl_files('.'); +all_critic_ok(@files); ++++++ os-autoinst.obsinfo ++++++ --- /var/tmp/diff_new_pack.7b13IZ/_old 2026-03-24 18:49:27.095898615 +0100 +++ /var/tmp/diff_new_pack.7b13IZ/_new 2026-03-24 18:49:27.099898780 +0100 @@ -1,5 +1,5 @@ name: os-autoinst -version: 5.1774101470.e82b4cb -mtime: 1774101470 -commit: e82b4cba721a6c42070988eb68956999147a686b +version: 5.1774283485.5af53fe +mtime: 1774283485 +commit: 5af53feb2cb2969b72228bab06f148c633668b23
