Script 'mail_helper' called by obssrc
Hello community,

here is the log from the commit of package yast2-proxy for openSUSE:Factory 
checked in at 2026-03-26 21:07:05
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-proxy (Old)
 and      /work/SRC/openSUSE:Factory/.yast2-proxy.new.8177 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "yast2-proxy"

Thu Mar 26 21:07:05 2026 rev:28 rq:1342593 version:5.0.1

Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-proxy/yast2-proxy.changes  2023-10-20 
23:17:58.697171445 +0200
+++ /work/SRC/openSUSE:Factory/.yast2-proxy.new.8177/yast2-proxy.changes        
2026-03-27 06:53:34.724047915 +0100
@@ -1,0 +2,6 @@
+Tue Mar 10 09:00:28 UTC 2026 - Michal Filka <[email protected]>
+
+- jsc#PED-14507
+  - Removed reference to update-desktop-files from spec file 
+  - 5.0.1
+-------------------------------------------------------------------

Old:
----
  yast2-proxy-5.0.0.tar.bz2

New:
----
  yast2-proxy-5.0.1.tar.bz2

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ yast2-proxy.spec ++++++
--- /var/tmp/diff_new_pack.PvrjAL/_old  2026-03-27 06:53:35.236069053 +0100
+++ /var/tmp/diff_new_pack.PvrjAL/_new  2026-03-27 06:53:35.236069053 +0100
@@ -1,7 +1,7 @@
 #
 # spec file for package yast2-proxy
 #
-# Copyright (c) 2023 SUSE LLC
+# Copyright (c) 2026 SUSE LLC and contributors
 #
 # All modifications and additions to the file contributed by third parties
 # remain the property of their copyright owners, unless otherwise agreed
@@ -17,7 +17,7 @@
 
 
 Name:           yast2-proxy
-Version:        5.0.0
+Version:        5.0.1
 Release:        0
 Summary:        YaST2 - Proxy Configuration
 License:        GPL-2.0-or-later
@@ -26,7 +26,6 @@
 
 Source0:        %{name}-%{version}.tar.bz2
 
-BuildRequires:  update-desktop-files
 BuildRequires:  yast2
 BuildRequires:  yast2-buildtools >= 4.2.2
 BuildRequires:  rubygem(%{rb_default_ruby_abi}:rspec)

++++++ yast2-proxy-5.0.0.tar.bz2 -> yast2-proxy-5.0.1.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-proxy-5.0.0/.github/workflows/ci.yml 
new/yast2-proxy-5.0.1/.github/workflows/ci.yml
--- old/yast2-proxy-5.0.0/.github/workflows/ci.yml      2023-10-18 
23:19:14.000000000 +0200
+++ new/yast2-proxy-5.0.1/.github/workflows/ci.yml      2026-03-25 
18:36:01.000000000 +0100
@@ -1,9 +1,8 @@
-
 # See 
https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions
 
 name: CI
 
-on: [push, pull_request]
+on: [ push, pull_request ]
 
 jobs:
   Tests:
@@ -12,33 +11,32 @@
     strategy:
       fail-fast: false
       matrix:
-        distro:  [ "tumbleweed", "leap_latest" ]
+        distro: [ "tumbleweed" ]
 
     container:
       image: 
registry.opensuse.org/yast/head/containers_${{matrix.distro}}/yast-ruby
 
     steps:
+      - name: Git Checkout
+        uses: actions/checkout@v2
 
-    - name: Git Checkout
-      uses: actions/checkout@v2
-
-    # just for easier debugging...
-    - name: Inspect Installed Packages
-      run: rpm -qa | sort
-
-    - name: Unit Tests
-      run: rake test:unit
-      # enable code coverage reporting
-      env:
-        COVERAGE: 1
-
-    # send the coverage report to coveralls.io
-    - name: Coveralls Report
-      # send it only from the TW build to avoid duplicate submits
-      if: ${{ matrix.distro == 'tumbleweed' }}
-      uses: coverallsapp/github-action@master
-      with:
-        github-token: ${{ secrets.GITHUB_TOKEN }}
+      # just for easier debugging...
+      - name: Inspect Installed Packages
+        run: rpm -qa | sort
+
+      - name: Unit Tests
+        run: rake test:unit
+        # enable code coverage reporting
+        env:
+          COVERAGE: 1
+
+      # send the coverage report to coveralls.io
+      - name: Coveralls Report
+        # send it only from the TW build to avoid duplicate submits
+        if: ${{ matrix.distro == 'tumbleweed' }}
+        uses: coverallsapp/github-action@master
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
 
   Rubocop:
     runs-on: ubuntu-latest
@@ -46,37 +44,38 @@
     strategy:
       fail-fast: false
       matrix:
-        distro: [ "leap_latest" ]
+        distro: [ "tumbleweed" ]
 
     container:
       image: 
registry.opensuse.org/yast/head/containers_${{matrix.distro}}/yast-ruby
 
     steps:
+      - name: Git Checkout
+        uses: actions/checkout@v2
 
-    - name: Git Checkout
-      uses: actions/checkout@v2
-
-    - name: Rubocop
-      run: rake check:rubocop
+      - name: Rubocop
+        run: rake check:rubocop
 
   Package:
+    # skip in master, but run in forks
+    if:  github.ref_name != 'master' || github.repository_owner != 'yast'
+
     runs-on: ubuntu-latest
 
     strategy:
       fail-fast: false
       matrix:
-        distro:  [ "tumbleweed", "leap_latest" ]
+        distro: [ "tumbleweed" ]
 
     container:
       image: 
registry.opensuse.org/yast/head/containers_${{matrix.distro}}/yast-ruby
 
     steps:
+      - name: Git Checkout
+        uses: actions/checkout@v2
 
-    - name: Git Checkout
-      uses: actions/checkout@v2
-
-    - name: Package Build
-      run: yast-ci-ruby -o package
+      - name: Package Build
+        run: yast-ci-ruby -o package
 
   Yardoc:
     runs-on: ubuntu-latest
@@ -84,18 +83,17 @@
     strategy:
       fail-fast: false
       matrix:
-        distro: [ "leap_latest" ]
+        distro: [ "tumbleweed" ]
 
     container:
       image: 
registry.opensuse.org/yast/head/containers_${{matrix.distro}}/yast-ruby
 
     steps:
+      - name: Git Checkout
+        uses: actions/checkout@v2
 
-    - name: Git Checkout
-      uses: actions/checkout@v2
-
-    - name: Yardoc
-      run: rake check:doc
+      - name: Yardoc
+        run: rake check:doc
 
   # downloading the Docker image takes some time so bundling several fast
   # checks into one job avoids that overhead
@@ -105,15 +103,14 @@
     strategy:
       fail-fast: false
       matrix:
-        distro: [ "leap_latest" ]
+        distro: [ "tumbleweed" ]
 
     container:
       image: 
registry.opensuse.org/yast/head/containers_${{matrix.distro}}/yast-ruby
 
     steps:
+      - name: Git Checkout
+        uses: actions/checkout@v2
 
-    - name: Git Checkout
-      uses: actions/checkout@v2
-
-    - name: POT Check
-      run: rake check:pot
+      - name: POT Check
+        run: rake check:pot
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-proxy-5.0.0/.github/workflows/submit.yml 
new/yast2-proxy-5.0.1/.github/workflows/submit.yml
--- old/yast2-proxy-5.0.0/.github/workflows/submit.yml  1970-01-01 
01:00:00.000000000 +0100
+++ new/yast2-proxy-5.0.1/.github/workflows/submit.yml  2026-03-25 
18:36:01.000000000 +0100
@@ -0,0 +1,29 @@
+# See 
https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions
+
+name: OBS
+
+on:
+  # only when committing to master
+  push:
+    branches: master
+
+  # allow running manually from GitHub Web
+  workflow_dispatch:
+
+jobs:
+  submit:
+    # do not run in forks
+    if: github.repository_owner == 'yast'
+
+    runs-on: ubuntu-latest
+
+    # the default timeout is 6 hours, do not wait for that long if osc gets 
stucked
+    timeout-minutes: 30
+
+    steps:
+      - name: Submit the package
+        # see https://github.com/yast/actions/blob/master/submit/action.yml
+        uses: yast/actions/submit@master
+        with:
+          obs_user:     ${{ secrets.OBS_USER }}
+          obs_password: ${{ secrets.OBS_PASSWORD }}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-proxy-5.0.0/.rubocop.yml 
new/yast2-proxy-5.0.1/.rubocop.yml
--- old/yast2-proxy-5.0.0/.rubocop.yml  2023-10-18 23:19:14.000000000 +0200
+++ new/yast2-proxy-5.0.1/.rubocop.yml  2026-03-25 18:36:01.000000000 +0100
@@ -1,6 +1,6 @@
 # use the shared Yast defaults
 inherit_from:
-  /usr/share/YaST2/data/devtools/data/rubocop-0.71.0_yast_style.yml
+  /usr/share/YaST2/data/devtools/data/rubocop-1.24.1_yast_style.yml
 
 # this needs more testing if we can have frozen string literals
 Style/FrozenStringLiteralComment:
@@ -37,13 +37,6 @@
   Max: 60
 
 # Offense count: 10
-# Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, 
IgnoreCopDirectives, IgnoredPatterns.
-# URISchemes: http, https
-Metrics/LineLength:
-  Max: 140
-
-# Offense count: 10
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/MethodLength:
   Max: 320
@@ -67,7 +60,7 @@
 # Offense count: 2
 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, 
AllowedNames, ForbiddenNames.
 # AllowedNames: io, id, to, by, on, in, at, ip, db
-Naming/UncommunicativeMethodParamName:
+Naming/MethodParameterName:
   Exclude:
     - 'src/modules/Proxy.rb'
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-proxy-5.0.0/README.md 
new/yast2-proxy-5.0.1/README.md
--- old/yast2-proxy-5.0.0/README.md     2023-10-18 23:19:14.000000000 +0200
+++ new/yast2-proxy-5.0.1/README.md     2026-03-25 18:36:01.000000000 +0100
@@ -2,6 +2,5 @@
 
 [![Workflow 
Status](https://github.com/yast/yast-proxy/workflows/CI/badge.svg?branch=master)](
 https://github.com/yast/yast-proxy/actions?query=branch%3Amaster)
-[![Jenkins 
Status](https://ci.opensuse.org/buildStatus/icon?job=yast-yast-proxy-master)](
-https://ci.opensuse.org/view/Yast/job/yast-yast-proxy-master/)
+[![OBS](https://github.com/yast/yast-proxy/actions/workflows/submit.yml/badge.svg)](https://github.com/yast/yast-proxy/actions/workflows/submit.yml)
 [![Coverage 
Status](https://img.shields.io/coveralls/yast/yast-proxy.svg)](https://coveralls.io/r/yast/yast-proxy?branch=master)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-proxy-5.0.0/package/yast2-proxy.changes 
new/yast2-proxy-5.0.1/package/yast2-proxy.changes
--- old/yast2-proxy-5.0.0/package/yast2-proxy.changes   2023-10-18 
23:19:14.000000000 +0200
+++ new/yast2-proxy-5.0.1/package/yast2-proxy.changes   2026-03-25 
18:36:01.000000000 +0100
@@ -1,4 +1,10 @@
 -------------------------------------------------------------------
+Tue Mar 10 09:00:28 UTC 2026 - Michal Filka <[email protected]>
+
+- jsc#PED-14507
+  - Removed reference to update-desktop-files from spec file 
+  - 5.0.1
+-------------------------------------------------------------------
 Wed Aug 30 20:16:10 UTC 2023 - Josef Reidinger <[email protected]>
 
 - 5.0.0 (bsc#1185510)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-proxy-5.0.0/package/yast2-proxy.spec 
new/yast2-proxy-5.0.1/package/yast2-proxy.spec
--- old/yast2-proxy-5.0.0/package/yast2-proxy.spec      2023-10-18 
23:19:14.000000000 +0200
+++ new/yast2-proxy-5.0.1/package/yast2-proxy.spec      2026-03-25 
18:36:01.000000000 +0100
@@ -17,7 +17,7 @@
 
 
 Name:           yast2-proxy
-Version:        5.0.0
+Version:        5.0.1
 Release:        0
 Summary:        YaST2 - Proxy Configuration
 License:        GPL-2.0-or-later
@@ -26,7 +26,6 @@
 
 Source0:        %{name}-%{version}.tar.bz2
 
-BuildRequires:  update-desktop-files
 BuildRequires:  yast2-buildtools >= 4.2.2
 BuildRequires:  rubygem(%{rb_default_ruby_abi}:rspec)
 BuildRequires:  rubygem(%{rb_default_ruby_abi}:yast-rake)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-proxy-5.0.0/src/include/proxy/dialogs.rb 
new/yast2-proxy-5.0.1/src/include/proxy/dialogs.rb
--- old/yast2-proxy-5.0.0/src/include/proxy/dialogs.rb  2023-10-18 
23:19:14.000000000 +0200
+++ new/yast2-proxy-5.0.1/src/include/proxy/dialogs.rb  2026-03-25 
18:36:01.000000000 +0100
@@ -159,12 +159,18 @@
       proxy_retcode = ""
       # getting the return code string from the stderr
       Builtins.foreach(Builtins.splitstring(proxy_ret_stderr, "\r?\n")) do 
|proxy_stderr|
-        proxy_retcode = Builtins.regexpsub(proxy_stderr, ".*(HTTP.*)", "\\1") 
if Builtins.regexpmatch(proxy_stderr, "HTTP/[0-9.]+ [0-9]+")
+        if Builtins.regexpmatch(
+          proxy_stderr, "HTTP/[0-9.]+ [0-9]+"
+        )
+          proxy_retcode = Builtins.regexpsub(proxy_stderr, ".*(HTTP.*)",
+            "\\1")
+        end
       end
 
       Builtins.y2milestone("Proxy %1 test: %2", test_type, proxy_retcode)
 
-      # The default error code, replaced with the current error code got from 
proxy if any code found
+      # The default error code, replaced with the current error code got from
+      # proxy if any code found
       retcode = _("Unknown Error Code")
       Builtins.foreach(Builtins.splitstring(proxy_retcode, " ")) do 
|ret_code_part|
         if Builtins.regexpmatch(ret_code_part, "^[0-9]+$") &&
@@ -334,16 +340,16 @@
       Builtins.foreach(proxy_list) do |one_proxy|
         one_proxy = String.CutBlanks(one_proxy)
         # IP/netmask
-        if !Builtins.findfirstof(one_proxy, "/").nil?
+        if Builtins.findfirstof(one_proxy, "/").nil?
+          hostname = one_proxy
+          # .domain.name case
+          hostname = Builtins.substring(hostname, 1) if 
Builtins.findfirstof(hostname, ".") == 0
+        else
           tmp = Builtins.splitstring(one_proxy, "/")
           hostname = Ops.get(tmp, 0, "")
           netmask = Ops.get(tmp, 1, "")
 
           validate = false if !Netmask.Check(netmask)
-        else
-          hostname = one_proxy
-          # .domain.name case
-          hostname = Builtins.substring(hostname, 1) if 
Builtins.findfirstof(hostname, ".") == 0
         end
         Builtins.y2milestone("hostname %1, netmask %2", hostname, netmask)
         validate = false if !Address.Check(hostname)
@@ -389,36 +395,41 @@
           Ops.add(
             _(
               "<p>Configure your Internet proxy (caching) settings 
here.</p>\n" \
-                "<p><b>Note:</b> It is generally recommended to relogin for 
the settings to take effect, \n" \
-                "however in some cases the application may pick up new 
settings immediately. Please check \n" \
-                "what your application (web browser, ftp client,...) supports. 
</p>"
+              "<p><b>Note:</b> It is generally recommended to relogin for the 
" \
+              "settings to take effect, \n" \
+              "however in some cases the application may pick up new settings 
" \
+              "immediately. Please check \n" \
+              "what your application (web browser, ftp client,...) supports. 
</p>"
             ) +
               # Proxy dialog help 2/8
               _(
-                "<p><b>HTTP Proxy URL</b> is the name of the proxy server for 
your access\nto the World Wide Web (WWW).</p>\n"
+                "<p><b>HTTP Proxy URL</b> is the name of the proxy server for 
your access\n" \
+                "to the World Wide Web (WWW).</p>\n"
               ) +
               # Proxy dialog help 3/8
               _(
-                "<p><b>HTTPS Proxy URL</b> is the name of the proxy server for 
your secured access\nto the World Wide Web (WWW).</p>\n"
+                "<p><b>HTTPS Proxy URL</b> is the name of the proxy server for 
your secured " \
+                "access\nto the World Wide Web (WWW).</p>\n"
               ) +
               # Proxy dialog help 3.5/8
               _("<p>Example: <i>http://proxy.example.com:3128/</i></p>") +
               # Proxy dialog help 4/8
               _(
-                "<p><b>FTP Proxy URL</b> is the name of the proxy server for 
your access\nto the file transfer services (FTP).</p>"
+                "<p><b>FTP Proxy URL</b> is the name of the proxy server for 
your access\n" \
+                "to the file transfer services (FTP).</p>"
               ) +
               # Proxy dialog help 5/8
               _(
                 "<p>If you check <b>Use the Same Proxy for All Protocols</b>, 
it is\n" \
-                  "enough to fill in the HTTP proxy URL. It will be used for 
all protocols\n" \
-                  "(HTTP, HTTPS and FTP).\n"
+                "enough to fill in the HTTP proxy URL. It will be used for all 
protocols\n" \
+                "(HTTP, HTTPS and FTP).\n"
               ),
             # Proxy dialog help 6/8
             Builtins.sformat(
               _(
                 "<p><b>No Proxy Domains</b> is a comma-separated list of 
domains\n" \
-                  "for which the requests should be made directly without 
caching,\n" \
-                  "for example, <i>%1</i>.</p>\n"
+                "for which the requests should be made directly without 
caching,\n" \
+                "for example, <i>%1</i>.</p>\n"
               ),
               "localhost, .intranet.example.com, www.example.com"
             )
@@ -426,17 +437,18 @@
           # Proxy dialog help 7/8
           _(
             "<p>If you are using a proxy server with authorization, enter\n" \
-              "the <b>Proxy User Name</b> and <b>Proxy Password</b>. A valid 
username\n" \
-              "consists of printable ASCII characters only (except for 
quotation marks).</p>\n"
+            "the <b>Proxy User Name</b> and <b>Proxy Password</b>. A valid 
username\n" \
+            "consists of printable ASCII characters only (except for quotation 
marks).</p>\n"
           )
         ),
         # Proxy dialog help 8/8
-        if !Mode.installation
+        if Mode.installation
+          ""
+        else
           _(
-            "<p>Press <b>Test Proxy Settings</b> to test\nthe current 
configuration for HTTP, HTTPS, and FTP proxy.</p> \n"
+            "<p>Press <b>Test Proxy Settings</b> to test\n" \
+            "the current configuration for HTTP, HTTPS, and FTP proxy.</p> \n"
           )
-        else
-          ""
         end
       )
 
@@ -516,10 +528,10 @@
           ),
           VSpacing(s),
           # Test Proxy Settings - push button
-          if !Mode.installation
-            PushButton(Id("test_proxy"), _("Test Pr&oxy Settings"))
-          else
+          if Mode.installation
             Empty()
+          else
+            PushButton(Id("test_proxy"), _("Test Pr&oxy Settings"))
           end
         ),
         HSpacing(5)
@@ -607,17 +619,15 @@
               UrlContainPassword(@https) ||
               UrlContainPassword(@ftp)
 
-            if password_inside && ret != "test_proxy"
-              if !Popup.ContinueCancel(
+            if password_inside && ret != "test_proxy" && !Popup.ContinueCancel(
                 _(
                   "Security warning:\n" \
-                    "Username and password will be stored unencrypted\n" \
-                    "in a worldwide readable plaintext file.\n" \
-                    "Really use these settings?"
+                  "Username and password will be stored unencrypted\n" \
+                  "in a worldwide readable plaintext file.\n" \
+                  "Really use these settings?"
                 )
               )
-                next
-              end
+              next
             end
           end
           # check_*
@@ -682,22 +692,20 @@
               next
             end
           end
-          if @no != "" && [email protected]?
-            if !ValidateNoProxyDomains(@no)
-              # Translators: no proxy domain is a domain that can be accessed 
without proxy
-              Popup.Error(
-                _(
-                  "One or more no proxy domains are invalid. \n" \
-                    "Check if all domains match one of the following:\n" \
-                    "* IP address\n" \
-                    "* IP address/netmask\n" \
-                    "* Fully qualified hostname\n" \
-                    "* Domain name prefixed by '.'"
-                )
+          if @no != "" && [email protected]? && !ValidateNoProxyDomains(@no)
+            # Translators: no proxy domain is a domain that can be accessed 
without proxy
+            Popup.Error(
+              _(
+                "One or more no proxy domains are invalid. \n" \
+                "Check if all domains match one of the following:\n" \
+                "* IP address\n" \
+                "* IP address/netmask\n" \
+                "* Fully qualified hostname\n" \
+                "* Domain name prefixed by '.'"
               )
-              UI.SetFocus(Id(:no))
-              next
-            end
+            )
+            UI.SetFocus(Id(:no))
+            next
           end
 
           break if ret == :next
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-proxy-5.0.0/src/lib/proxy/auto_client.rb 
new/yast2-proxy-5.0.1/src/lib/proxy/auto_client.rb
--- old/yast2-proxy-5.0.0/src/lib/proxy/auto_client.rb  2023-10-18 
23:19:14.000000000 +0200
+++ new/yast2-proxy-5.0.1/src/lib/proxy/auto_client.rb  2026-03-25 
18:36:01.000000000 +0100
@@ -42,36 +42,37 @@
       Builtins.y2debug("param=%1", @param)
 
       # Create a summary
-      if @func == "Summary"
+      case @func
+      when "Summary"
         @ret = ProxySummary()
       # Reset configuration
-      elsif @func == "Reset"
+      when "Reset"
         Proxy.Import({})
         @ret = {}
       # Change configuration (run AutoSequence)
-      elsif @func == "Change"
+      when "Change"
         Wizard.CreateDialog
         Wizard.SetDesktopTitleAndIcon("org.opensuse.yast.Proxy")
         @ret = ProxyMainDialog(true)
         UI.CloseDialog
       # return required package list
-      elsif @func == "Packages"
+      when "Packages"
         @ret = {}
       # Import configuration
-      elsif @func == "Import"
+      when "Import"
         @ret = Proxy.Import(@param)
-      elsif @func == "SetModified"
+      when "SetModified"
         @ret = Proxy.SetModified
-      elsif @func == "GetModified"
+      when "GetModified"
         @ret = Proxy.GetModified
       # Read configuration (useful for cloning)
-      elsif @func == "Read"
+      when "Read"
         @ret = Proxy.Read
       # Return actual state
-      elsif @func == "Export"
+      when "Export"
         @ret = Proxy.Export
       # Write givven settings
-      elsif @func == "Write"
+      when "Write"
         Yast.import "Progress"
         @progress_orig = Progress.set(false)
         Proxy.write_only = true
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-proxy-5.0.0/src/modules/Proxy.rb 
new/yast2-proxy-5.0.1/src/modules/Proxy.rb
--- old/yast2-proxy-5.0.0/src/modules/Proxy.rb  2023-10-18 23:19:14.000000000 
+0200
+++ new/yast2-proxy-5.0.1/src/modules/Proxy.rb  2026-03-25 18:36:01.000000000 
+0100
@@ -212,7 +212,8 @@
       Builtins.sleep(sl)
       Progress.NextStage
 
-      # user can't relogin in installation and update, do not show the msg 
then (bnc#486037, bnc#543469)
+      # user can't relogin in installation and update, do not show the msg then
+      # (bnc#486037, bnc#543469)
       ProxyFinishPopup(true) if Mode.normal
       # By now the configuration written to the inst-sys should be copied 
always to the target
       # system, so it is set here in order to discharge others from 
establishing it. (bsc#1185016)
@@ -279,16 +280,14 @@
       # --url https://www.suse.com --insecure
       ret = {}
 
-      test_http = (http_proxy != "" && http_proxy != "http://";) ? true : false
-      test_https = (https_proxy != "" && https_proxy != "http://";) ? true : 
false
-      test_ftp = (ftp_proxy != "" && ftp_proxy != "http://";) ? true : false
+      test_http = (http_proxy != "" && http_proxy != "http://";)
+      test_https = (https_proxy != "" && https_proxy != "http://";)
+      test_ftp = (ftp_proxy != "" && ftp_proxy != "http://";)
 
       user_pass = ""
-      if proxy_user != ""
-        if proxy_password != ""
-          user_pass = " --proxy-user #{proxy_user.shellescape}" +
-            user_pass << ":#{proxy_password.shellescape}"
-        end
+      if proxy_user != "" && (proxy_password != "")
+        user_pass = (" --proxy-user #{proxy_user.shellescape}" +
+          user_pass) << ":#{proxy_password.shellescape}"
       end
 
       # timeout for the connection
@@ -410,9 +409,7 @@
     # @return summary text
     def Summary
       # Summary text
-      ret = if !@enabled
-        [Summary.Device(_("Proxy is disabled."), "")]
-      else
+      ret = if @enabled
         # Summary text
         [
           Summary.Device(
@@ -423,36 +420,38 @@
                   Ops.add(
                     "",
                     # Summary text
-                    if @http != ""
+                    if @http == ""
+                      ""
+                    else
                       Ops.add(
                         Builtins.sformat(_("HTTP Proxy: %1"), @http),
                         "<br>"
                       )
-                    else
-                      ""
                     end
                   ),
                   # Summary text
-                  if @https != ""
+                  if @https == ""
+                    ""
+                  else
                     Ops.add(
                       Builtins.sformat(_("HTTPS Proxy: %1"), @https),
                       "<br>"
                     )
-                  else
-                    ""
                   end
                 ),
                 # Summary text
-                if @ftp != ""
-                  Ops.add(Builtins.sformat(_("FTP Proxy: %1"), @ftp), "<br>")
-                else
+                if @ftp == ""
                   ""
+                else
+                  Ops.add(Builtins.sformat(_("FTP Proxy: %1"), @ftp), "<br>")
                 end
               ),
               ""
             )
           )
         ]
+      else
+        [Summary.Device(_("Proxy is disabled."), "")]
       end
 
       Summary.DevicesList(ret)
@@ -499,7 +498,8 @@
     publish function: :Read, type: "boolean ()"
     publish function: :Write, type: "boolean ()"
     publish function: :Import, type: "boolean (map)"
-    publish function: :RunTestProxy, type: "map <string, map <string, any>> 
(string, string, string, string, string)"
+    publish function: :RunTestProxy,
+      type: "map <string, map <string, any>> (string, string, string, string, 
string)"
     publish function: :Export, type: "map ()"
     publish function: :Summary, type: "string ()"
     publish function: :GetModified, type: "boolean ()"
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-proxy-5.0.0/test/proxy_test.rb 
new/yast2-proxy-5.0.1/test/proxy_test.rb
--- old/yast2-proxy-5.0.0/test/proxy_test.rb    2023-10-18 23:19:14.000000000 
+0200
+++ new/yast2-proxy-5.0.1/test/proxy_test.rb    2026-03-25 18:36:01.000000000 
+0100
@@ -24,7 +24,7 @@
 
     it "writes proxy settings, and a comment, when proxy is enabled" do
       subject.Import("enabled"    => true,
-                     "http_proxy" => "proxy.example.org:3128")
+        "http_proxy" => "proxy.example.org:3128")
 
       expect(Yast::SCR).to receive(:Write)
         .with(path_matching(/^\.root\.curlrc\..*\."comment"/), /Changed/)
@@ -51,9 +51,9 @@
 
     it "writes proxy settings, and a comment, when proxy is enabled via 
InstallInfConvertor" do
       subject.Import("enabled"        => true,
-                     "http_proxy"     => "proxy.example.org:3128",
-                     "proxy_user"     => nil,
-                     "proxy_password" => nil)
+        "http_proxy"     => "proxy.example.org:3128",
+        "proxy_user"     => nil,
+        "proxy_password" => nil)
 
       expect(Yast::SCR).to receive(:Write)
         .with(path_matching(/^\.root\.curlrc\..*\."comment"/), /Changed/)
@@ -80,8 +80,8 @@
 
     it "writes a no-proxy setting" do
       subject.Import("enabled"    => true,
-                     "http_proxy" => "proxy.example.org:3128",
-                     "no_proxy"   => "example.org,example.com,localhost")
+        "http_proxy" => "proxy.example.org:3128",
+        "no_proxy"   => "example.org,example.com,localhost")
       expect(Yast::SCR).to receive(:Write)
         .with(path(".root.curlrc.\"--noproxy\""),
           "example.org,example.com,localhost")
@@ -96,8 +96,8 @@
 
     it "writes a no-proxy setting without spaces" do
       subject.Import("enabled"    => true,
-                     "http_proxy" => "proxy.example.org:3128",
-                     "no_proxy"   => "example.org, example.com, localhost")
+        "http_proxy" => "proxy.example.org:3128",
+        "no_proxy"   => "example.org, example.com, localhost")
       expect(Yast::SCR).to receive(:Write)
         .with(path(".root.curlrc.\"--noproxy\""),
           "example.org,example.com,localhost")
@@ -112,9 +112,9 @@
 
     it "escapes user name" do
       subject.Import("enabled"        => true,
-                     "http_proxy"     => "proxy.example.org:3128",
-                     "proxy_user"     => "User\\Domain",
-                     "proxy_password" => "P")
+        "http_proxy"     => "proxy.example.org:3128",
+        "proxy_user"     => "User\\Domain",
+        "proxy_password" => "P")
 
       expect(Yast::SCR).to receive(:Write)
         .with(path(".root.curlrc.\"--proxy-user\""), "User\\\\Domain:P")

Reply via email to