Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package yast2-ntp-client for
openSUSE:Factory checked in at 2026-03-26 21:07:01
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-ntp-client (Old)
and /work/SRC/openSUSE:Factory/.yast2-ntp-client.new.8177 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-ntp-client"
Thu Mar 26 21:07:01 2026 rev:135 rq:1342586 version:5.0.1
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-ntp-client/yast2-ntp-client.changes
2023-10-20 23:18:08.309522158 +0200
+++
/work/SRC/openSUSE:Factory/.yast2-ntp-client.new.8177/yast2-ntp-client.changes
2026-03-27 06:53:31.631920258 +0100
@@ -1,0 +2,6 @@
+Tue Mar 10 09:00:28 UTC 2026 - Michal Filka <[email protected]>
+
+- jsc#PED-14507
+ - Removed reference to update-desktop-files from spec file
+ - 5.0.1
+-------------------------------------------------------------------
Old:
----
yast2-ntp-client-5.0.0.tar.bz2
New:
----
yast2-ntp-client-5.0.1.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-ntp-client.spec ++++++
--- /var/tmp/diff_new_pack.1s1KtW/_old 2026-03-27 06:53:32.219944534 +0100
+++ /var/tmp/diff_new_pack.1s1KtW/_new 2026-03-27 06:53:32.223944699 +0100
@@ -1,7 +1,7 @@
#
# spec file for package yast2-ntp-client
#
-# Copyright (c) 2023 SUSE LLC
+# Copyright (c) 2026 SUSE LLC and contributors
#
# All modifications and additions to the file contributed by third parties
# remain the property of their copyright owners, unless otherwise agreed
@@ -17,7 +17,7 @@
Name: yast2-ntp-client
-Version: 5.0.0
+Version: 5.0.1
Release: 0
Summary: YaST2 - NTP Client Configuration
License: GPL-2.0-or-later
@@ -27,7 +27,6 @@
Source0: %{name}-%{version}.tar.bz2
BuildRequires: augeas-lenses
-BuildRequires: update-desktop-files
# need as it own /usr/lib/systemd and for systemd macros
BuildRequires: systemd-rpm-macros
%{?systemd_requires}
++++++ yast2-ntp-client-5.0.0.tar.bz2 -> yast2-ntp-client-5.0.1.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-ntp-client-5.0.0/.github/workflows/ci.yml
new/yast2-ntp-client-5.0.1/.github/workflows/ci.yml
--- old/yast2-ntp-client-5.0.0/.github/workflows/ci.yml 2023-10-18
23:18:05.000000000 +0200
+++ new/yast2-ntp-client-5.0.1/.github/workflows/ci.yml 2026-03-25
18:35:00.000000000 +0100
@@ -1,9 +1,8 @@
-
# See
https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions
name: CI
-on: [push, pull_request]
+on: [ push, pull_request ]
jobs:
Tests:
@@ -12,33 +11,32 @@
strategy:
fail-fast: false
matrix:
- distro: [ "tumbleweed", "leap_latest" ]
+ distro: [ "tumbleweed" ]
container:
image:
registry.opensuse.org/yast/head/containers_${{matrix.distro}}/yast-ruby
steps:
+ - name: Git Checkout
+ uses: actions/checkout@v2
- - name: Git Checkout
- uses: actions/checkout@v2
-
- # just for easier debugging...
- - name: Inspect Installed Packages
- run: rpm -qa | sort
-
- - name: Unit Tests
- run: rake test:unit
- # enable code coverage reporting
- env:
- COVERAGE: 1
-
- # send the coverage report to coveralls.io
- - name: Coveralls Report
- # send it only from the TW build to avoid duplicate submits
- if: ${{ matrix.distro == 'tumbleweed' }}
- uses: coverallsapp/github-action@master
- with:
- github-token: ${{ secrets.GITHUB_TOKEN }}
+ # just for easier debugging...
+ - name: Inspect Installed Packages
+ run: rpm -qa | sort
+
+ - name: Unit Tests
+ run: rake test:unit
+ # enable code coverage reporting
+ env:
+ COVERAGE: 1
+
+ # send the coverage report to coveralls.io
+ - name: Coveralls Report
+ # send it only from the TW build to avoid duplicate submits
+ if: ${{ matrix.distro == 'tumbleweed' }}
+ uses: coverallsapp/github-action@master
+ with:
+ github-token: ${{ secrets.GITHUB_TOKEN }}
Rubocop:
runs-on: ubuntu-latest
@@ -46,37 +44,38 @@
strategy:
fail-fast: false
matrix:
- distro: [ "leap_latest" ]
+ distro: [ "tumbleweed" ]
container:
image:
registry.opensuse.org/yast/head/containers_${{matrix.distro}}/yast-ruby
steps:
+ - name: Git Checkout
+ uses: actions/checkout@v2
- - name: Git Checkout
- uses: actions/checkout@v2
-
- - name: Rubocop
- run: rake check:rubocop
+ - name: Rubocop
+ run: rake check:rubocop
Package:
+ # skip in master, but run in forks
+ if: github.ref_name != 'master' || github.repository_owner != 'yast'
+
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
- distro: [ "tumbleweed", "leap_latest" ]
+ distro: [ "tumbleweed" ]
container:
image:
registry.opensuse.org/yast/head/containers_${{matrix.distro}}/yast-ruby
steps:
+ - name: Git Checkout
+ uses: actions/checkout@v2
- - name: Git Checkout
- uses: actions/checkout@v2
-
- - name: Package Build
- run: yast-ci-ruby -o package
+ - name: Package Build
+ run: yast-ci-ruby -o package
Yardoc:
runs-on: ubuntu-latest
@@ -84,18 +83,17 @@
strategy:
fail-fast: false
matrix:
- distro: [ "leap_latest" ]
+ distro: [ "tumbleweed" ]
container:
image:
registry.opensuse.org/yast/head/containers_${{matrix.distro}}/yast-ruby
steps:
+ - name: Git Checkout
+ uses: actions/checkout@v2
- - name: Git Checkout
- uses: actions/checkout@v2
-
- - name: Yardoc
- run: rake check:doc
+ - name: Yardoc
+ run: rake check:doc
# downloading the Docker image takes some time so bundling several fast
# checks into one job avoids that overhead
@@ -105,15 +103,14 @@
strategy:
fail-fast: false
matrix:
- distro: [ "leap_latest" ]
+ distro: [ "tumbleweed" ]
container:
image:
registry.opensuse.org/yast/head/containers_${{matrix.distro}}/yast-ruby
steps:
+ - name: Git Checkout
+ uses: actions/checkout@v2
- - name: Git Checkout
- uses: actions/checkout@v2
-
- - name: POT Check
- run: rake check:pot
+ - name: POT Check
+ run: rake check:pot
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-ntp-client-5.0.0/.github/workflows/submit.yml
new/yast2-ntp-client-5.0.1/.github/workflows/submit.yml
--- old/yast2-ntp-client-5.0.0/.github/workflows/submit.yml 1970-01-01
01:00:00.000000000 +0100
+++ new/yast2-ntp-client-5.0.1/.github/workflows/submit.yml 2026-03-25
18:35:00.000000000 +0100
@@ -0,0 +1,29 @@
+# See
https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions
+
+name: OBS
+
+on:
+ # only when committing to master
+ push:
+ branches: master
+
+ # allow running manually from GitHub Web
+ workflow_dispatch:
+
+jobs:
+ submit:
+ # do not run in forks
+ if: github.repository_owner == 'yast'
+
+ runs-on: ubuntu-latest
+
+ # the default timeout is 6 hours, do not wait for that long if osc gets
stucked
+ timeout-minutes: 30
+
+ steps:
+ - name: Submit the package
+ # see https://github.com/yast/actions/blob/master/submit/action.yml
+ uses: yast/actions/submit@master
+ with:
+ obs_user: ${{ secrets.OBS_USER }}
+ obs_password: ${{ secrets.OBS_PASSWORD }}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-ntp-client-5.0.0/.rubocop.yml
new/yast2-ntp-client-5.0.1/.rubocop.yml
--- old/yast2-ntp-client-5.0.0/.rubocop.yml 2023-10-18 23:18:05.000000000
+0200
+++ new/yast2-ntp-client-5.0.1/.rubocop.yml 2026-03-25 18:35:00.000000000
+0100
@@ -1,6 +1,6 @@
# use the shared Yast defaults
inherit_from:
- /usr/share/YaST2/data/devtools/data/rubocop-0.71.0_yast_style.yml
+ /usr/share/YaST2/data/devtools/data/rubocop-1.24.1_yast_style.yml
Metrics/AbcSize:
Max: 129
@@ -65,10 +65,6 @@
Metrics/ParameterLists:
Max: 4
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/AndOr:
- EnforcedStyle: conditionals
-
Style/Documentation:
Include:
- 'src/lib/**/*.rb' # force well documented code only for new code
@@ -77,10 +73,6 @@
Include:
- 'src/lib/**/*.rb' # force correct names on new code
-# JR: I found lambda easier to read and understand than ->()
-Style/Lambda:
- Enabled: false
-
Naming/MethodName:
Include:
- 'src/lib/**/*.rb' # force correct names on new code
@@ -89,10 +81,6 @@
Include:
- 'src/lib/**/*.rb' # force known variables only for new code
-# method_alias is safer and more predictable
-Style/Alias:
- EnforcedStyle: prefer_alias_method
-
# this needs more testing if we can have frozen string literals
Style/FrozenStringLiteralComment:
Enabled: false
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-ntp-client-5.0.0/README.md
new/yast2-ntp-client-5.0.1/README.md
--- old/yast2-ntp-client-5.0.0/README.md 2023-10-18 23:18:05.000000000
+0200
+++ new/yast2-ntp-client-5.0.1/README.md 2026-03-25 18:35:00.000000000
+0100
@@ -2,7 +2,6 @@
[](
https://github.com/yast/yast-ntp-client/actions?query=branch%3Amaster)
-[](
-https://ci.opensuse.org/view/Yast/job/yast-yast-ntp-client-master/)
+[](https://github.com/yast/yast-ntp-client/actions/workflows/submit.yml)
[](https://coveralls.io/r/yast/yast-ntp-client?branch=master)
[](http://inch-ci.org/github/yast/yast-ntp-client)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-ntp-client-5.0.0/package/yast2-ntp-client.changes
new/yast2-ntp-client-5.0.1/package/yast2-ntp-client.changes
--- old/yast2-ntp-client-5.0.0/package/yast2-ntp-client.changes 2023-10-18
23:18:05.000000000 +0200
+++ new/yast2-ntp-client-5.0.1/package/yast2-ntp-client.changes 2026-03-25
18:35:00.000000000 +0100
@@ -1,4 +1,10 @@
-------------------------------------------------------------------
+Tue Mar 10 09:00:28 UTC 2026 - Michal Filka <[email protected]>
+
+- jsc#PED-14507
+ - Removed reference to update-desktop-files from spec file
+ - 5.0.1
+-------------------------------------------------------------------
Wed Aug 30 20:16:10 UTC 2023 - Josef Reidinger <[email protected]>
- 5.0.0 (bsc#1185510)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-ntp-client-5.0.0/package/yast2-ntp-client.spec
new/yast2-ntp-client-5.0.1/package/yast2-ntp-client.spec
--- old/yast2-ntp-client-5.0.0/package/yast2-ntp-client.spec 2023-10-18
23:18:05.000000000 +0200
+++ new/yast2-ntp-client-5.0.1/package/yast2-ntp-client.spec 2026-03-25
18:35:00.000000000 +0100
@@ -17,7 +17,7 @@
Name: yast2-ntp-client
-Version: 5.0.0
+Version: 5.0.1
Release: 0
Summary: YaST2 - NTP Client Configuration
License: GPL-2.0-or-later
@@ -27,7 +27,6 @@
Source0: %{name}-%{version}.tar.bz2
BuildRequires: augeas-lenses
-BuildRequires: update-desktop-files
# need as it own /usr/lib/systemd and for systemd macros
BuildRequires: systemd-rpm-macros
%{?systemd_requires}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-ntp-client-5.0.0/src/clients/ntp-client_proposal.rb
new/yast2-ntp-client-5.0.1/src/clients/ntp-client_proposal.rb
--- old/yast2-ntp-client-5.0.0/src/clients/ntp-client_proposal.rb
2023-10-18 23:18:05.000000000 +0200
+++ new/yast2-ntp-client-5.0.1/src/clients/ntp-client_proposal.rb
2026-03-25 18:35:00.000000000 +0100
@@ -521,9 +521,10 @@
end
when :ntp_now
rv = Write("ntpdate_only" => true)
- if rv == :invalid_hostname
+ case rv
+ when :invalid_hostname
handle_invalid_hostname(UI.QueryWidget(Id(:ntp_address), :Value))
- elsif rv == :success
+ when :success
redraw = true # update time widgets
else
Report.Error(_("Connection to selected NTP server failed."))
@@ -565,10 +566,11 @@
# we get [ "address", :<type> ], we need only address here
server = @sources_table.sources.first[0]
Builtins.y2milestone("ui_try_save argmap %1", argmap)
- if rv == :invalid_hostname
+ case rv
+ when :invalid_hostname
handle_invalid_hostname(server)
return false # loop on
- elsif rv == :ntpdate_failed
+ when :ntpdate_failed
# Translators: yes-no popup,
# ntpdate is a command, %1 is the server address
if Popup.YesNo(
@@ -649,11 +651,11 @@
return @cached_fallback_ntp_items if @cached_fallback_ntp_items
@cached_fallback_ntp_items = dhcp_ntp_items
- if !@cached_fallback_ntp_items.empty?
- log.info("Proposing NTP server list provided by DHCP")
- else
+ if @cached_fallback_ntp_items.empty?
log.info("Proposing current timezone-based NTP server list")
@cached_fallback_ntp_items = timezone_ntp_items
+ else
+ log.info("Proposing NTP server list provided by DHCP")
end
@cached_fallback_ntp_items
end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-ntp-client-5.0.0/src/include/ntp-client/wizards.rb
new/yast2-ntp-client-5.0.1/src/include/ntp-client/wizards.rb
--- old/yast2-ntp-client-5.0.0/src/include/ntp-client/wizards.rb
2023-10-18 23:18:05.000000000 +0200
+++ new/yast2-ntp-client-5.0.1/src/include/ntp-client/wizards.rb
2026-03-25 18:35:00.000000000 +0100
@@ -25,9 +25,9 @@
# @return sequence result
def NtpClientSequence
aliases = {
- "read" => [lambda { ReadDialog() }, true],
- "main" => lambda { Y2NtpClient::Dialog::Main.run },
- "write" => [lambda { WriteDialog() }, true]
+ "read" => [-> { ReadDialog() }, true],
+ "main" => -> { Y2NtpClient::Dialog::Main.run },
+ "write" => [-> { WriteDialog() }, true]
}
sequence = {
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-ntp-client-5.0.0/src/lib/cfa/chrony_conf.rb
new/yast2-ntp-client-5.0.1/src/lib/cfa/chrony_conf.rb
--- old/yast2-ntp-client-5.0.0/src/lib/cfa/chrony_conf.rb 2023-10-18
23:18:05.000000000 +0200
+++ new/yast2-ntp-client-5.0.1/src/lib/cfa/chrony_conf.rb 2026-03-25
18:35:00.000000000 +0100
@@ -138,14 +138,14 @@
when String
[entry, {}]
when AugeasTreeValue
- options = Hash[entry.tree.data.map { |e| [e[:key], e[:value]] }]
+ options = entry.tree.data.map { |e| [e[:key], e[:value]] }.to_h
[entry.value, options]
else
raise "invalid source data #{entry.inspect}"
end
end
- Hash[sources_map]
+ sources_map.to_h
end
def add_source(type, address, options = :default)
@@ -159,7 +159,7 @@
else
# place after the last pool available
Matcher.new(key: existing.last[:key],
- value_matcher: existing.last[:value])
+ value_matcher: existing.last[:value])
end
placer = AfterPlacer.new(matcher)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-ntp-client-5.0.0/src/lib/y2ntp_client/client/auto.rb
new/yast2-ntp-client-5.0.1/src/lib/y2ntp_client/client/auto.rb
--- old/yast2-ntp-client-5.0.0/src/lib/y2ntp_client/client/auto.rb
2023-10-18 23:18:05.000000000 +0200
+++ new/yast2-ntp-client-5.0.1/src/lib/y2ntp_client/client/auto.rb
2026-03-25 18:35:00.000000000 +0100
@@ -13,6 +13,7 @@
# Does not do any changes to the configuration.
class Auto < ::Installation::AutoClient
def initialize
+ super
textdomain "ntp-client"
end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-ntp-client-5.0.0/src/lib/y2ntp_client/client/finish.rb
new/yast2-ntp-client-5.0.1/src/lib/y2ntp_client/client/finish.rb
--- old/yast2-ntp-client-5.0.0/src/lib/y2ntp_client/client/finish.rb
2023-10-18 23:18:05.000000000 +0200
+++ new/yast2-ntp-client-5.0.1/src/lib/y2ntp_client/client/finish.rb
2026-03-25 18:35:00.000000000 +0100
@@ -11,6 +11,7 @@
include Yast::I18n
def initialize
+ super
textdomain "ntp-client"
end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-ntp-client-5.0.0/src/lib/y2ntp_client/dialog/add_pool.rb
new/yast2-ntp-client-5.0.1/src/lib/y2ntp_client/dialog/add_pool.rb
--- old/yast2-ntp-client-5.0.0/src/lib/y2ntp_client/dialog/add_pool.rb
2023-10-18 23:18:05.000000000 +0200
+++ new/yast2-ntp-client-5.0.1/src/lib/y2ntp_client/dialog/add_pool.rb
2026-03-25 18:35:00.000000000 +0100
@@ -29,6 +29,7 @@
# @param address_widget [CWM::InputField]
# @param pool_type [Symbol]
def initialize(address_widget, pool_type)
+ super()
textdomain "ntp-client"
@address_widget = address_widget
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-ntp-client-5.0.0/src/lib/y2ntp_client/dialog/main.rb
new/yast2-ntp-client-5.0.1/src/lib/y2ntp_client/dialog/main.rb
--- old/yast2-ntp-client-5.0.0/src/lib/y2ntp_client/dialog/main.rb
2023-10-18 23:18:05.000000000 +0200
+++ new/yast2-ntp-client-5.0.1/src/lib/y2ntp_client/dialog/main.rb
2026-03-25 18:35:00.000000000 +0100
@@ -12,6 +12,7 @@
# Main entry point for Ntp Client
class Main < CWM::Dialog
def initialize
+ super
textdomain "ntp-client"
end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-ntp-client-5.0.0/src/lib/y2ntp_client/dialog/pool.rb
new/yast2-ntp-client-5.0.1/src/lib/y2ntp_client/dialog/pool.rb
--- old/yast2-ntp-client-5.0.0/src/lib/y2ntp_client/dialog/pool.rb
2023-10-18 23:18:05.000000000 +0200
+++ new/yast2-ntp-client-5.0.1/src/lib/y2ntp_client/dialog/pool.rb
2026-03-25 18:35:00.000000000 +0100
@@ -16,6 +16,7 @@
# key is option and value is string for key value options
# or nil for keyword options
def initialize(address = "", options = {})
+ super()
textdomain "ntp-client"
@address = address
@options = options
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-ntp-client-5.0.0/src/lib/y2ntp_client/widgets/main_widgets.rb
new/yast2-ntp-client-5.0.1/src/lib/y2ntp_client/widgets/main_widgets.rb
--- old/yast2-ntp-client-5.0.0/src/lib/y2ntp_client/widgets/main_widgets.rb
2023-10-18 23:18:05.000000000 +0200
+++ new/yast2-ntp-client-5.0.1/src/lib/y2ntp_client/widgets/main_widgets.rb
2026-03-25 18:35:00.000000000 +0100
@@ -14,6 +14,7 @@
# Widget for netconfig policy
class PolicyCombo < CWM::ComboBox
def initialize
+ super
textdomain "ntp-client"
end
@@ -27,9 +28,10 @@
# TRANSLATORS: configuration source combo box help, %{manual} is a
# manual page reference, e.g. "man 8 netconfig"
format(_("<p>The NTP configuration may be provided by the local
network over DHCP. " \
- "<b>Configuration Source</b> can simply enable or disable using that
configuration. " \
- "In cases where there may be multiple DHCP sources, it can
prioritize them: " \
- "see '%{manual}'.</p>"), manual: "man 8 netconfig")
+ "<b>Configuration Source</b> can simply enable or disable " \
+ "using that configuration. " \
+ "In cases where there may be multiple DHCP sources, it can
prioritize them: " \
+ "see '%{manual}'.</p>"), manual: "man 8 netconfig")
end
def opt
@@ -76,6 +78,7 @@
# Widget to configure how ntp will be started
class NtpStart < CWM::RadioButtons
def initialize(replace_point)
+ super()
textdomain "ntp-client"
@replace_point = replace_point
@@ -137,6 +140,7 @@
# Widget representing how often synchronize via cron
class SyncInterval < CWM::IntField
def initialize
+ super
textdomain "ntp-client"
end
@@ -164,6 +168,7 @@
# Table with ntp pool servers
class ServersTable < CWM::Table
def initialize
+ super
textdomain "ntp-client"
end
@@ -205,6 +210,7 @@
# Button to add ntp pool server
class AddPoolButton < CWM::PushButton
def initialize
+ super
textdomain "ntp-client"
end
@@ -230,6 +236,7 @@
# Button to edit ntp pool server
class EditPoolButton < CWM::PushButton
def initialize(table)
+ super()
textdomain "ntp-client"
@table = table
@@ -253,6 +260,7 @@
# Button to delete ntp pool server
class DeletePoolButton < CWM::PushButton
def initialize(table)
+ super()
textdomain "ntp-client"
@table = table
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-ntp-client-5.0.0/src/lib/y2ntp_client/widgets/pool_widgets.rb
new/yast2-ntp-client-5.0.1/src/lib/y2ntp_client/widgets/pool_widgets.rb
--- old/yast2-ntp-client-5.0.0/src/lib/y2ntp_client/widgets/pool_widgets.rb
2023-10-18 23:18:05.000000000 +0200
+++ new/yast2-ntp-client-5.0.1/src/lib/y2ntp_client/widgets/pool_widgets.rb
2026-03-25 18:35:00.000000000 +0100
@@ -15,6 +15,7 @@
# @macro seeAbstractWidget
def initialize(initial_value)
+ super()
textdomain "ntp-client"
@address = initial_value
@@ -49,6 +50,7 @@
# Button that tests if server is reachable
class TestButton < CWM::PushButton
def initialize(address_widget)
+ super()
textdomain "ntp-client"
@address_widget = address_widget
@@ -69,6 +71,7 @@
# Enable iburst option
class Iburst < CWM::CheckBox
def initialize(options)
+ super()
textdomain "ntp-client"
@options = options
@@ -104,6 +107,7 @@
#
# @param options [Hash] current ntp server address options
def initialize(options)
+ super()
textdomain "ntp-client"
@options = options
end
@@ -151,6 +155,7 @@
#
# @param address_widget [PoolAddress] the dialog pool address widget
def initialize(address_widget)
+ super()
textdomain "ntp-client"
@address_widget = address_widget
end
@@ -207,6 +212,7 @@
#
# @param address [String] current NTP pool address
def initialize(address)
+ super()
textdomain "ntp-client"
@address = address
@@ -273,6 +279,7 @@
#
# @param address [String] current NTP pool address
def initialize(address)
+ super()
textdomain "ntp-client"
@country_pools = CountryPools.new
@@ -323,6 +330,7 @@
# Country chooser
class Country < CWM::ComboBox
def initialize(country, country_pools)
+ super()
textdomain "ntp-client"
@country = country
@@ -373,6 +381,7 @@
# Ntp sources selector filtered by country
class CountryPools < CWM::ComboBox
def initialize
+ super
textdomain "ntp-client"
end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-ntp-client-5.0.0/src/lib/y2ntp_client/widgets/sources_table.rb
new/yast2-ntp-client-5.0.1/src/lib/y2ntp_client/widgets/sources_table.rb
--- old/yast2-ntp-client-5.0.0/src/lib/y2ntp_client/widgets/sources_table.rb
2023-10-18 23:18:05.000000000 +0200
+++ new/yast2-ntp-client-5.0.1/src/lib/y2ntp_client/widgets/sources_table.rb
2026-03-25 18:35:00.000000000 +0100
@@ -34,6 +34,7 @@
# @param sources [Hash<String, Symbol>] hash of ntp sources address (ip
or url)
# and type (pool or server)
def initialize(sources = {})
+ super()
textdomain "ntp-client"
# TODO: validation of the input
@@ -78,6 +79,7 @@
# A button for adding an item into @see SourcesTable
class SourcesAdd < CWM::PushButton
def initialize
+ super
textdomain "ntp-client"
end
@@ -93,6 +95,7 @@
# A button for removing an item from @see SourcesTable
class SourcesRemove < CWM::PushButton
def initialize
+ super
textdomain "ntp-client"
end
@@ -108,6 +111,7 @@
# A ComboBox containing varius supported types of NTP Sources
class SourcesType < CWM::ComboBox
def initialize
+ super
textdomain "ntp-client"
end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-ntp-client-5.0.0/src/modules/NtpClient.rb
new/yast2-ntp-client-5.0.1/src/modules/NtpClient.rb
--- old/yast2-ntp-client-5.0.0/src/modules/NtpClient.rb 2023-10-18
23:18:05.000000000 +0200
+++ new/yast2-ntp-client-5.0.1/src/modules/NtpClient.rb 2026-03-25
18:35:00.000000000 +0100
@@ -261,13 +261,13 @@
def GetNtpServersByCountry(country, terse_output)
country_names = {}
servers = GetNtpServers()
- if country.to_s != ""
+ if country.to_s == ""
+ country_names = GetCountryNames()
+ else
servers.select! { |_server, attrs| attrs["country"] == country }
# bnc#458917 add country, in case data/country.ycp does not have it
pool_country_record = MakePoolRecord(country, "")
servers[pool_country_record["address"]] = pool_country_record
- else
- country_names = GetCountryNames()
end
default = false
@@ -512,9 +512,7 @@
result = Yast::Summary.AddLine(result, policy_line)
# TRANSLATORS: summary line. %s is formatted list of addresses.
servers_line = format(_("Servers: %s."), GetUsedNtpServers().join(", "))
- result = Yast::Summary.AddLine(result, servers_line)
-
- result
+ Yast::Summary.AddLine(result, servers_line)
end
# Dump the ntp-client settings to a single map
@@ -604,7 +602,9 @@
# if package is not installed (in the inst-sys, it is: bnc#399659)
if !Stage.initial && !Package.Installed(required_package)
- if !Package.CheckAndInstallPackages([required_package])
+ if Package.CheckAndInstallPackages([required_package])
+ SCR.RegisterAgent(path(".slp"), term(:ag_slp, term(:SlpAgent)))
+ else
Report.Error(
Builtins.sformat(
_(
@@ -615,8 +615,6 @@
)
Builtins.y2warning("Not searching for local NTP servers via SLP")
return []
- else
- SCR.RegisterAgent(path(".slp"), term(:ag_slp, term(:SlpAgent)))
end
end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-ntp-client-5.0.0/test/cfa/chrony_conf_test.rb
new/yast2-ntp-client-5.0.1/test/cfa/chrony_conf_test.rb
--- old/yast2-ntp-client-5.0.0/test/cfa/chrony_conf_test.rb 2023-10-18
23:18:05.000000000 +0200
+++ new/yast2-ntp-client-5.0.1/test/cfa/chrony_conf_test.rb 2026-03-25
18:35:00.000000000 +0100
@@ -42,17 +42,17 @@
context "there is already pool" do
let(:content) do
"# Use public servers from the pool.ntp.org project.\n"\
- "# Please consider joining the pool
(http://www.pool.ntp.org/join.html).\n" \
- "pool 2.opensuse.pool.ntp.org iburst\n"\
- "rtcsync\n"
+ "# Please consider joining the pool
(http://www.pool.ntp.org/join.html).\n" \
+ "pool 2.opensuse.pool.ntp.org iburst\n"\
+ "rtcsync\n"
end
let(:expected_output) do
"# Use public servers from the pool.ntp.org project.\n"\
- "# Please consider joining the pool
(http://www.pool.ntp.org/join.html).\n" \
- "pool 2.opensuse.pool.ntp.org iburst\n"\
- "pool ntp.suse.cz offline\n"\
- "rtcsync\n"
+ "# Please consider joining the pool
(http://www.pool.ntp.org/join.html).\n" \
+ "pool 2.opensuse.pool.ntp.org iburst\n"\
+ "pool ntp.suse.cz offline\n"\
+ "rtcsync\n"
end
it "adds new pool after the latest pool entry" do
@@ -65,15 +65,15 @@
context "there is pool comments" do
let(:content) do
"# Use public servers from the pool.ntp.org project.\n"\
- "# Please consider joining the pool
(http://www.pool.ntp.org/join.html).\n" \
- "rtcsync\n"
+ "# Please consider joining the pool
(http://www.pool.ntp.org/join.html).\n" \
+ "rtcsync\n"
end
let(:expected_output) do
"# Use public servers from the pool.ntp.org project.\n"\
- "# Please consider joining the pool
(http://www.pool.ntp.org/join.html).\n" \
- "pool ntp.suse.cz offline\n"\
- "rtcsync\n"
+ "# Please consider joining the pool
(http://www.pool.ntp.org/join.html).\n" \
+ "pool ntp.suse.cz offline\n"\
+ "rtcsync\n"
end
it "adds new pool after the comment" do
@@ -90,7 +90,7 @@
let(:expected_output) do
"rtcsync\n" \
- "pool ntp.suse.cz offline\n"
+ "pool ntp.suse.cz offline\n"
end
it "adds new pool at the end" do
@@ -115,7 +115,7 @@
context "no hardware clock defined" do
let(:content) do
"rtcsync\n" \
- "pool ntp.suse.cz offline\n"
+ "pool ntp.suse.cz offline\n"
end
it "return true" do
@@ -161,7 +161,7 @@
describe "#delete_pool" do
let(:content) do
"pool test.ntp.org iburst\n" \
- "pool lest.ntp.org offline\n"
+ "pool lest.ntp.org offline\n"
end
it "deletes pool entry with given address" do
@@ -188,9 +188,9 @@
describe "#pools" do
let(:content) do
"pool test.ntp.org iburst\n" \
- "pool lest.ntp.org offline\n" \
- "pool lest2.ntp.org\n" \
- "# fancy comment\n"
+ "pool lest.ntp.org offline\n" \
+ "pool lest2.ntp.org\n" \
+ "# fancy comment\n"
end
it "returns Hash with address as key and options as value" do
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-ntp-client-5.0.0/test/ntp_client_proposal_test.rb
new/yast2-ntp-client-5.0.1/test/ntp_client_proposal_test.rb
--- old/yast2-ntp-client-5.0.0/test/ntp_client_proposal_test.rb 2023-10-18
23:18:05.000000000 +0200
+++ new/yast2-ntp-client-5.0.1/test/ntp_client_proposal_test.rb 2026-03-25
18:35:00.000000000 +0100
@@ -2,7 +2,7 @@
require_relative "test_helper"
-require_relative "../src/clients/ntp-client_proposal.rb"
+require_relative "../src/clients/ntp-client_proposal"
Yast.import "Packages"
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-ntp-client-5.0.0/test/y2ntp_client/widgets/main_widgets_test.rb
new/yast2-ntp-client-5.0.1/test/y2ntp_client/widgets/main_widgets_test.rb
--- old/yast2-ntp-client-5.0.0/test/y2ntp_client/widgets/main_widgets_test.rb
2023-10-18 23:18:05.000000000 +0200
+++ new/yast2-ntp-client-5.0.1/test/y2ntp_client/widgets/main_widgets_test.rb
2026-03-25 18:35:00.000000000 +0100
@@ -21,9 +21,9 @@
before do
allow(Yast::NtpClient).to receive(:ntp_conf)
.and_return(double(
- pools: { "ntp.org" => {}, "us.ntp.org" => {} },
- modify_pool: nil
- ))
+ pools: { "ntp.org" => {}, "us.ntp.org" => {} },
+ modify_pool: nil
+ ))
allow(subject).to receive(:value).and_return("ntp.org")
allow(subject).to receive(:value=)
allow(Y2NtpClient::Dialog::Pool).to receive(:new)
@@ -37,9 +37,9 @@
before do
allow(Yast::NtpClient).to receive(:ntp_conf)
.and_return(double(
- default_pool_options: {},
- add_pool: nil
- ))
+ default_pool_options: {},
+ add_pool: nil
+ ))
allow(Y2NtpClient::Dialog::Pool).to receive(:new)
.and_return(double(run: :next, resulting_pool: ["de.ntp.org", {}]))
end
