Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package OpenBoard for openSUSE:Factory checked in at 2026-06-01 18:08:50 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/OpenBoard (Old) and /work/SRC/openSUSE:Factory/.OpenBoard.new.1937 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "OpenBoard" Mon Jun 1 18:08:50 2026 rev:19 rq:1356375 version:1.7.7 Changes: -------- --- /work/SRC/openSUSE:Factory/OpenBoard/OpenBoard.changes 2026-04-04 19:09:03.757172276 +0200 +++ /work/SRC/openSUSE:Factory/.OpenBoard.new.1937/OpenBoard.changes 2026-06-01 18:09:32.456078131 +0200 @@ -1,0 +2,6 @@ +Mon Jun 1 13:32:59 UTC 2026 - Martin Winter <[email protected]> + +- add patch 1474-support-poppler-26-04.patch + * compatibility with poppler 26.04 + +------------------------------------------------------------------- New: ---- 1474-support-poppler-26-04.patch ----------(New B)---------- New: - add patch 1474-support-poppler-26-04.patch * compatibility with poppler 26.04 ----------(New E)---------- ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ OpenBoard.spec ++++++ --- /var/tmp/diff_new_pack.mGqiTg/_old 2026-06-01 18:09:33.540123087 +0200 +++ /var/tmp/diff_new_pack.mGqiTg/_new 2026-06-01 18:09:33.540123087 +0200 @@ -30,6 +30,8 @@ Patch955: 0955-shortcut-configuration.patch # https://github.com/OpenBoard-org/OpenBoard/pull/1446 Patch1446: 1446-chore-add-appdata-metainfo.patch +# https://github.com/OpenBoard-org/OpenBoard/pull/1474 +Patch1474: 1474-support-poppler-26-04.patch # https://github.com/letsfindaway/OpenBoard/pull/117 Patch9117: 9117-disable-software-update.patch BuildRequires: desktop-file-utils ++++++ 1474-support-poppler-26-04.patch ++++++ >From b68a0bed3caa5dfcfb9bbbb72cc8d78d95533eb3 Mon Sep 17 00:00:00 2001 From: Vekhir <[email protected]> Date: Wed, 15 Apr 2026 01:18:37 +0200 Subject: [PATCH] refactor: Remove unused pdf title code The code breaks with poppler 26.04. There are no known uses of this function in the code base, and limited testing showed no regressions. --- src/pdf/PDFRenderer.h | 2 -- src/pdf/XPDFRenderer.cpp | 33 --------------------------------- src/pdf/XPDFRenderer.h | 1 - 3 files changed, 36 deletions(-) diff --git a/src/pdf/PDFRenderer.h b/src/pdf/PDFRenderer.h index 8f0cb93e0..a5e872611 100644 --- a/src/pdf/PDFRenderer.h +++ b/src/pdf/PDFRenderer.h @@ -58,8 +58,6 @@ class PDFRenderer : public QObject virtual QSizeF pointSizeF(int pageNumber) const = 0; - virtual QString title() const = 0; - void attach(); void detach(); diff --git a/src/pdf/XPDFRenderer.cpp b/src/pdf/XPDFRenderer.cpp index 8e361430c..bb4bca36c 100644 --- a/src/pdf/XPDFRenderer.cpp +++ b/src/pdf/XPDFRenderer.cpp @@ -157,39 +157,6 @@ int XPDFRenderer::pageCount() const return 0; } -QString XPDFRenderer::title() const -{ - if (isValid()) - { -#if POPPLER_VERSION_MAJOR > 0 || POPPLER_VERSION_MINOR >= 55 - Object pdfInfo = mDocument->getDocInfo(); -#else - Object pdfInfo; - mDocument->getDocInfo(&pdfInfo); -#endif - if (pdfInfo.isDict()) - { - Dict *infoDict = pdfInfo.getDict(); -#if POPPLER_VERSION_MAJOR > 0 || POPPLER_VERSION_MINOR >= 55 - Object title = infoDict->lookup((char*)"Title"); -#else - Object title; - infoDict->lookup((char*)"Title", &title); -#endif - if (title.isString()) - { -#if POPPLER_VERSION_MAJOR > 0 || POPPLER_VERSION_MINOR >= 72 - return QString(title.getString()->c_str()); -#else - return QString(title.getString()->getCString()); -#endif - } - } - } - - return QString(); -} - QSizeF XPDFRenderer::pageSizeF(int pageNumber) const { diff --git a/src/pdf/XPDFRenderer.h b/src/pdf/XPDFRenderer.h index 6264ae1b0..7a9bdf777 100644 --- a/src/pdf/XPDFRenderer.h +++ b/src/pdf/XPDFRenderer.h @@ -73,7 +73,6 @@ class XPDFRenderer : public PDFRenderer virtual QSizeF pageSizeF(int pageNumber) const override; virtual int pageRotation(int pageNumber) const override; virtual QSizeF pointSizeF(int pageNumber) const override; - virtual QString title() const override; virtual void render(QPainter *p, int pageNumber, const bool cacheAllowed, const QRectF &bounds = QRectF()) override; signals:
