Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package libvalkey for openSUSE:Factory checked in at 2026-07-24 00:18:22 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/libvalkey (Old) and /work/SRC/openSUSE:Factory/.libvalkey.new.2004 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libvalkey" Fri Jul 24 00:18:22 2026 rev:3 rq:1367513 version:0.5.0 Changes: -------- --- /work/SRC/openSUSE:Factory/libvalkey/libvalkey.changes 2026-02-25 21:22:08.370737587 +0100 +++ /work/SRC/openSUSE:Factory/.libvalkey.new.2004/libvalkey.changes 2026-07-24 00:18:25.395304645 +0200 @@ -1,0 +2,14 @@ +Thu Jul 23 17:46:31 UTC 2026 - Andreas Stieger <[email protected]> + +- update to 0.5.0: + * Try all addresses from DNS before failing to connect + * Fix potential heap-buffer-overflow in cluster error reply parsing + * RDMA: Fix lost EPOLLIN/POLLIN events + * Additional overflow protection for MAP/ATTR + * Fix gcc warnings +- includes changes from 0.4.0: + * Add support for runtime dynamic (lazy) loading of RDMA libraries +- add libvalkey-0.5.0-Fix-unused-variable.patch +- disable RDMA support due to linker errors + +------------------------------------------------------------------- Old: ---- libvalkey-0.3.0.tar.gz New: ---- libvalkey-0.5.0-Fix-unused-variable.patch libvalkey-0.5.0.tar.gz ----------(New B)---------- New: * Add support for runtime dynamic (lazy) loading of RDMA libraries - add libvalkey-0.5.0-Fix-unused-variable.patch - disable RDMA support due to linker errors ----------(New E)---------- ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libvalkey.spec ++++++ --- /var/tmp/diff_new_pack.yYUivm/_old 2026-07-24 00:18:25.979325138 +0200 +++ /var/tmp/diff_new_pack.yYUivm/_new 2026-07-24 00:18:25.979325138 +0200 @@ -1,7 +1,7 @@ # # spec file for package libvalkey # -# Copyright (c) 2025 Andreas Stieger <[email protected]> +# Copyright (c) 2026 Andreas Stieger <[email protected]> # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -18,14 +18,15 @@ %define sover 0 %bcond_without tls -%bcond_without rdma +%bcond_with rdma Name: libvalkey -Version: 0.3.0 +Version: 0.5.0 Release: 0 Summary: Valkey client library in C License: BSD-3-Clause URL: https://github.com/valkey-io/libvalkey Source: https://github.com/valkey-io/libvalkey/archive/refs/tags/%{version}.tar.gz#/%{name}-%{version}.tar.gz +Patch0: libvalkey-0.5.0-Fix-unused-variable.patch BuildRequires: cmake %if %{with tls} BuildRequires: pkgconfig(libcrypto) ++++++ libvalkey-0.5.0-Fix-unused-variable.patch ++++++ >From 2cdedcf710d9739b7b2f1b2237587bd23c8d4a9b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Svensson?= <[email protected]> Date: Tue, 23 Jun 2026 09:47:47 +0200 Subject: [PATCH] Fix unused variable warnings in rdma.c with NDEBUG (#312) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Remove unnecessary local variables `ctx` and `event` in `valkeyRdmaWaitConn` that only existed to make an `assert()` more readable. When built with `-DNDEBUG -Werror`, the assert is removed and both variables become unused, causing a build failure. Also enable Release build types in the RDMA CI job so that NDEBUG is defined and this class of issue is caught going forward. --------- Signed-off-by: Björn Svensson <[email protected]> --- .github/workflows/ci.yml | 4 ++-- src/rdma.c | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 589c5792..f0924506 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -206,12 +206,12 @@ jobs: - name: Build shared libraries using CMake run: | mkdir build-shared && cd build-shared - cmake -DENABLE_RDMA=ON .. + cmake -DENABLE_RDMA=ON -DCMAKE_BUILD_TYPE=Release .. sudo make install - name: Build static libraries using CMake run: | mkdir build-static && cd build-static - cmake -DBUILD_SHARED_LIBS=OFF -DENABLE_RDMA=ON .. + cmake -DBUILD_SHARED_LIBS=OFF -DENABLE_RDMA=ON -DCMAKE_BUILD_TYPE=RelWithDebInfo .. sudo make install - name: Build using Makefile run: | diff --git a/src/rdma.c b/src/rdma.c index 8a310863..6b8ef6ef 100644 --- a/src/rdma.c +++ b/src/rdma.c @@ -1035,8 +1035,7 @@ static int valkeyRdmaCM(valkeyContext *c, long timeout) { static int valkeyRdmaWaitConn(valkeyContext *c, long timeout) { long now, end; - RdmaContext *ctx = c->privctx; - struct epoll_event events[1], *event; + struct epoll_event events[1]; int nevent; assert(timeout >= 0); @@ -1062,8 +1061,9 @@ static int valkeyRdmaWaitConn(valkeyContext *c, long timeout) { return VALKEY_ERR; } - event = &events[0]; - assert(event->data.fd == ctx->cm_channel->fd); /* CM channel fd wakes up only now */ + /* Only the CM channel fd is polled here */ + assert(events[0].data.fd == ((RdmaContext *)c->privctx)->cm_channel->fd); + if (valkeyRdmaCM(c, end - now) == VALKEY_ERR) { return VALKEY_ERR; } ++++++ libvalkey-0.3.0.tar.gz -> libvalkey-0.5.0.tar.gz ++++++ ++++ 2012 lines of diff (skipped)
