Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package picotool for openSUSE:Factory checked in at 2021-05-12 19:32:18 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/picotool (Old) and /work/SRC/openSUSE:Factory/.picotool.new.2988 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "picotool" Wed May 12 19:32:18 2021 rev:4 rq:892433 version:0.0~git20210424.a49dc0b Changes: -------- --- /work/SRC/openSUSE:Factory/picotool/picotool.changes 2021-04-10 15:28:36.226465020 +0200 +++ /work/SRC/openSUSE:Factory/.picotool.new.2988/picotool.changes 2021-05-12 19:32:52.158884906 +0200 @@ -1,0 +2,8 @@ +Sat May 1 08:43:19 UTC 2021 - Mustafa ??al????kan <mus...@protonmail.com> + +- Update to version 0.0~git20210424.a49dc0b: + * Fix detection of unknown flash-size when saving + * Add boot2 to build information + * Various typos fixed + +------------------------------------------------------------------- Old: ---- picotool-0.0~git20210305.21d5eb9.tar.gz New: ---- picotool-0.0~git20210424.a49dc0b.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ picotool.spec ++++++ --- /var/tmp/diff_new_pack.6ZLUL1/_old 2021-05-12 19:32:52.706882716 +0200 +++ /var/tmp/diff_new_pack.6ZLUL1/_new 2021-05-12 19:32:52.710882700 +0200 @@ -20,7 +20,7 @@ Name: picotool URL: https://github.com/raspberrypi/picotool -Version: 0.0~git20210305.21d5eb9 +Version: 0.0~git20210424.a49dc0b Release: 0 Summary: Tool to inspect RP2040 binaries License: BSD-3-Clause ++++++ picotool-0.0~git20210305.21d5eb9.tar.gz -> picotool-0.0~git20210424.a49dc0b.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/picotool-0.0~git20210305.21d5eb9/README.md new/picotool-0.0~git20210424.a49dc0b/README.md --- old/picotool-0.0~git20210305.21d5eb9/README.md 2021-03-06 03:07:21.000000000 +0100 +++ new/picotool-0.0~git20210424.a49dc0b/README.md 2021-04-24 14:36:53.000000000 +0200 @@ -16,7 +16,7 @@ make ``` -for Windows non mingw/lsw: +for Windows non MinGW/WSL: ```bash mkdir build @@ -255,7 +255,7 @@ ### Pins -This is certainly handy when you have an execute called 'hello_world.elf' but you forgot what board it is built for... +This is certainly handy when you have an executable called 'hello_world.elf' but you forgot what board it is built for... Static (fixed) pin assignments can be recorded in the binary in very compact form: @@ -313,8 +313,8 @@ ### Details -Things are designed to waste as little space as possible, but you can turn everything of with preprocessor var `PICO_NO_BINARY_INFO=1`. Additionally -any SDK code that inserts binary info cane be separately excluded by its own preprocesor var. +Things are designed to waste as little space as possible, but you can turn everything off with preprocessor var `PICO_NO_BINARY_INFO=1`. Additionally +any SDK code that inserts binary info can be separately excluded by its own preprocesor var. You need ```c @@ -397,7 +397,7 @@ ### Block devices MicroPython and CircuitPython, eventually the SDK and others may support one or more storage devices in flash. We already -have macros to define these although picotool doesn't do wanything with them yet... but backup/restore/file copy and even fuse mount +have macros to define these although picotool doesn't do anything with them yet... but backup/restore/file copy and even fuse mount in the future might be interesting. I suggest we tag these now... @@ -433,11 +433,11 @@ ### USB device descriptors Seems like tagging these might be nice (we just need to store the pointer to it assuming - as is often the case - -the descriptor is just a linear chunk of memory) ... I assume there is a tool out there to prettyify such a think if picotool dumps the descriptor -in binary.. +the descriptor is just a linear chunk of memory) ... I assume there is a tool out there to prettyify such a thing if picotool dumps the descriptor +in binary. ### Issues If you ctrl+c out of the middle of a long operation, then libusb seems to get a bit confused, which means we aren't able to unlock our lockout of USB MSD writes (we have turned them off so the user doesn't step on their own toes). Simply running -`picotool info` again will unlock it properly the nex time (or you can reboot the device). +`picotool info` again will unlock it properly the next time (or you can reboot the device). diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/picotool-0.0~git20210305.21d5eb9/main.cpp new/picotool-0.0~git20210424.a49dc0b/main.cpp --- old/picotool-0.0~git20210305.21d5eb9/main.cpp 2021-03-06 03:07:21.000000000 +0100 +++ new/picotool-0.0~git20210424.a49dc0b/main.cpp 2021-04-24 14:36:53.000000000 +0200 @@ -837,28 +837,28 @@ static void read_and_check_elf32_header(FILE *in, elf32_header& eh_out) { if (1 != fread(&eh_out, sizeof(eh_out), 1, in)) { - fail(ERROR_FORMAT, "'" + settings.filename +" is not an ELF file"); + fail(ERROR_FORMAT, "'" + settings.filename +"' is not an ELF file"); } if (eh_out.common.magic != ELF_MAGIC) { - fail(ERROR_FORMAT, "'" + settings.filename +" is not an ELF file"); + fail(ERROR_FORMAT, "'" + settings.filename +"' is not an ELF file"); } if (eh_out.common.version != 1 || eh_out.common.version2 != 1) { - fail(ERROR_FORMAT, "'" + settings.filename +" has an unsupported ELF version"); + fail(ERROR_FORMAT, "'" + settings.filename +"' has an unsupported ELF version"); } if (eh_out.common.arch_class != 1 || eh_out.common.endianness != 1) { - fail(ERROR_INCOMPATIBLE, "'" + settings.filename +" is not a 32 bit little-endian ELF"); + fail(ERROR_INCOMPATIBLE, "'" + settings.filename +"' is not a 32 bit little-endian ELF"); } if (eh_out.eh_size != sizeof(struct elf32_header)) { - fail(ERROR_FORMAT, "'" + settings.filename + "is not valid"); + fail(ERROR_FORMAT, "'" + settings.filename + "' is not valid"); } if (eh_out.common.machine != EM_ARM) { - fail(ERROR_FORMAT, "'" + settings.filename +" is not an ARM executable"); + fail(ERROR_FORMAT, "'" + settings.filename +"' is not an ARM executable"); } if (eh_out.common.abi != 0) { - fail(ERROR_INCOMPATIBLE, "'" + settings.filename +" has the wrong architecture"); + fail(ERROR_INCOMPATIBLE, "'" + settings.filename +"' has the wrong architecture"); } if (eh_out.flags & EF_ARM_ABI_FLOAT_HARD) { - fail(ERROR_INCOMPATIBLE, "'" + settings.filename +" has the wrong architecture (hard float)"); + fail(ERROR_INCOMPATIBLE, "'" + settings.filename +"' has the wrong architecture (hard float)"); } } @@ -1318,7 +1318,7 @@ map<string, vector<string>> named_feature_group_values; string program_name, program_build_date, program_version, program_url, program_description; - string pico_board, sdk_version; + string pico_board, sdk_version, boot2_name; vector<string> program_features, build_attributes; uint32_t binary_end = 0; @@ -1359,6 +1359,7 @@ else if (id == BINARY_INFO_ID_RP_PROGRAM_BUILD_ATTRIBUTE) build_attributes.push_back(value); else if (id == BINARY_INFO_ID_RP_PICO_BOARD) pico_board = value; else if (id == BINARY_INFO_ID_RP_SDK_VERSION) sdk_version = value; + else if (id == BINARY_INFO_ID_RP_BOOT2_NAME) boot2_name = value; }); visitor.pin([&](uint pin, const string &name) { pins[pin].push_back(name); @@ -1434,6 +1435,7 @@ select_group(build_info); info_pair("sdk version", sdk_version); info_pair("pico_board", pico_board); + info_pair("boot2_name", boot2_name); info_pair("build date", program_build_date); info_pair("build attributes", cli::join(build_attributes, "\n")); } @@ -1613,7 +1615,7 @@ } } else { end = FLASH_START + guess_flash_size(raw_access); - if (end == 0) { + if (end <= FLASH_START) { fail(ERROR_NOT_POSSIBLE, "Cannot determine the flash size, so cannot save the entirety of flash, try --range."); } }
