Script 'mail_helper' called by obssrc
Hello community,

here is the log from the commit of package NetworkManager for openSUSE:Factory 
checked in at 2026-11-16 09:07:32
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/NetworkManager (Old)
 and      /work/SRC/openSUSE:Factory/.NetworkManager.new.1251 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "NetworkManager"

Mon Nov 16 09:07:32 2026 rev:297 rq:1397276 version:1.58.1

Changes:
--------
--- /work/SRC/openSUSE:Factory/NetworkManager/NetworkManager.changes    
2026-10-02 23:01:40.882119125 +0200
+++ /work/SRC/openSUSE:Factory/.NetworkManager.new.1251/NetworkManager.changes  
2026-11-16 09:11:30.853455411 +0100
@@ -1,0 +2,7 @@
+Fri Nov 13 07:01:14 UTC 2026 - Jonathan Kang <[email protected]>
+
+- Add NetworkManager-restrict-dhcp-cleanup-to-ovs.patch:
+  device: Restrict DHCP cleanup in DEACTIVATING to OVS devices
+  (bsc#1284486, glfd#NetworkManager/NetworkManager!2579).
+
+-------------------------------------------------------------------

New:
----
  NetworkManager-restrict-dhcp-cleanup-to-ovs.patch

----------(New B)----------
  New:
- Add NetworkManager-restrict-dhcp-cleanup-to-ovs.patch:
  device: Restrict DHCP cleanup in DEACTIVATING to OVS devices
----------(New E)----------

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ NetworkManager.spec ++++++
--- /var/tmp/diff_new_pack.wgJQ13/_old  2026-11-16 09:11:31.806495367 +0100
+++ /var/tmp/diff_new_pack.wgJQ13/_new  2026-11-16 09:11:31.807495409 +0100
@@ -107,6 +107,8 @@
 Patch11:        0001-man-document-static-ip-setup-differences-to-dracut-n.patch
 # PATCH-FEATURE-SLE NetworkManager-initrd-generator-ip-hcn.patch PED-14534 
[email protected] -- handle "ip=hcn" option in nm-initrd-generator, it generates 
an empty connection
 Patch16:        NetworkManager-initrd-generator-ip-hcn.patch
+# PATCH-FIX-UPSTREAM NetworkManager-restrict-dhcp-cleanup-to-ovs.patch 
bsc#1284486, glfd#NetworkManager/NetworkManager!2579 [email protected] --  
device: Restrict DHCP cleanup in DEACTIVATING to OVS devices
+Patch17:        NetworkManager-restrict-dhcp-cleanup-to-ovs.patch
 
 BuildRequires:  c++_compiler
 BuildRequires:  dnsmasq
@@ -340,6 +342,7 @@
 %if 0%{?sle_version} && 0%{?sle_version} > 160000
 %patch -P 16 -p1
 %endif
+%patch -P 17 -p1
 
 # Fix server.conf's location, to end up in %%{_defaultdocdir}/%%{name},
 # rather then %%{_datadir}/doc/%%{name}/examples:

++++++ NetworkManager-restrict-dhcp-cleanup-to-ovs.patch ++++++
>From 3df71dc9b0622934acfb9a62c655326ea63377a1 Mon Sep 17 00:00:00 2001
From: Jonathan Kang <[email protected]>
Date: Fri, 23 Oct 2026 10:27:19 +0800
Subject: [PATCH] device: Restrict DHCP cleanup in DEACTIVATING to OVS devices

Commit 09784fcc performs a full DHCP cleanup in DEACTIVATING. This
removes the DHCP addresses before the pre-down scripts run. As a
result, no IP is available for some devices in the pre-down dispatcher
phase since version 1.58.

Fix this by only cleaning up DHCP for OVS devices that have
ipv4/6.dhcp-send-release set to TRUE.

https://bugzilla.suse.com/show_bug.cgi?id=1284486
---
 src/core/devices/nm-device.c | 49 +++++++++++++++++++++++++++++++-----
 1 file changed, 43 insertions(+), 6 deletions(-)

diff --git a/src/core/devices/nm-device.c b/src/core/devices/nm-device.c
index 6e154d0a92..e5c31cc79c 100644
--- a/src/core/devices/nm-device.c
+++ b/src/core/devices/nm-device.c
@@ -2233,6 +2233,35 @@ _prop_get_ipvx_dhcp_send_hostname(NMDevice *self, int 
addr_family)
     return send_hostname_v2;
 }
 
+static gboolean
+_prop_get_ipvx_dhcp_send_release(NMDevice *self, int addr_family)
+{
+    const int          IS_IPv4 = NM_IS_IPv4(addr_family);
+    NMSettingIPConfig *s_ip = IS_IPv4
+                                  ? nm_device_get_applied_setting(self, 
NM_TYPE_SETTING_IP4_CONFIG)
+                                  : nm_device_get_applied_setting(self, 
NM_TYPE_SETTING_IP6_CONFIG);
+    NMTernary          send_release;
+
+    g_return_val_if_fail(s_ip, FALSE);
+
+    send_release = nm_setting_ip_config_get_dhcp_send_release(s_ip);
+
+    /* If it is explicitly configured, respect it.
+     * Otherwise check if NetworkManager's global default is enabled,
+     * or evaluate ternary truthiness: */
+    if (send_release != NM_TERNARY_DEFAULT)
+        return (send_release == NM_TERNARY_TRUE);
+
+    return nm_config_data_get_connection_default_int64(
+        NM_CONFIG_GET_DATA,
+        IS_IPv4 ? NM_CON_DEFAULT("ipv4.dhcp-send-release")
+                : NM_CON_DEFAULT("ipv6.dhcp-send-release"),
+        self,
+        NM_TERNARY_FALSE,
+        NM_TERNARY_TRUE,
+        NM_TERNARY_FALSE) == NM_TERNARY_TRUE;
+}
+
 static NMSettingIPConfigForwarding
 _prop_get_ipv4_forwarding(NMDevice *self)
 {
@@ -18002,12 +18031,20 @@ _set_state_full(NMDevice *self, NMDeviceState state, 
NMDeviceStateReason reason,
         }
         break;
     case NM_DEVICE_STATE_DEACTIVATING:
-        /* When deactivating, certain devices are removed/disconnected after 
the
-         * STATE_CHANGED signal is sent and before the DHCP release packet
-         * can be sent. To ensure the release packet is sent, we cleanup DHCP
-         * before the signal is emitted*/
-        _dev_ipdhcpx_cleanup(self, AF_INET, TRUE, FALSE);
-        _dev_ipdhcpx_cleanup(self, AF_INET6, TRUE, FALSE);
+        gboolean is_ovs_interface = (nm_device_get_device_type(self) == 
NM_DEVICE_TYPE_OVS_INTERFACE)
+                            || (priv->controller && 
nm_device_get_device_type(priv->controller) == NM_DEVICE_TYPE_OVS_PORT);
+
+        /* For OVS interfaces, the controller removes the link from ovsdb as 
soon
+         * as the STATE_CHANGED signal is emitted. If dhcp-send-release is 
enabled,
+         * the release packet must be sent prior to signal emission to avoid
+         * packet loss from an already-removed interface. */
+        if (is_ovs_interface) {
+            if (_prop_get_ipvx_dhcp_send_release(self, AF_INET))
+                _dev_ipdhcpx_cleanup(self, AF_INET, TRUE, FALSE);
+
+            if (_prop_get_ipvx_dhcp_send_release(self, AF_INET6))
+                _dev_ipdhcpx_cleanup(self, AF_INET6, TRUE, FALSE);
+        }
         break;
     case NM_DEVICE_STATE_DISCONNECTED:
         if (old_state > NM_DEVICE_STATE_DISCONNECTED) {
-- 
2.55.0


++++++ _scmsync.obsinfo ++++++
--- /var/tmp/diff_new_pack.wgJQ13/_old  2026-11-16 09:11:31.938500901 +0100
+++ /var/tmp/diff_new_pack.wgJQ13/_new  2026-11-16 09:11:31.941501027 +0100
@@ -1,7 +1,7 @@
-mtime: 1790847577
-commit: 898e9456e8de176a77ccbdf016d1b344e6214eade15ed01857cfe69e3b076981
+mtime: 1794553352
+commit: bf663a2ef2fde01b82880db586c2cabef8c7a15639991de84fc6d0d6dbc85d44
 url: https://src.opensuse.org/GNOME/NetworkManager
-revision: 898e9456e8de176a77ccbdf016d1b344e6214eade15ed01857cfe69e3b076981
+revision: bf663a2ef2fde01b82880db586c2cabef8c7a15639991de84fc6d0d6dbc85d44
 trackingbranch: factory
 projectscmsync: https://src.opensuse.org/GNOME/_ObsPrj
 

++++++ build.specials.obscpio ++++++

++++++ build.specials.obscpio ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/.gitignore new/.gitignore
--- old/.gitignore      1970-01-01 01:00:00.000000000 +0100
+++ new/.gitignore      2026-11-13 08:02:32.000000000 +0100
@@ -0,0 +1,5 @@
+*.obscpio
+*.osc
+_build.*
+.pbuild
+osc-collab.*

Reply via email to