Script 'mail_helper' called by obssrc
Hello community,

here is the log from the commit of package fish for openSUSE:Factory checked in 
at 2026-11-18 18:29:30
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/fish (Old)
 and      /work/SRC/openSUSE:Factory/.fish.new.1251 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "fish"

Wed Nov 18 18:29:30 2026 rev:53 rq:1398171 version:4.8.1

Changes:
--------
--- /work/SRC/openSUSE:Factory/fish/fish.changes        2026-07-23 
23:08:46.056968950 +0200
+++ /work/SRC/openSUSE:Factory/.fish.new.1251/fish.changes      2026-11-18 
18:29:38.073972565 +0100
@@ -1,0 +2,10 @@
+Tue Nov 17 11:40:00 UTC 2026 - Ana Guerrero <[email protected]>
+
+- Add fish-fix-cmake-4.5-install-code.patch: use the install(CODE)
+  signature instead of install(SCRIPT CODE ...) for the inline
+  directory-creation commands. CMake 4.5 rejects the latter because
+  SCRIPT has no filename, which made configuration fail with
+  "install SCRIPT given invalid argument: SCRIPT: missing required
+  value" (upstream commit 95dccbe).
+
+-------------------------------------------------------------------

New:
----
  fish-fix-cmake-4.5-install-code.patch

----------(New B)----------
  New:
- Add fish-fix-cmake-4.5-install-code.patch: use the install(CODE)
  signature instead of install(SCRIPT CODE ...) for the inline
----------(New E)----------

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ fish.spec ++++++
--- /var/tmp/diff_new_pack.Jy0oV9/_old  2026-11-18 18:29:39.037013355 +0100
+++ /var/tmp/diff_new_pack.Jy0oV9/_new  2026-11-18 18:29:39.038013397 +0100
@@ -27,6 +27,7 @@
 Source:         
https://github.com/fish-shell/fish-shell/releases/download/%{version}/fish-%{version}.tar.xz
 Source2:        vendor.tar.xz
 Source100:      fish.keyring
+Patch0:         fish-fix-cmake-4.5-install-code.patch
 BuildRequires:  %{python_module Sphinx}
 BuildRequires:  cargo
 BuildRequires:  cmake

++++++ fish-fix-cmake-4.5-install-code.patch ++++++
>From 95dccbe55eefe73e526563296beded4a8407b8a8 Mon Sep 17 00:00:00 2001
From: Rui Chen <[email protected]>
Date: Sat, 14 Nov 2026 03:46:50 -0500
Subject: [PATCH] cmake: use CODE signature for inline install commands

CMake 4.5 now rejects install(SCRIPT CODE ...) because SCRIPT has no filename. 
Use the CODE signature for the existing inline directory-creation commands, 
preserving their install-time behavior.

Observed while building fish 4.9.3 in Homebrew/homebrew-core#325151; the 
failure occurs during CMake configuration, before Rust compilation.

Signed-off-by: Rui Chen <[email protected]>
---
 cmake/Install.cmake | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cmake/Install.cmake b/cmake/Install.cmake
index 37c2ebe7c28e..d9d5625d9134 100644
--- a/cmake/Install.cmake
+++ b/cmake/Install.cmake
@@ -71,7 +71,7 @@ function(FISH_TRY_CREATE_DIRS)
         else()
             set(abs_dir "\$ENV{DESTDIR}${dir}")
         endif()
-        install(SCRIPT CODE "
+        install(CODE "
             EXECUTE_PROCESS(COMMAND mkdir -p ${abs_dir} OUTPUT_QUIET 
ERROR_QUIET)
             execute_process(COMMAND chmod 755 ${abs_dir} OUTPUT_QUIET 
ERROR_QUIET)
         ")

Reply via email to