Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package python-keystonemiddleware for
openSUSE:Factory checked in at 2026-11-18 18:29:59
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/python-keystonemiddleware (Old)
and /work/SRC/openSUSE:Factory/.python-keystonemiddleware.new.1251 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "python-keystonemiddleware"
Wed Nov 18 18:29:59 2026 rev:25 rq:1398172 version:13.0.2
Changes:
--------
---
/work/SRC/openSUSE:Factory/python-keystonemiddleware/python-keystonemiddleware.changes
2026-09-08 16:58:03.570844898 +0200
+++
/work/SRC/openSUSE:Factory/.python-keystonemiddleware.new.1251/python-keystonemiddleware.changes
2026-11-18 18:30:37.455487798 +0100
@@ -1,0 +2,9 @@
+Tue Nov 17 14:03:27 UTC 2026 - Dirk Müller <[email protected]>
+
+- update to 13.0.2:
+ * Fix service-token presence bypass of access_rules and token
+ bind
+ * Update TOX_CONSTRAINTS_FILE for stable/2026.2
+ * Update .gitreview for stable/2026.2
+
+-------------------------------------------------------------------
Old:
----
keystonemiddleware-13.0.1.tar.gz
New:
----
keystonemiddleware-13.0.2.tar.gz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ python-keystonemiddleware.spec ++++++
--- /var/tmp/diff_new_pack.H3dsN3/_old 2026-11-18 18:30:38.686539952 +0100
+++ /var/tmp/diff_new_pack.H3dsN3/_new 2026-11-18 18:30:38.688540036 +0100
@@ -17,7 +17,7 @@
Name: python-keystonemiddleware
-Version: 13.0.1
+Version: 13.0.2
Release: 0
Summary: Middleware for OpenStack Identity
License: Apache-2.0
++++++ keystonemiddleware-13.0.1.tar.gz -> keystonemiddleware-13.0.2.tar.gz
++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/keystonemiddleware-13.0.1/ChangeLog
new/keystonemiddleware-13.0.2/ChangeLog
--- old/keystonemiddleware-13.0.1/ChangeLog 2026-08-25 09:52:40.928218800
+0200
+++ new/keystonemiddleware-13.0.2/ChangeLog 2026-11-02 11:26:52.791066600
+0100
@@ -1,6 +1,13 @@
CHANGES
=======
+13.0.2
+------
+
+* Fix service-token presence bypass of access\_rules and token bind
+* Update TOX\_CONSTRAINTS\_FILE for stable/2026.2
+* Update .gitreview for stable/2026.2
+
13.0.1
------
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/keystonemiddleware-13.0.1/PKG-INFO
new/keystonemiddleware-13.0.2/PKG-INFO
--- old/keystonemiddleware-13.0.1/PKG-INFO 2026-08-25 09:52:41.090254800
+0200
+++ new/keystonemiddleware-13.0.2/PKG-INFO 2026-11-02 11:26:53.019079000
+0100
@@ -1,6 +1,6 @@
Metadata-Version: 2.4
Name: keystonemiddleware
-Version: 13.0.1
+Version: 13.0.2
Summary: Middleware for OpenStack Identity
Home-page: https://docs.openstack.org/keystonemiddleware/latest/
Author: OpenStack
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/keystonemiddleware-13.0.1/keystonemiddleware/auth_token/__init__.py
new/keystonemiddleware-13.0.2/keystonemiddleware/auth_token/__init__.py
--- old/keystonemiddleware-13.0.1/keystonemiddleware/auth_token/__init__.py
2026-08-25 09:51:52.752014400 +0200
+++ new/keystonemiddleware-13.0.2/keystonemiddleware/auth_token/__init__.py
2026-11-02 11:25:57.468931400 +0100
@@ -412,7 +412,12 @@
allow_expired=allow_expired)
if user_auth_ref.version != 'v2.0':
self.validate_allowed_request(request, data['token'])
- if not request.service_token:
+ # Require a *valid* service token before skipping bind, same
+ # presence-vs-validity fix as validate_allowed_request
+ # (LP#2162748). An arbitrary X-Service-Token must not defeat
+ # Kerberos (or other) token binding.
+ if not (request.service_token and
+ request.service_token_valid):
self._confirm_token_bind(user_auth_ref, request)
except ksm_exceptions.InvalidToken:
self.log.info('Invalid user token')
@@ -572,10 +577,10 @@
' [keystone_authtoken] is not a valid service'
' type in the catalog.')
raise ksm_exceptions.InvalidToken(_('Token authorization failed'))
- if request.service_token:
- # The request may not match an allowed request, but the presence
- # of the service token indicates this is a chain of requests and
- # hence this request was not user-facing
+ if request.service_token and request.service_token_valid:
+ # The request may not match an allowed request, but a valid
+ # service token indicates this is a chain of requests and
+ # hence this request was not user-facing (LP#2162748).
return
for access_rule in access_rules:
method = access_rule['method']
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/keystonemiddleware-13.0.1/keystonemiddleware/tests/unit/auth_token/test_auth_token_middleware.py
new/keystonemiddleware-13.0.2/keystonemiddleware/tests/unit/auth_token/test_auth_token_middleware.py
---
old/keystonemiddleware-13.0.1/keystonemiddleware/tests/unit/auth_token/test_auth_token_middleware.py
2026-08-25 09:51:52.757025500 +0200
+++
new/keystonemiddleware-13.0.2/keystonemiddleware/tests/unit/auth_token/test_auth_token_middleware.py
2026-11-02 11:25:57.479935200 +0100
@@ -861,6 +861,65 @@
use_kerberos='[email protected]',
success=False)
+ def test_kerberos_bind_skipped_by_invalid_service_token(self):
+ """LP#2162748 follow-up: garbage X-Service-Token skips Kerberos bind.
+
+ ``_confirm_token_bind()`` is gated on ``if not request.service_token``
+ (header presence), not ``service_token_valid``. With
+ ``delay_auth_decision``, the invalid service token does not abort
+ the request, so a Kerberos-bound user token is marked Confirmed
+ without a Negotiate session — the theft scenario binding exists
+ to prevent.
+ """
+ conf = {
+ "www_authenticate_uri": BASE_HOST,
+ "auth_type": "admin_token",
+ "endpoint": f"{BASE_URI}/v3",
+ "token": FAKE_ADMIN_TOKEN_ID,
+ "enforce_token_bind": "kerberos",
+ "auth_version": self.auth_version,
+ "delay_auth_decision": True,
+ }
+ self.set_middleware(conf=conf)
+
+ # Replace FakeApp — its delayed-auth branches KeyError when no
+ # service-status header is present. We only care what auth_token
+ # stamped on the request.
+ @webob.dec.wsgify
+ def _passthrough(req):
+ return webob.Response(body=b"OK", status=200)
+
+ self.middleware._app = _passthrough
+ token = self.token_dict["uuid_token_bind"]
+
+ # Baseline: no service token, no Kerberos → bind fails → user Invalid.
+ req = webob.Request.blank("/")
+ req.headers["X-Auth-Token"] = token
+ resp = req.get_response(self.middleware)
+ self.assertEqual(200, resp.status_int)
+ self.assertEqual(
+ "Invalid",
+ req.environ.get("HTTP_X_IDENTITY_STATUS"),
+ )
+
+ # Attack: same bound token + arbitrary X-Service-Token, still no
+ # Kerberos. Bind is skipped; user is Confirmed.
+ req = webob.Request.blank("/")
+ req.headers["X-Auth-Token"] = token
+ req.headers["X-Service-Token"] = "invalid-garbage"
+ resp = req.get_response(self.middleware)
+ self.assertEqual(200, resp.status_int)
+ self.assertEqual(
+ "Invalid",
+ req.environ.get("HTTP_X_SERVICE_IDENTITY_STATUS"),
+ )
+ # Vulnerable before the fix: Confirmed without Kerberos. After the
+ # fix, bind runs because service_token_valid is False → Invalid.
+ self.assertEqual(
+ "Invalid",
+ req.environ.get("HTTP_X_IDENTITY_STATUS"),
+ )
+
def test_uuid_bind_token_with_unknown_named_FOO(self):
token = self.token_dict['uuid_token_bind']
@@ -1296,6 +1355,20 @@
expected_status=200,
method='GET', path='/v2/images')
+ def test_app_cred_access_rules_invalid_service_token(self):
+ """Arbitrary invalid X-Service-Token must not bypass access_rules."""
+ self.set_middleware(conf={"service_type": "compute"})
+ token = self.examples.v3_APP_CRED_ACCESS_RULES
+ self.call_middleware(
+ headers={
+ "X-Auth-Token": token,
+ "X-Service-Token": "invalid-garbage",
+ },
+ expected_status=401,
+ method="GET",
+ path="/v2.1/servers/someuuid",
+ )
+
def test_app_cred_no_access_rules_token(self):
self.set_middleware(conf={'service_type': 'compute'})
token = self.examples.v3_APP_CRED_EMPTY_ACCESS_RULES
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/keystonemiddleware-13.0.1/keystonemiddleware/tests/unit/auth_token/test_base_middleware.py
new/keystonemiddleware-13.0.2/keystonemiddleware/tests/unit/auth_token/test_base_middleware.py
---
old/keystonemiddleware-13.0.1/keystonemiddleware/tests/unit/auth_token/test_base_middleware.py
2026-08-25 09:51:52.758027800 +0200
+++
new/keystonemiddleware-13.0.2/keystonemiddleware/tests/unit/auth_token/test_base_middleware.py
2026-11-02 11:25:57.480935600 +0100
@@ -19,6 +19,7 @@
import webob
from keystonemiddleware import auth_token
+from keystonemiddleware.auth_token import _exceptions as ksm_exceptions
from keystonemiddleware.auth_token import _request
@@ -229,3 +230,92 @@
resp = self.call(m, headers={'X-Project-Id': project_id,
'X-Domain-Id': domain_id})
self.assertEqual(body, resp.text)
+
+ def test_app_cred_access_rules_invalid_service_token(self):
+ """An invalid service token must not bypass access_rules."""
+ access_rules = [
+ {"path": "/v2.1/servers", "method": "GET", "service": "compute"}
+ ]
+ token_data = {
+ "is_admin": 0,
+ "user": {"id": "user1"},
+ "methods": [],
+ "application_credential": {
+ "id": "app_cred_1",
+ "access_rules": access_rules,
+ },
+ "catalog": [
+ {
+ "type": "compute",
+ "name": "nova",
+ "endpoints": [
+ {
+ "id": "ep",
+ "interface": "public",
+ "url": "http://nova:8774/v2.1",
+ }
+ ],
+ }
+ ],
+ }
+ mock_request = mock.MagicMock()
+ mock_request.method = "GET"
+ mock_request.path = "/v2.1/servers/someuuid"
+ mock_request.service_token = "garbage-invalid-token"
+ mock_request.service_token_valid = False
+
+ class TestMiddleware(auth_token.BaseAuthProtocol):
+ def __init__(self, app):
+ super(TestMiddleware, self).__init__(app)
+ self._service_type = "compute"
+
+ m = TestMiddleware(FakeApp())
+
+ self.assertRaises(
+ ksm_exceptions.InvalidToken,
+ m.validate_allowed_request,
+ mock_request,
+ token_data,
+ )
+
+ def test_app_cred_access_rules_valid_service_token(self):
+ """A valid service token should bypass access_rules."""
+ access_rules = [
+ {"path": "/v2.1/servers", "method": "GET", "service": "compute"}
+ ]
+ token_data = {
+ "is_admin": 0,
+ "user": {"id": "user1"},
+ "methods": [],
+ "application_credential": {
+ "id": "app_cred_1",
+ "access_rules": access_rules,
+ },
+ "catalog": [
+ {
+ "type": "compute",
+ "name": "nova",
+ "endpoints": [
+ {
+ "id": "ep",
+ "interface": "public",
+ "url": "http://nova:8774/v2.1",
+ }
+ ],
+ }
+ ],
+ }
+ mock_request = mock.MagicMock()
+ mock_request.method = "GET"
+ mock_request.path = "/v2.1/servers/someuuid"
+ mock_request.service_token = "valid-service-token"
+ mock_request.service_token_valid = True
+
+ class TestMiddleware(auth_token.BaseAuthProtocol):
+ def __init__(self, app):
+ super(TestMiddleware, self).__init__(app)
+ self._service_type = "compute"
+
+ m = TestMiddleware(FakeApp())
+
+ m.validate_allowed_request(mock_request, token_data)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/keystonemiddleware-13.0.1/keystonemiddleware.egg-info/PKG-INFO
new/keystonemiddleware-13.0.2/keystonemiddleware.egg-info/PKG-INFO
--- old/keystonemiddleware-13.0.1/keystonemiddleware.egg-info/PKG-INFO
2026-08-25 09:52:41.008237000 +0200
+++ new/keystonemiddleware-13.0.2/keystonemiddleware.egg-info/PKG-INFO
2026-11-02 11:26:52.912073100 +0100
@@ -1,6 +1,6 @@
Metadata-Version: 2.4
Name: keystonemiddleware
-Version: 13.0.1
+Version: 13.0.2
Summary: Middleware for OpenStack Identity
Home-page: https://docs.openstack.org/keystonemiddleware/latest/
Author: OpenStack
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/keystonemiddleware-13.0.1/keystonemiddleware.egg-info/SOURCES.txt
new/keystonemiddleware-13.0.2/keystonemiddleware.egg-info/SOURCES.txt
--- old/keystonemiddleware-13.0.1/keystonemiddleware.egg-info/SOURCES.txt
2026-08-25 09:52:41.051246200 +0200
+++ new/keystonemiddleware-13.0.2/keystonemiddleware.egg-info/SOURCES.txt
2026-11-02 11:26:52.969076400 +0100
@@ -113,6 +113,7 @@
releasenotes/notes/bug-1803940-9a39c66014763af0.yaml
releasenotes/notes/bug-1809101-6b5088443d5970ba.yaml
releasenotes/notes/bug-1813739-80eae72371903119.yaml
+releasenotes/notes/bug-2162748-service-token-presence-bypass-eedd42093bbee9b9.yaml
releasenotes/notes/bug_1540115-677cf5016bc46348.yaml
releasenotes/notes/change-default-identity-endpoint-fab39579255c31bb.yaml
releasenotes/notes/delay_auth_instead_of_503-f9b46bf4fbc11455.yaml
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/keystonemiddleware-13.0.1/keystonemiddleware.egg-info/pbr.json
new/keystonemiddleware-13.0.2/keystonemiddleware.egg-info/pbr.json
--- old/keystonemiddleware-13.0.1/keystonemiddleware.egg-info/pbr.json
2026-08-25 09:52:41.006236300 +0200
+++ new/keystonemiddleware-13.0.2/keystonemiddleware.egg-info/pbr.json
2026-11-02 11:26:52.910073000 +0100
@@ -1 +1 @@
-{"git_version": "25a680f", "is_release": true}
\ No newline at end of file
+{"git_version": "5042f7b", "is_release": true}
\ No newline at end of file
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/keystonemiddleware-13.0.1/releasenotes/notes/bug-2162748-service-token-presence-bypass-eedd42093bbee9b9.yaml
new/keystonemiddleware-13.0.2/releasenotes/notes/bug-2162748-service-token-presence-bypass-eedd42093bbee9b9.yaml
---
old/keystonemiddleware-13.0.1/releasenotes/notes/bug-2162748-service-token-presence-bypass-eedd42093bbee9b9.yaml
1970-01-01 01:00:00.000000000 +0100
+++
new/keystonemiddleware-13.0.2/releasenotes/notes/bug-2162748-service-token-presence-bypass-eedd42093bbee9b9.yaml
2026-11-02 11:25:57.417913400 +0100
@@ -0,0 +1,14 @@
+---
+security:
+ - |
+ [`bug 2162748 <https://launchpad.net/bugs/2162748>`_]
+ ``auth_token`` middleware no longer treats the mere presence of an
+ ``X-Service-Token`` header as sufficient to skip application
+ credential ``access_rules`` checks or token binding
+ (``enforce_token_bind``, including Kerberos). Both paths now
+ require the service token to also be valid
+ (``service_token_valid``). Previously an arbitrary
+ ``X-Service-Token`` value could bypass ``access_rules`` and, when
+ ``delay_auth_decision`` was enabled, skip Kerberos (or other)
+ binding so a stolen bound user token would be marked Confirmed
+ without a Negotiate session.
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/keystonemiddleware-13.0.1/tox.ini
new/keystonemiddleware-13.0.2/tox.ini
--- old/keystonemiddleware-13.0.1/tox.ini 2026-08-25 09:51:52.771057000
+0200
+++ new/keystonemiddleware-13.0.2/tox.ini 2026-11-02 11:25:57.492939700
+0100
@@ -9,7 +9,7 @@
OS_STDOUT_NOCAPTURE=False
OS_STDERR_NOCAPTURE=False
deps =
-
-c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}
+
-c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/2026.2}
-r{toxinidir}/requirements.txt
-r{toxinidir}/test-requirements.txt
commands =
@@ -38,7 +38,7 @@
[testenv:docs]
deps =
-
-c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}
+
-c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/2026.2}
-r{toxinidir}/doc/requirements.txt
commands=
doc8 doc/source
@@ -56,7 +56,7 @@
[testenv:releasenotes]
deps =
-
-c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}
+
-c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/2026.2}
-r{toxinidir}/doc/requirements.txt
commands =
sphinx-build -a -E -W -d releasenotes/build/doctrees -b html
releasenotes/source releasenotes/build/html