Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package python-acme for openSUSE:Factory checked in at 2026-11-19 16:57:54 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/python-acme (Old) and /work/SRC/openSUSE:Factory/.python-acme.new.1251 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "python-acme" Thu Nov 19 16:57:54 2026 rev:86 rq:1398693 version:5.10.0 Changes: -------- --- /work/SRC/openSUSE:Factory/python-acme/python-acme.changes 2026-09-08 17:07:56.037611338 +0200 +++ /work/SRC/openSUSE:Factory/.python-acme.new.1251/python-acme.changes 2026-11-19 16:59:10.711117605 +0100 @@ -1,0 +2,7 @@ +Thu Nov 19 12:15:12 UTC 2026 - Markéta Machová <[email protected]> + +- update to 5.10.0 + * Rejects invalid ARI suggested renewal windows whose end time + is not after their start time. + +------------------------------------------------------------------- Old: ---- acme-5.8.0.tar.gz New: ---- acme-5.10.0.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ python-acme.spec ++++++ --- /var/tmp/diff_new_pack.Cj7Lox/_old 2026-11-19 16:59:11.679158638 +0100 +++ /var/tmp/diff_new_pack.Cj7Lox/_new 2026-11-19 16:59:11.681158723 +0100 @@ -19,7 +19,7 @@ %{?sle15_python_module_pythons} %define libname acme Name: python-%{libname} -Version: 5.8.0 +Version: 5.10.0 Release: 0 Summary: Python library for the ACME protocol License: Apache-2.0 ++++++ acme-5.8.0.tar.gz -> acme-5.10.0.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/acme-5.8.0/PKG-INFO new/acme-5.10.0/PKG-INFO --- old/acme-5.8.0/PKG-INFO 2026-09-01 19:52:22.358728600 +0200 +++ new/acme-5.10.0/PKG-INFO 2026-11-10 23:28:31.376786500 +0100 @@ -1,6 +1,6 @@ Metadata-Version: 2.4 Name: acme -Version: 5.8.0 +Version: 5.10.0 Summary: ACME protocol implementation in Python Author: Certbot Project License-Expression: Apache-2.0 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/acme-5.8.0/setup.py new/acme-5.10.0/setup.py --- old/acme-5.8.0/setup.py 2026-09-01 19:52:19.687980200 +0200 +++ new/acme-5.10.0/setup.py 2026-11-10 23:28:28.038778000 +0100 @@ -1,6 +1,6 @@ from setuptools import setup -version = '5.8.0' +version = '5.10.0' setup( version=version, diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/acme-5.8.0/src/acme/__init__.py new/acme-5.10.0/src/acme/__init__.py --- old/acme-5.8.0/src/acme/__init__.py 2026-09-01 19:52:18.777984400 +0200 +++ new/acme-5.10.0/src/acme/__init__.py 2026-11-10 23:28:27.536776800 +0100 @@ -6,6 +6,7 @@ """ import sys +import warnings # This code exists to keep backwards compatibility with people using acme.jose # before it became the standalone josepy package. @@ -19,3 +20,10 @@ # preserved (acme.jose.* is josepy.*) if mod == 'josepy' or mod.startswith('josepy.'): sys.modules['acme.' + mod.replace('josepy', 'jose', 1)] = sys.modules[mod] + +if sys.version_info[:2] == (3, 10): + warnings.warn( + "Python 3.10 support will be dropped in the next release " + "of acme. Please upgrade your Python version.", + DeprecationWarning + ) # pragma: no cover diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/acme-5.8.0/src/acme/_internal/tests/client_test.py new/acme-5.10.0/src/acme/_internal/tests/client_test.py --- old/acme-5.8.0/src/acme/_internal/tests/client_test.py 2026-09-01 19:52:18.778493000 +0200 +++ new/acme-5.10.0/src/acme/_internal/tests/client_test.py 2026-11-10 23:28:27.536776800 +0100 @@ -517,7 +517,7 @@ self.response.json.return_value = { "suggestedWindow": { "start": "2025-03-14T01:01:01Z", - "end": "2025-03-14T01:01:01Z", + "end": "2025-03-15T01:01:01Z", }, "message": "Keep those certs fresh" } @@ -527,7 +527,8 @@ self.net.get.assert_called_once_with("https://www.letsencrypt-demo.org/acme/renewal-info/" + ari_path_component, content_type='application/json') - assert t == datetime.datetime(2025, 3, 14, 1, 1, 1, tzinfo=datetime.timezone.utc) + assert t >= datetime.datetime(2025, 3, 14, 1, 1, 1, tzinfo=datetime.timezone.utc) + assert t <= datetime.datetime(2025, 3, 15, 1, 1, 1, tzinfo=datetime.timezone.utc) self.net.reset_mock() @@ -545,6 +546,41 @@ assert t >= datetime.datetime(2025, 3, 16, 1, 1, 1, tzinfo=datetime.timezone.utc) assert t <= datetime.datetime(2025, 3, 17, 1, 1, 1, tzinfo=datetime.timezone.utc) + @mock.patch('acme.client.random.uniform') + @mock.patch('acme.client.datetime') + def test_renewal_time_invalid_window(self, dt_mock, mock_uniform): + def now(tzinfo=None): + return datetime.datetime(2025, 3, 15, tzinfo=tzinfo) + dt_mock.datetime.now.side_effect = now + dt_mock.timedelta = datetime.timedelta + dt_mock.timezone = datetime.timezone + + cert_pem = make_cert_for_renewal( + not_before=datetime.datetime(2025, 3, 12), + not_after=datetime.datetime(2025, 3, 30), + ) + self.client.directory = messages.Directory({ + 'renewalInfo': 'https://www.letsencrypt-demo.org/acme/renewal-info', + }) + self.response.headers['Retry-After'] = '100' + windows = [ + ('2025-03-14T00:00:00Z', '2025-03-14T00:00:00Z'), + ('2025-03-14T00:00:00Z', '2025-03-13T00:00:00Z'), + ('2025-03-17T00:00:00Z', '2025-03-17T00:00:00Z'), + ('2025-03-17T00:00:00Z', '2025-03-16T00:00:00Z'), + ('2025-03-14T01:00:00+01:00', '2025-03-14T00:00:00Z'), + ('2025-03-14T00:00:00Z', '2025-03-14T00:30:00+01:00'), + ] + for start, end in windows: + with self.subTest(start=start, end=end): + self.response.json.return_value = { + 'suggestedWindow': {'start': start, 'end': end}, + } + with pytest.raises(errors.ARIError) as exception_info: + self.client.renewal_time(cert_pem) + assert exception_info.value.retry_after == now() + datetime.timedelta(hours=6) + mock_uniform.assert_not_called() + @mock.patch('acme.client.datetime') def test_renewal_time_renewal_info_errors(self, dt_mock): def now(tzinfo=None): @@ -598,7 +634,7 @@ self.response.json.return_value = { "suggestedWindow": { "start": "2025-03-14T01:01:01Z", - "end": "2025-03-14T01:01:01Z", + "end": "2025-03-15T01:01:01Z", }, "message": "Keep those certs fresh" } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/acme-5.8.0/src/acme/client.py new/acme-5.10.0/src/acme/client.py --- old/acme-5.8.0/src/acme/client.py 2026-09-01 19:52:18.781589300 +0200 +++ new/acme-5.10.0/src/acme/client.py 2026-11-10 23:28:27.538776600 +0100 @@ -328,9 +328,10 @@ :returns: Tuple of time to attempt renewal, next time to ask for renewal info :raises errors.ARIError: If an error occurs fetching ARI from the - server. Explicit exception chaining is used so the original error - can be accessed through the __cause__ attribute on the ARIError if - desired. + server or the returned suggested renewal window is invalid + (its end time is not after its start time). Fetch errors use + explicit exception chaining so the original error can be + accessed through the __cause__ attribute if desired. """ now = datetime.datetime.now() @@ -363,6 +364,10 @@ start = renewal_info.suggested_window.start # pylint: disable=no-member end = renewal_info.suggested_window.end # pylint: disable=no-member + if end <= start: + raise errors.ARIError('suggestedWindow end must be after start', + now + default_retry_after) + delta_seconds = (end - start).total_seconds() random_seconds = random.uniform(0, delta_seconds) random_time = start + datetime.timedelta(seconds=random_seconds) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/acme-5.8.0/src/acme/jws.py new/acme-5.10.0/src/acme/jws.py --- old/acme-5.8.0/src/acme/jws.py 2026-09-01 19:52:18.782086100 +0200 +++ new/acme-5.10.0/src/acme/jws.py 2026-11-10 23:28:27.539776800 +0100 @@ -12,9 +12,9 @@ class Header(jose.Header): """ACME-specific JOSE Header. Implements nonce, kid, and url. """ - nonce: Optional[bytes] = jose.field('nonce', omitempty=True, encoder=jose.encode_b64jose) - kid: Optional[str] = jose.field('kid', omitempty=True) - url: Optional[str] = jose.field('url', omitempty=True) + nonce: bytes | None = jose.field('nonce', omitempty=True, encoder=jose.encode_b64jose) + kid: str | None = jose.field('kid', omitempty=True) + url: str | None = jose.field('url', omitempty=True) # Mypy does not understand the josepy magic happening here, and falsely claims # that nonce is redefined. Let's ignore the type check here. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/acme-5.8.0/src/acme/messages.py new/acme-5.10.0/src/acme/messages.py --- old/acme-5.8.0/src/acme/messages.py 2026-09-01 19:52:18.782173400 +0200 +++ new/acme-5.10.0/src/acme/messages.py 2026-11-10 23:28:27.539776800 +0100 @@ -6,7 +6,6 @@ from typing import Iterator from typing import Mapping from typing import MutableMapping -from typing import Optional from typing import TypeVar from cryptography import x509 @@ -132,11 +131,11 @@ """ typ: str = jose.field('type', omitempty=True, default='about:blank') - title: str = jose.field('title', omitempty=True) - detail: str = jose.field('detail', omitempty=True) - identifier: Optional['Identifier'] = jose.field( + title: str | None = jose.field('title', omitempty=True) + detail: str | None = jose.field('detail', omitempty=True) + identifier: Identifier | None = jose.field( 'identifier', decoder=Identifier.from_json, omitempty=True) - subproblems: Optional[tuple['Error', ...]] = jose.field('subproblems', omitempty=True) + subproblems: tuple['Error', ...] | None = jose.field('subproblems', omitempty=True) # Mypy does not understand the josepy magic happening here, and falsely claims # that subproblems is redefined. Let's ignore the type check here. @@ -161,7 +160,7 @@ return cls(typ=typ, **kwargs) @property - def description(self) -> Optional[str]: + def description(self) -> str | None: """Hardcoded error description based on its type. :returns: Description if standard ACME error or ``None``. @@ -171,7 +170,7 @@ return ERROR_TYPE_DESCRIPTIONS.get(self.typ) @property - def code(self) -> Optional[str]: + def code(self) -> str | None: """ACME error code. Basically self.typ without the ERROR_PREFIX. @@ -225,18 +224,19 @@ class Meta(jose.JSONObjectWithFields): """Directory Meta.""" - _terms_of_service: str = jose.field('termsOfService', omitempty=True) - website: str = jose.field('website', omitempty=True) - caa_identities: list[str] = jose.field('caaIdentities', omitempty=True) - external_account_required: bool = jose.field('externalAccountRequired', omitempty=True) - profiles: dict[str, str] = jose.field('profiles', omitempty=True) + _terms_of_service: str | None = jose.field('termsOfService', omitempty=True) + website: str | None = jose.field('website', omitempty=True) + caa_identities: tuple[str, ...] | None = jose.field('caaIdentities', omitempty=True) + external_account_required: bool | None = jose.field('externalAccountRequired', + omitempty=True) + profiles: dict[str, str] | None = jose.field('profiles', omitempty=True) def __init__(self, **kwargs: Any) -> None: kwargs = {self._internal_name(k): v for k, v in kwargs.items()} super().__init__(**kwargs) @property - def terms_of_service(self) -> str: + def terms_of_service(self) -> str | None: """URL for the CA TOS""" return self._terms_of_service @@ -344,20 +344,20 @@ # contacts while not expecting the `contact` field when loading from json. # This is implemented in the constructor and *_json methods. contact: tuple[str, ...] = jose.field('contact', omitempty=True, default=()) - agreement: str = jose.field('agreement', omitempty=True) - status: Status = jose.field('status', omitempty=True) - terms_of_service_agreed: bool = jose.field('termsOfServiceAgreed', omitempty=True) - only_return_existing: bool = jose.field('onlyReturnExisting', omitempty=True) - external_account_binding: dict[str, Any] = jose.field('externalAccountBinding', + agreement: str | None = jose.field('agreement', omitempty=True) + status: Status | None = jose.field('status', omitempty=True) + terms_of_service_agreed: bool | None = jose.field('termsOfServiceAgreed', omitempty=True) + only_return_existing: bool | None = jose.field('onlyReturnExisting', omitempty=True) + external_account_binding: dict[str, Any] | None = jose.field('externalAccountBinding', omitempty=True) phone_prefix = 'tel:' email_prefix = 'mailto:' @classmethod - def from_data(cls: type[GenericRegistration], phone: Optional[str] = None, - email: Optional[str] = None, - external_account_binding: Optional[dict[str, Any]] = None, + def from_data(cls: type[GenericRegistration], phone: str | None = None, + email: str | None = None, + external_account_binding: dict[str, Any] | None = None, **kwargs: Any) -> GenericRegistration: """ Create registration resource from contact details. @@ -483,8 +483,8 @@ _url: str = jose.field('url', omitempty=True, default=None) status: Status = jose.field('status', decoder=Status.from_json, omitempty=True, default=STATUS_PENDING) - validated: datetime.datetime = fields.rfc3339('validated', omitempty=True) - error: Error = jose.field('error', decoder=Error.from_json, + validated: datetime.datetime | None = fields.rfc3339('validated', omitempty=True) + error: Error | None = jose.field('error', decoder=Error.from_json, omitempty=True, default=None) def __init__(self, **kwargs: Any) -> None: @@ -556,8 +556,8 @@ # general, but for Key Authorization '[t]he "expires" field MUST # be absent'... then acme-spec gives example with 'expires' # present... That's confusing! - expires: datetime.datetime = fields.rfc3339('expires', omitempty=True) - wildcard: bool = jose.field('wildcard', omitempty=True) + expires: datetime.datetime | None = fields.rfc3339('expires', omitempty=True) + wildcard: bool | None = jose.field('wildcard', omitempty=True) # Mypy does not understand the josepy magic happening here, and falsely claims # that challenge is redefined. Let's ignore the type check here. @@ -635,14 +635,14 @@ :ivar ~.Error error: Any error that occurred during finalization, if applicable. """ # https://datatracker.ietf.org/doc/draft-aaron-acme-profiles/ - profile: str = jose.field('profile', omitempty=True) + profile: str | None = jose.field('profile', omitempty=True) identifiers: list[Identifier] = jose.field('identifiers', omitempty=True) status: Status = jose.field('status', decoder=Status.from_json, omitempty=True) authorizations: list[str] = jose.field('authorizations', omitempty=True) - certificate: str = jose.field('certificate', omitempty=True) + certificate: str | None = jose.field('certificate', omitempty=True) finalize: str = jose.field('finalize', omitempty=True) - expires: datetime.datetime = fields.rfc3339('expires', omitempty=True) - error: Error = jose.field('error', omitempty=True, decoder=Error.from_json) + expires: datetime.datetime | None = fields.rfc3339('expires', omitempty=True) + error: Error | None = jose.field('error', omitempty=True, decoder=Error.from_json) # Mypy does not understand the josepy magic happening here, and falsely claims # that identifiers is redefined. Let's ignore the type check here. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/acme-5.8.0/src/acme.egg-info/PKG-INFO new/acme-5.10.0/src/acme.egg-info/PKG-INFO --- old/acme-5.8.0/src/acme.egg-info/PKG-INFO 2026-09-01 19:52:22.340264600 +0200 +++ new/acme-5.10.0/src/acme.egg-info/PKG-INFO 2026-11-10 23:28:31.352786500 +0100 @@ -1,6 +1,6 @@ Metadata-Version: 2.4 Name: acme -Version: 5.8.0 +Version: 5.10.0 Summary: ACME protocol implementation in Python Author: Certbot Project License-Expression: Apache-2.0
