Script 'mail_helper' called by obssrc
Hello community,

here is the log from the commit of package apache2-mod_authn_otp for 
openSUSE:Factory checked in at 2026-11-19 16:55:39
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/apache2-mod_authn_otp (Old)
 and      /work/SRC/openSUSE:Factory/.apache2-mod_authn_otp.new.1251 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "apache2-mod_authn_otp"

Thu Nov 19 16:55:39 2026 rev:16 rq:1398592 version:1.1.13

Changes:
--------
--- 
/work/SRC/openSUSE:Factory/apache2-mod_authn_otp/apache2-mod_authn_otp.changes  
    2025-08-02 00:43:08.946015390 +0200
+++ 
/work/SRC/openSUSE:Factory/.apache2-mod_authn_otp.new.1251/apache2-mod_authn_otp.changes
    2026-11-19 16:56:36.537582504 +0100
@@ -1,0 +2,8 @@
+Tue Nov 17 21:23:52 UTC 2026 - Archie Cobbs <[email protected]>
+
+- Update to version 1.1.13
+  + Added "OTPAuthUsersFileGroupReadable" configuration setting (issue #56)
+  + Allow some configuration directives in server and virtual host contexts 
(issue #56)
+  + Fix OpenSSL-related build issue on certain non-standard systems (issue #59)
+
+-------------------------------------------------------------------

Old:
----
  mod_authn_otp-1.1.12.tar.gz

New:
----
  mod_authn_otp-1.1.13.tar.gz

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ apache2-mod_authn_otp.spec ++++++
--- /var/tmp/diff_new_pack.Ezgfca/_old  2026-11-19 16:56:37.392618747 +0100
+++ /var/tmp/diff_new_pack.Ezgfca/_new  2026-11-19 16:56:37.394618832 +0100
@@ -1,7 +1,7 @@
 #
 # spec file for package apache2-mod_authn_otp
 #
-# Copyright (c) 2025 SUSE LLC
+# Copyright (c) 2026 SUSE LLC and contributors
 # Copyright (c) 2012 Archie L. Cobbs <[email protected]>
 #
 # All modifications and additions to the file contributed by third parties
@@ -19,7 +19,7 @@
 
 %define mod_name           mod_authn_otp
 Name:           apache2-%{mod_name}
-Version:        1.1.12
+Version:        1.1.13
 Release:        0
 Summary:        Apache module for one-time password authentication
 License:        Apache-2.0

++++++ mod_authn_otp-1.1.12.tar.gz -> mod_authn_otp-1.1.13.tar.gz ++++++
++++ 9018 lines of diff (skipped)
++++    retrying with extended exclude list
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude 
config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 
--exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh 
old/mod_authn_otp-1.1.12/CHANGES new/mod_authn_otp-1.1.13/CHANGES
--- old/mod_authn_otp-1.1.12/CHANGES    2025-07-26 18:22:17.000000000 +0200
+++ new/mod_authn_otp-1.1.13/CHANGES    2026-11-17 22:13:33.000000000 +0100
@@ -1,3 +1,9 @@
+Version 1.1.13 released November 17, 2026
+
+    - Added "OTPAuthUsersFileGroupReadable" configuration setting (issue #56)
+    - Allow some configuration directives in server and virtual host contexts 
(issue #56)
+    - Fix OpenSSL-related build issue on certain non-standard systems (issue 
#59)
+
 Version 1.1.12 released July 26, 2025
 
     - Added "OTPAuthMaxIdle" as an alternative to "OTPAuthMaxLinger" (issue 
#51).
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude 
config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 
--exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh 
old/mod_authn_otp-1.1.12/Makefile.am new/mod_authn_otp-1.1.13/Makefile.am
--- old/mod_authn_otp-1.1.12/Makefile.am        2024-06-29 23:07:56.000000000 
+0200
+++ new/mod_authn_otp-1.1.13/Makefile.am        2026-11-12 17:16:24.000000000 
+0100
@@ -21,7 +21,7 @@
 
 module: mod_authn_otp.c
                if test "$(srcdir)" != "."; then $(CP) 
$(srcdir)/mod_authn_otp.c .; fi
-               $(APXS) -c -D_REENTRANT `echo $(GCC_WARN_FLAGS) | sed 's/ -/ 
-Wc,-/g'` -l crypto mod_authn_otp.c hotp.c motp.c phex.c md5q.c
+               $(APXS) -c -D_REENTRANT $(OPENSSL_CFLAGS) `echo 
$(GCC_WARN_FLAGS) | sed 's/ -/ -Wc,-/g'` $(OPENSSL_LIBS) mod_authn_otp.c hotp.c 
motp.c phex.c md5q.c
 
 install-exec-local: module
                mkdir -p "$(DESTDIR)`$(APXS) -q LIBEXECDIR`"
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude 
config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 
--exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh 
old/mod_authn_otp-1.1.12/config.h.in new/mod_authn_otp-1.1.13/config.h.in
--- old/mod_authn_otp-1.1.12/config.h.in        2025-07-26 18:27:39.000000000 
+0200
+++ new/mod_authn_otp-1.1.13/config.h.in        2026-11-17 22:17:27.000000000 
+0100
@@ -12,9 +12,6 @@
 /* Define to 1 if you have the <inttypes.h> header file. */
 #undef HAVE_INTTYPES_H
 
-/* Define to 1 if you have the <memory.h> header file. */
-#undef HAVE_MEMORY_H
-
 /* Define to 1 if you have the <openssl/evp.h> header file. */
 #undef HAVE_OPENSSL_EVP_H
 
@@ -39,7 +36,7 @@
 /* Define to 1 if you have the <string.h> header file. */
 #undef HAVE_STRING_H
 
-/* Define to 1 if you have the `strptime' function. */
+/* Define to 1 if you have the 'strptime' function. */
 #undef HAVE_STRPTIME
 
 /* Define to 1 if you have the <sys/stat.h> header file. */
@@ -75,7 +72,9 @@
 /* Define to the version of this package. */
 #undef PACKAGE_VERSION
 
-/* Define to 1 if you have the ANSI C header files. */
+/* Define to 1 if all of the C89 standard headers exist (not just the ones
+   required in a freestanding environment). This macro is provided for
+   backward compatibility; new code need not use it. */
 #undef STDC_HEADERS
 
 /* Version number of package */
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude 
config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 
--exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh 
old/mod_authn_otp-1.1.12/configure.ac new/mod_authn_otp-1.1.13/configure.ac
--- old/mod_authn_otp-1.1.12/configure.ac       2025-07-26 18:25:42.000000000 
+0200
+++ new/mod_authn_otp-1.1.13/configure.ac       2026-11-17 22:13:51.000000000 
+0100
@@ -17,7 +17,7 @@
 # limitations under the License.
 #
 
-AC_INIT([mod_authn_otp Apache2 authentication module supporting one-time 
passwords], [1.1.12], [https://github.com/archiecobbs/mod-authn-otp], 
[mod_authn_otp])
+AC_INIT([mod_authn_otp Apache2 authentication module supporting one-time 
passwords], [1.1.13], [https://github.com/archiecobbs/mod-authn-otp], 
[mod_authn_otp])
 AC_CONFIG_AUX_DIR(scripts)
 AM_INIT_AUTOMAKE
 dnl AM_MAINTAINER_MODE
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude 
config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 
--exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh 
old/mod_authn_otp-1.1.12/mod_authn_otp.c 
new/mod_authn_otp-1.1.13/mod_authn_otp.c
--- old/mod_authn_otp-1.1.12/mod_authn_otp.c    2025-07-23 17:48:14.000000000 
+0200
+++ new/mod_authn_otp-1.1.13/mod_authn_otp.c    2026-11-12 17:12:08.000000000 
+0100
@@ -84,9 +84,11 @@
 #define DEFAULT_NUM_DIGITS              6
 #define DEFAULT_MAX_OFFSET              4
 #define DEFAULT_MAX_LINGER              (10 * 60)   /* 10 minutes (but only if 
max_idle is not set) */
+#define DEFAULT_MAX_OTP_FAILURES        0           /* unlimited */
 #define DEFAULT_LOGOUT_IP_CHANGE        0
 #define DEFAULT_ALLOW_FALLTHROUGH       0
 #define DEFAULT_PIN_FAKE_BASIC_AUTH     0
+#define DEFAULT_USERS_GROUP_READABLE    0
 
 /* PIN configuration */
 #define PIN_CONFIG_LITERAL              0
@@ -117,10 +119,12 @@
 /* Per-directory configuration */
 struct otp_config {
     char                *users_file;            /* Name of the users file */
+    apr_fileperms_t     users_mode;             /* File mode to use when 
writing new users file */
+    int                 users_group_readable;   /* The configuration setting 
that controls "users_mode" */
     int                 max_offset;             /* Maximum allowed counter 
offset from expected value */
     int                 max_linger;             /* Maximum time for which the 
same OTP can be used repeatedly */
     int                 max_idle;               /* Maximum time for which the 
same OTP can remain unused and continue to work */
-    u_int               max_otp_failures;       /* Maximum wrong OTP values 
before account becomes locked, or zero for no limit */
+    int                 max_otp_failures;       /* Maximum wrong OTP values 
before account becomes locked, or zero for no limit */
     int                 logout_ip_change;       /* Auto-logout user if IP 
address changes */
     int                 allow_fallthrough;      /* Allow fall-through if OTP 
auth fails */
     authn_provider_list *provlist;              /* Authorization providers for 
checking PINs */
@@ -145,7 +149,7 @@
 };
 
 /* Internal functions */
-static authn_status find_update_user(request_rec *r, const char *usersfile, 
struct otp_user *const user, int update);
+static authn_status find_update_user(request_rec *r, const struct otp_config 
*conf, struct otp_user *const user, int update);
 static int          parse_token_type(const char *type, struct otp_user 
*tokinfo);
 static apr_status_t print_user(apr_file_t *file, const struct otp_user *user);
 static void         pin_fake_basic_auth(request_rec *r, const char *user, 
const char *pin);
@@ -173,7 +177,7 @@
  * Note: finding, the "user" structure must be initialized with zeroes.
  */
 static authn_status
-find_update_user(request_rec *r, const char *usersfile, struct otp_user *const 
user, const int update)
+find_update_user(request_rec *r, const struct otp_config *const conf, struct 
otp_user *const user, const int update)
 {
     char invalid_reason[128];
     char newusersfile[APR_PATH_MAX];
@@ -190,9 +194,9 @@
 
     /* If updating, open and lock lockfile and grab mutex */
     if (update) {
-        apr_snprintf(lockusersfile, sizeof(lockusersfile), "%s%s", usersfile, 
LOCKFILE_SUFFIX);
+        apr_snprintf(lockusersfile, sizeof(lockusersfile), "%s%s", 
conf->users_file, LOCKFILE_SUFFIX);
         if ((status = apr_file_open(&lockfile, lockusersfile,
-          APR_WRITE|APR_CREATE|APR_TRUNCATE, APR_UREAD|APR_UWRITE, r->pool)) 
!= 0) {
+          APR_WRITE|APR_CREATE|APR_TRUNCATE, conf->users_mode, r->pool)) != 0) 
{
             ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r, "can't open OTP users 
lock file \"%s\": %s",
               lockusersfile, apr_strerror(status, errbuf, sizeof(errbuf)));
             goto fail;
@@ -214,17 +218,17 @@
     }
 
     /* Open existing users file */
-    if ((status = apr_file_open(&file, usersfile, APR_READ, 0, r->pool)) != 0) 
{
+    if ((status = apr_file_open(&file, conf->users_file, APR_READ, 0, 
r->pool)) != 0) {
         ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r, "can't open OTP users file 
\"%s\": %s",
-          usersfile, apr_strerror(status, errbuf, sizeof(errbuf)));
+          conf->users_file, apr_strerror(status, errbuf, sizeof(errbuf)));
         goto fail;
     }
 
     /* Open new users file if updating */
     if (update) {
-        apr_snprintf(newusersfile, sizeof(newusersfile), "%s%s", usersfile, 
NEWFILE_SUFFIX);
+        apr_snprintf(newusersfile, sizeof(newusersfile), "%s%s", 
conf->users_file, NEWFILE_SUFFIX);
         if ((status = apr_file_open(&newfile, newusersfile,
-          APR_WRITE|APR_CREATE|APR_TRUNCATE, APR_UREAD|APR_UWRITE, r->pool)) 
!= 0) {
+          APR_WRITE|APR_CREATE|APR_TRUNCATE, conf->users_mode, r->pool)) != 0) 
{
             ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r, "can't new open OTP 
users file \"%s\": %s", newusersfile,
               apr_strerror(status, errbuf, sizeof(errbuf)));
             goto fail;
@@ -401,7 +405,7 @@
 invalid:
         /* Report invalid entry (but copy it anyway) */
         ap_log_rerror(APLOG_MARK, APLOG_WARNING, 0, r, "ignoring invalid entry 
in OTP users file \"%s\" on line %d: %s",
-          usersfile, linenum, invalid_reason);
+          conf->users_file, linenum, invalid_reason);
 
 copy:
         /* Copy line to new file */
@@ -417,7 +421,8 @@
 
     /* If we're not updating and we get here, then the user was not found */
     if (!update) {
-        ap_log_rerror(APLOG_MARK, APLOG_NOTICE, 0, r, "user \"%s\" not found 
in OTP users file \"%s\"", user->username, usersfile);
+        ap_log_rerror(APLOG_MARK, APLOG_NOTICE, 0, r, "user \"%s\" not found 
in OTP users file \"%s\"",
+          user->username, conf->users_file);
         return AUTH_USER_NOT_FOUND;
     }
 
@@ -430,9 +435,9 @@
     newfile = NULL;
 
     /* Replace old file with new one */
-    if ((status = apr_file_rename(newusersfile, usersfile, r->pool)) != 0) {
+    if ((status = apr_file_rename(newusersfile, conf->users_file, r->pool)) != 
0) {
         ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r, "error renaming new OTP 
users file \"%s\" to \"%s\": %s",
-          newusersfile, usersfile, apr_strerror(status, errbuf, 
sizeof(errbuf)));
+          newusersfile, conf->users_file, apr_strerror(status, errbuf, 
sizeof(errbuf)));
         goto fail;
     }
 
@@ -720,12 +725,12 @@
     /* Lookup user in the users file */
     memset(user, 0, sizeof(*user));
     apr_snprintf(user->username, sizeof(user->username), "%s", username);
-    if ((status = find_update_user(r, conf->users_file, user, 0)) != 
AUTH_USER_FOUND)
+    if ((status = find_update_user(r, conf, user, 0)) != AUTH_USER_FOUND)
         return status;
 
     /* Check for max failures */
     if (conf->max_otp_failures != 0 && user->num_otp_failures >= 
conf->max_otp_failures) {
-        ap_log_rerror(APLOG_MARK, APLOG_NOTICE, 0, r, "user \"%s\" has reached 
the maximum wrong OTP limit of %u",
+        ap_log_rerror(APLOG_MARK, APLOG_NOTICE, 0, r, "user \"%s\" has reached 
the maximum wrong OTP limit of %d",
           user->username, conf->max_otp_failures);
         return conf->allow_fallthrough ? AUTH_USER_NOT_FOUND : AUTH_DENIED;
     }
@@ -736,7 +741,7 @@
 
         /* Forget previous OTP */
         *user->last_otp = '\0';
-        find_update_user(r, conf->users_file, user, 1);
+        find_update_user(r, conf, user, 1);
         return conf->allow_fallthrough ? AUTH_USER_NOT_FOUND : AUTH_DENIED;
     }
 
@@ -862,10 +867,10 @@
 
     /* Report failure to the log */
     if (conf->max_otp_failures != 0) {
-        ap_log_rerror(APLOG_MARK, APLOG_NOTICE, 0, r, "user \"%s\" provided 
the wrong OTP (%d/%d consecutive)",
+        ap_log_rerror(APLOG_MARK, APLOG_NOTICE, 0, r, "user \"%s\" provided 
the wrong OTP (%u/%d consecutive)",
           user->username, user->num_otp_failures + 1, conf->max_otp_failures);
     } else {
-        ap_log_rerror(APLOG_MARK, APLOG_NOTICE, 0, r, "user \"%s\" provided 
the wrong OTP (%d consecutive)",
+        ap_log_rerror(APLOG_MARK, APLOG_NOTICE, 0, r, "user \"%s\" provided 
the wrong OTP (%u consecutive)",
           user->username, user->num_otp_failures + 1);
     }
     goto fail;
@@ -882,7 +887,7 @@
     apr_snprintf(user->last_ip, sizeof(user->last_ip), "%s", USER_AGENT_IP(r));
 
     /* Update user's record */
-    find_update_user(r, conf->users_file, user, 1);
+    find_update_user(r, conf, user, 1);
 
     /* Done */
     return AUTH_GRANTED;
@@ -891,7 +896,7 @@
     /* Update user's failure count */
     if (user->num_otp_failures < UINT_MAX) {
         user->num_otp_failures++;
-        find_update_user(r, conf->users_file, user, 1);
+        find_update_user(r, conf, user, 1);
     }
     return AUTH_DENIED;
 }
@@ -923,12 +928,12 @@
     /* Lookup the user in the users file */
     memset(user, 0, sizeof(*user));
     apr_snprintf(user->username, sizeof(user->username), "%s", username);
-    if ((status = find_update_user(r, conf->users_file, user, 0)) != 
AUTH_USER_FOUND)
+    if ((status = find_update_user(r, conf, user, 0)) != AUTH_USER_FOUND)
         return status;
 
     /* Check for max failures */
     if (conf->max_otp_failures != 0 && user->num_otp_failures >= 
conf->max_otp_failures) {
-        ap_log_rerror(APLOG_MARK, APLOG_NOTICE, 0, r, "user \"%s\" has reached 
the maximum wrong OTP limit of %u",
+        ap_log_rerror(APLOG_MARK, APLOG_NOTICE, 0, r, "user \"%s\" has reached 
the maximum wrong OTP limit of %d",
           user->username, conf->max_otp_failures);
         return conf->allow_fallthrough ? AUTH_USER_NOT_FOUND : AUTH_DENIED;
     }
@@ -1000,7 +1005,7 @@
             user->offset = counter + 1;
         apr_snprintf(user->last_otp, sizeof(user->last_otp), "%s", otpbuf);
         user->last_auth = now;
-        find_update_user(r, conf->users_file, user, 1);
+        find_update_user(r, conf, user, 1);
     }
 
     /* Done */
@@ -1029,6 +1034,7 @@
     conf = apr_pcalloc(r->pool, sizeof(*conf));
     if (dir_conf->users_file != NULL)
         conf->users_file = apr_pstrdup(r->pool, dir_conf->users_file);
+    conf->users_group_readable = dir_conf->users_group_readable;
     conf->max_offset = dir_conf->max_offset;
     conf->max_linger = dir_conf->max_linger;
     conf->max_idle = dir_conf->max_idle;
@@ -1039,10 +1045,14 @@
     conf->pin_fake_basic_auth = dir_conf->pin_fake_basic_auth;
 
     /* Apply defaults for any unset values */
+    if (conf->users_group_readable == -1)
+        conf->users_group_readable = DEFAULT_USERS_GROUP_READABLE;
     if (conf->max_offset == -1)
         conf->max_offset = DEFAULT_MAX_OFFSET;
     if (conf->max_linger == -1 && conf->max_idle == -1)
         conf->max_linger = DEFAULT_MAX_LINGER;
+    if (conf->max_otp_failures == -1)
+        conf->max_otp_failures = DEFAULT_MAX_OTP_FAILURES;
     if (conf->logout_ip_change == -1)
         conf->logout_ip_change = DEFAULT_LOGOUT_IP_CHANGE;
     if (conf->allow_fallthrough == -1)
@@ -1050,6 +1060,11 @@
     if (conf->pin_fake_basic_auth == -1)
         conf->pin_fake_basic_auth = DEFAULT_PIN_FAKE_BASIC_AUTH;
 
+    /* Derive "users_mode" from "users_group_readable" */
+    conf->users_mode = (APR_UREAD | APR_UWRITE);
+    if (conf->users_group_readable)
+        conf->users_mode |= (APR_GREAD | APR_GWRITE);
+
     /* Validate config */
     if (conf->users_file == NULL) {
         ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r, "No %s has been 
configured", "OTPAuthUsersFile");
@@ -1078,7 +1093,7 @@
             return NULL;
         }
     }
-    if (conf->max_otp_failures != -1 && conf->max_otp_failures < 0) {
+    if (conf->max_otp_failures < 0) {
         ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r, "Invalid negative value for 
%s", "OTPAuthMaxOTPFailure");
         return NULL;
     }
@@ -1096,10 +1111,12 @@
     struct otp_config *conf = apr_pcalloc(p, sizeof(struct otp_config));
 
     conf->users_file = NULL;
+    conf->users_group_readable = -1;
+    conf->users_mode = 0;               // just to be safe
     conf->max_offset = -1;
     conf->max_linger = -1;
     conf->max_idle = -1;
-    conf->max_otp_failures = 0;
+    conf->max_otp_failures = -1;
     conf->logout_ip_change = -1;
     conf->allow_fallthrough = -1;
     conf->provlist = NULL;
@@ -1118,10 +1135,11 @@
         conf->users_file = apr_pstrdup(p, conf2->users_file);
     else if (conf1->users_file != NULL)
         conf->users_file = apr_pstrdup(p, conf1->users_file);
+    conf->users_group_readable = conf2->users_group_readable != -1 ? 
conf2->users_group_readable : conf1->users_group_readable;
     conf->max_offset = conf2->max_offset != -1 ? conf2->max_offset : 
conf1->max_offset;
     conf->max_linger = conf2->max_linger != -1 ? conf2->max_linger : 
conf1->max_linger;
     conf->max_idle = conf2->max_idle != -1 ? conf2->max_idle : conf1->max_idle;
-    conf->max_otp_failures = conf2->max_otp_failures != 0 ? 
conf2->max_otp_failures : conf1->max_otp_failures;
+    conf->max_otp_failures = conf2->max_otp_failures != -1 ? 
conf2->max_otp_failures : conf1->max_otp_failures;
     conf->logout_ip_change = conf2->logout_ip_change != -1 ? 
conf2->logout_ip_change : conf1->logout_ip_change;
     conf->allow_fallthrough = conf2->allow_fallthrough != -1 ? 
conf2->allow_fallthrough : conf1->allow_fallthrough;
     copy_provider_list(p, &conf->provlist, conf2->provlist != NULL ? 
conf2->provlist : conf1->provlist);
@@ -1193,7 +1211,6 @@
 static void
 register_hooks(apr_pool_t *p)
 {
-    ap_register_provider(p, AUTHN_PROVIDER_GROUP, OTP_AUTHN_PROVIDER_NAME, 
AUTHN_PROVIDER_VERSION, &authn_otp_provider);
     apr_status_t status;
     char errbuf[64];
 
@@ -1202,6 +1219,9 @@
         ap_log_perror(APLOG_MARK, APLOG_ERR, 0, p, "can't create OTP mutex: 
%s", apr_strerror(status, errbuf, sizeof(errbuf)));
         return;
     }
+
+    /* Register authorization provider */
+    ap_register_provider(p, AUTHN_PROVIDER_GROUP, OTP_AUTHN_PROVIDER_NAME, 
AUTHN_PROVIDER_VERSION, &authn_otp_provider);
 }
 
 /* Configuration directives */
@@ -1212,30 +1232,35 @@
         (void *)APR_OFFSETOF(struct otp_config, users_file),
         OR_AUTHCFG,
         "pathname of the one-time password users file"),
+    AP_INIT_FLAG("OTPAuthUsersFileGroupReadable",
+        ap_set_flag_slot,
+        (void *)APR_OFFSETOF(struct otp_config, users_group_readable),
+        RSRC_CONF | OR_AUTHCFG,
+        "set file mode to allow group access when writing the users file"),
     AP_INIT_TAKE1("OTPAuthMaxOffset",
         ap_set_int_slot,
         (void *)APR_OFFSETOF(struct otp_config, max_offset),
-        OR_AUTHCFG,
+        RSRC_CONF | OR_AUTHCFG,
         "maximum allowed offset from expected event or time counter value"),
     AP_INIT_TAKE1("OTPAuthMaxLinger",
         ap_set_int_slot,
         (void *)APR_OFFSETOF(struct otp_config, max_linger),
-        OR_AUTHCFG,
+        RSRC_CONF | OR_AUTHCFG,
         "maximum time (in seconds) for which a one-time password can be 
repeatedly used"),
     AP_INIT_TAKE1("OTPAuthMaxIdle",
         ap_set_int_slot,
         (void *)APR_OFFSETOF(struct otp_config, max_idle),
-        OR_AUTHCFG,
+        RSRC_CONF | OR_AUTHCFG,
         "maximum time (in seconds) between requests before a one-time password 
can no longer be used"),
     AP_INIT_TAKE1("OTPAuthMaxOTPFailure",
         ap_set_int_slot,
         (void *)APR_OFFSETOF(struct otp_config, max_otp_failures),
-        OR_AUTHCFG,
+        RSRC_CONF | OR_AUTHCFG,
         "maximum number of consecutive wrong OTP values before account becomes 
locked"),
     AP_INIT_FLAG("OTPAuthLogoutOnIPChange",
         ap_set_flag_slot,
         (void *)APR_OFFSETOF(struct otp_config, logout_ip_change),
-        OR_AUTHCFG,
+        RSRC_CONF | OR_AUTHCFG,
         "enable automatic logout of user if the user's IP address changes"),
     AP_INIT_ITERATE("OTPAuthPINAuthProvider",
         add_authn_provider,
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude 
config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 
--exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh 
old/mod_authn_otp-1.1.12/scripts/compile 
new/mod_authn_otp-1.1.13/scripts/compile
--- old/mod_authn_otp-1.1.12/scripts/compile    2025-07-26 18:27:39.000000000 
+0200
+++ new/mod_authn_otp-1.1.13/scripts/compile    2026-11-17 22:17:27.000000000 
+0100
@@ -1,9 +1,9 @@
 #! /bin/sh
 # Wrapper for compilers which do not understand '-c -o'.
 
-scriptversion=2016-01-11.22; # UTC
+scriptversion=2025-06-18.21; # UTC
 
-# Copyright (C) 1999-2017 Free Software Foundation, Inc.
+# Copyright (C) 1999-2025 Free Software Foundation, Inc.
 # Written by Tom Tromey <[email protected]>.
 #
 # This program is free software; you can redistribute it and/or modify
@@ -17,7 +17,7 @@
 # GNU General Public License for more details.
 #
 # You should have received a copy of the GNU General Public License
-# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+# along with this program.  If not, see <https://www.gnu.org/licenses/>.
 
 # As a special exception to the GNU General Public License, if you
 # distribute this file as part of a program that contains a
@@ -37,11 +37,11 @@
 
 file_conv=
 
-# func_file_conv build_file lazy
+# func_file_conv build_file unneeded_conversions
 # Convert a $build file to $host form and store it in $file
 # Currently only supports Windows hosts. If the determined conversion
-# type is listed in (the comma separated) LAZY, no conversion will
-# take place.
+# type is listed in (the comma separated) UNNEEDED_CONVERSIONS, no
+# conversion will take place.
 func_file_conv ()
 {
   file=$1
@@ -51,9 +51,20 @@
        # lazily determine how to convert abs files
        case `uname -s` in
          MINGW*)
-           file_conv=mingw
+           if test -n "$MSYSTEM" && (cygpath --version) >/dev/null 2>&1; then
+             # MSYS2 environment.
+             file_conv=cygwin
+           else
+             # Original MinGW environment.
+             file_conv=mingw
+           fi
+           ;;
+         MSYS*)
+           # Old MSYS environment, or MSYS2 with 32-bit MSYS2 shell.
+           file_conv=cygwin
            ;;
          CYGWIN*)
+           # Cygwin environment.
            file_conv=cygwin
            ;;
          *)
@@ -63,12 +74,14 @@
       fi
       case $file_conv/,$2, in
        *,$file_conv,*)
+         # This is the optimization mentioned above:
+         # If UNNEEDED_CONVERSIONS contains $file_conv, don't convert.
          ;;
        mingw/*)
          file=`cmd //C echo "$file " | sed -e 's/"\(.*\) " *$/\1/'`
          ;;
        cygwin/*)
-         file=`cygpath -m "$file" || echo "$file"`
+         file=`cygpath -w "$file" || echo "$file"`
          ;;
        wine/*)
          file=`winepath -w "$file" || echo "$file"`
@@ -143,7 +156,7 @@
          # configure might choose to run compile as 'compile cc -o foo foo.c'.
          eat=1
          case $2 in
-           *.o | *.[oO][bB][jJ])
+           *.o | *.lo | *.[oO][bB][jJ])
              func_file_conv "$2"
              set x "$@" -Fo"$file"
              shift
@@ -248,14 +261,17 @@
 right script to run: please start by reading the file 'INSTALL'.
 
 Report bugs to <[email protected]>.
+GNU Automake home page: <https://www.gnu.org/software/automake/>.
+General help using GNU software: <https://www.gnu.org/gethelp/>.
 EOF
     exit $?
     ;;
   -v | --v*)
-    echo "compile $scriptversion"
+    echo "compile (GNU Automake) $scriptversion"
     exit $?
     ;;
   cl | *[/\\]cl | cl.exe | *[/\\]cl.exe | \
+  clang-cl | *[/\\]clang-cl | clang-cl.exe | *[/\\]clang-cl.exe | \
   icl | *[/\\]icl | icl.exe | *[/\\]icl.exe )
     func_cl_wrapper "$@"      # Doesn't return...
     ;;
@@ -340,9 +356,9 @@
 # Local Variables:
 # mode: shell-script
 # sh-indentation: 2
-# eval: (add-hook 'write-file-hooks 'time-stamp)
+# eval: (add-hook 'before-save-hook 'time-stamp nil t)
 # time-stamp-start: "scriptversion="
-# time-stamp-format: "%:y-%02m-%02d.%02H"
+# time-stamp-format: "%Y-%02m-%02d.%02H"
 # time-stamp-time-zone: "UTC0"
 # time-stamp-end: "; # UTC"
 # End:
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude 
config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 
--exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh 
old/mod_authn_otp-1.1.12/scripts/missing 
new/mod_authn_otp-1.1.13/scripts/missing
--- old/mod_authn_otp-1.1.12/scripts/missing    2025-07-26 18:27:39.000000000 
+0200
+++ new/mod_authn_otp-1.1.13/scripts/missing    2026-11-17 22:17:27.000000000 
+0100
@@ -1,9 +1,11 @@
 #! /bin/sh
-# Common wrapper for a few potentially missing GNU programs.
+# Common wrapper for a few potentially missing GNU and other programs.
 
-scriptversion=2016-01-11.22; # UTC
+scriptversion=2025-06-18.21; # UTC
 
-# Copyright (C) 1996-2017 Free Software Foundation, Inc.
+# shellcheck disable=SC2006,SC2268 # we must support pre-POSIX shells
+
+# Copyright (C) 1996-2025 Free Software Foundation, Inc.
 # Originally written by Fran,cois Pinard <[email protected]>, 1996.
 
 # This program is free software; you can redistribute it and/or modify
@@ -17,7 +19,7 @@
 # GNU General Public License for more details.
 
 # You should have received a copy of the GNU General Public License
-# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+# along with this program.  If not, see <https://www.gnu.org/licenses/>.
 
 # As a special exception to the GNU General Public License, if you
 # distribute this file as part of a program that contains a
@@ -54,18 +56,20 @@
   -v, --version   output version information and exit
 
 Supported PROGRAM values:
-  aclocal   autoconf  autoheader   autom4te  automake  makeinfo
-  bison     yacc      flex         lex       help2man
+aclocal autoconf autogen  autoheader autom4te automake autoreconf
+bison   flex     help2man lex        makeinfo perl     yacc
 
 Version suffixes to PROGRAM as well as the prefixes 'gnu-', 'gnu', and
 'g' are ignored when checking the name.
 
-Send bug reports to <[email protected]>."
+Report bugs to <[email protected]>.
+GNU Automake home page: <https://www.gnu.org/software/automake/>.
+General help using GNU software: <https://www.gnu.org/gethelp/>."
     exit $?
     ;;
 
   -v|--v|--ve|--ver|--vers|--versi|--versio|--version)
-    echo "missing $scriptversion (GNU Automake)"
+    echo "missing (GNU Automake) $scriptversion"
     exit $?
     ;;
 
@@ -101,14 +105,14 @@
   exit $st
 fi
 
-perl_URL=http://www.perl.org/
-flex_URL=http://flex.sourceforge.net/
-gnu_software_URL=http://www.gnu.org/software
+perl_URL=https://www.perl.org/
+flex_URL=https://github.com/westes/flex
+gnu_software_URL=https://www.gnu.org/software
 
 program_details ()
 {
   case $1 in
-    aclocal|automake)
+    aclocal|automake|autoreconf)
       echo "The '$1' program is part of the GNU Automake package:"
       echo "<$gnu_software_URL/automake>"
       echo "It also requires GNU Autoconf, GNU m4 and Perl in order to run:"
@@ -123,6 +127,9 @@
       echo "<$gnu_software_URL/m4/>"
       echo "<$perl_URL>"
       ;;
+    *)
+      :
+      ;;
   esac
 }
 
@@ -137,48 +144,55 @@
   printf '%s\n' "'$1' is $msg."
 
   configure_deps="'configure.ac' or m4 files included by 'configure.ac'"
+  autoheader_deps="'acconfig.h'"
+  automake_deps="'Makefile.am'"
+  aclocal_deps="'acinclude.m4'"
   case $normalized_program in
+    aclocal*)
+      echo "You should only need it if you modified $aclocal_deps or"
+      echo "$configure_deps."
+      ;;
     autoconf*)
-      echo "You should only need it if you modified 'configure.ac',"
-      echo "or m4 files included by it."
-      program_details 'autoconf'
+      echo "You should only need it if you modified $configure_deps."
+      ;;
+    autogen*)
+      echo "You should only need it if you modified a '.def' or '.tpl' file."
+      echo "You may want to install the GNU AutoGen package:"
+      echo "<$gnu_software_URL/autogen/>"
       ;;
     autoheader*)
-      echo "You should only need it if you modified 'acconfig.h' or"
+      echo "You should only need it if you modified $autoheader_deps or"
       echo "$configure_deps."
-      program_details 'autoheader'
       ;;
     automake*)
-      echo "You should only need it if you modified 'Makefile.am' or"
-      echo "$configure_deps."
-      program_details 'automake'
-      ;;
-    aclocal*)
-      echo "You should only need it if you modified 'acinclude.m4' or"
+      echo "You should only need it if you modified $automake_deps or"
       echo "$configure_deps."
-      program_details 'aclocal'
       ;;
-   autom4te*)
+    autom4te*)
       echo "You might have modified some maintainer files that require"
       echo "the 'autom4te' program to be rebuilt."
-      program_details 'autom4te'
+      ;;
+    autoreconf*)
+      echo "You should only need it if you modified $aclocal_deps or"
+      echo "$automake_deps or $autoheader_deps or $automake_deps or"
+      echo "$configure_deps."
       ;;
     bison*|yacc*)
       echo "You should only need it if you modified a '.y' file."
       echo "You may want to install the GNU Bison package:"
       echo "<$gnu_software_URL/bison/>"
       ;;
-    lex*|flex*)
-      echo "You should only need it if you modified a '.l' file."
-      echo "You may want to install the Fast Lexical Analyzer package:"
-      echo "<$flex_URL>"
-      ;;
     help2man*)
       echo "You should only need it if you modified a dependency" \
            "of a man page."
       echo "You may want to install the GNU Help2man package:"
       echo "<$gnu_software_URL/help2man/>"
     ;;
+    lex*|flex*)
+      echo "You should only need it if you modified a '.l' file."
+      echo "You may want to install the Fast Lexical Analyzer package:"
+      echo "<$flex_URL>"
+      ;;
     makeinfo*)
       echo "You should only need it if you modified a '.texi' file, or"
       echo "any other file indirectly affecting the aspect of the manual."
@@ -189,6 +203,12 @@
       echo "want to install GNU make:"
       echo "<$gnu_software_URL/make/>"
       ;;
+    perl*)
+      echo "You should only need it to run GNU Autoconf, GNU Automake, "
+      echo "  assorted other tools, or if you modified a Perl source file."
+      echo "You may want to install the Perl 5 language interpreter:"
+      echo "<$perl_URL>"
+      ;;
     *)
       echo "You might have modified some files without having the proper"
       echo "tools for further handling them.  Check the 'README' file, it"
@@ -197,6 +217,7 @@
       echo "case some other package contains this missing '$1' program."
       ;;
   esac
+  program_details "$normalized_program"
 }
 
 give_advice "$1" | sed -e '1s/^/WARNING: /' \
@@ -207,9 +228,9 @@
 exit $st
 
 # Local variables:
-# eval: (add-hook 'write-file-hooks 'time-stamp)
+# eval: (add-hook 'before-save-hook 'time-stamp nil t)
 # time-stamp-start: "scriptversion="
-# time-stamp-format: "%:y-%02m-%02d.%02H"
+# time-stamp-format: "%Y-%02m-%02d.%02H"
 # time-stamp-time-zone: "UTC0"
 # time-stamp-end: "; # UTC"
 # End:

Reply via email to