Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package polybar for openSUSE:Factory checked in at 2021-06-01 10:35:22 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/polybar (Old) and /work/SRC/openSUSE:Factory/.polybar.new.1898 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "polybar" Tue Jun 1 10:35:22 2021 rev:4 rq:895292 version:3.5.6 Changes: -------- --- /work/SRC/openSUSE:Factory/polybar/polybar.changes 2021-03-06 21:19:28.797284141 +0100 +++ /work/SRC/openSUSE:Factory/.polybar.new.1898/polybar.changes 2021-06-01 10:35:55.600656237 +0200 @@ -1,0 +2,10 @@ +Tue May 25 06:51:42 UTC 2021 - Michael Vetter <mvet...@suse.com> + +- Update to 3.5.6: + Build: + * Support building documentation on sphinx 4.0 (#2424) + Fixed: + * Tray icons sometimes appears outside of bar (#2430, #1679) + * Crash in the i3 module (#2416) + +------------------------------------------------------------------- Old: ---- polybar-3.5.5.tar.gz New: ---- polybar-3.5.6.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ polybar.spec ++++++ --- /var/tmp/diff_new_pack.SxBo4f/_old 2021-06-01 10:35:56.104657096 +0200 +++ /var/tmp/diff_new_pack.SxBo4f/_new 2021-06-01 10:35:56.108657102 +0200 @@ -17,7 +17,7 @@ Name: polybar -Version: 3.5.5 +Version: 3.5.6 Release: 0 Summary: A fast and easy-to-use status bar License: MIT ++++++ polybar-3.5.5.tar.gz -> polybar-3.5.6.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/polybar-3.5.5/CHANGELOG.md new/polybar-3.5.6/CHANGELOG.md --- old/polybar-3.5.5/CHANGELOG.md 2021-03-01 21:40:18.000000000 +0100 +++ new/polybar-3.5.6/CHANGELOG.md 2021-05-24 01:06:24.000000000 +0200 @@ -9,6 +9,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). ## [Unreleased] +## [3.5.6] - 2021-05-24 +### Build +- Support building documentation on sphinx 4.0 ([`#2424`](https://github.com/polybar/polybar/issues/2424)) +### Fixed +- Tray icons sometimes appears outside of bar ([`#2430`](https://github.com/polybar/polybar/issues/2430), [`#1679`](https://github.com/polybar/polybar/issues/1679)) +- Crash in the i3 module ([`#2416`](https://github.com/polybar/polybar/issues/2416)) + ## [3.5.5] - 2021-03-01 ### Build - Support older python sphinx versions again ([`#2356`](https://github.com/polybar/polybar/issues/2356)) @@ -23,7 +30,8 @@ ### Fixed - Empty color values are no longer treated as invalid and no longer produce an error. -[Unreleased]: https://github.com/polybar/polybar/compare/3.5.5...HEAD +[Unreleased]: https://github.com/polybar/polybar/compare/3.5.6...HEAD +[3.5.5]: https://github.com/polybar/polybar/releases/tag/3.5.6 [3.5.5]: https://github.com/polybar/polybar/releases/tag/3.5.5 [3.5.4]: https://github.com/polybar/polybar/releases/tag/3.5.4 [3.5.3]: https://github.com/polybar/polybar/releases/tag/3.5.3 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/polybar-3.5.5/doc/conf.py new/polybar-3.5.6/doc/conf.py --- old/polybar-3.5.5/doc/conf.py 2021-03-01 21:40:18.000000000 +0100 +++ new/polybar-3.5.6/doc/conf.py 2021-05-24 01:06:24.000000000 +0200 @@ -185,6 +185,9 @@ ('man/polybar.5', 'polybar', 'configuration file for polybar(1)', [], 5) ] +man_make_section_directory = False + + # -- Options for Texinfo output ---------------------------------------------- # Grouping the document tree into Texinfo files. List of tuples diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/polybar-3.5.5/lib/i3ipcpp/src/ipc.cpp new/polybar-3.5.6/lib/i3ipcpp/src/ipc.cpp --- old/polybar-3.5.5/lib/i3ipcpp/src/ipc.cpp 2021-03-01 21:40:19.000000000 +0100 +++ new/polybar-3.5.6/lib/i3ipcpp/src/ipc.cpp 2021-05-24 01:06:25.000000000 +0200 @@ -265,7 +265,7 @@ pclose(in); str = str_buf; } - if (str.back() == '\n') { + if (!str.empty() && str.back() == '\n') { str.pop_back(); } return str; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/polybar-3.5.5/src/x11/tray_client.cpp new/polybar-3.5.6/src/x11/tray_client.cpp --- old/polybar-3.5.5/src/x11/tray_client.cpp 2021-03-01 21:40:18.000000000 +0100 +++ new/polybar-3.5.6/src/x11/tray_client.cpp 2021-05-24 01:06:24.000000000 +0200 @@ -1,9 +1,10 @@ +#include "x11/tray_client.hpp" + #include <xcb/xcb.h> #include <xcb/xcb_aux.h> #include "utils/memory.hpp" #include "x11/connection.hpp" -#include "x11/tray_client.hpp" #include "x11/xembed.hpp" POLYBAR_NS @@ -28,11 +29,7 @@ } void tray_client::clear_window() const { - try { - m_connection.clear_area_checked(1, window(), 0, 0, width(), height()); - } catch (const xpp::x::error::window& err) { - // ignore - } + m_connection.clear_area_checked(1, window(), 0, 0, width(), height()); } /** diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/polybar-3.5.5/src/x11/tray_manager.cpp new/polybar-3.5.6/src/x11/tray_manager.cpp --- old/polybar-3.5.5/src/x11/tray_manager.cpp 2021-03-01 21:40:18.000000000 +0100 +++ new/polybar-3.5.6/src/x11/tray_manager.cpp 2021-05-24 01:06:24.000000000 +0200 @@ -427,13 +427,21 @@ m_connection.poly_fill_rectangle(m_pixmap, m_gc, 1, &rect); } - if (m_surface) + if (m_surface) { m_surface->flush(); + } m_connection.clear_area(0, m_tray, 0, 0, width, height); for (auto&& client : m_clients) { - client->clear_window(); + try { + if (client->mapped()) { + client->clear_window(); + } + } catch (const std::exception& e) { + m_log.err("Failed to clear tray client %s '%s' (%s)", m_connection.id(client->window()), + ewmh_util::get_wm_name(client->window()), e.what()); + } } m_connection.flush(); @@ -477,8 +485,8 @@ << cw_class(XCB_WINDOW_CLASS_INPUT_OUTPUT) << cw_params_backing_store(XCB_BACKING_STORE_WHEN_MAPPED) << cw_params_event_mask(XCB_EVENT_MASK_SUBSTRUCTURE_REDIRECT - |XCB_EVENT_MASK_STRUCTURE_NOTIFY - |XCB_EVENT_MASK_EXPOSURE) + |XCB_EVENT_MASK_STRUCTURE_NOTIFY + |XCB_EVENT_MASK_EXPOSURE) << cw_params_override_redirect(true); // clang-format on @@ -726,7 +734,7 @@ * Process client docking request */ void tray_manager::process_docking_request(xcb_window_t win) { - m_log.info("Processing docking request from %s", m_connection.id(win)); + m_log.info("Processing docking request from '%s' (%s)", ewmh_util::get_wm_name(win), m_connection.id(win)); m_clients.emplace_back(factory_util::shared<tray_client>(m_connection, win, m_opts.width, m_opts.height)); auto& client = m_clients.back(); @@ -734,18 +742,15 @@ try { m_log.trace("tray: Get client _XEMBED_INFO"); xembed::query(m_connection, win, client->xembed()); - } catch (const application_error& err) { - m_log.err(err.what()); - } catch (const xpp::x::error::window& err) { + } catch (const std::exception& err) { m_log.err("Failed to query _XEMBED_INFO, removing client... (%s)", err.what()); remove_client(win, true); return; } try { - const unsigned int mask{XCB_CW_BACK_PIXMAP | XCB_CW_EVENT_MASK}; - const unsigned int values[]{ - XCB_BACK_PIXMAP_PARENT_RELATIVE, XCB_EVENT_MASK_PROPERTY_CHANGE | XCB_EVENT_MASK_STRUCTURE_NOTIFY}; + const unsigned int mask = XCB_CW_EVENT_MASK; + const unsigned int values[]{XCB_EVENT_MASK_PROPERTY_CHANGE | XCB_EVENT_MASK_STRUCTURE_NOTIFY}; m_log.trace("tray: Update client window"); m_connection.change_window_attributes_checked(client->window(), mask, values); @@ -767,8 +772,9 @@ m_log.trace("tray: Map client"); m_connection.map_window_checked(client->window()); } - } catch (const xpp::x::error::window& err) { - m_log.err("Failed to setup tray client, removing... (%s)", err.what()); + + } catch (const std::exception& err) { + m_log.err("Failed to setup tray client removing... (%s)", err.what()); remove_client(win, false); } } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/polybar-3.5.5/version.txt new/polybar-3.5.6/version.txt --- old/polybar-3.5.5/version.txt 2021-03-01 21:40:18.000000000 +0100 +++ new/polybar-3.5.6/version.txt 2021-05-24 01:06:24.000000000 +0200 @@ -1,4 +1,4 @@ # Polybar version information # Update this on every release # This is used to create the version string if a git repo is not available -3.5.5 +3.5.6