Script 'mail_helper' called by obssrc
Hello community,

here is the log from the commit of package kactivities-stats for 
openSUSE:Factory checked in at 2021-08-16 10:07:26
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/kactivities-stats (Old)
 and      /work/SRC/openSUSE:Factory/.kactivities-stats.new.1899 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "kactivities-stats"

Mon Aug 16 10:07:26 2021 rev:65 rq:912107 version:5.85.0

Changes:
--------
--- /work/SRC/openSUSE:Factory/kactivities-stats/kactivities-stats.changes      
2021-07-16 00:00:52.937317584 +0200
+++ 
/work/SRC/openSUSE:Factory/.kactivities-stats.new.1899/kactivities-stats.changes
    2021-08-16 10:11:12.835124700 +0200
@@ -1,0 +2,12 @@
+Fri Aug  6 12:11:22 UTC 2021 - Christophe Giboudeaux <[email protected]>
+
+- Update to 5.85.0
+  * New feature release
+  * For more details please see:
+  * https://kde.org/announcements/frameworks/5/5.85.0
+- Changes since 5.84.0:
+  * Autotests: restore test commented-out in 2016
+  * Autotests: test-internals before refactoring
+  * Avoid test-crash because of QStringBuilder
+
+-------------------------------------------------------------------

Old:
----
  kactivities-stats-5.84.0.tar.xz
  kactivities-stats-5.84.0.tar.xz.sig

New:
----
  kactivities-stats-5.85.0.tar.xz
  kactivities-stats-5.85.0.tar.xz.sig

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ kactivities-stats.spec ++++++
--- /var/tmp/diff_new_pack.3MXBAT/_old  2021-08-16 10:11:13.823123541 +0200
+++ /var/tmp/diff_new_pack.3MXBAT/_new  2021-08-16 10:11:13.827123536 +0200
@@ -17,7 +17,7 @@
 
 
 %define lname   libKF5ActivitiesStats1
-%define _tar_path 5.84
+%define _tar_path 5.85
 # Full KF5 version (e.g. 5.33.0)
 %{!?_kf5_version: %global _kf5_version %{version}}
 # Last major and minor KF5 version (e.g. 5.33)
@@ -25,7 +25,7 @@
 # Only needed for the package signature condition
 %bcond_without lang
 Name:           kactivities-stats
-Version:        5.84.0
+Version:        5.85.0
 Release:        0
 Summary:        KDE Plasma Activities support
 License:        LGPL-2.0-or-later


++++++ kactivities-stats-5.84.0.tar.xz -> kactivities-stats-5.85.0.tar.xz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/kactivities-stats-5.84.0/CMakeLists.txt 
new/kactivities-stats-5.85.0/CMakeLists.txt
--- old/kactivities-stats-5.84.0/CMakeLists.txt 2021-06-24 16:17:36.000000000 
+0200
+++ new/kactivities-stats-5.85.0/CMakeLists.txt 2021-07-20 00:07:21.000000000 
+0200
@@ -2,8 +2,8 @@
 
 cmake_minimum_required(VERSION 3.16)
 
-set(KF_VERSION "5.84.0") # handled by release scripts
-set(KF_DEP_VERSION "5.84.0") # handled by release scripts
+set(KF_VERSION "5.85.0") # handled by release scripts
+set(KF_DEP_VERSION "5.85.0") # handled by release scripts
 project (KActivitiesStats VERSION ${KF_VERSION})
 
 set (REQUIRED_QT_VERSION 5.15.0)
@@ -20,7 +20,7 @@
 
 # Extra CMake stuff
 include (FeatureSummary)
-find_package (ECM 5.84.0  NO_MODULE)
+find_package (ECM 5.85.0  NO_MODULE)
 set_package_properties (ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake 
Modules." URL "https://commits.kde.org/extra-cmake-modules";)
 feature_summary (WHAT REQUIRED_PACKAGES_NOT_FOUND 
FATAL_ON_MISSING_REQUIRED_PACKAGES)
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/kactivities-stats-5.84.0/README.md 
new/kactivities-stats-5.85.0/README.md
--- old/kactivities-stats-5.84.0/README.md      2021-06-24 16:17:36.000000000 
+0200
+++ new/kactivities-stats-5.85.0/README.md      2021-07-20 00:07:21.000000000 
+0200
@@ -5,7 +5,7 @@
 ## Introduction
 
 The KActivitiesStats library provides a querying mechanism for the data
-that the activitiy manager collects - which documents hae been opened by
+that the activity manager collects - which documents hae been opened by
 which applications, and what documents have been linked to which activity.
 The activity manager also keeps the score for each document which gets
 higher when a particular document has been often accessed or kept open
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/kactivities-stats-5.84.0/autotests/ResultSetTest.cpp 
new/kactivities-stats-5.85.0/autotests/ResultSetTest.cpp
--- old/kactivities-stats-5.84.0/autotests/ResultSetTest.cpp    2021-06-24 
16:17:36.000000000 +0200
+++ new/kactivities-stats-5.85.0/autotests/ResultSetTest.cpp    2021-07-20 
00:07:21.000000000 +0200
@@ -47,22 +47,72 @@
 }
 }
 
+void ResultSetTest::testConcat()
+{
+    using namespace KAStats;
+    using namespace KAStats::Terms;
+
+    TEST_CHUNK(QStringLiteral("Checking barred function"))
+    {
+        ResultSet::Result r;
+        r.setResource(QStringLiteral("quack"));
+
+        QCOMPARE(getBarredUri(KAStats::ResultSet::Result{}), 
QStringLiteral("|"));
+        QCOMPARE(getBarredUri(r), QStringLiteral("quack|"));
+        r.setResource(QStringLiteral("http://www.kde.org";));
+        QVERIFY(getBarredUri(r).startsWith(QStringLiteral("http://";)));
+        QVERIFY(getBarredUri(r).endsWith(QStringLiteral("org|")));
+    }
+
+    TEST_CHUNK(QStringLiteral("Checking empty concatenation"))
+    {
+        ResultSet rs(KActivities::Stats::Terms::LinkedResources);
+        // There is no "count" on a resultset
+        unsigned int rs_count = 0;
+        for(const auto& r : rs)
+        {
+            Q_UNUSED(r);
+            rs_count++;
+        }
+        QCOMPARE(rs_count, 0);  // It's empty
+        QCOMPARE(concatenateResults(rs), QStringLiteral("|"));  // 0 results 
pasted after a "|" to start
+    }
+
+    TEST_CHUNK(QStringLiteral("Checking non-empty concatenation"))
+    {
+        ResultSet rs(UsedResources
+                    | HighScoredFirst
+                    | Agent{QStringLiteral("gvim")}
+                    );
+        // There is no "count" on a resultset
+        unsigned int rs_count = 0;
+        for(const auto& r : rs)
+        {
+            Q_UNUSED(r);
+            rs_count++;
+        }
+        QCOMPARE(rs_count, 5);  // Not empty (see data inserted into 
ResourceLink, in initTestCase()
+
+        const QString cat = concatenateResults(rs);
+        QCOMPARE(cat.count(QStringLiteral("|")), 6);  // 5 items, plus 1 to 
start
+    }
+}
+
+
 void ResultSetTest::testLinkedResources()
 {
     using namespace KAStats;
     using namespace KAStats::Terms;
 
-    // TEST_CHUNK("Getting the linked resources alphabetically")
-    // {
-    //     ResultSet result(LinkedResources
-    //                         | Agent { "gvim" }
-    //                         | Activity { 
"860d9ec8-87f9-8e96-1558-1faf54b98e97" }
-    //                         | OrderAlphabetically
-    //                     );
-    //
-    //     QCOMPARE(result.at(0).resource, QStringLiteral("/path/mid1_a1"));
-    //     QCOMPARE(result.at(1).resource, QStringLiteral("/path/mid2_a1"));
-    // }
+    TEST_CHUNK(QStringLiteral("Getting the linked resources alphabetically"))
+    {
+        ResultSet result(LinkedResources
+                            | Agent { QStringLiteral("gvim") }
+                            | Activity { QStringLiteral("activity1") }
+                        );
+        QCOMPARE(result.at(0).resource(), QStringLiteral("/path/mid1_a1"));
+        QCOMPARE(result.at(1).resource(), QStringLiteral("/path/mid2_a1"));
+    }
 }
 
 void ResultSetTest::testUsedResources()
@@ -175,7 +225,7 @@
         qFatal("Can not create a temporary directory");
     }
 
-    const auto databaseFile = dir.path() + QStringLiteral("/database");
+    const QString databaseFile = dir.path() + QStringLiteral("/database");
 
     Common::ResourcesDatabaseSchema::overridePath(databaseFile);
     qDebug() << "Creating database in " << databaseFile;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/kactivities-stats-5.84.0/autotests/ResultSetTest.h 
new/kactivities-stats-5.85.0/autotests/ResultSetTest.h
--- old/kactivities-stats-5.84.0/autotests/ResultSetTest.h      2021-06-24 
16:17:36.000000000 +0200
+++ new/kactivities-stats-5.85.0/autotests/ResultSetTest.h      2021-07-20 
00:07:21.000000000 +0200
@@ -23,6 +23,7 @@
 private Q_SLOTS:
     void initTestCase();
 
+    void testConcat();  ///< Tests test-implementation-details
     void testLinkedResources();
     void testUsedResources();
 
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/kactivities-stats-5.84.0/autotests/ResultWatcherTest.cpp 
new/kactivities-stats-5.85.0/autotests/ResultWatcherTest.cpp
--- old/kactivities-stats-5.84.0/autotests/ResultWatcherTest.cpp        
2021-06-24 16:17:36.000000000 +0200
+++ new/kactivities-stats-5.85.0/autotests/ResultWatcherTest.cpp        
2021-07-20 00:07:21.000000000 +0200
@@ -91,7 +91,7 @@
 
     KAStats::ResultWatcher watcher(UsedResources | Agent::current() | 
Activity::any());
 
-    // Openning a resource for a few seconds
+    // Opening a resource for a few seconds
     {
         KActivities::ResourceInstance resource(0);
         resource.setUri(QUrl(QStringLiteral("test://test1")));
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/kactivities-stats-5.84.0/src/common/database/schema/ResourcesDatabaseSchema.cpp
 
new/kactivities-stats-5.85.0/src/common/database/schema/ResourcesDatabaseSchema.cpp
--- 
old/kactivities-stats-5.84.0/src/common/database/schema/ResourcesDatabaseSchema.cpp
 2021-06-24 16:17:36.000000000 +0200
+++ 
new/kactivities-stats-5.85.0/src/common/database/schema/ResourcesDatabaseSchema.cpp
 2021-07-20 00:07:21.000000000 +0200
@@ -27,7 +27,7 @@
     /* clang-format off */
     return QStringList()
 
-        << // Schema informations table, used for versioning
+        << // Schema information table, used for versioning
            QStringLiteral("CREATE TABLE IF NOT EXISTS SchemaInfo ("
                "key text PRIMARY KEY, value text"
            ")")
@@ -48,7 +48,7 @@
                "end INTEGER "
            ")")
 
-        << // The ResourceScoreCache table stores the calcualted scores
+        << // The ResourceScoreCache table stores the calculated scores
            // for resources based on the recorded events.
            QStringLiteral("CREATE TABLE IF NOT EXISTS ResourceScoreCache ("
                "usedActivity TEXT, "

Reply via email to