Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package yast2-ruby-bindings for
openSUSE:Factory checked in at 2021-08-19 13:06:41
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-ruby-bindings (Old)
and /work/SRC/openSUSE:Factory/.yast2-ruby-bindings.new.1899 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-ruby-bindings"
Thu Aug 19 13:06:41 2021 rev:113 rq:912918 version:4.4.4
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-ruby-bindings/yast2-ruby-bindings.changes
2021-07-25 20:09:06.563453982 +0200
+++
/work/SRC/openSUSE:Factory/.yast2-ruby-bindings.new.1899/yast2-ruby-bindings.changes
2021-08-19 13:06:46.679972874 +0200
@@ -1,0 +2,12 @@
+Wed Aug 18 14:32:24 UTC 2021 - Josef Reidinger <[email protected]>
+
+- Fix dependency on s390 (revealed by previous fix for bsc#972548)
+- 4.4.4
+
+-------------------------------------------------------------------
+Fri Aug 13 16:00:32 UTC 2021 - Ladislav Slez??k <[email protected]>
+
+- Added an unit test for testing empty help text (bsc#972548)
+- 4.4.3
+
+-------------------------------------------------------------------
Old:
----
yast2-ruby-bindings-4.4.2.tar.bz2
New:
----
yast2-ruby-bindings-4.4.4.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-ruby-bindings.spec ++++++
--- /var/tmp/diff_new_pack.NxdtSe/_old 2021-08-19 13:06:47.123972261 +0200
+++ /var/tmp/diff_new_pack.NxdtSe/_new 2021-08-19 13:06:47.123972261 +0200
@@ -17,7 +17,7 @@
Name: yast2-ruby-bindings
-Version: 4.4.2
+Version: 4.4.4
Release: 0
URL: https://github.com/yast/yast-ruby-bindings
BuildRoot: %{_tmppath}/%{name}-%{version}-build
@@ -28,21 +28,22 @@
BuildRequires: gcc-c++
BuildRequires: yast2-core-devel
BuildRequires: yast2-devtools >= 3.1.10
-%if 0%{?suse_version} == 1310
-BuildRequires: rubygem-fast_gettext < 3.0
-BuildRequires: rubygem-rspec
-Requires: rubygem-fast_gettext < 3.0
-%else
BuildRequires: rubygem(%{rb_default_ruby_abi}:fast_gettext) < 3.0
BuildRequires: rubygem(%{rb_default_ruby_abi}:rspec)
Requires: rubygem(%{rb_default_ruby_abi}:fast_gettext) < 3.0
-%endif
BuildRequires: ruby-devel
Requires: yast2-core >= 3.2.2
BuildRequires: yast2-core-devel >= 3.2.2
# MenuBar-shortcuts-test.rb
Requires: yast2-ycp-ui-bindings >= 4.3.7
BuildRequires: yast2-ycp-ui-bindings-devel >= 4.3.7
+%ifarch s390 s390x
+# s390 specific frame title that is read from readvalues from s390-tools
+# needed also for tests, so build require it
+BuildRequires: s390-tools
+Requires: s390-tools
+%endif
+
# The test suite includes a regression test (std_streams_spec.rb) for a
# libyui-ncurses bug fixed in 2.47.3
BuildRequires: libyui-ncurses >= 2.47.3
@@ -71,6 +72,7 @@
%prep
%setup -n yast2-ruby-bindings-%{version}
+
%build
mkdir build
cd build
++++++ yast2-ruby-bindings-4.4.2.tar.bz2 -> yast2-ruby-bindings-4.4.4.tar.bz2
++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-ruby-bindings-4.4.2/package/yast2-ruby-bindings.changes
new/yast2-ruby-bindings-4.4.4/package/yast2-ruby-bindings.changes
--- old/yast2-ruby-bindings-4.4.2/package/yast2-ruby-bindings.changes
2021-07-22 10:50:42.000000000 +0200
+++ new/yast2-ruby-bindings-4.4.4/package/yast2-ruby-bindings.changes
2021-08-18 16:52:17.000000000 +0200
@@ -1,4 +1,16 @@
-------------------------------------------------------------------
+Wed Aug 18 14:32:24 UTC 2021 - Josef Reidinger <[email protected]>
+
+- Fix dependency on s390 (revealed by previous fix for bsc#972548)
+- 4.4.4
+
+-------------------------------------------------------------------
+Fri Aug 13 16:00:32 UTC 2021 - Ladislav Slez??k <[email protected]>
+
+- Added an unit test for testing empty help text (bsc#972548)
+- 4.4.3
+
+-------------------------------------------------------------------
Wed Jul 21 14:30:46 UTC 2021 - Jos?? Iv??n L??pez Gonz??lez <[email protected]>
- Avoid IO exception when the stderr was closed. This could happen
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-ruby-bindings-4.4.2/package/yast2-ruby-bindings.spec
new/yast2-ruby-bindings-4.4.4/package/yast2-ruby-bindings.spec
--- old/yast2-ruby-bindings-4.4.2/package/yast2-ruby-bindings.spec
2021-07-22 10:50:42.000000000 +0200
+++ new/yast2-ruby-bindings-4.4.4/package/yast2-ruby-bindings.spec
2021-08-18 16:52:17.000000000 +0200
@@ -17,7 +17,7 @@
Name: yast2-ruby-bindings
-Version: 4.4.2
+Version: 4.4.4
Release: 0
URL: https://github.com/yast/yast-ruby-bindings
BuildRoot: %{_tmppath}/%{name}-%{version}-build
@@ -28,21 +28,23 @@
BuildRequires: gcc-c++
BuildRequires: yast2-core-devel
BuildRequires: yast2-devtools >= 3.1.10
-%if 0%{?suse_version} == 1310
-BuildRequires: rubygem-fast_gettext < 3.0
-BuildRequires: rubygem-rspec
-Requires: rubygem-fast_gettext < 3.0
-%else
BuildRequires: rubygem(%{rb_default_ruby_abi}:fast_gettext) < 3.0
BuildRequires: rubygem(%{rb_default_ruby_abi}:rspec)
Requires: rubygem(%{rb_default_ruby_abi}:fast_gettext) < 3.0
-%endif
BuildRequires: ruby-devel
Requires: yast2-core >= 3.2.2
BuildRequires: yast2-core-devel >= 3.2.2
# MenuBar-shortcuts-test.rb
Requires: yast2-ycp-ui-bindings >= 4.3.7
BuildRequires: yast2-ycp-ui-bindings-devel >= 4.3.7
+%ifarch s390 s390x
+# s390 specific frame title that is read from readvalues from s390-tools
+# needed also for tests, so build require it
+BuildRequires: s390-tools
+Requires: s390-tools
+%endif
+
+
# The test suite includes a regression test (std_streams_spec.rb) for a
# libyui-ncurses bug fixed in 2.47.3
BuildRequires: libyui-ncurses >= 2.47.3
@@ -71,6 +73,7 @@
%prep
%setup -n yast2-ruby-bindings-%{version}
+
%build
mkdir build
cd build
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-ruby-bindings-4.4.2/tests/integration/run.rb
new/yast2-ruby-bindings-4.4.4/tests/integration/run.rb
--- old/yast2-ruby-bindings-4.4.2/tests/integration/run.rb 2021-07-22
10:50:42.000000000 +0200
+++ new/yast2-ruby-bindings-4.4.4/tests/integration/run.rb 2021-08-18
16:52:17.000000000 +0200
@@ -13,36 +13,27 @@
# If tmux is not available, just skip this without failing
if !tmux_available?
- puts "Test skipped."
+ puts "tmux not available, test skipped."
exit true
end
-RESULT = "/tmp/exit".freeze
-OUTPUT = "/tmp/test_cmd_output".freeze
+require "tempfile"
+RESULT = Tempfile.new("test_result")
+OUTPUT = Tempfile.new("test_output")
-def cleanup
- [RESULT, OUTPUT].each do |file|
- File.delete(file) if File.exist?(file)
- end
-end
-
-test = File.dirname(__FILE__) + "/std_streams_spec.rb"
-cmd = "rspec #{test} >#{OUTPUT} 2>&1"
+test = File.join(__dir__, "std_streams_spec.rb")
+cmd = "rspec #{test} >#{OUTPUT.path} 2>&1"
-tmux_out = `TERM=screen tmux -c '#{cmd}; echo \$? > #{RESULT}'`
+tmux_out = `TERM=screen tmux -c '#{cmd}; echo \$? > #{RESULT.path}'`
puts "Outside tmux output:"
puts tmux_out
-if File.exist?(RESULT) && File.read(RESULT) == "0\n"
+if RESULT.read == "0\n"
puts "Test succeeded."
- cleanup
exit true
else
puts "Test failed: '#{cmd}'."
- puts "result: #{File.exist?(RESULT) ? "'#{File.read(RESULT)}'" : "file not
exist"}"
- if File.exist?(OUTPUT)
- puts "Output was:"
- puts File.read(OUTPUT)
- end
- cleanup
+ puts "result: '#{RESULT.read}'"
+ puts "Output was:"
+ puts OUTPUT.read
exit false
end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-ruby-bindings-4.4.2/tests/libyui/empty_help.rb
new/yast2-ruby-bindings-4.4.4/tests/libyui/empty_help.rb
--- old/yast2-ruby-bindings-4.4.2/tests/libyui/empty_help.rb 1970-01-01
01:00:00.000000000 +0100
+++ new/yast2-ruby-bindings-4.4.4/tests/libyui/empty_help.rb 2021-08-18
16:52:17.000000000 +0200
@@ -0,0 +1,29 @@
+#! /usr/bin/env ruby
+
+require "yast"
+require "yast/ui_shortcuts"
+include Yast::UIShortcuts
+
+Yast.ui_component = ARGV[0] || "ncurses" if Yast.ui_component == ""
+
+Yast.import "UI"
+Yast::UI.OpenUI
+
+# trivial UI, just [Help] and [Close] buttons
+Yast::UI.OpenDialog(
+ Opt(:defaultsize),
+ HBox(
+ HStretch(),
+ PushButton(Id(:help), Opt(:key_F1, :helpButton), "&Help"),
+ HSpacing(3),
+ PushButton(Id(:close), Opt(:key_F10, :default), "&Close"),
+ HStretch()
+ )
+)
+
+ui = Yast::UI.UserInput
+
+Yast::UI.CloseDialog
+Yast::UI.CloseUI
+
+puts ui.inspect
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-ruby-bindings-4.4.2/tests/libyui/empty_help_spec.rb
new/yast2-ruby-bindings-4.4.4/tests/libyui/empty_help_spec.rb
--- old/yast2-ruby-bindings-4.4.2/tests/libyui/empty_help_spec.rb
1970-01-01 01:00:00.000000000 +0100
+++ new/yast2-ruby-bindings-4.4.4/tests/libyui/empty_help_spec.rb
2021-08-18 16:52:17.000000000 +0200
@@ -0,0 +1,49 @@
+#! /usr/bin/env rspec
+
+require_relative "rspec_tmux_tui"
+
+# check that the test client is running and displaying the initial dialog
+def check_dialog
+ screenshot = @tui.capture_pane
+ # the buttons are there
+ expect(screenshot).to include("[Help]")
+ expect(screenshot).to include("[Close]")
+end
+
+describe "Help text" do
+ around(:each) do |example|
+ y2start = "ruby -r #{__dir__}/../test_helper
#{__dir__}/../../src/y2start/y2start"
+ @base = "empty_help"
+ @tui = TmuxTui.new
+ @log_base = "#{@tui.log_dir}/#{@base}"
+ @tui.new_session "#{y2start} #{__dir__}/#{@base}.rb ncurses" do
+ example.run
+ end
+ end
+
+ # check that the empty help text is properly displayed (bsc#972548),
+ # in the original buggy behavior there was no popup and UI.UseInput()
+ # returned :help in the ncurses UI if the help text was empty,
+ # the Qt UI also displays an empty popup
+ it "displays empty popup for empty help text" do
+ @tui.await("[Help]")
+ check_dialog
+ @tui.capture_pane_to("#{@log_base}-1-initial")
+
+ # show help by pressing F1
+ @tui.send_keys "F1"
+ # check that the help popup is displayed, there is an empty popup
+ # so we cannot check anything better than the OK button :-/
+ @tui.await("[OK]")
+ @tui.capture_pane_to("#{@log_base}-2-help-activated")
+
+ # close the help popup
+ @tui.send_keys "Enter"
+ @tui.capture_pane_to("#{@log_base}-3-help-closed")
+ @tui.await("[Help]")
+ check_dialog
+
+ # close the application (&Close)
+ @tui.send_keys "M-C"
+ end
+end
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-ruby-bindings-4.4.2/tests/libyui/menu_item_spec.rb
new/yast2-ruby-bindings-4.4.4/tests/libyui/menu_item_spec.rb
--- old/yast2-ruby-bindings-4.4.2/tests/libyui/menu_item_spec.rb
2021-07-22 10:50:42.000000000 +0200
+++ new/yast2-ruby-bindings-4.4.4/tests/libyui/menu_item_spec.rb
2021-08-18 16:52:17.000000000 +0200
@@ -2,10 +2,10 @@
describe "Menu Item" do
before(:all) do
- @base = "multi_selection_box_basics"
@tui = YastTui.new
@tui.example("MenuBar-shortcuts-test")
@tui.await(/File.*Edit.*View/)
+ @base = "#{@tui.log_dir}/multi_selection_box_basics"
end
after(:all) do
@@ -14,7 +14,7 @@
bug = "1177760" # https://bugzilla.suse.com/show_bug.cgi?id=1177760
it "has shortcuts in menu items, boo##{bug}" do
- @base = "menu_shortcuts_#{bug}"
+ @base = "#{@tui.log_dir}/menu_shortcuts_#{bug}"
@tui.capture_pane_to("#{@base}-1-initial")
@tui.send_keys "M-V" # &View menu
@@ -31,7 +31,7 @@
bug = nil
it "menu shortcuts have higher priority than button shortcuts" do
- @base = "menu_shortcuts_prio"
+ @base = "#{@tui.log_dir}/menu_shortcuts_prio"
@tui.capture_pane_to("#{@base}-1-initial")
# No extra buttons: The "&View" menu has shortcut "V"
@@ -67,7 +67,7 @@
bug = "1178394" # https://bugzilla.suse.com/show_bug.cgi?id=1178394
it "remains disabled after shortcuts are recomputed" do
- @base = "menu_disabled_#{bug}"
+ @base = "#{@tui.log_dir}/menu_disabled_#{bug}"
@tui.capture_pane_to("#{@base}-1-initial")
@tui.send_keys "M-E" # &Edit menu
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-ruby-bindings-4.4.2/tests/libyui/multi_selection_box_spec.rb
new/yast2-ruby-bindings-4.4.4/tests/libyui/multi_selection_box_spec.rb
--- old/yast2-ruby-bindings-4.4.2/tests/libyui/multi_selection_box_spec.rb
2021-07-22 10:50:42.000000000 +0200
+++ new/yast2-ruby-bindings-4.4.4/tests/libyui/multi_selection_box_spec.rb
2021-08-18 16:52:17.000000000 +0200
@@ -3,10 +3,10 @@
describe "MultiSelectionBox" do
context "Basics" do
before(:all) do
- @base = "multi_selection_box_basics"
@tui = YastTui.new
@tui.example("MultiSelectionBox-test")
@tui.await("Select toppings")
+ @base = "#{@tui.log_dir}/multi_selection_box_basics"
@tui.capture_pane_to("#{@base}-1")
end
@@ -93,8 +93,8 @@
context "Known fixed bugs" do
around(:each) do |ex|
- @base = "multi_selection_box"
@tui = YastTui.new
+ @base = "#{@tui.log_dir}/multi_selection_box"
@tui.example("MultiSelectionBox-test") do
@tui.await("Select toppings")
ex.run
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-ruby-bindings-4.4.2/tests/libyui/rspec_tmux_tui.rb
new/yast2-ruby-bindings-4.4.4/tests/libyui/rspec_tmux_tui.rb
--- old/yast2-ruby-bindings-4.4.2/tests/libyui/rspec_tmux_tui.rb
2021-07-22 10:50:42.000000000 +0200
+++ new/yast2-ruby-bindings-4.4.4/tests/libyui/rspec_tmux_tui.rb
2021-08-18 16:52:17.000000000 +0200
@@ -122,6 +122,14 @@
def ensure_no_session
kill_session if has_session?
end
+
+ # Create a logging directory
+ # @return [String] Path to the directory
+ def log_dir
+ log_dir = "#{__dir__}/log"
+ Dir.mkdir log_dir if !File.exist?(log_dir)
+ log_dir
+ end
end
class YastTui < TmuxTui
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/yast2-ruby-bindings-4.4.2/tests/libyui/table_sort_spec.rb
new/yast2-ruby-bindings-4.4.4/tests/libyui/table_sort_spec.rb
--- old/yast2-ruby-bindings-4.4.2/tests/libyui/table_sort_spec.rb
2021-07-22 10:50:42.000000000 +0200
+++ new/yast2-ruby-bindings-4.4.4/tests/libyui/table_sort_spec.rb
2021-08-18 16:52:17.000000000 +0200
@@ -13,7 +13,7 @@
bug = "1165388" # https://bugzilla.suse.com/show_bug.cgi?id=1165388
it "ChangeWidget(_, Cell(row, col)) changes the correct cell, boo##{bug}"
do
- base = @base + "_cell"
+ base = "#{@tui.log_dir}/#{@base}_cell"
@tui.await(/Table sorting test/)
@tui.capture_pane_to("#{base}-1-initial")
@@ -30,7 +30,7 @@
bug = "1177145" # https://bugzilla.suse.com/show_bug.cgi?id=1177145
it "ChangeWidget(_, :CurrentItem) activates the correct line, boo##{bug}"
do
- base = @base + "_current_item"
+ base = "#{@tui.log_dir}/#{@base}_current_item"
@tui.await(/Table sorting test/)
@tui.capture_pane_to("#{base}-1-ccc-selected")
# the UI code performs a
