Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package libyui for openSUSE:Factory checked in at 2021-09-04 22:31:58 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/libyui (Old) and /work/SRC/openSUSE:Factory/.libyui.new.1899 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libyui" Sat Sep 4 22:31:58 2021 rev:67 rq:915517 version:4.2.16 Changes: -------- --- /work/SRC/openSUSE:Factory/libyui/libyui.changes 2021-08-12 09:01:38.518153332 +0200 +++ /work/SRC/openSUSE:Factory/.libyui.new.1899/libyui.changes 2021-09-04 22:32:03.391889278 +0200 @@ -1,0 +2,7 @@ +Tue Aug 24 15:30:52 UTC 2021 - Ladislav Slez??k <[email protected]> + +- Fixed using an uninitialized variable, in some situations + the patch category could be missing in the Qt UI (bsc#1174390) +- 4.2.16 + +------------------------------------------------------------------- Old: ---- libyui-4.2.15.tar.bz2 New: ---- libyui-4.2.16.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libyui-bindings.spec ++++++ --- /var/tmp/diff_new_pack.6uykYe/_old 2021-09-04 22:32:04.107890225 +0200 +++ /var/tmp/diff_new_pack.6uykYe/_new 2021-09-04 22:32:04.107890225 +0200 @@ -20,7 +20,7 @@ Name: libyui-bindings # DO NOT manually bump the version here; instead, use rake version:bump -Version: 4.2.15 +Version: 4.2.16 Release: 0 Summary: Bindings for libyui License: LGPL-2.1-only OR LGPL-3.0-only ++++++ libyui-ncurses-pkg.spec ++++++ --- /var/tmp/diff_new_pack.6uykYe/_old 2021-09-04 22:32:04.131890257 +0200 +++ /var/tmp/diff_new_pack.6uykYe/_new 2021-09-04 22:32:04.135890262 +0200 @@ -19,7 +19,7 @@ Name: libyui-ncurses-pkg # DO NOT manually bump the version here; instead, use rake version:bump -Version: 4.2.15 +Version: 4.2.16 Release: 0 %define so_version 15 libyui-ncurses-rest-api.spec: same change libyui-ncurses.spec: same change ++++++ libyui-qt-graph.spec ++++++ --- /var/tmp/diff_new_pack.6uykYe/_old 2021-09-04 22:32:04.203890352 +0200 +++ /var/tmp/diff_new_pack.6uykYe/_new 2021-09-04 22:32:04.203890352 +0200 @@ -19,7 +19,7 @@ Name: libyui-qt-graph # DO NOT manually bump the version here; instead, use rake version:bump -Version: 4.2.15 +Version: 4.2.16 Release: 0 %define so_version 15 @@ -61,6 +61,7 @@ # Force removal of old -doc packages (bsc#1184363) Obsoletes: %{name}-doc < %{version} + %description -n %{bin_name} This package contains the Qt graph component for libyui. ++++++ libyui-qt-pkg.spec ++++++ --- /var/tmp/diff_new_pack.6uykYe/_old 2021-09-04 22:32:04.223890379 +0200 +++ /var/tmp/diff_new_pack.6uykYe/_new 2021-09-04 22:32:04.227890384 +0200 @@ -19,7 +19,7 @@ Name: libyui-qt-pkg # DO NOT manually bump the version here; instead, use rake version:bump -Version: 4.2.15 +Version: 4.2.16 Release: 0 %define so_version 15 libyui-qt-rest-api.spec: same change libyui-qt.spec: same change libyui-rest-api.spec: same change ++++++ libyui.spec ++++++ --- /var/tmp/diff_new_pack.6uykYe/_old 2021-09-04 22:32:04.323890511 +0200 +++ /var/tmp/diff_new_pack.6uykYe/_new 2021-09-04 22:32:04.323890511 +0200 @@ -19,7 +19,7 @@ Name: libyui # DO NOT manually bump the version here; instead, use rake version:bump -Version: 4.2.15 +Version: 4.2.16 Release: 0 %define so_version 15 @@ -54,6 +54,7 @@ Requires: yui_backend = %{so_version} # Force removal of old -doc packages (bsc#1184363) Obsoletes: %{name}-doc < %{version} +Provides: %{name}-doc = %{version} %description -n %{bin_name} This is the user interface engine that provides the abstraction from ++++++ libyui-4.2.15.tar.bz2 -> libyui-4.2.16.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.2.15/VERSION.cmake new/libyui-4.2.16/VERSION.cmake --- old/libyui-4.2.15/VERSION.cmake 2021-08-06 19:24:46.000000000 +0200 +++ new/libyui-4.2.16/VERSION.cmake 2021-09-01 09:10:04.000000000 +0200 @@ -1,6 +1,6 @@ SET( VERSION_MAJOR "4") SET( VERSION_MINOR "2" ) -SET( VERSION_PATCH "15" ) +SET( VERSION_PATCH "16" ) SET( VERSION "${VERSION_MAJOR}.${VERSION_MINOR}.${VERSION_PATCH}" ) SET( SONAME_MAJOR "15" ) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.2.15/libyui-qt-pkg/src/YQPkgPatchList.cc new/libyui-4.2.16/libyui-qt-pkg/src/YQPkgPatchList.cc --- old/libyui-4.2.15/libyui-qt-pkg/src/YQPkgPatchList.cc 2021-08-06 19:24:46.000000000 +0200 +++ new/libyui-4.2.16/libyui-qt-pkg/src/YQPkgPatchList.cc 2021-09-01 09:10:04.000000000 +0200 @@ -35,7 +35,6 @@ #include <set> #include <QPainter> -#include <QItemDelegate> #include <QMenu> #include <QAction> #include <QEvent> @@ -51,41 +50,6 @@ using std::set; -class YQPkgPatchItemDelegate : public QItemDelegate -{ - YQPkgPatchList *_view; -public: - YQPkgPatchItemDelegate( YQPkgPatchList *parent ) : QItemDelegate( parent ), _view( parent ) {} - - virtual void paint ( QPainter * painter, const QStyleOptionViewItem & option, const QModelIndex & index ) const - { - painter->save(); - - YQPkgPatchCategoryItem *citem = dynamic_cast<YQPkgPatchCategoryItem *>(_view->itemFromIndex(index)); - // special painting for category items - if ( citem ) - { - QFont f = painter->font(); - f.setWeight(QFont::Bold); - QFontMetrics fm(f); - f.setPixelSize( (int) ( fm.height() * 1.05 ) ); - citem->setFont(_view->summaryCol(), f); - - QItemDelegate::paint(painter, option, index); - painter->restore(); - return; - } - - YQPkgPatchListItem *item = dynamic_cast<YQPkgPatchListItem *>(_view->itemFromIndex(index)); - if ( item ) - { - painter->restore(); - QItemDelegate::paint(painter, option, index); - } - } -}; - - YQPkgPatchList::YQPkgPatchList( QWidget * parent ) : YQPkgObjList( parent ) { @@ -101,6 +65,7 @@ //headers << _( "Patch" ); _nameCol = numCol++; headers << _( "Summary" ); _summaryCol = numCol++; //headers << _( "Category" ); _categoryCol = numCol++; + _categoryCol = -1; //headers << _( "Size" ); _sizeCol = numCol++; //headers << _( "Version" ); _versionCol = numCol++; @@ -119,9 +84,6 @@ header()->setSectionResizeMode(_summaryCol, QHeaderView::Stretch); - setItemDelegateForColumn( _summaryCol, new YQPkgPatchItemDelegate( this ) ); - setItemDelegateForColumn( _statusCol, new YQPkgPatchItemDelegate( this ) ); - setAllColumnsShowFocus( true ); //FIXME setColumnAlignment( sizeCol(), Qt::AlignRight ); @@ -558,15 +520,17 @@ _category = category; - - if ( _patchList->categoryCol() > -1 ) + if ( _patchList->summaryCol() > -1 ) setText( _patchList->summaryCol(), YQPkgPatchCategoryItem::asString( _category ) ); - - //setText( _patchList->summaryCol(), "Category" ); - setExpanded( true ); setTreeIcon(); + + QFont categoryFont = font( _patchList->summaryCol() ); + categoryFont.setBold(true); + QFontMetrics metrics( categoryFont ); + categoryFont.setPixelSize(int (metrics.height() * 1.05)); + setFont( _patchList->summaryCol(), categoryFont ); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.2.15/libyui-qt-pkg/src/YQPkgPatternList.cc new/libyui-4.2.16/libyui-qt-pkg/src/YQPkgPatternList.cc --- old/libyui-4.2.15/libyui-qt-pkg/src/YQPkgPatternList.cc 2021-08-06 19:24:46.000000000 +0200 +++ new/libyui-4.2.16/libyui-qt-pkg/src/YQPkgPatternList.cc 2021-09-01 09:10:04.000000000 +0200 @@ -41,7 +41,6 @@ #include <QHeaderView> #include <QLabel> #include <QLayout> -#include <QItemDelegate> #include "YQPackageSelector.h" #include "YQPkgPatternList.h" @@ -52,95 +51,6 @@ using std::set; -class YQPkgPatternItemDelegate : public QItemDelegate -{ - YQPkgPatternList *_view; - -public: - - YQPkgPatternItemDelegate( YQPkgPatternList *parent ) - : QItemDelegate( parent ) - , _view( parent ) - {} - - - virtual void paint ( QPainter * painter, - const QStyleOptionViewItem & option, - const QModelIndex & index ) const - { - painter->save(); - - YQPkgPatternCategoryItem *citem = dynamic_cast<YQPkgPatternCategoryItem *>( _view->itemFromIndex( index ) ); - - // special painting for category items - if ( citem ) - { - QFont f = painter->font(); - f.setWeight( QFont::Bold ); - QFontMetrics fm(f); - f.setPixelSize( (int) ( fm.height() * 1.1 ) ); - citem->setFont( _view->summaryCol(), f ); - - QItemDelegate::paint( painter, option, index ); - painter->restore(); - return; - } - - YQPkgPatternListItem *item = dynamic_cast<YQPkgPatternListItem *>( _view->itemFromIndex( index ) ); - - if ( item ) - { - //if ( index.column() == _view->howmanyCol() ) - if ( false ) - { - QColor background = option.palette.color(QPalette::Window); - painter->setBackground( background ); - - float percent = (item->totalPackages() > 0) - ? (((float)item->installedPackages()*100) / (float)item->totalPackages()) - : 0; - - QColor fillColor = option.palette.color(QPalette::Mid); - - if ( percent > 100.0 ) percent = 100.0; - if ( percent < 0.0 ) percent = 0.0; - int x = option.rect.left() + 1; - int y = option.rect.top() + 1; - int w = option.rect.width() - 2; - int h = (int) ( ( (float) option.rect.height() )/2 ); - int fillWidth = 0; - if ( w > 0 ) - { - fillWidth = (int) ( w * percent / 100.0 ); - - // Fill the desired percentage. - - painter->fillRect( x, y, fillWidth, h, fillColor ); - - QString percentageText = QString( "%1/%2" ) - .arg( item->installedPackages() ) - .arg( item->totalPackages() ); - - painter->setPen( _view->palette().color( QPalette::Base ) ); - painter->drawText( QRect( x, y, - w, h ), - Qt::AlignHCenter, percentageText ); - painter->restore(); - } - painter->restore(); - return; - - } - else - { - painter->restore(); - QItemDelegate::paint( painter, option, index ); - } - } - } -}; - - YQPkgPatternList::YQPkgPatternList( QWidget * parent, bool autoFill, bool autoFilter ) : YQPkgObjList( parent ) , _howmanyCol(0) @@ -169,11 +79,6 @@ setIndentation(0); - setItemDelegateForColumn( _iconCol, new YQPkgPatternItemDelegate( this ) ); - setItemDelegateForColumn( _statusCol, new YQPkgPatternItemDelegate( this ) ); - setItemDelegateForColumn( _summaryCol, new YQPkgPatternItemDelegate( this ) ); - //setItemDelegateForColumn( _howmanyCol, new YQPkgPatternItemDelegate(this) ); - // Can use the same colum for "broken" and "satisfied": // Both states are mutually exclusive @@ -586,6 +491,12 @@ setExpanded( true ); setTreeIcon(); + + QFont categoryFont = font( _patternList->summaryCol() ); + categoryFont.setBold(true); + QFontMetrics metrics( categoryFont ); + categoryFont.setPixelSize(int (metrics.height() * 1.1)); + setFont( _patternList->summaryCol(), categoryFont ); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.2.15/package/libyui-bindings.spec new/libyui-4.2.16/package/libyui-bindings.spec --- old/libyui-4.2.15/package/libyui-bindings.spec 2021-08-06 19:24:46.000000000 +0200 +++ new/libyui-4.2.16/package/libyui-bindings.spec 2021-09-01 09:10:04.000000000 +0200 @@ -20,7 +20,7 @@ Name: libyui-bindings # DO NOT manually bump the version here; instead, use rake version:bump -Version: 4.2.15 +Version: 4.2.16 Release: 0 Summary: Bindings for libyui License: LGPL-2.1-only OR LGPL-3.0-only diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.2.15/package/libyui-ncurses-pkg.spec new/libyui-4.2.16/package/libyui-ncurses-pkg.spec --- old/libyui-4.2.15/package/libyui-ncurses-pkg.spec 2021-08-06 19:24:46.000000000 +0200 +++ new/libyui-4.2.16/package/libyui-ncurses-pkg.spec 2021-09-01 09:10:04.000000000 +0200 @@ -19,7 +19,7 @@ Name: libyui-ncurses-pkg # DO NOT manually bump the version here; instead, use rake version:bump -Version: 4.2.15 +Version: 4.2.16 Release: 0 %define so_version 15 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.2.15/package/libyui-ncurses-rest-api.spec new/libyui-4.2.16/package/libyui-ncurses-rest-api.spec --- old/libyui-4.2.15/package/libyui-ncurses-rest-api.spec 2021-08-06 19:24:46.000000000 +0200 +++ new/libyui-4.2.16/package/libyui-ncurses-rest-api.spec 2021-09-01 09:10:04.000000000 +0200 @@ -19,7 +19,7 @@ Name: libyui-ncurses-rest-api # DO NOT manually bump the version here; instead, use rake version:bump -Version: 4.2.15 +Version: 4.2.16 Release: 0 %define so_version 15 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.2.15/package/libyui-ncurses.spec new/libyui-4.2.16/package/libyui-ncurses.spec --- old/libyui-4.2.15/package/libyui-ncurses.spec 2021-08-06 19:24:46.000000000 +0200 +++ new/libyui-4.2.16/package/libyui-ncurses.spec 2021-09-01 09:10:04.000000000 +0200 @@ -19,7 +19,7 @@ Name: libyui-ncurses # DO NOT manually bump the version here; instead, use rake version:bump -Version: 4.2.15 +Version: 4.2.16 Release: 0 %define so_version 15 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.2.15/package/libyui-qt-graph.spec new/libyui-4.2.16/package/libyui-qt-graph.spec --- old/libyui-4.2.15/package/libyui-qt-graph.spec 2021-08-06 19:24:46.000000000 +0200 +++ new/libyui-4.2.16/package/libyui-qt-graph.spec 2021-09-01 09:10:04.000000000 +0200 @@ -19,7 +19,7 @@ Name: libyui-qt-graph # DO NOT manually bump the version here; instead, use rake version:bump -Version: 4.2.15 +Version: 4.2.16 Release: 0 %define so_version 15 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.2.15/package/libyui-qt-pkg.spec new/libyui-4.2.16/package/libyui-qt-pkg.spec --- old/libyui-4.2.15/package/libyui-qt-pkg.spec 2021-08-06 19:24:46.000000000 +0200 +++ new/libyui-4.2.16/package/libyui-qt-pkg.spec 2021-09-01 09:10:04.000000000 +0200 @@ -19,7 +19,7 @@ Name: libyui-qt-pkg # DO NOT manually bump the version here; instead, use rake version:bump -Version: 4.2.15 +Version: 4.2.16 Release: 0 %define so_version 15 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.2.15/package/libyui-qt-rest-api.spec new/libyui-4.2.16/package/libyui-qt-rest-api.spec --- old/libyui-4.2.15/package/libyui-qt-rest-api.spec 2021-08-06 19:24:46.000000000 +0200 +++ new/libyui-4.2.16/package/libyui-qt-rest-api.spec 2021-09-01 09:10:04.000000000 +0200 @@ -19,7 +19,7 @@ Name: libyui-qt-rest-api # DO NOT manually bump the version here; instead, use rake version:bump -Version: 4.2.15 +Version: 4.2.16 Release: 0 %define so_version 15 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.2.15/package/libyui-qt.spec new/libyui-4.2.16/package/libyui-qt.spec --- old/libyui-4.2.15/package/libyui-qt.spec 2021-08-06 19:24:46.000000000 +0200 +++ new/libyui-4.2.16/package/libyui-qt.spec 2021-09-01 09:10:04.000000000 +0200 @@ -19,7 +19,7 @@ Name: libyui-qt # DO NOT manually bump the version here; instead, use rake version:bump -Version: 4.2.15 +Version: 4.2.16 Release: 0 %define so_version 15 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.2.15/package/libyui-rest-api.spec new/libyui-4.2.16/package/libyui-rest-api.spec --- old/libyui-4.2.15/package/libyui-rest-api.spec 2021-08-06 19:24:46.000000000 +0200 +++ new/libyui-4.2.16/package/libyui-rest-api.spec 2021-09-01 09:10:04.000000000 +0200 @@ -19,7 +19,7 @@ Name: libyui-rest-api # DO NOT manually bump the version here; instead, use rake version:bump -Version: 4.2.15 +Version: 4.2.16 Release: 0 %define so_version 15 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.2.15/package/libyui.changes new/libyui-4.2.16/package/libyui.changes --- old/libyui-4.2.15/package/libyui.changes 2021-08-06 19:24:46.000000000 +0200 +++ new/libyui-4.2.16/package/libyui.changes 2021-09-01 09:10:04.000000000 +0200 @@ -1,4 +1,11 @@ ------------------------------------------------------------------- +Tue Aug 24 15:30:52 UTC 2021 - Ladislav Slez??k <[email protected]> + +- Fixed using an uninitialized variable, in some situations + the patch category could be missing in the Qt UI (bsc#1174390) +- 4.2.16 + +------------------------------------------------------------------- Fri Aug 6 15:08:31 UTC 2021 - Ladislav Slez??k <[email protected]> - Fixed displaying empty help text or empty release notes diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-4.2.15/package/libyui.spec new/libyui-4.2.16/package/libyui.spec --- old/libyui-4.2.15/package/libyui.spec 2021-08-06 19:24:46.000000000 +0200 +++ new/libyui-4.2.16/package/libyui.spec 2021-09-01 09:10:04.000000000 +0200 @@ -19,7 +19,7 @@ Name: libyui # DO NOT manually bump the version here; instead, use rake version:bump -Version: 4.2.15 +Version: 4.2.16 Release: 0 %define so_version 15 @@ -54,6 +54,7 @@ Requires: yui_backend = %{so_version} # Force removal of old -doc packages (bsc#1184363) Obsoletes: %{name}-doc < %{version} +Provides: %{name}-doc = %{version} %description -n %{bin_name} This is the user interface engine that provides the abstraction from
