Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package pcsc-lite for openSUSE:Factory checked in at 2021-10-11 16:48:38 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/pcsc-lite (Old) and /work/SRC/openSUSE:Factory/.pcsc-lite.new.2443 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "pcsc-lite" Mon Oct 11 16:48:38 2021 rev:89 rq:924113 version:1.9.4 Changes: -------- --- /work/SRC/openSUSE:Factory/pcsc-lite/pcsc-lite.changes 2021-08-16 10:05:49.575508537 +0200 +++ /work/SRC/openSUSE:Factory/.pcsc-lite.new.2443/pcsc-lite.changes 2021-10-11 16:48:44.646179974 +0200 @@ -1,0 +2,7 @@ +Thu Oct 7 14:36:44 UTC 2021 - Wolfgang Rosenauer <w...@rosenauer.org> + +- version 1.9.4 + * fix a memory leak when libusb is used for hotplug + (i.e. non-Linux systems) + +------------------------------------------------------------------- Old: ---- pcsc-lite-1.9.3.tar.bz2 pcsc-lite-1.9.3.tar.bz2.asc New: ---- pcsc-lite-1.9.4.tar.bz2 pcsc-lite-1.9.4.tar.bz2.asc ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ pcsc-lite.spec ++++++ --- /var/tmp/diff_new_pack.vyB2q3/_old 2021-10-11 16:48:45.214180877 +0200 +++ /var/tmp/diff_new_pack.vyB2q3/_new 2021-10-11 16:48:45.218180883 +0200 @@ -26,7 +26,7 @@ %define PKG_USER scard %define PKG_GROUP scard Name: pcsc-lite -Version: 1.9.3 +Version: 1.9.4 Release: 0 Summary: PC/SC Smart Cards Library License: BSD-3-Clause AND GPL-3.0-or-later ++++++ pcsc-lite-1.9.3.tar.bz2 -> pcsc-lite-1.9.4.tar.bz2 ++++++ ++++ 13953 lines of diff (skipped) ++++ retrying with extended exclude list diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/pcsc-lite-1.9.3/ChangeLog new/pcsc-lite-1.9.4/ChangeLog --- old/pcsc-lite-1.9.3/ChangeLog 2021-08-06 22:04:30.000000000 +0200 +++ new/pcsc-lite-1.9.4/ChangeLog 2021-10-01 18:00:00.000000000 +0200 @@ -1,3 +1,8 @@ +1.9.4: Ludovic Rousseau +1 October 2021 +- fix a memory leak when libusb is used for hotplug (i.e. non-Linux + systems) + 1.9.3: Ludovic Rousseau 6 August 2021 - fix a stupid regression with systemd introduced in the previous version diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/pcsc-lite-1.9.3/ChangeLog.git new/pcsc-lite-1.9.4/ChangeLog.git --- old/pcsc-lite-1.9.3/ChangeLog.git 2021-08-06 22:07:39.000000000 +0200 +++ new/pcsc-lite-1.9.4/ChangeLog.git 2021-10-01 18:01:27.000000000 +0200 @@ -1,4 +1,76 @@ -commit 6a62e0b5c956ee5a27a00083ee795220ed2fc4d6 (HEAD -> master, tag: 1.9.3, zotac/master, origin/master, origin/HEAD, github/master) +commit baa02edd1fb47c18b6bb7dfe79b2b38390271ce6 (HEAD -> master, zotac/master) +Author: Ludovic Rousseau <ludovic.rouss...@free.fr> +Date: Fri Oct 1 17:40:31 2021 +0200 + + Release 1.9.4 + + Signed-off-by: Ludovic Rousseau <ludovic.rouss...@free.fr> + + ChangeLog | 5 +++++ + configure.ac | 2 +- + 2 files changed, 6 insertions(+), 1 deletion(-) + +commit a41b472dc32adabb2a6dcf1466d6399bdcef5f6a +Author: Ludovic Rousseau <ludovic.rouss...@free.fr> +Date: Fri Oct 1 17:55:54 2021 +0200 + + Use AC_PROG_LEX instead of AM_PROG_LEX + + And also use the "noyywrap" option. + + configure.ac:63: warning: AC_PROG_LEX without either yywrap or noyywrap is obsolete + ./lib/autoconf/programs.m4:716: _AC_PROG_LEX is expanded from... + ./lib/autoconf/programs.m4:709: AC_PROG_LEX is expanded from... + aclocal.m4:1580: AM_PROG_LEX is expanded from... + configure.ac:63: the top level + + configure.ac | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +commit 98cce6806c1d5ab31451eed681823a714b551d86 +Author: Ludovic Rousseau <ludovic.rouss...@free.fr> +Date: Fri Oct 1 17:46:55 2021 +0200 + + Remove obsolete autoconf macros + + AC_HEADER_STDC & AC_HEADER_TIME are obsolete according to autoupdate 2.71. + + configure.ac | 2 -- + 1 file changed, 2 deletions(-) + +commit a79e1d8409befc6ae0e6d77c0ff47a24f1bb31c3 (origin/master, origin/HEAD, github/master) +Author: Ludovic Rousseau <ludovic.rouss...@free.fr> +Date: Fri Oct 1 16:51:49 2021 +0200 + + hotplug_libusb: fix a memory leak + + We must release the configuration descriptor even if the USB device is + NOT a smart card reader. + + This problem was specific to hotplug using libusb. By default GNU/Linux + systems should use libudev instead. So the problem is visible in FreeBSD + systems or other non Linux systems. + + Thanks to Sergey V. Koupreyenko for the bug report. + + The problem was also reported to pfSense at + https://redmine.pfsense.org/issues/12095 + + src/hotplug_libusb.c | 1 + + 1 file changed, 1 insertion(+) + +commit 3d78c971bbd484cf63f0c29f02f9d531d2cd595b +Author: Ludovic Rousseau <ludovic.rouss...@free.fr> +Date: Fri Oct 1 13:43:24 2021 +0200 + + Call libusb_exit() before exiting + + This makes the code cleaner. + + src/hotplug_libusb.c | 1 + + 1 file changed, 1 insertion(+) + +commit 6a62e0b5c956ee5a27a00083ee795220ed2fc4d6 (tag: 1.9.3) Author: Ludovic Rousseau <ludovic.rouss...@free.fr> Date: Fri Aug 6 22:03:15 2021 +0200 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/pcsc-lite-1.9.3/config.h.in new/pcsc-lite-1.9.4/config.h.in --- old/pcsc-lite-1.9.3/config.h.in 2021-08-06 22:05:25.000000000 +0200 +++ new/pcsc-lite-1.9.4/config.h.in 2021-10-01 17:57:42.000000000 +0200 @@ -6,22 +6,16 @@ /* display ATR parsing debug messages. */ #undef ATR_DEBUG -/* Define to one of `_getb67', `GETB67', `getb67' for Cray-2 and Cray-YMP - systems. This function is required for `alloca.c' support on those systems. - */ -#undef CRAY_STACKSEG_END - -/* Define to 1 if using `alloca.c'. */ +/* Define to 1 if using 'alloca.c'. */ #undef C_ALLOCA /* Filter reader names */ #undef FILTER_NAMES -/* Define to 1 if you have `alloca', as a function or macro. */ +/* Define to 1 if you have 'alloca', as a function or macro. */ #undef HAVE_ALLOCA -/* Define to 1 if you have <alloca.h> and it should be used (not on Ultrix). - */ +/* Define to 1 if <alloca.h> works. */ #undef HAVE_ALLOCA_H /* Define to 1 if you have the <dirent.h> header file, and it defines `DIR'. @@ -61,9 +55,6 @@ /* Define to 1 if you have the <libusb.h> header file. */ #undef HAVE_LIBUSB_H -/* Define to 1 if you have the <memory.h> header file. */ -#undef HAVE_MEMORY_H - /* Define to 1 if you have the `nanosleep' function. */ #undef HAVE_NANOSLEEP @@ -89,6 +80,9 @@ /* Define to 1 if you have the <stdint.h> header file. */ #undef HAVE_STDINT_H +/* Define to 1 if you have the <stdio.h> header file. */ +#undef HAVE_STDIO_H + /* Define to 1 if you have the <stdlib.h> header file. */ #undef HAVE_STDLIB_H @@ -188,12 +182,11 @@ STACK_DIRECTION = 0 => direction of growth unknown */ #undef STACK_DIRECTION -/* Define to 1 if you have the ANSI C header files. */ +/* Define to 1 if all of the C90 standard headers exist (not just the ones + required in a freestanding environment). This macro is provided for + backward compatibility; new code need not use it. */ #undef STDC_HEADERS -/* Define to 1 if you can safely include both <sys/time.h> and <time.h>. */ -#undef TIME_WITH_SYS_TIME - /* directory containing IPC files */ #undef USE_IPCDIR diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/pcsc-lite-1.9.3/configure.ac new/pcsc-lite-1.9.4/configure.ac --- old/pcsc-lite-1.9.3/configure.ac 2021-08-06 22:04:30.000000000 +0200 +++ new/pcsc-lite-1.9.4/configure.ac 2021-10-01 18:00:00.000000000 +0200 @@ -3,7 +3,7 @@ AC_PREREQ([2.69]) -AC_INIT([pcsc-lite],[1.9.3]) +AC_INIT([pcsc-lite],[1.9.4]) AC_CONFIG_SRCDIR(src/pcscdaemon.c) AM_INIT_AUTOMAKE(1.8 dist-bzip2 no-dist-gzip) AC_CONFIG_HEADERS([config.h]) @@ -60,7 +60,7 @@ AC_PROG_INSTALL AC_PROG_LN_S AC_PROG_MAKE_SET -AM_PROG_LEX +AC_PROG_LEX([noyywrap]) PKG_PROG_PKG_CONFIG AM_PROG_CC_C_O AM_PROG_AR @@ -92,7 +92,6 @@ #AC_SUBST(LIBTOOL_DEPS) # Checks for header files -AC_HEADER_STDC AC_HEADER_SYS_WAIT AC_CHECK_HEADERS([getopt.h sys/filio.h syslog.h dl.h fcntl.h alloca.h]) @@ -100,7 +99,6 @@ AC_C_CONST AC_TYPE_UID_T AC_TYPE_SIZE_T -AC_HEADER_TIME AC_STRUCT_DIRENT_D_TYPE # Checks for library functions diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/pcsc-lite-1.9.3/src/PCSC/pcsclite.h new/pcsc-lite-1.9.4/src/PCSC/pcsclite.h --- old/pcsc-lite-1.9.3/src/PCSC/pcsclite.h 2021-08-06 22:05:25.000000000 +0200 +++ new/pcsc-lite-1.9.4/src/PCSC/pcsclite.h 2021-10-01 18:01:18.000000000 +0200 @@ -279,7 +279,7 @@ #define INFINITE 0xFFFFFFFF /**< Infinite timeout */ #endif -#define PCSCLITE_VERSION_NUMBER "1.9.3" /**< Current version */ +#define PCSCLITE_VERSION_NUMBER "1.9.4" /**< Current version */ /** Maximum readers context (a slot is count as a reader) */ #define PCSCLITE_MAX_READERS_CONTEXTS 16 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/pcsc-lite-1.9.3/src/hotplug_libusb.c new/pcsc-lite-1.9.4/src/hotplug_libusb.c --- old/pcsc-lite-1.9.3/src/hotplug_libusb.c 2021-01-02 16:20:35.000000000 +0100 +++ new/pcsc-lite-1.9.4/src/hotplug_libusb.c 2021-10-01 16:51:37.000000000 +0200 @@ -386,6 +386,7 @@ Log3(PCSC_LOG_DEBUG, "%d/%d is not a supported smart card reader", bus_number, device_address); #endif + libusb_free_config_descriptor(config_desc); continue; } @@ -516,6 +517,7 @@ SYS_Sleep(HPForceReaderPolling); HPRescanUsbBus(); } + libusb_exit(ctx); } else { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' --exclude Makefile.in --exclude configure --exclude config.guess --exclude '*.pot' --exclude mkinstalldirs --exclude aclocal.m4 --exclude config.sub --exclude depcomp --exclude install-sh --exclude ltmain.sh old/pcsc-lite-1.9.3/src/pcscd.h new/pcsc-lite-1.9.4/src/pcscd.h --- old/pcsc-lite-1.9.3/src/pcscd.h 2021-08-06 22:05:25.000000000 +0200 +++ new/pcsc-lite-1.9.4/src/pcscd.h 2021-10-01 18:01:18.000000000 +0200 @@ -42,14 +42,14 @@ #define SCARD_INSERTED 0x0002 /**< Card was inserted */ #define SCARD_REMOVED 0x0004 /**< Card was removed */ -#define PCSCLITE_CONFIG_DIR "/etc/reader.conf.d" +#define PCSCLITE_CONFIG_DIR "/usr/local/etc/reader.conf.d" #define PCSCLITE_IPC_DIR USE_IPCDIR #define PCSCLITE_RUN_PID PCSCLITE_IPC_DIR "/pcscd.pid" #define PCSCLITE_CSOCK_NAME PCSCLITE_IPC_DIR "/pcscd.comm" -#define PCSCLITE_VERSION_NUMBER "1.9.3" /**< Current version */ +#define PCSCLITE_VERSION_NUMBER "1.9.4" /**< Current version */ #define PCSCLITE_STATUS_POLL_RATE 400000 /**< Status polling rate */ #define PCSCLITE_LOCK_POLL_RATE 100000 /**< Lock polling rate */
