Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package pidgin for openSUSE:Factory checked
in at 2021-10-16 22:46:56
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/pidgin (Old)
and /work/SRC/openSUSE:Factory/.pidgin.new.1890 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "pidgin"
Sat Oct 16 22:46:56 2021 rev:140 rq:924951 version:2.14.7
Changes:
--------
--- /work/SRC/openSUSE:Factory/pidgin/pidgin.changes 2021-09-25
00:36:03.339170796 +0200
+++ /work/SRC/openSUSE:Factory/.pidgin.new.1890/pidgin.changes 2021-10-16
22:47:01.848661106 +0200
@@ -1,0 +2,5 @@
+Tue Oct 12 16:44:39 UTC 2021 - Lukas M??ller <expee...@outlook.com>
+
+- Add pidgin-fix-double-free-crash.patch: fix double free crash
+
+-------------------------------------------------------------------
New:
----
pidgin-fix-double-free-crash.patch
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ pidgin.spec ++++++
--- /var/tmp/diff_new_pack.5y7vMQ/_old 2021-10-16 22:47:03.648662623 +0200
+++ /var/tmp/diff_new_pack.5y7vMQ/_new 2021-10-16 22:47:03.652662626 +0200
@@ -38,6 +38,8 @@
Patch3: pidgin-use-default-alsa.patch
# PATCH-FIX-OPENSUSE pidgin-always-enable-intltool.patch mgo...@suse.com --
always enable intltool, needed for autoconf 2.71.
Patch4: pidgin-always-enable-intltool.patch
+# Fix a crash due to a freed double. Patch was taken from upstream and will be
included in version 2.14.8.
+Patch5: pidgin-fix-double-free-crash.patch
BuildRequires: ca-certificates-mozilla
BuildRequires: doxygen
BuildRequires: fdupes
@@ -220,6 +222,7 @@
%patch3 -p1
%endif
%patch4 -p1
+%patch5 -p1
cp -f %{SOURCE3} %{name}-prefs.xml
++++++ pidgin-fix-double-free-crash.patch ++++++
# HG changeset patch
# User Gary Kramlich <g...@reaperworld.com>
# Date 1632457638 18000
# Thu Sep 23 23:27:18 2021 -0500
# Branch release-2.x.y
# Node ID 740dafa46e5ea6a00f031ec39c76d38ad1b11172
# Parent e91465803c0e9e21de809dfcf8f8ab0f547cc269
Fix a double free in jabber/message.c and silence a warning
JabberBuddyResource is handled internally, but it's free function, which is
static, does in fact free the thread_id as well.
Testing Done:
Compiled
Bugs closed: PIDGIN-17547
Reviewed at https://reviews.imfreedom.org/r/932/
diff --git a/libpurple/protocols/jabber/message.c
b/libpurple/protocols/jabber/message.c
--- a/libpurple/protocols/jabber/message.c
+++ b/libpurple/protocols/jabber/message.c
@@ -798,7 +798,7 @@
case JABBER_MESSAGE_OTHER:
purple_debug_info("jabber",
"Received message of unknown type:
%s\n", type);
- /* Fall-through is intentional */
+ /* FALL-THROUGH */
case JABBER_MESSAGE_NORMAL:
case JABBER_MESSAGE_CHAT:
handle_chat(jm);
@@ -1179,12 +1179,13 @@
jm->id = jabber_get_next_id(jm->js);
if(jbr) {
- if(jbr->thread_id)
- jm->thread_id = jbr->thread_id;
+ if(jbr->thread_id) {
+ jm->thread_id = g_strdup(jbr->thread_id);
+ }
- if (jbr->chat_states == JABBER_CHAT_STATES_UNSUPPORTED)
+ if (jbr->chat_states == JABBER_CHAT_STATES_UNSUPPORTED) {
jm->chat_state = JM_STATE_NONE;
- else {
+ } else {
/* if(JABBER_CHAT_STATES_UNKNOWN == jbr->chat_states)
jbr->chat_states = JABBER_CHAT_STATES_UNSUPPORTED; */
}
